[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62f43c3eae24: [clang][Interp] Support floating-point values (authored by tbaeder). Changed prior to commit:

[clang] 62f43c3 - [clang][Interp] Support floating-point values

Author: Timm Bäder Date: 2023-01-25T14:41:26+01:00 New Revision: 62f43c3eae2460d4ca3da7897fd2d7c56920638c URL: https://github.com/llvm/llvm-project/commit/62f43c3eae2460d4ca3da7897fd2d7c56920638c DIFF: https://github.com/llvm/llvm-project/commit/62f43c3eae2460d4ca3da7897fd2d7c56920638c.diff

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

erichkeane added a comment. In D142500#4079135 , @Mordante wrote: > FYI I tested this patch with libc++ and as expected it does not fix the > libc++ modular build ICE. A man can dream, eh? CHANGES SINCE LAST ACTION

[PATCH] D140250: Define NULL in its own header

aaron.ballman added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7,

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#4079872 , @tianshilei1992 wrote: > In D129008#4079660 , @aaron.ballman > wrote: > >> In D129008#3640194 , >> @tianshilei1992 wrote:

[PATCH] D140377: [clang][Interp] Compound assign operators for FP values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf3a171dcffd: [clang][Interp] Compound assign operators for FP values (authored by tbaeder). Changed prior to commit:

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske updated this revision to Diff 492106. balazske added a comment. New patch after more thorough debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D142534: Fix emission of consteval constructor of derived type

shafik added a comment. Makes sense to me but I am not familiar with this area so I will let someone else who has more knowledge approve. Comment at: clang/test/CodeGenCXX/cxx20-consteval-crash.cpp:95 +namespace Issue60166 { + nitpick: I have been using

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); erichkeane wrote: > tbaeder wrote: > > Fznamznon wrote: >

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); tbaeder wrote: > Fznamznon wrote: > > This is not four

[clang] 024e4f1 - [clang][Interp] Implement switch statements

Author: Timm Bäder Date: 2023-01-25T13:21:24+01:00 New Revision: 024e4f16ca795b98a5dea371cab623f851858925 URL: https://github.com/llvm/llvm-project/commit/024e4f16ca795b98a5dea371cab623f851858925 DIFF: https://github.com/llvm/llvm-project/commit/024e4f16ca795b98a5dea371cab623f851858925.diff

[clang] a7a4463 - [clang][Interp] Start implementing builtin functions

Author: Timm Bäder Date: 2023-01-25T14:08:03+01:00 New Revision: a7a4463acbe10d1b5c9eadcd6cb94790caad86e4 URL: https://github.com/llvm/llvm-project/commit/a7a4463acbe10d1b5c9eadcd6cb94790caad86e4 DIFF: https://github.com/llvm/llvm-project/commit/a7a4463acbe10d1b5c9eadcd6cb94790caad86e4.diff

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGa7a4463acbe1: [clang][Interp] Start implementing builtin functions (authored by tbaeder). Repository:

[clang] b3b1d86 - Revert "[clang][Interp] Support floating-point values"

Author: Timm Bäder Date: 2023-01-25T14:48:39+01:00 New Revision: b3b1d86137422dbdc9e8626925067f1b50734036 URL: https://github.com/llvm/llvm-project/commit/b3b1d86137422dbdc9e8626925067f1b50734036 DIFF: https://github.com/llvm/llvm-project/commit/b3b1d86137422dbdc9e8626925067f1b50734036.diff

[clang] af3a171 - [clang][Interp] Compound assign operators for FP values

Author: Timm Bäder Date: 2023-01-25T16:25:04+01:00 New Revision: af3a171dcffd73837d1debdd81399d51f0a0054a URL: https://github.com/llvm/llvm-project/commit/af3a171dcffd73837d1debdd81399d51f0a0054a DIFF: https://github.com/llvm/llvm-project/commit/af3a171dcffd73837d1debdd81399d51f0a0054a.diff

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#4079892 , @ABataev wrote: > In D129008#4079872 , > @tianshilei1992 wrote: > >> In D129008#4079660 , >> @aaron.ballman wrote:

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); This is not four bools. Repository: rG LLVM Github

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Fznamznon wrote: > erichkeane wrote: > > tbaeder wrote: >

[PATCH] D137415: [clang][Interp] Implement switch statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG024e4f16ca79: [clang][Interp] Implement switch statements (authored by tbaeder). Changed prior to commit:

[clang] 1a84036 - [clang][Interp] Specify c++ standard used in switch test

Author: Timm Bäder Date: 2023-01-25T13:33:25+01:00 New Revision: 1a84036bb979c0ef34a8add2fe27ad9f0cb50b99 URL: https://github.com/llvm/llvm-project/commit/1a84036bb979c0ef34a8add2fe27ad9f0cb50b99 DIFF: https://github.com/llvm/llvm-project/commit/1a84036bb979c0ef34a8add2fe27ad9f0cb50b99.diff

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For simple derived type ConstantEmitter returns a struct of the same size but different type which is then stored

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

aaron.ballman added subscribers: efriedma, rjmccall. aaron.ballman added a comment. In D129008#3640194 , @tianshilei1992 wrote: > `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. Is it for ObjC? Looking at the comments, it

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This updates the parsing methods in

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This updates the AArch64's Target Parser

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. Unit tests fail seems unrelated. I'm seeing the same test fail for a commit that is already in main https://github.com/llvm/llvm-project/commit/f1f583347d00aad378eb0128e72d3d2e8be5174b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 added a comment. In D142484#4079869 , @Jake-Egan wrote: > Hi, this new test fails on AIX. Could you take a look? > https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c I'm actually not sure why

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#4079914 , @tianshilei1992 wrote: > In D129008#4079892 , @ABataev wrote: > >> In D129008#4079872 , >> @tianshilei1992 wrote: >> >>>

[PATCH] D142534: Fix emission of consteval constructor of derived type

shafik added a comment. I think having a link to the github issue in the summary allows for the issue be closed automatically when you commit. Is this correct @aaron.ballman I have been doing this for a while and they get closed when I commit but maybe there is another mechanism involved.

[clang] eee8075 - [clang][Interp][NFCI] Remove an unnecessary DupPtr op

Author: Timm Bäder Date: 2023-01-25T17:09:33+01:00 New Revision: eee8075f57f018e047b5bc8923b0284a6f62ea3e URL: https://github.com/llvm/llvm-project/commit/eee8075f57f018e047b5bc8923b0284a6f62ea3e DIFF: https://github.com/llvm/llvm-project/commit/eee8075f57f018e047b5bc8923b0284a6f62ea3e.diff

[clang] c68af56 - [clang][Interp][NFC] Cast in InterpFrame::localBlock

Author: Timm Bäder Date: 2023-01-25T17:09:34+01:00 New Revision: c68af565ff0c2fdc5537e9ac0c2d7c75df44b035 URL: https://github.com/llvm/llvm-project/commit/c68af565ff0c2fdc5537e9ac0c2d7c75df44b035 DIFF: https://github.com/llvm/llvm-project/commit/c68af565ff0c2fdc5537e9ac0c2d7c75df44b035.diff

[clang-tools-extra] c4c5e79 - Fix warnings

Author: Kazu Hirata Date: 2023-01-25T08:21:29-08:00 New Revision: c4c5e79dd4b4c78eee7cffd9b0d7394b5bedcf12 URL: https://github.com/llvm/llvm-project/commit/c4c5e79dd4b4c78eee7cffd9b0d7394b5bedcf12 DIFF: https://github.com/llvm/llvm-project/commit/c4c5e79dd4b4c78eee7cffd9b0d7394b5bedcf12.diff

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

arsenm added a comment. In D142506#4078532 , @scchan wrote: > In D142506#4078402 , @arsenm wrote: > >> The resource directory should be strictly controlled. why would lib64 ever >> be used here? > > The

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4080080 , @jdoerfert wrote: > Thanks for taking a look, see my responses inline. For more information, the RFC is at https://reviews.llvm.org/D139617 > Quick questions, and they might not apply here since you seem to

[clang] 2725e2c - [clang][Interp] Fix ImplicitValueInitExprs for pointer types

Author: Timm Bäder Date: 2023-01-25T12:31:49+01:00 New Revision: 2725e2c0323f1408467452e3cc2a4a8cb3ea49a7 URL: https://github.com/llvm/llvm-project/commit/2725e2c0323f1408467452e3cc2a4a8cb3ea49a7 DIFF: https://github.com/llvm/llvm-project/commit/2725e2c0323f1408467452e3cc2a4a8cb3ea49a7.diff

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

This revision was automatically updated to reflect the committed changes. Closed by commit rG2725e2c0323f: [clang][Interp] Fix ImplicitValueInitExprs for pointer types (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D137235?vs=472545=492049#toc Repository: rG LLVM

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4a6842c5a4d: [clang][Interp] Reject invalid declarations and expressions (authored by tbaeder). Changed prior to commit:

[clang] f4a6842 - [clang][Interp] Reject invalid declarations and expressions

Author: Timm Bäder Date: 2023-01-25T12:52:44+01:00 New Revision: f4a6842c5a4d729bacfd0240b44fa726a28e6bfb URL: https://github.com/llvm/llvm-project/commit/f4a6842c5a4d729bacfd0240b44fa726a28e6bfb DIFF: https://github.com/llvm/llvm-project/commit/f4a6842c5a4d729bacfd0240b44fa726a28e6bfb.diff

[clang] df33d17 - [clang][Interp][NFC] Remove an unused function

Author: Timm Bäder Date: 2023-01-25T16:03:33+01:00 New Revision: df33d17b38a179fb3f811d1983a48f160220d699 URL: https://github.com/llvm/llvm-project/commit/df33d17b38a179fb3f811d1983a48f160220d699 DIFF: https://github.com/llvm/llvm-project/commit/df33d17b38a179fb3f811d1983a48f160220d699.diff

[clang] c61fe18 - [clang][Interp][NFC] Get rid of InterpSize

Author: Timm Bäder Date: 2023-01-25T16:03:33+01:00 New Revision: c61fe188a7e8e8c4b3098998f3dfa194e4842ebc URL: https://github.com/llvm/llvm-project/commit/c61fe188a7e8e8c4b3098998f3dfa194e4842ebc DIFF: https://github.com/llvm/llvm-project/commit/c61fe188a7e8e8c4b3098998f3dfa194e4842ebc.diff

[clang] 8b70d97 - [clang][Interp][NFC] Use InitThisField in initializers

Author: Timm Bäder Date: 2023-01-25T16:59:19+01:00 New Revision: 8b70d97c39174e1547447e8d33b228384987a152 URL: https://github.com/llvm/llvm-project/commit/8b70d97c39174e1547447e8d33b228384987a152 DIFF: https://github.com/llvm/llvm-project/commit/8b70d97c39174e1547447e8d33b228384987a152.diff

[clang] cb70343 - [clang][Interp] Add back Run() call

Author: Timm Bäder Date: 2023-01-25T17:01:55+01:00 New Revision: cb703434cbdc71beb02a7b555083f3e160a13363 URL: https://github.com/llvm/llvm-project/commit/cb703434cbdc71beb02a7b555083f3e160a13363 DIFF: https://github.com/llvm/llvm-project/commit/cb703434cbdc71beb02a7b555083f3e160a13363.diff

[PATCH] D140724: [clang][Interp] Add back Run() call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb703434cbdc: [clang][Interp] Add back Run() call (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0a6c8c1 - [clang][Interp][NFC] Add a helper function for local variables

Author: Timm Bäder Date: 2023-01-25T16:57:59+01:00 New Revision: 0a6c8c1b2570e3fc9c652989afed5de1aee0c0be URL: https://github.com/llvm/llvm-project/commit/0a6c8c1b2570e3fc9c652989afed5de1aee0c0be DIFF: https://github.com/llvm/llvm-project/commit/0a6c8c1b2570e3fc9c652989afed5de1aee0c0be.diff

[clang] 93aa412 - [clang][Interp][NFC] Refector OffsetHelper

Author: Timm Bäder Date: 2023-01-25T17:22:59+01:00 New Revision: 93aa4123066fb32a8e3c757ff0a280cfd93ec9f3 URL: https://github.com/llvm/llvm-project/commit/93aa4123066fb32a8e3c757ff0a280cfd93ec9f3 DIFF: https://github.com/llvm/llvm-project/commit/93aa4123066fb32a8e3c757ff0a280cfd93ec9f3.diff

[PATCH] D142555: Refactor symbol page parsing.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142555 Files:

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); How

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492130. VitaNuo added a comment. Refactor the symbol parsing loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files:

[clang] fb6c130 - [LTO] Remove -lto-opaque-pointers flag

Author: Nikita Popov Date: 2023-01-25T12:18:50+01:00 New Revision: fb6c1300f23f249aa29eb6c5325aebc7d61d7345 URL: https://github.com/llvm/llvm-project/commit/fb6c1300f23f249aa29eb6c5325aebc7d61d7345 DIFF: https://github.com/llvm/llvm-project/commit/fb6c1300f23f249aa29eb6c5325aebc7d61d7345.diff

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

Jake-Egan added a comment. Hi, this new test fails on AIX. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142484/new/

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 added a comment. In D142484#4079869 , @Jake-Egan wrote: > Hi, this new test fails on AIX. Could you take a look? > https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c I might just put that

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} sorry for showing up late to the party but instead of

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added a comment. This patch got a little bit out of control at the last revision, so I decided to remove every change from clang and add everything to the `ExceptionAnalyzer` only. The reason for that is with exceptions we have less conversions to check than we have inside the

[PATCH] D140415: [flang] stack arrays pass

jdoerfert added a comment. Quick questions, and they might not apply here since you seem to only look at explicit Flang generated values, right? Are you handling unwinding/exceptions, especially in-between the allocation and deallocation? Are you handling non-accessible stacks (e.g., on GPUs)

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks for preparing this fix! I've verified that it fixes the original reproducer as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4078843 , @nickdesaulniers wrote: > Is https://reviews.llvm.org/D142163 a blocker for this? Yes, and this patch needs to be updated to take `VisibleToRegularObj` into account. I'll update this patch once we

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 492115. isuckatcs added a comment. - Reverted the changes related to clang itself - Added more checks for exception handling - `isQualificationConvertiblePointer` is now iterative, not recursive - Added more test cases CHANGES SINCE LAST ACTION

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure it is at least 8 bits. Fixes #59801 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142550

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7348bb36c557: [clang][Interp] Support inc/dec operators for pointers (authored by tbaeder). Changed prior to commit:

[clang] 7348bb3 - [clang][Interp] Support inc/dec operators for pointers

Author: Timm Bäder Date: 2023-01-25T11:57:05+01:00 New Revision: 7348bb36c5570e718469f043504e80491bb7f12b URL: https://github.com/llvm/llvm-project/commit/7348bb36c5570e718469f043504e80491bb7f12b DIFF: https://github.com/llvm/llvm-project/commit/7348bb36c5570e718469f043504e80491bb7f12b.diff

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. In D133375#4079251 , @tambre wrote: > A Clang 16 release note for this would be nice. I didn't immediately notice > and got a bit broken by this change.  +1 to the request,

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

Szelethus added a comment. In D142354#4078450 , @NoQ wrote: > Interesting, what specific goals do you have here? Are you planning to find > specific bugs (eg. force-unwrap to a wrong type) or just to model the > semantics? Hi! Meant to write this

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

HantaoPan added a comment. Herald added a project: All. Hi, I am interesting in this feature too. You know, consistency is crucial to a large program... regards, Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14484/new/ https://reviews.llvm.org/D14484

[clang-tools-extra] 007b353 - doc: Fix typo in clang-tidy no-automatic-move doc

Author: MarcoFalke Date: 2023-01-25T15:39:41+01:00 New Revision: 007b35369501b244c8736d2c75b942d1d91d5d18 URL: https://github.com/llvm/llvm-project/commit/007b35369501b244c8736d2c75b942d1d91d5d18 DIFF: https://github.com/llvm/llvm-project/commit/007b35369501b244c8736d2c75b942d1d91d5d18.diff

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#4079660 , @aaron.ballman wrote: > In D129008#3640194 , > @tianshilei1992 wrote: > >> `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. > >

[PATCH] D142550: Fix sizeof of boolean vector

tbaeder added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:95 +void Sizeof() { + using FourBools = bool __attribute__((ext_vector_type(8))); + static_assert(sizeof(FourBools) == 1); Should be 4 instead of 8, shouldn't it? Repository: rG

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb added a comment. Thanks Luis for the quick review. As an important part of this is trying to align with gcc/g++ I'd really appreciate a review from @kito-cheng too if you have the time (thanks in advance!). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142327/new/

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 492044. tblah marked 5 inline comments as done. tblah added a comment. - Add missing early return for allocations not for arrays - Remove braces from if statement with a single statement in its body - Assert that a correct insertion point is found for the

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:352 + LLVM_DEBUG(llvm::dbgs() + << "--Allocation is not for an array: skipping\n"); +} jeanPerier wrote: > I think the early return may be missing

[PATCH] D137488: [clang][Interp] Array initialization via string literal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a3243de62c1: [clang][Interp] Array initialization via string literal (authored by tbaeder). Changed prior to commit:

[clang] 0a3243d - [clang][Interp] Array initialization via string literal

Author: Timm Bäder Date: 2023-01-25T14:22:05+01:00 New Revision: 0a3243de62c1f0a1e0c2b3c5b4aae8323bef9605 URL: https://github.com/llvm/llvm-project/commit/0a3243de62c1f0a1e0c2b3c5b4aae8323bef9605 DIFF: https://github.com/llvm/llvm-project/commit/0a3243de62c1f0a1e0c2b3c5b4aae8323bef9605.diff

[clang] 611a748 - [clang][Interp] Add empty messages to static_asserts

Author: Timm Bäder Date: 2023-01-25T15:20:46+01:00 New Revision: 611a748b2252f9c529805cc2fa34c073e9b42bcd URL: https://github.com/llvm/llvm-project/commit/611a748b2252f9c529805cc2fa34c073e9b42bcd DIFF: https://github.com/llvm/llvm-project/commit/611a748b2252f9c529805cc2fa34c073e9b42bcd.diff

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

steakhal added a comment. I would be interested in some of the free-functions dealing with variants, such as `std::visit()`. https://godbolt.org/z/bbocrz4dG I hope that's also on the radar. In D142354#4079643 , @Szelethus wrote: > In D142354#4078450

[clang] 56184bb - [AMDGCN] Fix device lib test to work with lib64

Author: Siu Chi Chan Date: 2023-01-25T09:55:35-05:00 New Revision: 56184bb3ad3ff4f7ca00667ec4759648ce112269 URL: https://github.com/llvm/llvm-project/commit/56184bb3ad3ff4f7ca00667ec4759648ce112269 DIFF: https://github.com/llvm/llvm-project/commit/56184bb3ad3ff4f7ca00667ec4759648ce112269.diff

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56184bb3ad3f: [AMDGCN] Fix device lib test to work with lib64 (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5de6b94 - [clang][Interp][NFC] Replace remaining dyn_cast_or_null uses

Author: Timm Bäder Date: 2023-01-25T16:39:26+01:00 New Revision: 5de6b94f856f696832ce7df167e1dbc096fbe598 URL: https://github.com/llvm/llvm-project/commit/5de6b94f856f696832ce7df167e1dbc096fbe598 DIFF: https://github.com/llvm/llvm-project/commit/5de6b94f856f696832ce7df167e1dbc096fbe598.diff

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492125. Fznamznon added a comment. Adjust the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/test/SemaCXX/vector-bool.cpp Index:

[PATCH] D142477: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b28233599a: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006) (authored by RKSimon). Repository: rG LLVM Github

[clang] c9b2823 - [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006)

Author: Simon Pilgrim Date: 2023-01-25T10:56:01Z New Revision: c9b28233599a753506687f2f8a4f96331cd5dbb2 URL: https://github.com/llvm/llvm-project/commit/c9b28233599a753506687f2f8a4f96331cd5dbb2 DIFF: https://github.com/llvm/llvm-project/commit/c9b28233599a753506687f2f8a4f96331cd5dbb2.diff

[clang] 228462f - Fix one of the regressions found in revert of concept sugaring

Author: Erich Keane Date: 2023-01-25T06:01:44-08:00 New Revision: 228462f755f0d459882b19115c60e8872a057b25 URL: https://github.com/llvm/llvm-project/commit/228462f755f0d459882b19115c60e8872a057b25 DIFF: https://github.com/llvm/llvm-project/commit/228462f755f0d459882b19115c60e8872a057b25.diff

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG228462f755f0: Fix one of the regressions found in revert of concept sugaring (authored by erichkeane). Herald added a project: clang. Repository:

[clang] cb7f582 - Re-apply "[clang][Interp] Support floating-point values"

Author: Timm Bäder Date: 2023-01-25T15:13:09+01:00 New Revision: cb7f58221101cfad0ddec987465de57a20b0d11c URL: https://github.com/llvm/llvm-project/commit/cb7f58221101cfad0ddec987465de57a20b0d11c DIFF: https://github.com/llvm/llvm-project/commit/cb7f58221101cfad0ddec987465de57a20b0d11c.diff

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

MyDeveloperDay added a comment. I think they have branched (https://clang.llvm.org/docs/ClangFormatStyleOptions.html) the documentation has changed to 17.0 We would need your name and email in order to commit on your behalf. I checked this patch out and tested it on my large project and I

[PATCH] D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[clang] d5fe78d - [Clang] Make the linker wrapper test require Linux

Author: Joseph Huber Date: 2023-01-25T09:31:59-06:00 New Revision: d5fe78d939d25e5508ae57a2dc0c587c79ad16b1 URL: https://github.com/llvm/llvm-project/commit/d5fe78d939d25e5508ae57a2dc0c587c79ad16b1 DIFF: https://github.com/llvm/llvm-project/commit/d5fe78d939d25e5508ae57a2dc0c587c79ad16b1.diff

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. In D142534#4079958 , @shafik wrote: > I think having a link to the github issue in the summary allows for the issue > be closed automatically when you commit. Is this correct @aaron.ballman I > have been doing this for a

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} kadircet wrote: > sorry for showing up late to the

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492141. danakj added a comment. Adding back a period that was removed from a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files:

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

erichkeane added a comment. In D142500#4080279 , @Mordante wrote: > In D142500#4079669 , @erichkeane > wrote: > >> In D142500#4079135 , @Mordante >> wrote: >> >>> FYI I

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:121 // CHECK: annotate-comments-objc.m:32:9: ObjCInstanceMethodDecl=method1_isdoxy4:{{.*}} method1_isdoxy4 IS_DOXYGEN_SINGLE -// CHECK: annotate-comments-objc.m:43:22:

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138472/new/ https://reviews.llvm.org/D138472 ___ cfe-commits mailing list

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4080615 , @nickdesaulniers wrote: > The test is for x86, does this also work for aarch64 with BTI? IBT/BTI doesn't affect this specific optimization, it's only about KCFI. If you're referring to ibt-seal, I

[clang] cd61d2a - [clang][CodeGen][NFC] Fix `llvm-else-after-return`

Author: Michael Liao Date: 2023-01-25T13:53:35-05:00 New Revision: cd61d2abe0fdfcee52e16998f7f3fda82572cd6f URL: https://github.com/llvm/llvm-project/commit/cd61d2abe0fdfcee52e16998f7f3fda82572cd6f DIFF: https://github.com/llvm/llvm-project/commit/cd61d2abe0fdfcee52e16998f7f3fda82572cd6f.diff

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay Could you please commit this for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, dschuff. Herald added a project: All. royjacobson requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj created this revision. Herald added a subscriber: arphaman. Herald added a project: All. danakj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The key part of getRawCommentForDecl() required to find a comment is determining where

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added a comment. Just a couple more I'm concerned about after thinking about it, otherwise this looks about right. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 492179. iana added a comment. Revert the unnecessary changes to unspecified-var-size.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. > If you're referring to ibt-seal, I assume a similar optimization could be > added for BTI too. Yes, please. Does it make sense to add to this patch, or a follow up on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492182. Michael137 added a comment. - Set `IsDefaulted` when checking template arguments in `clang::Sema` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

  1   2   3   >