[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish updated this revision to Diff 504887. snehasish added a comment. Update the unittest in compiler-rt which was caught by the build bot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. I cannot find an example that throw `error: expression contains unexpanded parameter pack 'T'` in fold expression because code like ` (foo(10 + (static_cast(1))) + ...);` can be unpack both `T` and `U` in same `...` operator But this code can be diagnosed

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504893. lamb-j added a comment. Adding note to documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

aeubanks created this revision. Herald added subscribers: ormris, ChuanqiXu, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. CoroCleanup was running

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + Rather than hardcoding the filename and the location, which

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. In D143467#4182457 , @nemanjai wrote: > Another note regarding the motivating test case: > Use of `vector double` should require VSX. We don't really seem to have the > ability to turn this off early enough to catch this though.

[clang] b47d4df - Switch ABI references to env/environment

Author: Jacob Lambert Date: 2023-03-13T16:19:31-07:00 New Revision: b47d4df25c696739dbbb9e373ffd8a501eabcfef URL: https://github.com/llvm/llvm-project/commit/b47d4df25c696739dbbb9e373ffd8a501eabcfef DIFF: https://github.com/llvm/llvm-project/commit/b47d4df25c696739dbbb9e373ffd8a501eabcfef.diff

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4190901 , @scott.linder wrote: > Is there a corresponding document update to go along with this? If consumers > of the bundles will begin to rely on this it should be documented that it is > guaranteed by the

[PATCH] D142932: Multilib YAML parsing

phosek added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:137 +struct MultilibSetSerialization { + std::string ClangMinimumVersion; + std::vector Multilibs; Can we use a separate versioning scheme rather than tying the version to Clang? That is

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

yrouban added a comment. Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1057 + struct

[clang] b9db89f - [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

Author: Jakub Kuderski Date: 2023-03-13T20:59:06-04:00 New Revision: b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7 URL: https://github.com/llvm/llvm-project/commit/b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7 DIFF:

[PATCH] D145987: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9db89fbcfda: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/ (authored by kuhar). Repository: rG LLVM Github Monorepo

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. Herald added a subscriber: jobnoorman. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145088/new/ https://reviews.llvm.org/D145088 ___ cfe-commits mailing list

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

hazohelet updated this revision to Diff 504933. hazohelet added a comment. Address comments from @aaron.ballman - NFC stylistic changes Thanks for the review! Since I don't have commit access, would you please land this patch for me? Please use "Takuya Shimizu " for the patch attribution.

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143479/new/ https://reviews.llvm.org/D143479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish reopened this revision. snehasish added a comment. This revision is now accepted and ready to land. Reopening since I missed the updates to the memprof unit tests in compiler-rt. This was caught by the buildbots. As part of the changes I modified the `SerializeToRawProfile` API

[PATCH] D145833: Switch ABI references to env/environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47d4df25c69: Switch ABI references to env/environment (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145833/new/

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

samitolvanen accepted this revision. samitolvanen added a comment. LGTM. Folding D145979 into this one might also make sense. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default

[PATCH] D142933: Add -print-multi-selection-tags-experimental option

phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:237-245 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos, Neg; +

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/CodeGen/xray-function-index.cpp:1 +// RUN: %clang_cc1 -fxray-instrument -x c++ -std=c++11 -triple

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 148dc8a - [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

Author: ziqingluo-90 Date: 2023-03-13T17:22:22-07:00 New Revision: 148dc8a2a80f6b4ab80914c153279205a78315ed URL: https://github.com/llvm/llvm-project/commit/148dc8a2a80f6b4ab80914c153279205a78315ed DIFF: https://github.com/llvm/llvm-project/commit/148dc8a2a80f6b4ab80914c153279205a78315ed.diff

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG148dc8a2a80f: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream (authored by ziqingluo-90). Changed prior to commit:

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

shafik added a comment. LGTM, I wlll let @royjacobson give the final approval after reviewing codegen tests. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9161-9162 +if (CSM == Sema::CXXDefaultConstructor) { + // Default constructor of a union can also be valid if one

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added a comment. I have just one comment related to efficiency, but if it turns out to be too difficult to address, I'd be also fine landing this change as is and addressing that issue in a follow up change. Comment at: clang/lib/Driver/MultilibBuilder.cpp:94-100 +

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504884. francii added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, ormris. Update check in AIX.cpp, add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln added a comment. Mentioned removal of flag in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 ___ cfe-commits mailing list

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln updated this revision to Diff 504890. yln marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

jyu2 updated this revision to Diff 504907. jyu2 added a comment. Fix clang format problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146000/new/ https://reviews.llvm.org/D146000 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

shafik added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; aaron.ballman wrote: > I think there's one more test to add: > ``` > struct UnnamedEmptyBitfieldSplit { > short

[PATCH] D145993: [-Wunsafe-buffer-usage] Reducing non-determinism in diagnostics output stream

ziqingluo-90 updated this revision to Diff 504896. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145993/new/ https://reviews.llvm.org/D145993 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu added a comment. @iains @dblaikie gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144844/new/ https://reviews.llvm.org/D144844 ___ cfe-commits mailing list

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 ___ cfe-commits mailing list

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. @kadircet, could I get your review on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] df405db - [Driver] Make -X default for baremetal riscv

Author: Alex Brachet Date: 2023-03-14T05:17:54Z New Revision: df405dbfd316a598474b73f8c57f0d1051b4b51e URL: https://github.com/llvm/llvm-project/commit/df405dbfd316a598474b73f8c57f0d1051b4b51e DIFF: https://github.com/llvm/llvm-project/commit/df405dbfd316a598474b73f8c57f0d1051b4b51e.diff LOG:

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGdf405dbfd316: [Driver] Make -X default for baremetal riscv (authored by abrachet). Herald added a

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

abrachet added a comment. Both comments addressed in commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 504945. dhruvachak added a comment. Fixed LIT test failure, added new clang test OpenMP/bug60602.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 Files:

[PATCH] D145987: [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

kuhar updated this revision to Diff 504901. kuhar marked an inline comment as done. kuhar added a comment. Update lambda signature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145987/new/ https://reviews.llvm.org/D145987 Files:

[PATCH] D145794: [clang-format] Recognize Verilog always blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f8bab9bad7: [clang-format] Recognize Verilog always blocks (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a1f8bab - [clang-format] Recognize Verilog always blocks

Author: sstwcw Date: 2023-03-14T03:49:56Z New Revision: a1f8bab9bad7dc7ef5bae518bc3289f4111846f3 URL: https://github.com/llvm/llvm-project/commit/a1f8bab9bad7dc7ef5bae518bc3289f4111846f3 DIFF: https://github.com/llvm/llvm-project/commit/a1f8bab9bad7dc7ef5bae518bc3289f4111846f3.diff LOG:

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/XRay/xray-instrument-macos.c:1 +// RUN: %clang -o /dev/null -v -fxray-instrument -target aarch64-apple-darwin20 -c %s // RUN: %clang -o

[PATCH] D145941: [Clang] Always use -zdefs when linking AMDGPU images

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. While `--no-undefined` is an alias for `-z defs`, be consistent in the subject and the body. > Always use -zdefs `--no-undefined` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

Henric added a comment. Hi With this patch, the following code gives me a warning that I don't think is intentional. typedef struct S { int x:4; } S; void foo(S s) { for (int i=10; i > s.x; --i) ; } loop_var.c:6:22: warning: loop variable has narrower type 'int:4' than

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

skatrak added inline comments. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:15 +! CHECK: "{{[^"]*}}flang-new" "-fc1" "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fopenmp" {{.*}} "-fopenmp-is-device" {{.*}}.f90" +! CHECK: "{{[^"]*}}clang-offload-packager" {{.*}}

[PATCH] D145921: [clangd] Add missing unittests to build graph

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21 EXPECT_UNAVAILABLE("struct S { ^ };"); - EXPECT_UNAVAILABLE("union ^U {};"); + EXPECT_AVAILABLE("union ^U {};"); EXPECT_AVAILABLE("struct ^S { S(const S&);

[PATCH] D145922: [clangd] Include SpecialMembersTests.cpp to the unittest.

hokein abandoned this revision. hokein added a comment. I didn't notice https://reviews.llvm.org/D145921, let's deprecate this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145922/new/ https://reviews.llvm.org/D145922

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

MattDevereau updated this revision to Diff 504588. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145505/new/ https://reviews.llvm.org/D145505 Files: clang/include/clang/Basic/AArch64SVEACLETypes.def clang/lib/AST/ASTContext.cpp

[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

Arsenic updated this revision to Diff 504594. Arsenic added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145869/new/ https://reviews.llvm.org/D145869 Files: clang/include/clang/Driver/Options.td

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

PiotrZSL added a comment. Thank you for information, I will look into this Indeed test for this scenario is missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142587/new/ https://reviews.llvm.org/D142587

[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

dang added inline comments. Comment at: clang/test/ExtractAPI/ignored-symbols-multifile.c:34 +//--- ignores-list1 +IGNORED_FILE1_1 +IGNORED_FILE1_2 This test doesn't check the symbol name sorting behavior across multiple files, which is crucial

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

kiranchandramohan added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:112-114 + case llvm::Triple::riscv64: +getTargetFeatures(D, Triple, Args, CmdArgs, /*ForAs*/ false); +break; jrtc27 wrote: > mnadeem wrote: > > identical code,

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon updated this revision to Diff 504592. agozillon added a comment. - [Flang][Driver] Try to fix failing omp-frontend-forwarding.f90 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 Files:

[clang-tools-extra] fd299a7 - [clangd] Remove the IncludeStructure::isSelfContained API.

Author: Haojian Wu Date: 2023-03-13T12:37:38+01:00 New Revision: fd299a7880ae80911001590242e2cbdb55f24a37 URL: https://github.com/llvm/llvm-project/commit/fd299a7880ae80911001590242e2cbdb55f24a37 DIFF: https://github.com/llvm/llvm-project/commit/fd299a7880ae80911001590242e2cbdb55f24a37.diff

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

CarolineConcatto accepted this revision. CarolineConcatto added a comment. This revision is now accepted and ready to land. Thank you Matt. It LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145505/new/ https://reviews.llvm.org/D145505

[PATCH] D145921: [clangd] Add missing unittests to build graph

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Also

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

vabridgers added a comment. @balazske and I discussed, he will be commandeering this patch to improve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145868/new/ https://reviews.llvm.org/D145868 ___

[PATCH] D145922: [clangd] Include SpecialMembersTests.cpp to the unittest.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This file was missing

[PATCH] D145917: [clangd] Remove the IncludeStructure::isSelfContained API.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd299a7880ae: [clangd] Remove the IncludeStructure::isSelfContained API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127184: [clangd] Add to header map

kadircet added a comment. we can also handle them through the stdlib symbol mappings, see https://github.com/llvm/llvm-project/issues/61373 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184

[PATCH] D145921: [clangd] Add missing unittests to build graph

kadircet updated this revision to Diff 504597. kadircet marked an inline comment as done. kadircet added a comment. - Disable special members tweaks on unions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145921/new/

[PATCH] D145921: [clangd] Add missing unittests to build graph

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21 EXPECT_UNAVAILABLE("struct S { ^ };"); - EXPECT_UNAVAILABLE("union ^U {};"); + EXPECT_AVAILABLE("union ^U {};");

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

balazske commandeered this revision. balazske edited reviewers, added: vabridgers; removed: balazske. balazske added a comment. Herald added subscribers: steakhal, Szelethus, dkrupp. My opinion is that we can not omit importing the "underlying type". The `TypedefType` has the type of the

[PATCH] D145921: [clangd] Add missing unittests to build graph

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. doh, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145921/new/ https://reviews.llvm.org/D145921

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce updated this revision to Diff 504548. sunshaoce added a comment. Based on everyone's comments, I merged the test into `target-cpu-features.f90` and only kept the generic `-target-feature`. At the same time, I removed the `switch (TC.getArch())` and passed the test on x86 and RISC-V

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

hch12907 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20273 + Style.ColumnLimit = 20; + EXPECT_EQ( + "demo = std::array<\n" MyDeveloperDay wrote: > any reason you didn't use verifyFormat here? No particular reason - I simply

[PATCH] D145906: [clang-tidy] Correctly handle evaluation order of designated initializers.

mboehme created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. As designated

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:449 // No diagnostic if region was modified inside the frame. if (!CallExitLoc || isModifiedInFrame(N)) return nullptr; We also lost this,

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added a comment. Herald added a subscriber: jobnoorman. > Fix the issue of .o file generated by Flang with Flags info is 0x0 under > RISC-V. TBH, I don't see how this is addressed in this patch. If that's something that this patch is intending to fix, then there should be a

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 504577. karapsinie marked an inline comment as done. karapsinie added a comment. Fulfilled the wishes of cor3ntin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h

[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

dang added inline comments. Comment at: clang/test/ExtractAPI/ignored-symbols-multifile.c:27 + +// CHECK-NOT: IGNORED_1_FILE3 +// CHECK-NOT: IGNORED_7_FILE3 Should this not be a 6? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145921: [clangd] Add missing unittests to build graph

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe26dad0a661e: [clangd] Add missing unittests to build graph (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] e26dad0 - [clangd] Add missing unittests to build graph

Author: Kadir Cetinkaya Date: 2023-03-13T13:06:31+01:00 New Revision: e26dad0a661e055076002d0de4ceb713b8ca6917 URL: https://github.com/llvm/llvm-project/commit/e26dad0a661e055076002d0de4ceb713b8ca6917 DIFF:

[clang] e264fe8 - [doc] [Modules] Document how to implement ABI compatible code in module units

Author: Chuanqi Xu Date: 2023-03-13T16:44:10+08:00 New Revision: e264fe89e37fc0b12e18d72ed98056cea1a9eba6 URL: https://github.com/llvm/llvm-project/commit/e264fe89e37fc0b12e18d72ed98056cea1a9eba6 DIFF: https://github.com/llvm/llvm-project/commit/e264fe89e37fc0b12e18d72ed98056cea1a9eba6.diff

[PATCH] D145916: [clangd] Remove IWYU handling code that is used only for the old unused-include feature.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The old implementation has been

[PATCH] D145917: [clangd] Remove the IncludeStructure::isSelfContained API.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This API was merely used in the

[PATCH] D144453: [clangd] Fix a bug in TweakTest::decorate()

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Good catch, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144453/new/ https://reviews.llvm.org/D144453

[PATCH] D145919: [libc++] Add missing include in exception_ptr.h

hans created this revision. hans added a reviewer: philnik. hans added a project: libc++. Herald added a project: All. hans requested review of this revision. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Windows builds were failing due to missing include for

[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

Arsenic updated this revision to Diff 504590. Arsenic added a comment. Update clang/test/ExtractAPI/ignored-symbols-multifile.c : Shuffle the order of ignored symbols in test to check the sorting behaviour of APIIgnoresList Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] be39dae - [clangd] Remove IWYU handling code that is used only for the old unused-include feature.

Author: Haojian Wu Date: 2023-03-13T12:34:34+01:00 New Revision: be39daea846e6b5d43a8ee0c387feb0a556ff386 URL: https://github.com/llvm/llvm-project/commit/be39daea846e6b5d43a8ee0c387feb0a556ff386 DIFF: https://github.com/llvm/llvm-project/commit/be39daea846e6b5d43a8ee0c387feb0a556ff386.diff

[PATCH] D145916: [clangd] Remove IWYU handling code that is used only for the old unused-include feature.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe39daea846e: [clangd] Remove IWYU handling code that is used only for the old unused-include… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM once you fix the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145869/new/ https://reviews.llvm.org/D145869

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CompileCommands.cpp:199 + // use/change working directory, which ExpandResponseFiles doesn't). + FS =

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker On AIX, libraries are still being linked when `-r` is passed to the driver. This patch corrects this error.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145899 Files:

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe updated this revision to Diff 504517. mikecrowe marked 2 inline comments as done. mikecrowe added a comment. Documentation updates suggested by @PiotrZSL. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 504515. dhruvachak added a comment. Herald added subscribers: mattd, asavonic. Addressed comment. Using the alloca insert point for kernel args alloca. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504516. francii added a comment. Move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added a comment. Why does "flang/test/Driver/target-features.f90" list all RISC-V features? Why not use https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/target-cpu-features.f90 instead? Comment at: flang/test/Driver/target-features.f90:1 +! RUN:

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

jrtc27 added inline comments. Comment at: flang/test/Driver/target-features.f90:1 +! RUN: %flang --target=riscv64-linux-gnu --target=riscv64 -c %s -### 2>&1 \ +! RUN: | FileCheck %s -check-prefix=CHECK-RV64 awarzynski wrote: > jrtc27 wrote: > > awarzynski wrote:

[clang] 2e9977c - [C++20] [Modules] Treat module linkage as formal linkage only

Author: Chuanqi Xu Date: 2023-03-13T15:54:40+08:00 New Revision: 2e9977c2815653c141c6c060c4e0ab6c0db27911 URL: https://github.com/llvm/llvm-project/commit/2e9977c2815653c141c6c060c4e0ab6c0db27911 DIFF: https://github.com/llvm/llvm-project/commit/2e9977c2815653c141c6c060c4e0ab6c0db27911.diff

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe updated this revision to Diff 504537. mikecrowe edited the summary of this revision. mikecrowe added a comment. Quote types and functions correctly in redundant-string-cstr.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/

[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

lime updated this revision to Diff 504535. lime added a comment. Update and ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145491/new/ https://reviews.llvm.org/D145491 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransform.h

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

Pierre-vh added a comment. I'll wait a couple of more days and then land, if no one has any objections. As said before this has been deprecated for a long time, and clang was already warning on use of those options. Removal has been pending for a while :) Repository: rG LLVM Github Monorepo

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

jrtc27 added inline comments. Comment at: flang/test/Driver/target-features.f90:1 +! RUN: %flang --target=riscv64-linux-gnu --target=riscv64 -c %s -### 2>&1 \ +! RUN: | FileCheck %s -check-prefix=CHECK-RV64 awarzynski wrote: > What happens if the RISC-V backend

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504518. francii added a comment. Move `-r` check in `CommonArgs.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/redundant-string-cstr.rst:18 + or proper overload candidates that can do so should exist. This can be + used to configure functions such as fmt::format, spdlog::logger::info, +

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added inline comments. Comment at: flang/test/Driver/target-features.f90:1 +! RUN: %flang --target=riscv64-linux-gnu --target=riscv64 -c %s -### 2>&1 \ +! RUN: | FileCheck %s -check-prefix=CHECK-RV64 jrtc27 wrote: > awarzynski wrote: > > What happens

  1   2   3   4   >