[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

junaire added reviewers: aaron.ballman, tbaeder, shafik. junaire added a comment. I don't have enough context on this patch, but obviously, there's something you can improve. 1. You need to add a test, maybe somewhere in `clang/test/Sema/` 2. Please make a detailed summary of your patch so

[clang] 9795aa0 - [RISCV] Support vector crypto extension ISA string and assembly

Author: 4vtomat Date: 2023-03-25T05:15:55-07:00 New Revision: 9795aa042a843811120b1b2ef4f8a6d7f398a369 URL: https://github.com/llvm/llvm-project/commit/9795aa042a843811120b1b2ef4f8a6d7f398a369 DIFF: https://github.com/llvm/llvm-project/commit/9795aa042a843811120b1b2ef4f8a6d7f398a369.diff LOG:

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rG9795aa042a84: [RISCV] Support vector crypto extension ISA string and assembly (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

aaron.ballman added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:848 case APFloat::S_Float8E4M3FNUZ: + case APFloat::S_Float8E4M3B11FNUZ: llvm_unreachable("Tried to mangle unexpected APFloat semantics"); Why are there no changes needed

[clang] 254a71b - [Clang] Update DR status page to reflect Core Issues List 111.

Author: Corentin Jabot Date: 2023-03-25T13:20:11+01:00 New Revision: 254a71b6d2ef6a0ee1c1b2b9706ab56a56b7663f URL: https://github.com/llvm/llvm-project/commit/254a71b6d2ef6a0ee1c1b2b9706ab56a56b7663f DIFF:

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146420/new/ https://reviews.llvm.org/D146420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

owenpan updated this revision to Diff 508293. owenpan added a comment. Don't format imaginary numbers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146844/new/ https://reviews.llvm.org/D146844 Files: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. Also, regarding clang-analyzer-core checks, I have 2 tickets open: https://github.com/llvm/llvm-project/issues/59588 https://github.com/llvm/llvm-project/issues/59589 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL added a comment. @carlosgalvezp Do you want me to shorten documentation ? Or we leave it like it is ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 508303. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase + Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files:

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

aaron.ballman added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { cor3ntin wrote: > aaron.ballman wrote: > >

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL marked 8 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp:220 + if (!isAnyOperatorEnabled(OverloadedOperators, OperatorsRepresentation) && +

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 508297. Krishna-13-cyber added a comment. Updated with the new test cases and implemented the logic suggested for ignoring the BO_LOr operators at the top level. My sincere apologies @tbaeder that I could not place this logic at the first instance.

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. Reading through Github I found the associated ticket (it would be good if you could mention it in the commit message): https://github.com/llvm/llvm-project/issues/61520 So if I understand correctly, what you are trying to do is continue to let the

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Your understanding is correct, I'm currently just trying to hide them at the end (warnings-as-errors or not). This is how it worked until 5d12b13b0b26bc58b02ee23c369da8b83240cceb (present in LLVM 16)

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper created this revision. Herald added a project: All. simideveloper requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146867 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added a comment. Looks really good, thank you! I have only very minor comments, mostly style nits and suggestions for improved readability. Comment at: clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp:25 + +StringRef

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper added a comment. I am an outreachy applicant and working on this issue for the past some weeks for my contribution on the community page till that time this issue was listed on the introductory issues list on the outreachy page I thought this issue is still open but was not aware

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin updated this revision to Diff 508299. cor3ntin added a comment. - Address Aaron's and Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146719/new/ https://reviews.llvm.org/D146719 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { aaron.ballman wrote: > Would this change make

[PATCH] D146420: Document the Clang policies on claiming support for a feature

aaron.ballman updated this revision to Diff 508301. aaron.ballman added a comment. Fixing a typo pointed out off-list (missed an "as"). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146420/new/ https://reviews.llvm.org/D146420 Files: clang/docs/InternalsManual.rst Index:

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

cor3ntin added a comment. Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { aaron.ballman wrote: > cor3ntin wrote: > >

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. I noticed the pre-merge checks are red, however, would be good to get them fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM thank you! Really useful check! I'm not very expert in the PP callbacks so I can't give much feedback, feel free to wait for other more expert reviewers if you want.

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. I'm not sure I follow - if you enable warnings as error for all checks, then the expectation is that you indeed get an error if you violate one of the clang-analyzer checks. In what way is this not wanted? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/string-constructor.rst:25 + std::string str(buf[1], 5); // First arg should be '[1]'? + std::string str2((int)buf[1], 5); // Ok - explicitly cast to express intent

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

junaire added a comment. BTW, does this patch overlaps with https://reviews.llvm.org/D146358? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867 ___ cfe-commits

[PATCH] D146420: Document the Clang policies on claiming support for a feature

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. I have some minor reservations about defining feature macros on a per-target basis but at the same time, given the current coroutines on 32 bits windows situation - which has been

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 508302. PiotrZSL added a comment. Rebase + Shorten documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files:

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 508305. bolshakov-a added a comment. Add type to USR so as not to get confused with template struct S {}; struct { int n; } s; template<> struct S<(void*)> {}; template<> struct S<> {}; Add test on structural type NTTP USR. Just a

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:139 + + Check flags always enabled or disabled code blocks in preprocessor ``#if`` + conditions, such as ``#if 0`` and ``#if 1`` etc. Please omit `Check`.

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 508311. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D146881: [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

majnemer added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:848 case APFloat::S_Float8E4M3FNUZ: + case APFloat::S_Float8E4M3B11FNUZ: llvm_unreachable("Tried to mangle unexpected APFloat semantics"); aaron.ballman wrote: > Why are there

[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

aaron.ballman added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:848 case APFloat::S_Float8E4M3FNUZ: + case APFloat::S_Float8E4M3B11FNUZ: llvm_unreachable("Tried to mangle unexpected APFloat semantics"); majnemer wrote: > aaron.ballman

[PATCH] D146882: [clang-tidy] Correct union & macros handling in modernize-use-equals-default

alexander-shaposhnikov accepted this revision. alexander-shaposhnikov added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146882/new/ https://reviews.llvm.org/D146882

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:139 + + Check helps enforce consistent token representation for invoked binary, + unary and overloaded operators in C++ code. Please omit `Check`.

[PATCH] D146873: [POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 508309. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCVVTypes.def

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

vabridgers added a comment. @balazske , I tested these changes - again - and it all seems to work for me. I would have preferred we do not see the build status failures before doing this, but maybe we can be sure to avoid this next time (because I'll want to test again before our final merge).

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

yaxunl updated this revision to Diff 508312. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. adds check for both {resource_dir}/lib/{triple} and {resource_dir}/lib/{OS}/{arch} CHANGES SINCE LAST

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently test for

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 508320. PiotrZSL added a comment. Doc update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files:

[PATCH] D146882: [clang-tidy] Correct union & macros handling in modernize-use-equals-default

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. To this moment this

[PATCH] D146883: [documentation]Fixed Random Typos

ayushi-8102 created this revision. ayushi-8102 added a reviewer: samtebbs. Herald added a reviewer: NoQ. Herald added a project: All. ayushi-8102 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project:

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl added a comment. In D145770#4220246 , @mdtoguchi wrote: > @lamb-j - is it expected for any bundled objects created before your change > without the explicit env field to be able to be unbundled? Newly generated > bundles work as expected given

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch adapts to D140059

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. In D146148#4220591 , @zahiraam wrote: > In D146148#4220495 , @aaron.ballman > wrote: > >> In D146148#4220433 , @zahiraam >> wrote: >> >>> In

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

PiotrZSL added a comment. To be honest, that's lot of hard to understand code that at start is unmaintainable. I don't see anyone even trying to understand all this and do some fixes in future. Consider some refactoring, to reduce amount of code, split it into some functions, add some

[clang] f90668c - [clang-format] Handle Verilog assign statements

Author: sstwcw Date: 2023-03-25T21:13:15Z New Revision: f90668c8ccc5cd3d8c6521cfc872f3c51f2a02db URL: https://github.com/llvm/llvm-project/commit/f90668c8ccc5cd3d8c6521cfc872f3c51f2a02db DIFF: https://github.com/llvm/llvm-project/commit/f90668c8ccc5cd3d8c6521cfc872f3c51f2a02db.diff LOG:

[PATCH] D146402: [clang-format] Handle Verilog assign statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf90668c8ccc5: [clang-format] Handle Verilog assign statements (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e01c3d28217: [clang-format] More work on space around operators in Verilog (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0e01c3d - [clang-format] More work on space around operators in Verilog

Author: sstwcw Date: 2023-03-25T21:12:23Z New Revision: 0e01c3d282179ab11101988e1e1f2763f48f6882 URL: https://github.com/llvm/llvm-project/commit/0e01c3d282179ab11101988e1e1f2763f48f6882 DIFF: https://github.com/llvm/llvm-project/commit/0e01c3d282179ab11101988e1e1f2763f48f6882.diff LOG:

[PATCH] D146873: [POC][Clang][RISCV] Define RVV tuple types

eopXD created this revision. eopXD added reviewers: craig.topper, efriedma, sdesmalen, rogfer01, frasercrmck, lebedev.ri, david-arm, jdoerfert, reames, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton,

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 508310. PiotrZSL added a comment. Fixes in documentation & clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files:

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

PiotrZSL updated this revision to Diff 508321. PiotrZSL added a comment. Fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617 Files:

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 updated this revision to Diff 508328. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/as-options.cpp clang/test/Driver/gcc_forward.c Index:

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputType

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", +

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:19 protected: - static std::string format(llvm::StringRef Code, unsigned Offset, -

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper added a comment. can you please tell me if this issue is closed or I can work on making the changes you recommended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

PiotrZSL updated this revision to Diff 508315. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Added issue reference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146875/new/ https://reviews.llvm.org/D146875 Files:

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan updated this revision to Diff 508316. zyounan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874 Files: clang-tools-extra/clangd/Hover.cpp

[clang] 731264b - [clang][NFC] Fix location of 2>&1 in a few -print tests

Author: Louis Dionne Date: 2023-03-25T15:57:20-04:00 New Revision: 731264b0c2af7aa46bd39625202a99e06cfccff9 URL: https://github.com/llvm/llvm-project/commit/731264b0c2af7aa46bd39625202a99e06cfccff9 DIFF: https://github.com/llvm/llvm-project/commit/731264b0c2af7aa46bd39625202a99e06cfccff9.diff

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG731264b0c2af: [clang][NFC] Fix location of 21 in a few -print tests (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/

[PATCH] D146885: [clang-tidy][NFC] add debug log when clean empty namespace

HerrCai0907 created this revision. HerrCai0907 added a reviewer: njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding debug log when clean empty

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 508345. ccotter marked 4 inline comments as done. ccotter added a comment. - Add more cases to swapped params - Change message, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:70-74 + const auto CharExpr = expr(anyOf( + ignoringParenImpCasts(characterLiteral()), +

[PATCH] D146887: [clang-tidy] Fix if-constexpr false-positive in readability-misleading-indentation

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. When depend on

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[clang] a8d2bff - [clang-format] Don't wrap struct return types as structs

Author: Emilia Dreamer Date: 2023-03-26T04:38:52+03:00 New Revision: a8d2bff290e1b86b4bca4007493205b4878c4f68 URL: https://github.com/llvm/llvm-project/commit/a8d2bff290e1b86b4bca4007493205b4878c4f68 DIFF:

[clang] 5409fb3 - [clang-format] Annotate lambdas with requires clauses.

Author: Emilia Dreamer Date: 2023-03-26T04:38:26+03:00 New Revision: 5409fb38372dbf65a94725ccefab2b993fbb7a9b URL: https://github.com/llvm/llvm-project/commit/5409fb38372dbf65a94725ccefab2b993fbb7a9b DIFF:

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5409fb38372d: [clang-format] Annotate lambdas with requires clauses. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bb4f6c4 - [clang-format] Treat NTTP default values as expressions

Author: Emilia Dreamer Date: 2023-03-26T04:39:10+03:00 New Revision: bb4f6c4dca98a47054117708015bb2724256ee83 URL: https://github.com/llvm/llvm-project/commit/bb4f6c4dca98a47054117708015bb2724256ee83 DIFF:

[PATCH] D146281: [clang-format] Don't wrap struct return types as structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8d2bff290e1: [clang-format] Dont wrap struct return types as structs (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146760: [clang-format] Treat NTTP default values as expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb4f6c4dca98: [clang-format] Treat NTTP default values as expressions (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

brad updated this revision to Diff 508373. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://reviews.llvm.org/D146891 Files: clang/lib/Driver/ToolChains/NetBSD.cpp clang/test/Driver/netbsd.c clang/test/Driver/netbsd.cpp

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae created this revision. python3kgae added reviewers: rjmccall, Quuxplusone, riccibruno. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes 42469

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 508351. ccotter marked 8 inline comments as done. ccotter added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 508350. zhouyizhou added a comment. Add 128-bit integer support to enum element like GCC extension do. Also test coverage around _BitInt which can be arbitrarily large depending on the target. Also leave room for improvements to C2X because C2x made

[PATCH] D146889: [documentation]Fixed Random Typos

ayushi-8102 created this revision. ayushi-8102 added a reviewer: samtebbs. Herald added a reviewer: NoQ. Herald added a project: All. ayushi-8102 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project:

[PATCH] D146892: [documentation]Fixed Random Typo

ayushi-8102 created this revision. ayushi-8102 added a reviewer: samtebbs. Herald added a subscriber: dmgreen. Herald added a reviewer: NoQ. Herald added a project: All. ayushi-8102 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits,

[PATCH] D146895: [clang-format] Don't annotate left brace of struct as FunctionLBrace

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Related to

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 marked 2 inline comments as done. Ruturaj4 added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:347 +if (TagTy->getDecl()->isStruct()) { + for (const auto : API.getStructs()) { +if (Decl->getName() ==

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

nridge added a comment. Thanks for the clarification and suggested formulation. In D145843#4209750 , @sammccall wrote: > I'd suggest something like: > > Style: > QuotedHeaders: "path/to/.*" > AngledHeaders: "path/sdk/.*" > > where the regexes

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

PiotrZSL added a comment. First, https://reviews.llvm.org/D144347 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146888/new/ https://reviews.llvm.org/D146888 ___ cfe-commits mailing list

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

brad created this revision. brad added a reviewer: fcambus. brad added a project: clang. Herald added subscribers: fedor.sergeev, krytarowski. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. NetBSD 6.x and older is ancient.

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

brad updated this revision to Diff 508376. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://reviews.llvm.org/D146891 Files: clang/lib/Driver/ToolChains/NetBSD.cpp clang/test/Driver/netbsd.c clang/test/Driver/netbsd.cpp

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 updated this revision to Diff 508375. Ruturaj4 added a comment. 1. Updating D146385 : [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef # 2. Enter a brief description of the changes included in this update. 3.