[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 509910. alexander-shaposhnikov added a comment. Rebased + rerun all the tests + internal testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[clang] e9b150c - [clang][Interp][NFC] Add missing static_assert message

Author: Timm Bäder Date: 2023-03-31T08:22:34+02:00 New Revision: e9b150c2d9bb856f371d201d9968b504e12d98a3 URL: https://github.com/llvm/llvm-project/commit/e9b150c2d9bb856f371d201d9968b504e12d98a3 DIFF: https://github.com/llvm/llvm-project/commit/e9b150c2d9bb856f371d201d9968b504e12d98a3.diff

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509911. AMS21 marked 3 inline comments as done. AMS21 added a comment. Fixed docs and cleanup tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:45-49 +const auto *ProtoType = Decl->getType()->castAs(); +const Expr *NoexceptExpr = ProtoType->getNoexceptExpr(); +if (NoexceptExpr) { +

[clang] 068e0e0 - [clang][Interp][NFC] Add failing test case for InterpFrame::describe()

Author: Timm Bäder Date: 2023-03-31T08:32:42+02:00 New Revision: 068e0e001d63a76fcec0cb585ffe8832794115eb URL: https://github.com/llvm/llvm-project/commit/068e0e001d63a76fcec0cb585ffe8832794115eb DIFF: https://github.com/llvm/llvm-project/commit/068e0e001d63a76fcec0cb585ffe8832794115eb.diff

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These methods provide a less verbose way of

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

kito-cheng added a comment. I would support have `-march=help`, but I know it's really not make scene to alias `-march=help` to `--print-supported-extensions` for other targets, what about redirect that in `Driver.cpp` for RISC-V only? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fce093c - [clang][Interp] Fix parameter map when re-visiting function

Author: Timm Bäder Date: 2023-03-31T08:06:06+02:00 New Revision: fce093ccb1c56b57bc26c47b47e2a0388953a27f URL: https://github.com/llvm/llvm-project/commit/fce093ccb1c56b57bc26c47b47e2a0388953a27f DIFF: https://github.com/llvm/llvm-project/commit/fce093ccb1c56b57bc26c47b47e2a0388953a27f.diff

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfce093ccb1c5: [clang][Interp] Fix parameter map when re-visiting function (authored by tbaeder). Changed prior to commit:

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295 ___ cfe-commits mailing list

[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar updated this revision to Diff 509912. tstellar added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/

[PATCH] D147165: [Windows SEH] Fix catch+return crash for Windows -EHa

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, pls wait for 1 or 2 days in case there are comments from others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147165/new/

[clang] d29f706 - [clang][Interp] Fix binary comma operators

Author: Timm Bäder Date: 2023-03-31T14:54:51+02:00 New Revision: d29f70670db8ca43a49b6df9112035dc4b646182 URL: https://github.com/llvm/llvm-project/commit/d29f70670db8ca43a49b6df9112035dc4b646182 DIFF: https://github.com/llvm/llvm-project/commit/d29f70670db8ca43a49b6df9112035dc4b646182.diff

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai accepted this revision. nemanjai added subscribers: maryammo, kamaub, stefanp. nemanjai added a comment. This revision is now accepted and ready to land. This looks fine to me. I'd like some of the devs that have added builtins with Sema checking in the past to have a look here as well.

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 510022. jp4a50 added a comment. Alphabetical ordering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL added a comment. @carlosgalvezp Thank you, by any chance would you be able to look into other reviews ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG943ef0642010: [clang][Interp] Check This pointer without creating InterpFrame (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510032. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D147328: [clang-format] Handle enum in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Verilog has enum just like C. Repository: rG LLVM

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510014. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def

[PATCH] D147329: [clang-format] Handle Verilog struct literals

sstwcw created this revision. Herald added subscribers: cfe-commits, ctetreau. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously `isVerilogIdentifier` was mistaking the

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. Could I get a re-review on this one please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 ___ cfe-commits mailing list

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510039. VitaNuo added a comment. Rename function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

PiotrZSL abandoned this revision. PiotrZSL added a comment. Obsolete by D144522 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107294/new/ https://reviews.llvm.org/D107294

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

cjdb added a comment. Thanks so much for seeing this through; I'm unusually looking forward to rebuilding LLVM this weekend! Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:82 + +.. option:: OverloadedOperators +

[PATCH] D141831: [clang][Interp] Fix double-printing in InterpFrame::describe()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd472c55fa28a: [clang][Interp] Fix double-printing InterpFrame::describe() (authored by tbaeder). Changed prior to commit:

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2899acbcf1: [clang][Interp] Handle TypeTraitExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8d2899a - [clang][Interp] Handle TypeTraitExprs

Author: Timm Bäder Date: 2023-03-31T15:54:44+02:00 New Revision: 8d2899acbcf1b8ce120bc219aeb30207d4422042 URL: https://github.com/llvm/llvm-project/commit/8d2899acbcf1b8ce120bc219aeb30207d4422042 DIFF: https://github.com/llvm/llvm-project/commit/8d2899acbcf1b8ce120bc219aeb30207d4422042.diff

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon created this revision. Herald added subscribers: sunshaoce, bzcheeseman, rriddle, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a reviewer: kiranchandramohan. Herald added projects: Flang, All. agozillon requested review of this

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510038. sstwcw added a comment. Generate doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510036. VitaNuo added a comment. Remove extra formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510041. tkuchta marked an inline comment as done. tkuchta added a comment. Hello, I applied the review comments for strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files:

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added subscribers: debug-info, probinson. probinson added a comment. I think we cannot be 100% sure about source paths in a cross-compile situation. Cross-compiling on platform A targeting platform B does not mean your sources and debugger UI are on platform B. My users keep source

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the check! Please fix the missing space comment before landing. Comment at:

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The deduplicated code is moved into initVars().

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo abandoned this revision. VitaNuo added a comment. Erroneously created patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147325/new/ https://reviews.llvm.org/D147325 ___ cfe-commits mailing

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264 +- Improved :doc:`readability-static-accessed-through-instance + ` check to Please keep alphabetical order (by check name) in this section. Repository: rG LLVM

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. there is a strange build error which seems unrelated to my change - please let me know if that's an issue, I will try to rebase to newest master then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa084854266ca: [clang-tidy] Add readability-operators-representation check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D144522?vs=508310=510055#toc Repository: rG LLVM

[clang-tools-extra] a084854 - [clang-tidy] Add readability-operators-representation check

Author: Piotr Zegar Date: 2023-03-31T16:07:16Z New Revision: a084854266ca60748982228a4c98d036bca5f762 URL: https://github.com/llvm/llvm-project/commit/a084854266ca60748982228a4c98d036bca5f762 DIFF: https://github.com/llvm/llvm-project/commit/a084854266ca60748982228a4c98d036bca5f762.diff LOG:

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

ymandel accepted this revision. ymandel added a comment. Thank you! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl);

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510017. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def

[clang] 943ef06 - [clang][Interp] Check This pointer without creating InterpFrame

Author: Timm Bäder Date: 2023-03-31T16:18:15+02:00 New Revision: 943ef06420105cad23e3caea24d6a274cdb0316f URL: https://github.com/llvm/llvm-project/commit/943ef06420105cad23e3caea24d6a274cdb0316f DIFF: https://github.com/llvm/llvm-project/commit/943ef06420105cad23e3caea24d6a274cdb0316f.diff

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. In D147256#4237099 , @probinson wrote: > I think we cannot be 100% sure about source paths in a cross-compile > situation. Cross-compiling on platform A targeting platform B does not mean > your sources and debugger UI are on

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak MyDeveloperDay wrote: > did you check generating the html from the

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. In D145264#4236173 , @kiranchandramohan wrote: > Please split this patch into three: > > 1. Code changes and testing for the driver and the FIR+OpenMP dialect > generated. > 2. Code changes and test for FIR+OpenMP to

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510042. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 510057. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files:

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4236522 , @hans wrote: > Thanks for working on this! > > The `-ffile-reproducible` flag name refers to making `#file` directives > reproducible, but `LangOptions.UseTargetPathSeparator` sounds a lot broader > :) I

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon updated this revision to Diff 510080. agozillon added a comment. - Add FIR -> LLVM Dialect test here, more fitting than the other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147324/new/ https://reviews.llvm.org/D147324 Files:

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added a comment. We're getting really close! Yes, that build error looks unrelated. Someone should fix it soon. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base,

[PATCH] D147321: [Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada created this revision. domada added reviewers: dpalermo, skatrak, TIFitis, RogerV-AMD, kiranchandramohan, agozillon, kiranktp, NimishMishra. domada added projects: Flang, OpenMP. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui,

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. Thanks for working on this! The `-ffile-reproducible` flag name refers to making `#file` directives reproducible, but `LangOptions.UseTargetPathSeparator` sounds a lot broader :) I don't know what others think, but it would be nice to not have to introduce any more flags

[clang] d472c55 - [clang][Interp] Fix double-printing InterpFrame::describe()

Author: Timm Bäder Date: 2023-03-31T15:25:30+02:00 New Revision: d472c55fa28a249e1845908b47a1be6f2e05a1cd URL: https://github.com/llvm/llvm-project/commit/d472c55fa28a249e1845908b47a1be6f2e05a1cd DIFF: https://github.com/llvm/llvm-project/commit/d472c55fa28a249e1845908b47a1be6f2e05a1cd.diff

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. The flag addition and FlagsAttr generation component of: https://reviews.llvm.org/D145264 the LLVM-IR generation will come in a subsequent phabricator patch once I have created some additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147327: [clang-format] Add option for having one port on a line in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" qiongsiwu1 wrote: > hubert.reinterpretcast wrote: > > This needs the backend

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510047. tkuchta added a comment. Updates after the review of strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:465 + /// referenced in `FuncDecl`. `FuncDecl` must have a body. + void initVars(const FunctionDecl *FuncDecl); I wonder if we should rename this to

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

PiotrZSL abandoned this revision. PiotrZSL added a comment. Obsolete by D144522 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31308/new/ https://reviews.llvm.org/D31308 ___ cfe-commits mailing list

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510056. krzysz00 edited the summary of this revision. krzysz00 added a comment. Per discussion on the s.buffer.load revision, don't make those changes, and so revert this patch back to what it used to be. Repository: rG LLVM Github Monorepo CHANGES

[clang] 758bca6 - [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

Author: Ben Langmuir Date: 2023-03-31T09:43:22-07:00 New Revision: 758bca6483853a743297b68bd88a5dba9d5247f2 URL: https://github.com/llvm/llvm-project/commit/758bca6483853a743297b68bd88a5dba9d5247f2 DIFF: https://github.com/llvm/llvm-project/commit/758bca6483853a743297b68bd88a5dba9d5247f2.diff

[PATCH] D147282: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG758bca648385: [clang][deps] Remove -coverage-data-file and -coverage-notes-file from modules (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. Fragmented this patch into https://reviews.llvm.org/D147344 (lowering) and https://reviews.llvm.org/D147324 (driver/tool changes and application of attribute). I will keep this patch open until the others are closed to give a big picture for easier reference.

[PATCH] D141784: [clang][Interp] Fix binary comma operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd29f70670db8: [clang][Interp] Fix binary comma operators (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 9 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:119 + + std::unique_ptr GenModule(); + v.g.vassilev wrote: > We should not need this interface. `Interpreter::CompileDecl` needs

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510027. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files:

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/XRefs.cpp:1348 + auto Loc = SM.getFileLoc(Ref.RefLocation); + for (const auto : Providers) { +auto MatchingIncludes = ConvertedMainFileIncludes.match(H);

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:100 +// used `StorageLocation` subclasses and make them use a

[PATCH] D146987: [Assignment Tracking] Enable by default

haowei added a comment. This patch (which enables assignment tracking) and D147312 breaks llvm runtime build for `runtimes-armv7-unknown-linux-gnueabihf` Error message: FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 510108. dkrupp added a comment. This is a totally rewritten version of the patch which solely relies on the existing "interestingness" utility to track back the taint propagation. (And does not introduce a new FlowID in the ProgramState as requested in the

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb abandoned this revision. cjdb added a comment. In D147288#4237413 , @royjacobson wrote: > There was some discussion of this last year in this review: > https://reviews.llvm.org/D128750 > > It's such an edge case that I don't think we should lose

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { browneee wrote: > `base, sizeof(base)` does not make

[PATCH] D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

HerrCai0907 added a comment. In D147315#4236403 , @PiotrZSL wrote: > Add test with scoped enums, to validate that it works correctly. > In theory this change should suport them also. scoped enum not support to visit by member. `EnumName::` is needed for

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { tkuchta wrote: > browneee wrote: > > `base,

[clang] 253985d - [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

Author: Owen Pan Date: 2023-03-31T17:14:33-07:00 New Revision: 253985d58caf95db8a84632d5a761b96fb7cd7d6 URL: https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6 DIFF: https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6.diff

[PATCH] D147111: [clang-format] Add MinDigits suboptions to IntegerLiteralSeparator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG253985d58caf: [clang-format] Add MinDigits suboptions to

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:949 + /// If unset, ``ContinuationIndentWidth`` is used. + /// \code + /// AlignAfterOpenBracket: AlwaysBreak HazardyKnusperkeks wrote: > jp4a50 wrote: > > MyDeveloperDay wrote:

[PATCH] D147328: [clang-format] Handle enum in Verilog

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1712 break; - // This only applies for C++. - if (!Style.isCpp()) { + // This only applies for C++ and Verilog. + if (!Style.isCpp()

[PATCH] D147365: [HIPSPV] Remove useIntegratedAs. NFC

jhuber6 added a comment. I don't know the toolchain, does `HIPSPV` perform as expected if you pass `-fno-integrated-as`? The difference is that `useIntegratedAs` forces it to always be enabled so the user can't change it AFAIK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:99 + unless(isExpansionInSystemHeader()), argumentCountIs(1U), + IgnoreDependentExpresions + ?

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

aprantl added a comment. I think `debug_trampoline` both captures the semantics and makes it clear that this is related to debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595

[clang] 43825d1 - Revert "[Assignment Tracking] Enable by default"

Author: Haowei Wu Date: 2023-03-31T11:27:18-07:00 New Revision: 43825d19318695be48abe6f042369da00fbb808b URL: https://github.com/llvm/llvm-project/commit/43825d19318695be48abe6f042369da00fbb808b DIFF: https://github.com/llvm/llvm-project/commit/43825d19318695be48abe6f042369da00fbb808b.diff

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman updated this revision to Diff 510099. aaron.ballman added a comment. Oops, previous diff missed a change that was only locally staged. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147349/new/ https://reviews.llvm.org/D147349 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione updated this revision to Diff 510141. kastiglione added a comment. minor cleanup of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 Files:

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a42a7b4e873: [clang-format] Dont misannotate left squares as lambda introducers (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 2a42a7b - [clang-format] Don't misannotate left squares as lambda introducers

Author: Owen Pan Date: 2023-03-31T16:13:03-07:00 New Revision: 2a42a7b4e87395ae2a4321292f0fd9dce401b4e1 URL: https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1 DIFF: https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1.diff

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

owenpan added a comment. In D147295#4235648 , @rymiel wrote: > This is great! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

stefanp added a comment. Overall I think that this looks fine to me as well. I had a couple of minor comments and you may decide that you don't need to do either one so if that's the case just mention why in a comment and I will approve the patch. Comment at:

[PATCH] D147349: [C2x] Implement support for empty brace initialization (WG14 N2900 and WG14 N3011)

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, efriedma, erichkeane, cor3ntin, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This implements support for allowing `{}` to consistently

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

royjacobson added a comment. There was some discussion of this last year in this review: https://reviews.llvm.org/D128750 It's such an edge case that I don't think we should lose sleep about it until/unless the committee finds time to clarify the issue. Repository: rG LLVM Github Monorepo

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jplehr added a comment. In D140722#4219182 , @nextsilicon-itay-bookstein wrote: > Minor fix to the clang/CodeGen/ppc64le-varargs-f128.c test. > > @jdoerfert Does the PR CI run these, or are there build bots that cover the > different target-offloading

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects potentially

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/optional-value-conversion.rst:46 +expressions that match the methods. +Default value is `"::value$;::get$`. Unintended quote in value. Repository: rG

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I will leave this review open for 1 more week, in case someone have some comments, and by someone I mean you @carlosgalvezp. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 +

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

amyk added a comment. Overall looks OK to me, as well. I just had two questions that I wanted to ask. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector")

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

maryammo added a comment. It looks good to me, just added a minor question as I was not able to verify that. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector")

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 510132. PiotrZSL added a comment. Fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

  1   2   >