[PATCH] D151121: [Clang][UBSan] Fix the crash caused by __builtin_assume_aligned with -no-opaque-pointers enabled

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yronglin Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151121 Files:

[PATCH] D148573: Allow -fsanitize=function on all targets

sbc100 added a comment. This change seems to be causing problems on the emscripten auto-roller: https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8780394114149321217/overview Failures show up in ubsan tests and look like this: error: symbol '_Z4testi' unsupported

[PATCH] D145183: [libc++] Implement `stop_token`

clementval added a comment. Herald added a subscriber: JDevlieghere. Something seems wrong with this patch. It contains multiple unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145183/new/ https://reviews.llvm.org/D145183

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4355229 , @paperchalice wrote: > In D141907#4355228 , @tstellar > wrote: > >> @paperchalice Do you need someone to commit this for you? > > Sure, I don't have the commit

[PATCH] D151034: [clang] Add test for CWG1397

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151034/new/ https://reviews.llvm.org/D151034

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > hnrklssn wrote: > > nikic

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151059: [test] Add C++ ext_vector_type tests

porglezomp updated this revision to Diff 524429. porglezomp added a comment. Address review comments. File GitHub issues and reference them with the FIXMEs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/ https://reviews.llvm.org/D151059

[PATCH] D123649: Allow flexible array initialization in C++.

aaron.ballman added a comment. In D123649#4362402 , @efriedma wrote: > The assertion is correct; without it, your code is getting miscompiled. The assertion may be correct in its intent, but we still should not be asserting in practice:

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

jhuber6 added a comment. In D151087#4361237 , @ebevhan wrote: > Clang hasn't needed to formalize all of the address space behavior because > it's managed to piggyback off of the language semantics provided by OpenCL, > and no targets really have had a

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

nickdesaulniers updated this revision to Diff 524359. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150892/new/ https://reviews.llvm.org/D150892 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148573: Allow -fsanitize=function on all targets

sbc100 added a comment. (I guess this also mean we are lacking some upstream testing for ubsan + wasm + mc?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/ https://reviews.llvm.org/D148573

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks updated this revision to Diff 524406. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 Files: llvm/lib/Passes/PassBuilderPipelines.cpp

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c5c1ab2a18: [clang][ExprConstant] fix __builtin_object_size for flexible array members (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 57c5c1a - [clang][ExprConstant] fix __builtin_object_size for flexible array members

Author: Nick Desaulniers Date: 2023-05-22T11:38:38-07:00 New Revision: 57c5c1ab2a188b7962c9de5ac0f95e3c7441940a URL: https://github.com/llvm/llvm-project/commit/57c5c1ab2a188b7962c9de5ac0f95e3c7441940a DIFF:

[PATCH] D151133: [clang-tidy] Ignore implicit code in bugprone-branch-clone

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Implicit code like,

[PATCH] D151034: [clang] Add test for CWG1397

Endill added a comment. Thank you for the review! Comment at: clang/test/CXX/drs/dr13xx.cpp:488 +#if __cplusplus == 201103L + // expected-error@#dr1397-struct-A {{default member initializer for 'p' needed within definition of enclosing class 'A' outside of member functions}}

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. Hello Egenii, Thank you for your time and consideration of this PR. Since you last commented, @vitalybuka has approved the PR and added @maskray and yourself as blocking reviewers. @maskray has approved and we are awaiting your approval if you remain positive to it

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

aaron.ballman added a comment. The address space feature is governed by TR 18037 (https://standards.iso.org/ittf/PubliclyAvailableStandards/c051126_ISO_IEC_TR_18037_2008.zip), see section 5. The TR says (in part): > A non-null pointer into an address space A can be cast to a pointer into >

[PATCH] D123649: Allow flexible array initialization in C++.

ahatanak added a comment. The assertion also fails when the following code is compiled: struct S { int i[]; }; S value{0}; According to C99, flexible array members have to belong to structs that have more than one named member. But clang allows that as a GNU extension although gcc seems

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 524491. cor3ntin added a comment. In FunctionScopeInfo, only track that an immediate-escalating expression has been found rather than which one - as that is recorded on the expression itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151166: [clangd] Interactive AST matchers with #pragma clang query

sammccall updated this revision to Diff 524519. sammccall edited the summary of this revision. sammccall added a comment. Add demo link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151166/new/ https://reviews.llvm.org/D151166 Files:

[PATCH] D151130: [NFC][CLANG] Fix static code analyzer concerns with dereference null return value

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool: Inside

[PATCH] D151137: ]NFC][Clang] Fix Coverity bug with dereference null return value in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Reported by Coverity: Inside "CGExpr.cpp" file, in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr(clang::​OMPArraySectionExpr const *, bool):

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp updated this revision to Diff 524432. porglezomp added a comment. Rebasing onto modified tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151060/new/ https://reviews.llvm.org/D151060 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a request for a comment. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11196 if (D.isFunctionDefinition()) Diag(D.getIdentifierLoc(),

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

aaron.ballman added a comment. Precommit CI found various failures that need to be addressed. Also, have you tested to see what breaks in llvm-test-suite? Comment at: clang/docs/ReleaseNotes.rst:58 Clang will only search for std::coroutine_traits for coroutines then. +-

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 524351. jaredgrubb marked an inline comment as done. jaredgrubb added a comment. Address review comments: unroll a loop in unit tests to explicitly test all the property attributes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) && ldionne wrote: >

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

ebevhan added a comment. In D151087#4360859 , @jhuber6 wrote: > You can have address spaced in freestanding C++, they just need to be > assigned according to the backens, e.g. https://godbolt.org/z/ahazae6Ta. And > I don't think that's a desirable

[PATCH] D145183: [libc++] Implement `stop_token`

huixie90 updated this revision to Diff 524387. huixie90 added a comment. Herald added subscribers: cfe-commits, llvm-commits, lldb-commits, Sanitizers, TinaAMD, hoy, bviyer, wlei, jplehr, mgehre-amd, luke, hanchung, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, Enna1, bzcheeseman, mattd,

[clang] 39ba913 - [Driver] -fsanitize=function: unsupport wasm after D148573

Author: Fangrui Song Date: 2023-05-22T10:40:04-07:00 New Revision: 39ba913d13ab15c76cb6b5aa066fa111ddfe944b URL: https://github.com/llvm/llvm-project/commit/39ba913d13ab15c76cb6b5aa066fa111ddfe944b DIFF: https://github.com/llvm/llvm-project/commit/39ba913d13ab15c76cb6b5aa066fa111ddfe944b.diff

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 524408. cor3ntin marked 9 inline comments as done. cor3ntin added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. - Address Aaron's comments - Track which expressions are immediately escalating to offer better diagnostics

[PATCH] D148573: Allow -fsanitize=function on all targets

sbc100 added a comment. In D148573#4361509 , @MaskRay wrote: > In D148573#4361396 , @sbc100 wrote: > >> This change seems to be causing problems on the emscripten auto-roller: >>

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Just a side note, please link to commits, or even better the reviews here when talking about old commits. I found it through the github issue, but I think the other way around is better. I was interested in the

[PATCH] D148573: Allow -fsanitize=function on all targets

MaskRay added a comment. In D148573#4361894 , @sbc100 wrote: > In D148573#4361509 , @MaskRay wrote: > >> In D148573#4361396 , @sbc100 wrote: >> >>> This change seems to

[PATCH] D123649: Allow flexible array initialization in C++.

ahatanak added a comment. We found another case where the assertion fails. $ cat test.cpp struct S { int len; int i[]; }; S value{0, 0}; $ clang++ -std=c++11 -c test.cpp `CstSize` is only 4 while `VarSize` is 8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:362-363 HasX87 = true; +} else if (Feature == "+fullbf16") { + HasFullBFloat16 = true; } pengfei wrote: > Maybe not need it. Clarified on the other thread but if you

[PATCH] D151059: [test] Add C++ ext_vector_type tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG590eb76ba3cd: [test] Add C++ ext_vector_type tests (authored by porglezomp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/

[clang] 590eb76 - [test] Add C++ ext_vector_type tests

Author: Cassie Jones Date: 2023-05-22T15:58:01-07:00 New Revision: 590eb76ba3cd668baee7d06940ad820e89f830c4 URL: https://github.com/llvm/llvm-project/commit/590eb76ba3cd668baee7d06940ad820e89f830c4 DIFF: https://github.com/llvm/llvm-project/commit/590eb76ba3cd668baee7d06940ad820e89f830c4.diff

[clang] 986cbd8 - [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable declaration when it has a dependent type

Author: Takuya Shimizu Date: 2023-05-23T00:57:38+09:00 New Revision: 986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a URL: https://github.com/llvm/llvm-project/commit/986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a DIFF:

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

jhuber6 added a comment. In D151087#4361081 , @arsenm wrote: > They bypass all semantic checks. For example if you declare something as > address space 4, it will let you write to it unlike __constant__. It will let > you place stack objects in globals

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks added a comment. I was trying to get this landed with https://reviews.llvm.org/D145265 so I could measure the impact of the two together. But also now there are some merge conflicts that I'd rather deal with after submitting D145265 . But that patch

[PATCH] D151032: [clang] Add test for CWG2213

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you, I think more examples are never bad, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151032/new/ https://reviews.llvm.org/D151032

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

Anastasia added a comment. I don't feel `reinterpret_cast` is the right fit for this as it's expected to do just reinterpretation but `addrspacecast` LLVM instruction which Clang generates might result in some more operations in particular some special instructions for address calculation.

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

SR_team created this revision. SR_team added a reviewer: sammccall. SR_team added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. SR_team requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. In

[PATCH] D151137: ]NFC][Clang] Fix Coverity bug with dereference null return value in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151137/new/ https://reviews.llvm.org/D151137 ___ cfe-commits mailing list

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added a comment. In D147844#4335598 , @dblaikie wrote: > In D147844#4329497 , @aaron.ballman > wrote: > >> In general, I think this is incremental progress on the diagnostic behavior. >> However,

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

arsenm added a comment. In D151087#4361237 , @ebevhan wrote: > What is now a reinterpret_cast? An address space conversion, or a bitcast? > It's not as straightforward as it might seem. This is the most straightforward part. It's a bitcast.

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/bfloat16.cpp:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16 -S -emit-llvm

[clang] b5b6896 - [test] Add more ext_vector_type tests for C

Author: Cassie Jones Date: 2023-05-22T15:08:14-07:00 New Revision: b5b689679e1e435b5c82832f468ed939c7b72021 URL: https://github.com/llvm/llvm-project/commit/b5b689679e1e435b5c82832f468ed939c7b72021 DIFF: https://github.com/llvm/llvm-project/commit/b5b689679e1e435b5c82832f468ed939c7b72021.diff

[PATCH] D151061: [test] Add ext_vector_type tests for C

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b689679e1e: [test] Add more ext_vector_type tests for C (authored by porglezomp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/

[PATCH] D151166: [clangd] Interactive AST matchers with #pragma clang query

sammccall added a comment. @kadircet this is a slightly silly feature that I put together on vacation I'd like your call on whether this is something we should have. If so, feel free to hand off the review. It's definitely a power-user feature and nigh undiscoverable. I'd plan to write some

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. @MyDeveloperDay Thanks for the positive review. Regarding https://github.com/llvm/llvm-project/issues/56352 and the Beyoncé Rule, the original fix for the crash actually added a test (see the changes made at that time

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 524376. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148573: Allow -fsanitize=function on all targets

MaskRay added a comment. In D148573#4361396 , @sbc100 wrote: > This change seems to be causing problems on the emscripten auto-roller: > https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8780394114149321217/overview > > Failures show

[PATCH] D151034: [clang] Add test for CWG1397

shafik added inline comments. Comment at: clang/test/CXX/drs/dr13xx.cpp:488 +#if __cplusplus == 201103L + // expected-error@#dr1397-struct-A {{default member initializer for 'p' needed within definition of enclosing class 'A' outside of member functions}} + //

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:315-318 -} else if (RC == ::BFloat16RegsRegClass) { - Ret = (9 << 28); -} else if (RC == ::BFloat16x2RegsRegClass) { - Ret = (10 << 28); There's still something

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

rjmccall added a comment. It's weird to have C-style casts that can't be done with any combination of named casts, so I think this makes some sense. I do think it should be limited to numbered address spaces of the same size, though, rather than basing it on whether we're in OpenCL mode.

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11740 + LVal.getLValueBase().dyn_cast()); + Result += VD->getFlexibleArrayInitChars(Info.Ctx); +} nickdesaulniers wrote: > nickdesaulniers wrote: > > erichkeane wrote: >

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs updated this revision to Diff 524467. codemzs marked 12 inline comments as done. codemzs added a comment. @pengfei, @zahiraam, I appreciate your feedback. @pengfei, the `HasFullBFloat16` flag is primarily for identifying hardware with native `bfloat16` support to facilitate automatic

[PATCH] D151033: [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable declaration when it has a dependent type

This revision was automatically updated to reflect the committed changes. Closed by commit rG986cbd80d1dc: [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr… (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D151033?vs=524095=524346#toc

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

jhuber6 added a comment. In D151087#4361367 , @ebevhan wrote: > I don't think the standard argument really holds. It doesn't mention > restrictions on address spaces because it doesn't have to, since they don't > exist in C++. If they did, I'm pretty

[PATCH] D151061: [test] Add ext_vector_type tests for C

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://reviews.llvm.org/D151061

[PATCH] D147889: [clang-tidy] Improve bugprone-branch-clone with support for fallthrough attribute

PiotrZSL updated this revision to Diff 524419. PiotrZSL added a comment. Rebase, Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147889/new/ https://reviews.llvm.org/D147889 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

vzakhari accepted this revision. vzakhari added a comment. Thank you for the follow-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/ https://reviews.llvm.org/D151088 ___ cfe-commits mailing

[PATCH] D151130: [NFC][CLANG] Fix static code analyzer concerns with dereference null return value

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151130/new/ https://reviews.llvm.org/D151130 ___ cfe-commits mailing list

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11740 + LVal.getLValueBase().dyn_cast()); + Result += VD->getFlexibleArrayInitChars(Info.Ctx); +} efriedma wrote: > nickdesaulniers wrote: > > nickdesaulniers

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

Icantjuddle created this revision. Icantjuddle added a reviewer: clang-format. Herald added a project: All. Icantjuddle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Github Issue

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11740 + LVal.getLValueBase().dyn_cast()); + Result += VD->getFlexibleArrayInitChars(Info.Ctx); +} efriedma wrote: > nickdesaulniers wrote: > > efriedma wrote: > >

[PATCH] D123649: Allow flexible array initialization in C++.

ahatanak added a comment. Looks like `Init`'s type is wrong. It should be `{ i32, [1 x i32] }` instead of `{ i32, [0 x i32] }` in the case where `S` has two members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123649/new/

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane marked an inline comment as done. erichkeane added a comment. In D150875#4362434 , @aaron.ballman wrote: > Precommit CI found various failures that need to be addressed. Also, have you > tested to see what breaks in llvm-test-suite? Woops!

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151162 Files:

[PATCH] D151148: [clang][ExprConstant] fix __builtin_object_size for compound literal

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11737 bool Ret = HandleSizeof(Info, ExprLoc, Ty, Result); if (Ty->isStructureType() && Ty->getAsStructureType()->getDecl()->hasFlexibleArrayMember()) { For the second

[PATCH] D151061: [test] Add ext_vector_type tests for C

aaron.ballman added a comment. Thank you for the additional test coverage! The changes LGTM modulo the suggestion from @fhahn on how to improve the comments. (Note, given your goal of verifying that operations work, you might want to consider adding similar coverage for CodeGen tests to verify

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao added a subscriber: shafik. ayzhao added a comment. Status update on backports: - https://github.com/llvm/llvm-project/issues/62266 has been backported in https://github.com/llvm/llvm-project-release-prs/pull/441 - https://github.com/llvm/llvm-project/issues/61567 is still waiting on

[clang] 279a4d0 - -fsanitize=function: support C

Author: Fangrui Song Date: 2023-05-22T10:11:30-07:00 New Revision: 279a4d0d67c874e80c171666822f2fabdd6fa926 URL: https://github.com/llvm/llvm-project/commit/279a4d0d67c874e80c171666822f2fabdd6fa926 DIFF: https://github.com/llvm/llvm-project/commit/279a4d0d67c874e80c171666822f2fabdd6fa926.diff

[PATCH] D148827: -fsanitize=function: support C

This revision was automatically updated to reflect the committed changes. Closed by commit rG279a4d0d67c8: -fsanitize=function: support C (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D148827?vs=524110=524374#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11740 + LVal.getLValueBase().dyn_cast()); + Result += VD->getFlexibleArrayInitChars(Info.Ctx); +} nickdesaulniers wrote: > efriedma wrote: > > nickdesaulniers wrote: > >

[PATCH] D151148: [clang][ExprConstant] fix __builtin_object_size for compound literal

nickdesaulniers created this revision. nickdesaulniers added reviewers: efriedma, erichkeane. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixup to D150892 .

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias updated this revision to Diff 524484. galenelias edited the summary of this revision. galenelias added a comment. Thanks for the additional review comments. Hopefully everything if fixed. In D150403#4358845 , @owenpan wrote: > Can you put

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added a comment. The assertion is correct; without it, your code is getting miscompiled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123649/new/ https://reviews.llvm.org/D123649 ___

[PATCH] D151166: [clangd] Interactive AST matchers with #pragma clang query

sammccall created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The idea: you can type in AST

[PATCH] D150841: [IR] Make stack protector symbol dso_local according to -f[no-]direct-access-external-data

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. This also resolves https://github.com/llvm/llvm-project/issues/62482; was that intentional? If so, consider adding a link to

[PATCH] D151093: [clang][Diagnostic] Simplify emitDiagnosticLoc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add NFC to the patch summary when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151093/new/

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

JonChesterfield added a comment. I like the current behaviour of bypass semantic checking and emit IR with the same number on it as my primary use case for feeding freestanding C++ to clang is as a convenient way to emit specific IR and I'm not that bothered about clang detecting mistakes

[PATCH] D151059: [test] Add C++ ext_vector_type tests

aaron.ballman added a comment. Thank you for this coverage as well! Are there issues filed for the FIXME comments so we have a more prominent record of the problems? LGTM modulo comment concerns. Comment at: clang/test/SemaCXX/vector.cpp:554 +void

[PATCH] D150966: [clang] Don't define predefined macros multiple times

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); }

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

ebevhan added a comment. In D151087#4361263 , @jhuber6 wrote: > I'd rather have an operation whose semantics are a little dangerous than > something that doesn't work at all. As it stands we need to use C-style casts > for this and I don't think

[PATCH] D151061: [test] Add ext_vector_type tests for C

porglezomp updated this revision to Diff 524405. porglezomp added a comment. Address the comment suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://reviews.llvm.org/D151061 Files: clang/test/Sema/ext_vector_ops.c

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151059: [test] Add C++ ext_vector_type tests

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/ https://reviews.llvm.org/D151059

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

jhuber6 added a comment. We should at least be able to `reinterpret_cast` between cases we know are compatible, as the OpenCL check does. One of the problems with the numerical address space is it doesn't have any information to know if that's strictly legal or not. I'm not sure if casting

[PATCH] D151168: [CUDA] plumb through new sm_90-specific builtins.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, yaxunl. Herald added a project: All. tra added a reviewer: jlebar. tra published this revision for review. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. Repository: rG

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added a comment. In D123649#4362418 , @aaron.ballman wrote: > In D123649#4362402 , @efriedma > wrote: > >> The assertion is correct; without it, your code is getting miscompiled. > > The assertion may

[PATCH] D151148: [clang][ExprConstant] fix __builtin_object_size for compound literal

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11737 bool Ret = HandleSizeof(Info, ExprLoc, Ty, Result); if (Ty->isStructureType() && Ty->getAsStructureType()->getDecl()->hasFlexibleArrayMember()) { nickdesaulniers

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

saugustine added a comment. This change causes an assertion failure on the following test case. The memset is important for some reason. saugustine@saugustine-desktop:~/llvm/build $ cat t.c struct foo { unsigned char x; unsigned char data[]; }; extern void *memset (void

[PATCH] D151148: [clang][ExprConstant] fix __builtin_object_size for compound literal

nickdesaulniers updated this revision to Diff 524532. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - more dyn_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151148/new/ https://reviews.llvm.org/D151148

[PATCH] D151148: [clang][ExprConstant] fix __builtin_object_size for compound literal

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:11737 bool Ret = HandleSizeof(Info, ExprLoc, Ty, Result); if (Ty->isStructureType() && Ty->getAsStructureType()->getDecl()->hasFlexibleArrayMember()) { efriedma

  1   2   3   >