[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 530168. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[clang-tools-extra] 8fdedcd - [clang-tidy] Optimize misc-confusable-identifiers

Author: Piotr Zegar Date: 2023-06-10T11:06:49Z New Revision: 8fdedcd1a242f6b54eec969e72e35ac0a68b7ea1 URL: https://github.com/llvm/llvm-project/commit/8fdedcd1a242f6b54eec969e72e35ac0a68b7ea1 DIFF: https://github.com/llvm/llvm-project/commit/8fdedcd1a242f6b54eec969e72e35ac0a68b7ea1.diff LOG:

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fdedcd1a242: [clang-tidy] Optimize misc-confusable-identifiers (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/

[clang] 631c965 - [AMDGPU] Non hostcall printf support for HIP

Author: Vikram Date: 2023-06-10T09:55:00-04:00 New Revision: 631c965483e03355cdc1dba578e787b259c4d79d URL: https://github.com/llvm/llvm-project/commit/631c965483e03355cdc1dba578e787b259c4d79d DIFF: https://github.com/llvm/llvm-project/commit/631c965483e03355cdc1dba578e787b259c4d79d.diff LOG:

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG631c965483e0: [AMDGPU] Non hostcall printf support for HIP (authored by vikramRH). Changed prior to commit:

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof updated this revision to Diff 530219. fridtjof added a comment. - Deduplicated code by using templates (looks a bit ridicilous though) - Release notes entry added - Unit test added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373

[clang] 0e7cfa5 - [CodeGen] Remove mentions of OLDPM

Author: Kazu Hirata Date: 2023-06-10T10:40:43-07:00 New Revision: 0e7cfa59ebe9d87029ebf75bb4a05316dd3c3d63 URL: https://github.com/llvm/llvm-project/commit/0e7cfa59ebe9d87029ebf75bb4a05316dd3c3d63 DIFF: https://github.com/llvm/llvm-project/commit/0e7cfa59ebe9d87029ebf75bb4a05316dd3c3d63.diff

[PATCH] D152625: run-clang-tidy: forward warnings-as-errors argument

indev29 created this revision. indev29 added reviewers: cfe-commits, njames93. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a project: All. indev29 requested review of this revision. Herald added a project: clang-tools-extra. Forward `warnings-as-errors` argument to clang-tidy.

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter added a comment. bump please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152627: [RISCV] Change the immediate argument to Zvk intrinsics/builtins to i8.

craig.topper created this revision. craig.topper added reviewers: asb, reames, kito-cheng, VincentWu, ksyx, achieveartificialintelligence. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao created this revision. rZhBoYao added a reviewer: serge-sans-paille. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. Teach -Wuser-defined-literals to warn on using double underscores in

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

david-sawatzke added a comment. Thank you for the reply, I've compiled this with the most recent patch and also didn't see a problem (but can't get it running with rustc). Building the .ll with the older patch, the same issue also occurs, so I *do* think its the old patch version? Here is the

[PATCH] D152634: [Sema] Remove unused isNonTypeNestedNameSpecifier

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 04f131da0b19abff611773c03be9bafb53c753ce Author: Richard Smith Date: Fri Jan 24

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:3097 + FD->getLocation(), FD->getLocation()); +CGF.EmitFunctionBody(FD->getBody()); +CGF.FinishFunction(); Is there any way we can use GenerateCode as the

[clang] bb4d583 - Fix CodeGen HIP test case failing on some targets

Author: Vikram Date: 2023-06-10T13:28:33-04:00 New Revision: bb4d5833e564f4995db5888950a05c3ff1272ee9 URL: https://github.com/llvm/llvm-project/commit/bb4d5833e564f4995db5888950a05c3ff1272ee9 DIFF: https://github.com/llvm/llvm-project/commit/bb4d5833e564f4995db5888950a05c3ff1272ee9.diff LOG:

[PATCH] D152625: run-clang-tidy: forward warnings-as-errors argument

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152625/new/ https://reviews.llvm.org/D152625 ___ cfe-commits mailing list

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao added a reviewer: clang-language-wg. rZhBoYao added a comment. Few questions: I think this applies to all the language modes? Somehow, https://wg21.link/CWG2521 is not redirecting to https://cplusplus.github.io/CWG/issues/2521.html. Is this normal? Repository: rG LLVM Github

[PATCH] D152628: [RISCV] Add __builtin_riscv_zip/unzip for Zbkb to match gcc.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 530227. Krishna-13-cyber added a comment. - Update with addressing the comments - Update with example of Dynamic library usage in repl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

HazardyKnusperkeks added a comment. So I assume your `'` is a 'DictLiteral`? Does it have to be one? I don't know what else maybe a `DictLiteral` in what language and am not so comfortable with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9bf9ac8 - [CodeGen] Remove unused declaration createNVPTXRuntimeFunction

Author: Kazu Hirata Date: 2023-06-10T21:52:49-07:00 New Revision: 9bf9ac87d6ddf4d956bc2233c75d40b1f0e83f0b URL: https://github.com/llvm/llvm-project/commit/9bf9ac87d6ddf4d956bc2233c75d40b1f0e83f0b DIFF: https://github.com/llvm/llvm-project/commit/9bf9ac87d6ddf4d956bc2233c75d40b1f0e83f0b.diff

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1945 + auto DRE = + DeclRefExpr::Create(*Context, {}, {}, VD, false, SourceLocation(), + VD->getType(), VK_PRValue); NoQ wrote: > Is there a way to

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 530175. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/lib/Analysis/CFG.cpp clang/test/Sema/warn-thread-safety-analysis.c Index: clang/test/Sema/warn-thread-safety-analysis.c

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4410158 , @galenelias wrote: > Yah, I think leaving it open would be my preference at this point. Not sure > how to properly document that though? Just be explicit in the tests? > Mention it in

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL updated this revision to Diff 530185. PiotrZSL added a comment. Add comment to code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/ https://reviews.llvm.org/D151594 Files:

[clang] 6669dc0 - [clang][NFC] Refactor printableTextForNextCharacter

Author: Timm Bäder Date: 2023-06-10T07:51:36+02:00 New Revision: 6669dc09a441f27f3b5e18805a1a59fbe93a4cd6 URL: https://github.com/llvm/llvm-project/commit/6669dc09a441f27f3b5e18805a1a59fbe93a4cd6 DIFF: https://github.com/llvm/llvm-project/commit/6669dc09a441f27f3b5e18805a1a59fbe93a4cd6.diff

[clang] 0e9843b - [clang][parse][NFC] Fix grammar in a comment

Author: Timm Bäder Date: 2023-06-10T07:51:36+02:00 New Revision: 0e9843bf35d94100a843baf660700011227a6cc4 URL: https://github.com/llvm/llvm-project/commit/0e9843bf35d94100a843baf660700011227a6cc4 DIFF: https://github.com/llvm/llvm-project/commit/0e9843bf35d94100a843baf660700011227a6cc4.diff

[clang] 55aeb23 - [clang][WebAssembly] Implement support for table types and builtins

Author: Paulo Matos Date: 2023-06-10T15:53:13+02:00 New Revision: 55aeb23fe0084d930ecd7335092d712bd71694c7 URL: https://github.com/llvm/llvm-project/commit/55aeb23fe0084d930ecd7335092d712bd71694c7 DIFF: https://github.com/llvm/llvm-project/commit/55aeb23fe0084d930ecd7335092d712bd71694c7.diff

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55aeb23fe008: [clang][WebAssembly] Implement support for table types and builtins (authored by pmatos). Changed prior to commit:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. In D139010#4400303 , @aaron.ballman wrote: > Spotted a typo in the docs, but otherwise LGTM (thanks for your patience > while I was out last week). Thanks for your time one this. Repository: rG LLVM Github Monorepo CHANGES

[clang] 8e580b7 - [NFC][SetVector] Update some usages of SetVector to SmallSetVector

Author: Dhruv Chawla Date: 2023-06-10T12:36:43+05:30 New Revision: 8e580b7edd15e3a7fcf5951be14fb3fed519349a URL: https://github.com/llvm/llvm-project/commit/8e580b7edd15e3a7fcf5951be14fb3fed519349a DIFF: https://github.com/llvm/llvm-project/commit/8e580b7edd15e3a7fcf5951be14fb3fed519349a.diff

[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e580b7edd15: [NFC][SetVector] Update some usages of SetVector to SmallSetVector (authored by 0xdc03). Repository: rG LLVM Github Monorepo

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. First this looks like "misc" check, not as "readability" one. So please move it to proper module. There is no "readability" aspect of it. Second thing this is not an "absolute",

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL added a comment. Even with that for me for example, I would consider `#include "xyz"` be fine, but `#include "../xyz"` would be a red flag, so please consider adding `StrictMode` option to check so if `StrictMode` is not set then includes from same directory, or subdirectory would be

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

pcwang-thead added a comment. In D70401#4409782 , @david-sawatzke wrote: > Hey I've tried using this patch (roughly following > https://noxim.xyz/blog/rust-ch32v003/). > > It uses the older version of this patch for the rust llvm version (here the >

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added a comment. Thank you very much for the insightful review! Regarding to your suggestion, > We have an existing heuristic here, should we move the logic into > maybeDesugar() so it's all in one place? once we merge these two functions, the overloaded `addTypeHint` without a

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan updated this revision to Diff 530201. zyounan marked 7 inline comments as done. zyounan added a comment. Address many comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files:

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

This revision was automatically updated to reflect the committed changes. Closed by commit rG6669dc09a441: [clang][NFC] Refactor printableTextForNextCharacter (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D150843?vs=529170=530160#toc Repository: rG LLVM Github

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev added inline comments. Comment at: clang/docs/ClangRepl.rst:119 + clang-repl> int c = sum(9,10); + clang-repl> std::cout << c; + 19clang-repl> Comment at: clang/docs/ClangRepl.rst:120 + clang-repl> std::cout << c; +

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL added a comment. One more comment, according to this whitepaper you should actually check if include is relative, simply if `current file directory + include` exists and it's actually a file that is included, then its relative include. Currently you checking only `""` and its not a

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder updated this revision to Diff 530177. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152246/new/ https://reviews.llvm.org/D152246 Files: clang/lib/Analysis/ThreadSafety.cpp Index: clang/lib/Analysis/ThreadSafety.cpp

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Before: c = // '{default: 0}; After: c = //