[PATCH] D136154: [clang-format] Fix the continuation indenter

2023-09-13 Thread Henrik Lafrenz via Phabricator via cfe-commits
hel-ableton added a comment. Hi Owen, thanks for reaching out, no. In fact we realized that we don't have enough capacity to be working on it. Best, Henrik - Henrik Lafrenz, Ableton AG Schoenhauser Allee 6-7, 10119 Berlin, Germany T: +49 30 288 763-256 Board: Gerhard Behles, Jan Bohl

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,90 @@ +// RUN: %check_clang_tidy %s bugprone-compare-pointer-to-member-virtual-function %t + +struct A { + virtual ~A(); + void f1(); + void f2(); + virtual void f3(); + virtual void f4(); + + void g1(int); +}; + +bool Result; + +void base() { + Result = (::f1

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,66 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,107 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,37 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.h - clang-tidy *- C++ +//-*-===// EugeneZelenko wrote: Please merge with previous line. You could reduce number of `=`. https://github.com/llvm/llvm-project/pull/66055

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,66 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-13 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16970 + OS << '\''; + WriteCharValueForDiagnostic(CodeUnit, BTy, TyWidth, OS); + OS << "' (0x" To have the diagnostic printer handle separating

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-13 Thread via cfe-commits
@@ -214,6 +214,16 @@ class StmtComparer { return E1->size() == E2->size(); } + bool IsStmtEquivalent(const DeclRefExpr *DRE1, const DeclRefExpr *DRE2) { +auto *Decl1 = DRE1->getDecl(); +auto *Decl2 = DRE2->getDecl(); mzyKi wrote: ```cpp ///

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-13 Thread via cfe-commits
https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: If the function is `constexpr` do we treat it as a VLA? https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
@@ -13928,7 +13930,7 @@ static bool CheckTautologicalComparison(Sema , BinaryOperator *E, return false; IntRange OtherValueRange = GetExprRange( - S.Context, Other, S.isConstantEvaluated(), /*Approximate*/ false); + S.Context, Other,

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
@@ -13928,7 +13930,7 @@ static bool CheckTautologicalComparison(Sema , BinaryOperator *E, return false; IntRange OtherValueRange = GetExprRange( - S.Context, Other, S.isConstantEvaluated(), /*Approximate*/ false); + S.Context, Other,

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-13 Thread via cfe-commits
https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

2023-09-13 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi @leonardchan your change was still causing a failure on the PS4 linux bot, so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 . I noticed earlier that the failing test

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
@@ -15159,16 +15163,16 @@ static void CheckImplicitConversion(Sema , Expr *E, QualType T, IntRange SourceTypeRange = IntRange::forTargetOfCanonicalType(S.Context, Source); - IntRange LikelySourceRange = - GetExprRange(S.Context, E, S.isConstantEvaluated(),

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
@@ -14143,8 +14145,9 @@ static void AnalyzeComparison(Sema , BinaryOperator *E) { } // Otherwise, calculate the effective range of the signed operand. - IntRange signedRange = GetExprRange( - S.Context, signedOperand, S.isConstantEvaluated(), /*Approximate*/ true);

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
@@ -15090,8 +15093,9 @@ static void CheckImplicitConversion(Sema , Expr *E, QualType T, if (SourceBT && TargetBT && SourceBT->isIntegerType() && TargetBT->isFloatingType() && !IsListInit) { // Determine the number of precision bits in the source integer type. -

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

2023-09-13 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-13 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041: >From fd7138ee568d0a46a71a7f4e268ecd491e600b31 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-13 Thread Shafik Yaghmour via cfe-commits
@@ -9843,30 +9833,44 @@ class Sema final { /// diagnostics that will be suppressed. std::optional isSFINAEContext() const; - /// Determines whether we are currently in a context that - /// is not evaluated as per C++ [expr] p5. - bool isUnevaluatedContext() const { +

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Thanks for the detailed suggestion! I agree it's the appropriate approach. I was planning to separate `Wformat-truncation` from `Wfortify-source` sometime after this PR (as was requested in the same issue), but now that we are going to introduce a new warning group, we should

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2023-09-13 Thread Andrei Lebedev via cfe-commits
andreil99 wrote: Thanks, @cor3ntin! I have installed the latest myst-parser (2.0.0) on the publishing bot. Will see how it will fly. Please feel free to commit requirements.txt you have. I'll update it with the one with known-to-be-good versions frozen once we will confirm on that bot

[clang] Implement ACLE rintn and rintnf intrinsics (PR #66112)

2023-09-13 Thread David Green via cfe-commits
https://github.com/davemgreen commented: Could this use __builtin_roundeven directly, avoiding the need for __builtin_arm_rintnf? https://github.com/llvm/llvm-project/pull/66112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-09-13 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556630. iana added a comment. Actually allow the stdarg module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-13 Thread Martin Storsjö via cfe-commits
@@ -2866,8 +2871,10 @@ MicrosoftRecordLayoutBuilder::layoutNonVirtualBases(const CXXRecordDecl *RD) { for (const CXXBaseSpecifier : RD->bases()) { if (Base.isVirtual()) continue; + const CXXRecordDecl *BaseDecl = Base.getType()->getAsCXXRecordDecl();

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-13 Thread Martin Storsjö via cfe-commits
@@ -743,6 +743,7 @@ void CGRecordLowering::calculateZeroInit() { void CGRecordLowering::clipTailPadding() { std::vector::iterator Prior = Members.begin(); CharUnits Tail = getSize(Prior->Data); + mstorsjo wrote: Nit: The total PR sums up to adding a

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

2023-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes I don't now squat about Objective C, but the extra variable (and cast) seemed unnecessary and this is a good opportunity to re-format that ugly parameter list. -- Full diff: https://github.com/llvm/llvm-project/pull/66181.diff

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

2023-09-13 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/include/clang/Driver/Options.td:2249-2256 +def fexperimental_omit_rtti_component : + Flag<["-"], "fexperimental-omit-rtti-component">, + Group, Flags<[CC1Option]>, + HelpText<"Omit the RTTI component from virtual tables">; +def

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-13 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556627. iana added a comment. __stddef_max_align_t.h always needs a header guard, because the type merger can't handle struct's. If it has a header guard then it always needs to have a module too, even if `-fbuiltin-headers-in-system-modules` is passed.

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-13 Thread Piotr Zegar via cfe-commits
@@ -247,6 +247,10 @@ Changes in existing checks ` to support for-loops with iterators initialized by free functions like ``begin``, ``end``, or ``size``. +- Improved :doc:`modernize-use-emplace + ` to not replace aggregates that + ``emplace_back`` cannot construct with

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-13 Thread Piotr Zegar via cfe-commits
@@ -1332,6 +1337,17 @@ void testBracedInitTemporaries() { v3.push_back(NonTrivialWithCtor{{}}); v3.push_back({{0}}); v3.push_back({{}}); + + std::vector v4; + + // These should not be noticed or fixed; after the correction, the code won't + // compile. +

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-13 Thread Piotr Zegar via cfe-commits
@@ -207,11 +211,13 @@ void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) { auto HasConstructExpr = has(ignoringImplicit(SoughtConstructExpr)); // allow for T{} to be replaced, even if no CTOR is declared - auto HasConstructInitListExpr = has(initListExpr(anyOf(

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Overall LGTM, check comments, and verify if check shouldn't be made more strict. https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

2023-09-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

2023-09-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66181: I don't now squat about Objective C, but the extra variable (and cast) seemed unnecessary and this is a good opportunity to re-format that ugly parameter list. >From 37501edc47aea61b09ab775dbbc36b801cc0994e

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [sanitizer_symbolizer] Symbolizer Markup for linux (PR #66126)

2023-09-13 Thread Petr Hosek via cfe-commits
=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas petrhosek wrote: Could we move functions in

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-09-13 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556629. iana added a comment. Adjust for the changes in D159483 . Mostly the header guards that were added in that review have moved to this one, the stdarg module needs to always be allowed, and a few tests needed to adjust

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

2023-09-13 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-13 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-13 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-13 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH] [AArch64][SME]Update intrinsic interface for

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH] [AArch64][SME]Update intrinsic interface for

[clang] 99594ba - [clang][ARM] Enable --print-supported-extensions for ARM (#66083)

2023-09-13 Thread via cfe-commits
Author: David Spickett Date: 2023-09-13T10:10:57+01:00 New Revision: 99594ba30aaba7ad7c0850923bac474e4676af8e URL: https://github.com/llvm/llvm-project/commit/99594ba30aaba7ad7c0850923bac474e4676af8e DIFF:

[clang] [clang][ARM] Enable --print-supported-extensions for ARM (PR #66083)

2023-09-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Enable --print-supported-extensions for ARM (PR #66083)

2023-09-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65969: >From 5ee1a4f83c69b5e2910ea883dca7f0fa2c1a4bd3 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Wed, 13 Sep 2023 17:43:11 +0900 Subject: [PATCH 1/2] [clang][Diagnostics] Separate Wformat-overflow and

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-13 Thread via cfe-commits
0x59616e wrote: > There is also the question of what happen in the deeply nested case > > ```c++ > int foo(auto...); > auto f(auto... a) { >return [] { >return [] () requires requires { foo(a...) ;} {}; >}(); > } > > auto g = f()(); > ``` > > we may have to visit all

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-13 Thread via cfe-commits
@@ -245,10 +245,10 @@ runDataflowAnalysis( /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. -template -llvm::Expected> diagnoseFunction( +template +llvm::Expected diagnoseFunction(

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-13 Thread via cfe-commits
@@ -245,10 +245,10 @@ runDataflowAnalysis( /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. -template -llvm::Expected> diagnoseFunction( +template +llvm::Expected diagnoseFunction(

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

2023-09-13 Thread via cfe-commits
https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/66109: >From b5c45907b0a5c075dfdbd7f6b3727634d976787b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Tue, 12 Sep 2023 18:07:34 +0200 Subject: [PATCH] [analyzer] Fix StdLibraryFunctionsChecker

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

2023-09-13 Thread Nathan Gauër via Phabricator via cfe-commits
Keenuts accepted this revision. Keenuts added a comment. This revision is now accepted and ready to land. LGTM from the SPIR-V side. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

2023-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Otherwise, the test doesn't actually do anything. -- Full diff: https://github.com/llvm/llvm-project/pull/66195.diff 1 Files Affected: - (modified) clang/unittests/Analysis/FlowSensitive/TransferTest.cpp (+1-1) diff --git

[clang] [clang][dataflow] Rename test target function to `target()`. (PR #66195)

2023-09-13 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/66195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

2023-09-13 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/65306: >From 0126977e7f0e21713609425202b6c6b940941d39 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Tue, 5 Sep 2023 08:19:11 + Subject: [PATCH] Separate PNR into it's own Register Class This patch

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-13 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021: >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/2] [Clang] Static member initializers are not immediate

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,44 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-13 Thread via cfe-commits
martinboehme wrote: > Updated to enforce llvm::SmallVector, per Martin's recommendation. PTAL. LGTM, but note that the PR title is now out of date. https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-13 Thread Sam McCall via cfe-commits
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula , } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector , -llvm::DenseSet ) { - auto Res = VisitedTokens.insert(Token); - if

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-13 Thread Sam McCall via cfe-commits
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula , } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector , -llvm::DenseSet ) { - auto Res = VisitedTokens.insert(Token); - if

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-13 Thread Sam McCall via cfe-commits
@@ -150,7 +157,7 @@ bool DataflowAnalysisContext::flowConditionImplies(Atom Token, Constraints.insert(().makeAtomRef(Token)); Constraints.insert(().makeNot(Val)); llvm::DenseSet VisitedTokens; sam-mccall wrote: Indeed, oops!

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-13 Thread Sam McCall via cfe-commits
@@ -108,6 +108,16 @@ class DataflowAnalysisContext { /// A null `PointeeType` can be used for the pointee of `std::nullptr_t`. PointerValue (QualType PointeeType); + /// Adds `Constraint` to current and future flow conditions in this context. + /// + /// The global

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
@@ -20,8 +20,10 @@ // CHECK-NEXT:ret void // ARM_STREAMING_ATTR void test_svld1_hor_za8(uint32_t slice_base, svbool_t pg, const void *ptr) { - svld1_hor_za8(0, slice_base, 0, pg, ptr); - svld1_hor_za8(0, slice_base, 15, pg, ptr); + uint32_t slice = slice_base;

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread Sander de Smalen via cfe-commits
@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); -

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. LGTM with nit addressed! https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread Sander de Smalen via cfe-commits
@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); -

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. LGTM with nit addressed! https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 88b7e06 - Revert "[clang][CodeGen] Emit annotations for function declarations."

2023-09-13 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-09-13T13:22:57+02:00 New Revision: 88b7e06dcf9723d0869b0c6bee030b4140e4366d URL: https://github.com/llvm/llvm-project/commit/88b7e06dcf9723d0869b0c6bee030b4140e4366d DIFF:

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

2023-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Changes This patch separates PNR registers into their own register class instead of sharing a register class with PPR registers. This primarily allows us to return more accurate register classes when applying assembly

[clang] 05a11f3 - [clang][Sema][NFC] Add missing docs to some FieldDecl methods.

2023-09-13 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-13T14:20:10+02:00 New Revision: 05a11f3e6dc234582f18ffeeccec192251cc8b48 URL: https://github.com/llvm/llvm-project/commit/05a11f3e6dc234582f18ffeeccec192251cc8b48 DIFF: https://github.com/llvm/llvm-project/commit/05a11f3e6dc234582f18ffeeccec192251cc8b48.diff

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64] Separate PNR into its own Register Class (PR #65306)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: Few more nits, consider improving documentation & diagnostic message. https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

2023-09-13 Thread via cfe-commits
@@ -1427,8 +1427,13 @@ void StdLibraryFunctionsChecker::checkPostCall(const CallEvent , }); Pred = C.addTransition(NewState, Pred, Tag); } - if (!Pred) + if (!Pred || Pred->isSink()) { +// Pred may be: +// - a nullpointer,

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-13 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH 1/2] [AArch64][SME]Update intrinsic interface for

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-13 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-13 Thread Mariya Podchishchaeva via cfe-commits
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema , if (T1Quals.hasAddressSpace()) Sequence.AddQualificationConversionStep( cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue); + else if

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-13 Thread Mariya Podchishchaeva via cfe-commits
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema , if (T1Quals.hasAddressSpace()) Sequence.AddQualificationConversionStep( cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue); + else if

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-13 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: This needs a release note. cc @erichkeane https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-13 Thread via cfe-commits
https://github.com/martinboehme requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-13 Thread via cfe-commits
@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-13 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >