[PATCH] D156890: [clang] Remove outdated INSTALL.txt

2023-09-21 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @stephanlachnit do you need me to land this on your behalf? What email should we use? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156890/new/ https://reviews.llvm.org/D156890

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

2023-09-21 Thread Petr Hosek via cfe-commits
petrhosek wrote: > @petrhosek Please take a look -- this is passing CI and I believe this should > support your use case. And it's definitely the way these configuration files > should have been set up from the start, I guess I just didn't think of doing > it that way when I hit the sysroot

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-21 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: To avoid backend regressions, I will merge this PR after #66793. https://github.com/llvm/llvm-project/pull/66740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet updated https://github.com/llvm/llvm-project/pull/66504 >From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001 From: Guillaume Chatelet Date: Fri, 15 Sep 2023 12:34:17 + Subject: [PATCH 1/4] [clang-tidy] Update

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1288,11 +1291,33 @@ void TextDiagnostic::emitSnippet(StringRef SourceLine, // Print the source line one character at a time. bool

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/19] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,302 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken , if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.g. +

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-21 Thread via cfe-commits
Naville wrote: Push the buttom for me please :D https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-21 Thread via cfe-commits
@@ -347,10 +347,6 @@ if(LIBOMP_OMPD_SUPPORT AND ((NOT LIBOMP_OMPT_SUPPORT) OR (NOT "${CMAKE_SYSTEM_NA set(LIBOMP_OMPD_SUPPORT FALSE) endif() -# OMPX Taskgraph support Munesanz wrote: Sure, do you know where can we find the BOLT benchmark suite? Thanks!

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/23] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From f85c72686613389671667ddd4997bec696f81c77 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
gchatelet wrote: > As a single small change to make hardcoded namespaces configurable looks > fine. I added some comments related to overall issues in this check. Fell > free to fix them or ignore them. Thx for the review! I had to restructure the code a bit to accommodate for anonymous

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Remove inaccurate legacy handling of bad bitwise shifts (PR #66647)

2023-09-21 Thread Balazs Benics via cfe-commits
steakhal wrote: I think I'm fine with the numbers. Note that I could not inspect individual reports because the URL likely refers to some internal server on your side. Anyway, I'd recommend keeping the test files for two reasons: - It's probably not a big deal, we are talking about ~150 lines

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

2023-09-21 Thread via cfe-commits
@@ -2445,6 +2445,11 @@ bool ModuleAddressSanitizer::InstrumentGlobals(IRBuilder<> , Module , // zero so we can copy the metadata over as is. NewGlobal->copyMetadata(G, 0); +// Set sanitizer metadata for newly created global, +// if it doesn't have it.

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

2023-09-21 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett closed this revision. DavidSpickett added a comment. Herald added a project: All. Was landed on 10.x as https://github.com/llvm/llvm-project/commit/b4efc29f1ccbc03453590bf7aae337853c91c91f. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[libclc] libclc: clspv: create gen_convert.cl for clspv (PR #66902)

2023-09-21 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr updated https://github.com/llvm/llvm-project/pull/66902 >From 67e347f9987b48652daaaceb4a51041f7b9a1430 Mon Sep 17 00:00:00 2001 From: Romaric Jodin Date: Tue, 18 Jul 2023 09:30:09 +0200 Subject: [PATCH] libclc: clspv: create gen_convert.cl for clspv Create clspv

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: The new commit above lexes the entire file and divides multi-line tokens into single-line `StyleRange` objects. _No caching yet_.

[libunwind] [runtimes] Fix link order of system librarires on Apple platforms (PR #66940)

2023-09-21 Thread Louis Dionne via cfe-commits
@@ -659,24 +659,22 @@ function(cxx_link_system_libraries target) target_add_link_flags_if_supported(${target} PRIVATE "--unwindlib=none") endif() - if (LIBCXX_HAS_SYSTEM_LIB) -target_link_libraries(${target} PRIVATE System) - endif() - - if

[clang] [RISCV] Move sifive_files to riscv_files (PR #66872)

2023-09-21 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/66872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/17] Introduce PagedVector

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66997 Just using BLACK makes it invisible in terminals with a dark background. See this screenshot: ![Screenshot from 2023-09-21

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,349 @@ +// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \ +// RUN: -Xclang -analyzer-checker=core \ +// RUN: -Xclang -analyzer-checker=debug.ExprInspection \ +// RUN: -Xclang -analyzer-checker=core,alpha.core.StdVariant + +#include

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,312 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,349 @@ +// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \ +// RUN: -Xclang -analyzer-checker=core \ +// RUN: -Xclang -analyzer-checker=debug.ExprInspection \ +// RUN: -Xclang -analyzer-checker=core,alpha.core.StdVariant + +#include

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,324 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,349 @@ +// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \ +// RUN: -Xclang -analyzer-checker=core \ +// RUN: -Xclang -analyzer-checker=debug.ExprInspection \ +// RUN: -Xclang -analyzer-checker=core,alpha.core.StdVariant + +#include

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread via cfe-commits
@@ -0,0 +1,349 @@ +// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \ +// RUN: -Xclang -analyzer-checker=core \ +// RUN: -Xclang -analyzer-checker=debug.ExprInspection \ +// RUN: -Xclang -analyzer-checker=core,alpha.core.StdVariant + +#include

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From c31b72ae57575d61559379509eff2bd60bc39a3b Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken , if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.g. +

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet updated https://github.com/llvm/llvm-project/pull/66504 >From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001 From: Guillaume Chatelet Date: Fri, 15 Sep 2023 12:34:17 + Subject: [PATCH 1/5] [clang-tidy] Update

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -537,59 +537,52 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function , raw_ostream ) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
jchlanda wrote: A friendly ping. https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,309 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/18] Introduce PagedVector

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread Gábor Spaits via cfe-commits
spaits wrote: Thank you for your time and effort for editing my commit @Szelethus and for reviewing my commit @DonatNagyE @steakhal . I have edited my commit based on your comments. These are the thing I have added or changed: + Added a function to decide 'a' or 'an' should be used in the

[clang] 618e5d2 - [CMake] Fully delete the deprecated LLVM_USE_CRT* (#66850)

2023-09-21 Thread via cfe-commits
Author: Zhang Date: 2023-09-21T13:25:06+03:00 New Revision: 618e5d2c2d8e0c288c37b883ece553ca4f994c2e URL: https://github.com/llvm/llvm-project/commit/618e5d2c2d8e0c288c37b883ece553ca4f994c2e DIFF: https://github.com/llvm/llvm-project/commit/618e5d2c2d8e0c288c37b883ece553ca4f994c2e.diff LOG:

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-21 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread via cfe-commits
ldrumm wrote: including Artem as NVPTX is involved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-21 Thread via cfe-commits
@@ -12156,6 +12224,12 @@ void CGOpenMPSIMDRuntime::emitTaskwaitCall(CodeGenFunction , llvm_unreachable("Not supported in SIMD-only mode"); } +void CGOpenMPSIMDRuntime::emitTaskgraphCall(CodeGenFunction , +SourceLocation Loc, +

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 72369a9166375e46fe982a5330e29d7b0709c426 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-21 Thread David Spickett via cfe-commits
DavidSpickett wrote: Looks good to me, thanks for working on this. I'm not sure if you'll have permissions to click the merge button but if you do, go ahead. Please remember to edit the final commit message to remove the links to the output files.

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda updated https://github.com/llvm/llvm-project/pull/66496 >From 9c8caed3c8def15ccdbfdf831f36d0befed1fc84 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Fri, 15 Sep 2023 12:08:04 +0100 Subject: [PATCH 1/2] [NVPTX] Add support for maxclusterrank in launch_bounds

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -5662,22 +5677,39 @@ Sema::CreateLaunchBoundsAttr(const AttributeCommonInfo , Expr *MaxThreads, return nullptr; } + if (MaxBlocks) { +// Feature '.maxclusterrank' requires .target sm_90 or higher. +auto SM = getCudaArch(Context.getTargetInfo()); +if

[clang] ca3ed7b - [clang] Update Clang version from 17 to 18 in scan-build.1.

2023-09-21 Thread Frederic Cambus via cfe-commits
Author: Frederic Cambus Date: 2023-09-21T09:30:12+02:00 New Revision: ca3ed7b2a0fdea7349242c2b63fcb049fc4a2b14 URL: https://github.com/llvm/llvm-project/commit/ca3ed7b2a0fdea7349242c2b63fcb049fc4a2b14 DIFF:

[PATCH] D158071: [clang] Remove rdar links; NFC

2023-09-21 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin closed this revision. cor3ntin added a comment. This was landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.org/D158071 ___ cfe-commits mailing list

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-21 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/66740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114425: [clang] Add __builtin_bswap128

2023-09-21 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik abandoned this revision. philnik added a comment. I don't plan to work on this any time soon, so I'll abandon it to clean up the review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

2023-09-21 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski abandoned this revision. awarzynski added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. With the imminent switch to GitHub and no new comments in over 2 years, I feel that it's time to abandon this change. Feel free to re-use this in the future :)

[clang] fe87d62 - [RISCV] Move sifive_files to riscv_files (#66872)

2023-09-21 Thread via cfe-commits
Author: Brandon Wu Date: 2023-09-21T17:26:18+08:00 New Revision: fe87d62c9e0f0fbb64438e840ef35664c328c4f7 URL: https://github.com/llvm/llvm-project/commit/fe87d62c9e0f0fbb64438e840ef35664c328c4f7 DIFF: https://github.com/llvm/llvm-project/commit/fe87d62c9e0f0fbb64438e840ef35664c328c4f7.diff

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-21 Thread Guillaume Chatelet via cfe-commits
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check( return; if (const auto *NS = dyn_cast(MatchedDecl)) { -if (NS->getName() != RequiredNamespace) { - diag(NS->getLocation(), "'%0' needs to be the outermost namespace") - <<

[clang] [RISCV] Move sifive_files to riscv_files (PR #66872)

2023-09-21 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/66872 >From 531304c6d63183f28f836668d7116cb43ae60644 Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Wed, 20 Sep 2023 01:23:54 -0700 Subject: [PATCH] [RISCV] Move sifive_files to riscv_files ---

[libclc] [LIBCLC] Teach prepare-builtins how to handle text based IR (PR #66993)

2023-09-21 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda created https://github.com/llvm/llvm-project/pull/66993 None >From c37f854eb496937d0eb017b14bd8a9accefdab80 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Thu, 21 Sep 2023 10:48:33 +0100 Subject: [PATCH] [LIBCLC] Teach prepare-builtins how to handle text based

[libclc] [LIBCLC] Teach prepare-builtins how to handle text based IR (PR #66993)

2023-09-21 Thread via cfe-commits
https://github.com/ldrumm approved this pull request. https://github.com/llvm/llvm-project/pull/66993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [LIBCLC] Teach prepare-builtins how to handle text based IR (PR #66993)

2023-09-21 Thread via cfe-commits
https://github.com/ldrumm edited https://github.com/llvm/llvm-project/pull/66993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [LIBCLC] Teach prepare-builtins how to handle text based IR (PR #66993)

2023-09-21 Thread via cfe-commits
@@ -5,30 +5,37 @@ #include "llvm/Bitcode/ReaderWriter.h" #endif +#include "llvm/Config/llvm-config.h" #include "llvm/IR/Function.h" #include "llvm/IR/GlobalVariable.h" #include "llvm/IR/LLVMContext.h" #include "llvm/IR/Module.h" +#include "llvm/IRReader/IRReader.h"

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-21 Thread via cfe-commits
@@ -2729,6 +2729,55 @@ class OMPTaskwaitDirective : public OMPExecutableDirective { } }; +/// This represents '#pragma ompx taskgraph' directive. +/// Available with OMPX extensions. +/// +/// \code +/// #pragma ompx taskgraph +/// \endcode +/// +class

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-21 Thread Sam McCall via cfe-commits
@@ -88,10 +88,12 @@ class ModelDumper { void dump(Value ) { JOS.attribute("value_id", llvm::to_string()); -if (!Visited.insert().second) - return; - JOS.attribute("kind", debugString(V.getKind())); +if (!Visited.insert().second) { +

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-21 Thread Sam McCall via cfe-commits
@@ -123,13 +125,16 @@ class ModelDumper { } void dump(const StorageLocation ) { JOS.attribute("location", llvm::to_string()); -if (!Visited.insert().second) - return; - JOS.attribute("type", L.getType().getAsString()); if (auto *V = Env.getValue(L))

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-21 Thread Sam McCall via cfe-commits
@@ -88,10 +88,12 @@ class ModelDumper { void dump(Value ) { JOS.attribute("value_id", llvm::to_string()); -if (!Visited.insert().second) - return; - JOS.attribute("kind", debugString(V.getKind())); +if (!Visited.insert().second) {

[clang-tools-extra] [SelectionDAG] Flags are dropped when creating a new FMUL (PR #66701)

2023-09-21 Thread Jay Foad via cfe-commits
https://github.com/jayfoad approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/66701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-21 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. @hazohelet Nah, feel free to merge that first! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list

[PATCH] D49549: Change 'clang-test' to 'check-clang' on the hacking webpage

2023-09-21 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett closed this revision. DavidSpickett added a comment. Herald added a project: All. I updated this to the monorepo layout and landed it: https://github.com/llvm/llvm-project/commit/604a231881a0e8f204a6d3337bfa3e797e911e34 Given the long time this has been here and the last activity

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-21 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/66740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-21 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/66740 >From 85f7911dfe0f1e9112881a9f503bcd68edfde580 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 19 Sep 2023 10:19:46 +0800 Subject: [PATCH 1/3] [InstCombine] Canonicalize `and(zext(A), B)` into `select

[libunwind] e46de4e - [runtimes] Fix link order of system librarires on Apple platforms (#66940)

2023-09-21 Thread via cfe-commits
Author: Louis Dionne Date: 2023-09-21T05:10:05-04:00 New Revision: e46de4e54f63eb4088ca351253768b5db8cf1985 URL: https://github.com/llvm/llvm-project/commit/e46de4e54f63eb4088ca351253768b5db8cf1985 DIFF: https://github.com/llvm/llvm-project/commit/e46de4e54f63eb4088ca351253768b5db8cf1985.diff

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,302 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D138846#4649147 , @alanphipps wrote: > In D138846#4649110 , @akhuang wrote: > >> I'm still working on a repro, but after this patch we're seeing "truncated >> profile data" errors in

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 44b01fb22b4a44a2de35299e7649626cea30852a Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

2023-09-21 Thread Sheng via Phabricator via cfe-commits
0x59616e added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread Jakub Chlanda via cfe-commits
@@ -307,6 +307,14 @@ void CodeGenModule::handleCUDALaunchBoundsAttr( NVPTXTargetCodeGenInfo::addNVVMMetadata(F, "minctasm", MinBlocks.getExtValue()); } + if (Attr->getMaxBlocks()) { +llvm::APSInt MaxBlocks(32); +

[PATCH] D119008: Add Cortex-X1C to Clang LLVM 14 release notes

2023-09-21 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett closed this revision. DavidSpickett added a comment. Herald added a project: All. Landed on 14.x as https://github.com/llvm/llvm-project/commit/56dcb10a9942c206d53a59abd66c2207a01b39fa. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-21 Thread via cfe-commits
https://github.com/ldrumm edited https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-21 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > You might want to check whether this also fixes #66740 and if so add a test. Confirmed. I have added a pre-commit test for 66733 in 1a73a6b80b54cd23ee8380c6fa3304847e5cb5d1. https://github.com/llvm/llvm-project/pull/66740 ___

[clang-tools-extra] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-21 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > You might want to check whether this also fixes #66740 and if so add a test. Confirmed. I have added a pre-commit test for 66733 in 1a73a6b80b54cd23ee8380c6fa3304847e5cb5d1. https://github.com/llvm/llvm-project/pull/66740 ___

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From:

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: ![Screenshot from 2023-09-21 11-01-56](https://github.com/llvm/llvm-project/assets/49720664/6c09ff87-3c77-4d3f-96bf-a14b1f7cc2d2)

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From:

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-21 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From 91bc14998e08c60c1e425f141dbcf44c8579d166 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH] [analyzer] Add std::variant checker Adding a checker that checks

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,309 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. I just noticed this also broke some lit tests on mac: https://bugs.chromium.org/p/chromium/issues/detail?id=1485487#c0 That's also visible on greendragon: https://green.lab.llvm.org/green/view/Clang/job/clang-stage1-RA/35721/testReport/ Repository: rG LLVM Github

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5c92faeea71ae72725010c256a3e29aa3a7bcfca Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

2023-09-21 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,84 @@ +//===- llvm/unittest/ADT/PagedVectorTest.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] 4af62db - [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (#66954)

2023-09-21 Thread via cfe-commits
Author: Takuya Shimizu Date: 2023-09-21T21:27:38+09:00 New Revision: 4af62db053413ea0b01e59adbd51677c5665328b URL: https://github.com/llvm/llvm-project/commit/4af62db053413ea0b01e59adbd51677c5665328b DIFF:

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-21 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/66954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >