[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-17 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69287 >From 5a1f32f156801da271486dbb0fd37007adb4901c Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Mon, 16 Oct 2023 16:41:31 +0800 Subject: [PATCH] [NFC] [Serializer] Pack information in serializer Previously,

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-17 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From 11f5286f426d082f7fbcb578c0c6cabcd3660453 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[PATCH] D126689: [IR] Enable opaque pointers by default

2023-10-17 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. @uabelho The call is well-defined from an LLVM IR perspective, so the verifier cannot reject it, just as it can't reject calling convention or ABI attribute mismatch. In this specific case, the call is likely undefined behavior, but that is not generally the case just

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-17 Thread via cfe-commits
zyn0217 wrote: (Maybe this is the reason: https://github.com/llvm/llvm-project/commit/cefc31c9213a82879254006ef479ed5ef6af7e69. Only top-100 commits are fetched by the CI currently. And sorry for bikeshedding the PR) https://github.com/llvm/llvm-project/pull/69153

[PATCH] D150961: [Clang][SVE2.1] Add svcntp prototype

2023-10-17 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557724. CarolineConcatto added a comment. -remove wrong tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150961/new/ https://reviews.llvm.org/D150961 Files: clang/include/clang/Basic/arm_sve.td

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-17 Thread Luca Di sera via cfe-commits
diseraluca wrote: Closing this one, as we intend to maintain our own local version. https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-17 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca closed https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-17 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/11] Fix `Form` to recognize `_Alignas` in addition to

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-17 Thread Jonas Hahnfeld via cfe-commits
https://github.com/hahnjo updated https://github.com/llvm/llvm-project/pull/69076 >From d149de4d4e00b63e506441b516f35aeb41786408 Mon Sep 17 00:00:00 2001 From: Jonas Hahnfeld Date: Sat, 14 Oct 2023 20:10:28 +0200 Subject: [PATCH 1/2] Fix crash with modules and constexpr destructor Closes

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-17 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I guess it's a signal for 'rebasing your branch please' :) Could you say more about that? Where is the requirement that my branch be sufficient recently coming from? It's only about 3 weeks old. I don't like rebasing too often because rebuilding takes long.

[clang] 11f5e5e - [clang][Interp][NFC] Add thread_local tests

2023-10-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-17T10:37:28+02:00 New Revision: 11f5e5eb90c883d4b9ddba318e8fc57914b22ef3 URL: https://github.com/llvm/llvm-project/commit/11f5e5eb90c883d4b9ddba318e8fc57914b22ef3 DIFF: https://github.com/llvm/llvm-project/commit/11f5e5eb90c883d4b9ddba318e8fc57914b22ef3.diff

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sander de Smalen via cfe-commits
@@ -38,3 +38,18 @@ void test_svstr_vnum_za_1(uint32_t slice_base, void *ptr) { void test_svstr_za(uint32_t slice_base, void *ptr) { svstr_za(slice_base, ptr); } + +// CHECK-C-LABEL: @test_svstr_vnum_za_var( +// CHECK-CXX-LABEL: @_Z22test_svstr_vnum_za_varjPvm( +//

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sander de Smalen via cfe-commits
@@ -9716,13 +9711,17 @@ Value *CodeGenFunction::EmitSMELdrStr(const SVETypeFlags , if (Ops.size() == 3) { Function *Cntsb = CGM.getIntrinsic(Intrinsic::aarch64_sme_cntsb); llvm::Value *CntsbCall = Builder.CreateCall(Cntsb, {}, "svlb"); -llvm::Value *MulVL =

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sander de Smalen via cfe-commits
@@ -34,6 +34,22 @@ void test_svldr_vnum_za_1(uint32_t slice_base, const void *ptr) { // CHECK-NEXT: entry: // CHECK-NEXT:tail call void @llvm.aarch64.sme.ldr(i32 [[SLICE_BASE:%.*]], ptr [[PTR:%.*]]) // CHECK-NEXT:ret void +// void test_svldr_za(uint32_t slice_base,

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68908 >From 000c99324a0bd63e92e0ac056c3ff46d2b92c53e Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/5] [AArch64][SME] Remove immediate argument restriction for

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
@@ -9716,13 +9711,17 @@ Value *CodeGenFunction::EmitSMELdrStr(const SVETypeFlags , if (Ops.size() == 3) { Function *Cntsb = CGM.getIntrinsic(Intrinsic::aarch64_sme_cntsb); llvm::Value *CntsbCall = Builder.CreateCall(Cntsb, {}, "svlb"); -llvm::Value *MulVL =

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68908 >From 000c99324a0bd63e92e0ac056c3ff46d2b92c53e Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/6] [AArch64][SME] Remove immediate argument restriction for

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-17 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/10] Fix `Form` to recognize `_Alignas` in addition to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-17 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-17 Thread Jonas Hahnfeld via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-obj -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %t/main.cpp -o %t/main.o hahnjo wrote: No, we don't need it, you are right - the

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

2023-10-17 Thread via cfe-commits
cor3ntin wrote: @serge-sans-paille I'm still trying to understand whether this change will be tested by CI - or at all. SSE4 is not enabled by default and i don't think our cmake does that either - I did ping @AaronBallman and we are still thinking about it

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

2023-10-17 Thread via cfe-commits
serge-sans-paille wrote: ok. I obviously tested on my setup, but having consistent testing is important. Thanks for the quick answer! https://github.com/llvm/llvm-project/pull/68962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][LoongArch] Support compiler options -mlsx/-mlasx for clang (PR #68952)

2023-10-17 Thread via cfe-commits
https://github.com/yjijd closed https://github.com/llvm/llvm-project/pull/68952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Add ABI implementation of passing vectors (PR #68954)

2023-10-17 Thread via cfe-commits
https://github.com/yjijd closed https://github.com/llvm/llvm-project/pull/68954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Support the builtin functions for LSX (PR #68955)

2023-10-17 Thread via cfe-commits
https://github.com/yjijd closed https://github.com/llvm/llvm-project/pull/68955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-17 Thread via cfe-commits
zyn0217 wrote: > Where is the requirement that my branch be sufficiently recent coming from? There's no such explicit requirement AFAIK; In my recollection, I've encountered several CI issues on Phabricator, and all of those were solved by rebasing my patch on top of the main.

[PATCH] D126689: [IR] Enable opaque pointers by default

2023-10-17 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. Herald added subscribers: gysit, Dinistro, bviyer, jplehr, Moerafaat, kmitropoulou, zero9178, StephenFan. Herald added a reviewer: dcaballe. Hi @nikic, I know I'm very late to the party with this, but I just noticed that since opaque pointers got turned on by default,

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68908 >From 000c99324a0bd63e92e0ac056c3ff46d2b92c53e Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/3] [AArch64][SME] Remove immediate argument restriction for

[clang] [clang][NFC] Replace TypeAlignment with alignof(T) (PR #69185)

2023-10-17 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/69185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-17 Thread Jonas Hahnfeld via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-obj -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %t/main.cpp -o %t/main.o + +//--- V.h +#ifndef V_H +#define V_H + +class A { +public: + constexpr

[PATCH] D158414: [LexerTest] Use LexTokensUntilEOF() in StringifyArgs

2023-10-17 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-17 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From 2d90dc0547f90c3a217428b2d3b8d2253ae80973 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-17 Thread Clement Courbet via cfe-commits
@@ -1061,18 +1061,20 @@ def Most : DiagGroup<"most", [ ]>; // Thread Safety warnings -def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">; -def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">; -def ThreadSafetyPrecise:

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-17 Thread Jerin Philip via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -std=c23 -fsyntax-only -verify %s +// RUN: not %clang_cc1 -std=c99 -pedantic -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-EXT %s + +_Alignas(int) struct c1; // expected-warning {{attribute '_Alignas' before "struct" is ignored}}

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-17 Thread via cfe-commits
zyn0217 wrote: I guess it's a signal for 'rebasing your branch please' :) https://github.com/llvm/llvm-project/pull/69153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b98b567c2501540ef4a9d586c26ab8271c6d1f0d cbbb4e2ab3598c05fd817f5bd2665b862afc7170 --

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-17 Thread Mariya Podchishchaeva via cfe-commits
@@ -346,6 +351,11 @@ MultiLevelTemplateArgumentList Sema::getTemplateInstantiationArgs( CurDecl = Response::UseNextDecl(ND).NextDecl; } + if (!ND) { +assert(DC); Fznamznon wrote: Does this assertion makes sense? If `ND` and `DC` both were null,

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-17 Thread Mariya Podchishchaeva via cfe-commits
@@ -8615,8 +8604,48 @@ class Sema final { TPL_TemplateParamsEquivalent, }; + // A struct to represent the 'new' declaration, which is either itself just + // the named decl, or the important information we need about it in order to + // do constraint comparisions.

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68908 >From 000c99324a0bd63e92e0ac056c3ff46d2b92c53e Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/4] [AArch64][SME] Remove immediate argument restriction for

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-17 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/69287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-17 Thread via cfe-commits
@@ -53,19 +52,8 @@ static int blockIndexInPredecessor(const CFGBlock , return BlockPos - Pred.succ_begin(); } -static bool isLoopHead(const CFGBlock ) { - if (const auto *T = B.getTerminatorStmt()) -switch (T->getStmtClass()) { - case Stmt::WhileStmtClass: -

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-17 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/68923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

2023-10-17 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: I've no idea what the error causing the format check ("Error: Unable to determine a difference between 8592241e29e29f0e7e407e0989489c6e70c91c42..e1ae800faed2fe3f612686edf6fe61f5b16e090d") to fail means. https://github.com/llvm/llvm-project/pull/69153

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

2023-10-17 Thread Clement Courbet via Phabricator via cfe-commits
courbet added a comment. I've updated https://github.com/llvm/llvm-project/pull/68572 to do as suggested. To sum up: we have a new flag `-Wthread-safety-reference-return`, which is on by default under `-Wthread-safety-reference`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-17 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From db868042066e8b985d20c1b728729ba7102aaefa Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-10-17 Thread Yeting Kuo via cfe-commits
yetingk wrote: Ping. https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

2023-10-17 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle edited https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-10-17 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68908 >From 000c99324a0bd63e92e0ac056c3ff46d2b92c53e Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/2] [AArch64][SME] Remove immediate argument restriction for

[clang] f0601c7 - [clang][NFC] Replace TypeAlignment with alignof(T) (#69185)

2023-10-17 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-17T13:04:49+04:00 New Revision: f0601c7569c6e2001b180136e1b699f577fd5c06 URL: https://github.com/llvm/llvm-project/commit/f0601c7569c6e2001b180136e1b699f577fd5c06 DIFF:

[clang] [clang][NFC] Replace TypeAlignment with alignof(T) (PR #69185)

2023-10-17 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/69185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-17 Thread Qiu Chaofan via cfe-commits
ecnelises wrote: Ah, I meant potential changes to `llvm/lib/Target` and `llvm/lib/MC`. But I did search in backend using FreeBSD as keyword for example, few places need to support it explicitly. If Haiku uses similar ABI and binary format to Linux or FreeBSD, that makes sense.

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-17 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-17 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

2023-10-17 Thread via cfe-commits
serge-sans-paille wrote: @tbaederr / @cor3ntin Do I have your formal approval to merge this? https://github.com/llvm/llvm-project/pull/68962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

2023-10-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1213 std::optional SubExprT = classify(SubExpr); - if (E->getStorageDuration() == SD_Static) { + bool IsStatic = E->getStorageDuration() == SD_Static; + if (GlobalDecl || IsStatic) {

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

2023-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Chris Carlon (cjc25) Changes The `--stdlib` flag can affect the system headers used by `clang` during compilation. By default, `clang` will use the platform-installed C++ standard headers, but with `--stdlib=libc++`, `clang` can use

[clang] [Clang] Check features of tune CPU against target CPU (PR #68861)

2023-10-17 Thread Qiu Chaofan via cfe-commits
@@ -833,6 +833,22 @@ TargetInfo::CreateTargetInfo(DiagnosticsEngine , if (!Target->handleTargetFeatures(Opts->Features, Diags)) return nullptr; + // If TuneCPU is set, check if it contains all instruction sets needed by + // current feature map. + if

[PATCH] D126689: [IR] Enable opaque pointers by default

2023-10-17 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. @nikic: Thanks, nothing to do there then even if I'm surprised. I'm not sure but I *think* that llvm-reduce may have some problems with this. For my out of tree target I recently saw a case where llvm-reduced crashed with llvm-reduce:

[PATCH] D126689: [IR] Enable opaque pointers by default

2023-10-17 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. In D126689#4654124 , @uabelho wrote: > @nikic: Thanks, nothing to do there then even if I'm surprised. > > I'm not sure but I *think* that llvm-reduce may have some problems with this. > For my out of tree target I recently saw a

[PATCH] D126689: [IR] Enable opaque pointers by default

2023-10-17 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. In D126689#4654126 , @nikic wrote: > In D126689#4654124 , @uabelho wrote: > >> @nikic: Thanks, nothing to do there then even if I'm surprised. >> >> I'm not sure but I *think* that

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov edited https://github.com/llvm/llvm-project/pull/68908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-17 Thread Lawrence Benson via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple aarch64 -fsyntax-only -verify %s + +void test_builtin_vectorelements() { + __builtin_vectorelements(int); // expected-error {{'__builtin_vectorelements' argument must be a vector}} + __builtin_vectorelements(float); //

[clang] [SVE ACLE] Allow default zero initialisation for svcount_t. (PR #69321)

2023-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Walker (paulwalker-arm) Changes This matches the behaviour of the other SVE ACLE types. --- Full diff: https://github.com/llvm/llvm-project/pull/69321.diff 4 Files Affected: - (modified)

[PATCH] D155850: [HIP][Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

2023-10-17 Thread Henrik G Olsson via Phabricator via cfe-commits
hnrklssn added a comment. `clang/test/CodeGenHipStdPar/unannotated-functions-get-emitted.cpp` is failing: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/38041/testReport/junit/Clang/CodeGenHipStdPar/unannotated_functions_get_emitted_cpp/

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

2023-10-17 Thread via cfe-commits
Dominik =?utf-8?q?W=C3=B3jt?= Message-ID: In-Reply-To: https://github.com/john-brawn-arm approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/67412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-17 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/68743 From 33de4ec9a01a138203d0e703c8a313bb534d6e31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Tue, 10 Oct 2023 22:50:43 +0200 Subject: [PATCH] [clang-format] Don't align

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-17 Thread Björn Schäpers via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I -

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Dinar Temirbulatov via cfe-commits
@@ -9716,13 +9716,16 @@ Value *CodeGenFunction::EmitSMELdrStr(const SVETypeFlags , if (Ops.size() == 3) { Function *Cntsb = CGM.getIntrinsic(Intrinsic::aarch64_sme_cntsb); llvm::Value *CntsbCall = Builder.CreateCall(Cntsb, {}, "svlb"); -llvm::Value *MulVL =

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-10-17 Thread Leandro Lupori via cfe-commits
@@ -50,3 +50,12 @@ ! MSVC-SAME: FortranDecimal.lib ! MSVC-SAME: /subsystem:console ! MSVC-SAME: "[[object_file]]" + +! Verify that certain linker flags are known to the frontend and are passed on +! to the linker. + +! RUN: %flang -### -rpath /path/to/dir -shared -static %s

[clang] dd5d65a - [HIP][Clang][CodeGen] Add CodeGen support for `hipstdpar`

2023-10-17 Thread Alex Voicu via cfe-commits
Author: Alex Voicu Date: 2023-10-17T11:41:36+01:00 New Revision: dd5d65adb6413122a5ba1ed04c5c2c0b4951b76c URL: https://github.com/llvm/llvm-project/commit/dd5d65adb6413122a5ba1ed04c5c2c0b4951b76c DIFF: https://github.com/llvm/llvm-project/commit/dd5d65adb6413122a5ba1ed04c5c2c0b4951b76c.diff

[PATCH] D155850: [HIP][Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

2023-10-17 Thread Alex Voicu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd5d65adb641: [HIP][Clang][CodeGen] Add CodeGen support for `hipstdpar` (authored by AlexVlx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-17 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/68743 From 84ebaa789588605c924708a98392bd014c63f373 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Tue, 10 Oct 2023 22:50:43 +0200 Subject: [PATCH] [clang-format] Don't align

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-17 Thread Lawrence Benson via cfe-commits
https://github.com/lawben updated https://github.com/llvm/llvm-project/pull/69010 >From df8d0a53a31e1351bb6cd3b340e9012b489e9885 Mon Sep 17 00:00:00 2001 From: Lawrence Benson Date: Wed, 11 Oct 2023 17:26:11 +0200 Subject: [PATCH 1/9] Add __builtin_vectorelements to get the number of elements

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-17 Thread Björn Schäpers via cfe-commits
@@ -3191,20 +3191,120 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) { "}\n" "// Comment"; -#if 0 - // FIXME: The following comment is aligned with the namespace comment. verifyFormat("namespace A {\n" " int Foo;\n"

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-17 Thread Lawrence Benson via cfe-commits
lawben wrote: @erichkeane I think I've addressed all of your comments so far. Please check if there is anything else missing. https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-10-17 Thread Leandro Lupori via cfe-commits
luporl wrote: Adding `--target=x86_64-linux-gnu`, as @MaskRay suggests, fixes the test on Windows. But then we are not actually testing linking on Windows. On my Windows machine, the test output is practically the same as that reported by buildkite, as mentioned by @tarunprabhu above. I see

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

2023-10-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1213 std::optional SubExprT = classify(SubExpr); - if (E->getStorageDuration() == SD_Static) { +

[clang] [SVE ACLE] Allow default zero initialisation for svcount_t. (PR #69321)

2023-10-17 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm created https://github.com/llvm/llvm-project/pull/69321 This matches the behaviour of the other SVE ACLE types. >From d036844f5006adecbd5b0ae4fbc3014d43ef3992 Mon Sep 17 00:00:00 2001 From: Paul Walker Date: Tue, 17 Oct 2023 11:57:28 +0100 Subject: [PATCH]

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

2023-10-17 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/67663 From 9aea93ddeb70245a07984188aa98577d54e8e560 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Fri, 8 Sep 2023 14:20:00 +0200 Subject: [PATCH 01/11] [analyzer][clangsa] Add new option

[clang] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-17 Thread Freddy Ye via cfe-commits
@@ -1249,6 +1249,18 @@ def ProcessorFeatures { list ARLSFeatures = !listconcat(SRFFeatures, ARLSAdditionalFeatures); + // Pantherlake + list PTLAdditionalFeatures = [FeaturePREFETCHI]; + list PTLFeatures = +!listconcat(ARLSFeatures, PTLAdditionalFeatures);

[clang] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-17 Thread Freddy Ye via cfe-commits
@@ -2538,6 +2544,9 @@ // CHECK_SRF_M32: #define __PCONFIG__ 1 // CHECK_SRF_M32: #define __PKU__ 1 // CHECK_SRF_M32: #define __POPCNT__ 1 +// CHECK_SRF_M32-NOT: #define __PREFETCHI__ 1 +// CHECK_ARLS_M32-NOT: #define __PREFETCHI__ 1 +// CHECK_PTL_M32: #define __PREFETCHI__ 1

[clang] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-17 Thread Freddy Ye via cfe-commits
@@ -2628,6 +2647,9 @@ // CHECK_SRF_M64: #define __PCONFIG__ 1 // CHECK_SRF_M64: #define __PKU__ 1 // CHECK_SRF_M64: #define __POPCNT__ 1 +// CHECK_SRF_M64-NOT: #define __PREFETCHI__ 1 +// CHECK_ARLS_M64-NOT: #define __PREFETCHI__ 1 +// CHECK_PTL_M64: #define __PREFETCHI__ 1

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/69244 >From 810d49553eac0e42697283b008810cdc37971dd0 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 16 Oct 2023 13:02:14 -0700 Subject: [PATCH 1/3] [CONCEPTS]Corrected comparison of constraints with out of

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-17 Thread Erich Keane via cfe-commits
@@ -346,6 +351,11 @@ MultiLevelTemplateArgumentList Sema::getTemplateInstantiationArgs( CurDecl = Response::UseNextDecl(ND).NextDecl; } + if (!ND) { +assert(DC); erichkeane wrote: Probably not necessary, I'll remove it. I think I added that top

[clang] [Clang] Check features of tune CPU against target CPU (PR #68861)

2023-10-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: 1st pass through looks fine, but someone more knowledgable about powerPC and these compile options are likely better reviewers than I am. https://github.com/llvm/llvm-project/pull/68861 ___ cfe-commits mailing

[PATCH] D155850: [HIP][Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

2023-10-17 Thread Alex Voicu via Phabricator via cfe-commits
AlexVlx updated this revision to Diff 557733. AlexVlx added a comment. Simplify test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGStmt.cpp

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-10-17 Thread Gedare Bloom via cfe-commits
https://github.com/gedare created https://github.com/llvm/llvm-project/pull/69340 Function pointers are detected as a type of declaration using FunctionTypeLParen. They are aligned based on rules for AlignConsecutiveDeclarations. When a function pointer is on the right-hand side of an

[clang] 791b890 - [HIP][Clang][CodeGen] Simplify test for `hipstdpar`

2023-10-17 Thread Alex Voicu via cfe-commits
Author: Alex Voicu Date: 2023-10-17T15:42:28+01:00 New Revision: 791b890c468e5784113507f1f2fe7fed694c3962 URL: https://github.com/llvm/llvm-project/commit/791b890c468e5784113507f1f2fe7fed694c3962 DIFF: https://github.com/llvm/llvm-project/commit/791b890c468e5784113507f1f2fe7fed694c3962.diff

[clang] Correctly compute conversion seq for args to fn with reversed param order (PR #68999)

2023-10-17 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Friendly ping. https://github.com/llvm/llvm-project/pull/68999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,45 @@ +//===--- CoroutineHostileRAIICheck.h - clang-tidy *- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,45 @@ +//===--- CoroutineHostileRAIICheck.h - clang-tidy *- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [HIP] Document func ptr and virtual func (PR #68126)

2023-10-17 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: ping https://github.com/llvm/llvm-project/pull/68126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150961: [Clang][SVE2.1] Add svcntp prototype

2023-10-17 Thread Caroline via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG81d8fa5a1d01: [Clang][SVE2.1] Add svcntp prototype (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150961/new/

[clang] 81d8fa5 - [Clang][SVE2.1] Add svcntp prototype

2023-10-17 Thread Caroline Concatto via cfe-commits
Author: Caroline Concatto Date: 2023-10-17T14:14:45Z New Revision: 81d8fa5a1d01e1cd00865966957dba74b5e8613f URL: https://github.com/llvm/llvm-project/commit/81d8fa5a1d01e1cd00865966957dba74b5e8613f DIFF: https://github.com/llvm/llvm-project/commit/81d8fa5a1d01e1cd00865966957dba74b5e8613f.diff

[PATCH] D151081: [Clang][SVE2.1] Add svpext builtins

2023-10-17 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557730. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151081/new/ https://reviews.llvm.org/D151081 Files: clang/include/clang/Basic/arm_sve.td

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68908 >From 000c99324a0bd63e92e0ac056c3ff46d2b92c53e Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/7] [AArch64][SME] Remove immediate argument restriction for

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-17 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. LGTM, thanks. https://github.com/llvm/llvm-project/pull/68908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Document func ptr and virtual func (PR #68126)

2023-10-17 Thread via cfe-commits
@@ -176,3 +176,95 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +Compilation Modes += + +Each HIP source file contains intertwined device and host code. Depending on

[clang-tools-extra] [clang-tidy] Add check to diagnose coroutine-hostile RAII objects (PR #68738)

2023-10-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,117 @@ +//===--- CoroutineHostileRAII.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

  1   2   3   >