[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70213)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/70213 The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself,

[clang] [AMDGPU] Rematerialize scalar loads (PR #68778)

2023-10-25 Thread Piotr Sobczak via cfe-commits
piotrAMD wrote: Thanks. If there are no more comments, I will merge the change tomorrow. https://github.com/llvm/llvm-project/pull/68778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [AMDGPU] Rematerialize scalar loads (PR #68778)

2023-10-25 Thread Piotr Sobczak via cfe-commits
piotrAMD wrote: Thanks. If there are no more comments, I will merge the change tomorrow. https://github.com/llvm/llvm-project/pull/68778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: Can you make an example on how this is used now? Is there a way to test this? https://github.com/llvm/llvm-project/pull/70171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From 3cbae09c1bf66c4dc20e4e40d1051cb34497957e Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
owenpan closed this revision. owenpan added a comment. Herald added a subscriber: wangpc. Herald added a project: clang-format. Herald added a reviewer: rymiel. Fixed in D132001 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 23d6a6d - [clang-format] Fix the version for a newly added option

2023-10-25 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-25T05:45:32-07:00 New Revision: 23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9 URL: https://github.com/llvm/llvm-project/commit/23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9 DIFF: https://github.com/llvm/llvm-project/commit/23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9.diff

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Maybe a clang documentation can be added for this generic offloading > toolchain for OpenMP/CUDA/HIP. Could be a brief description about the > offloading entries and registration mechanism in the beginning then buffy it > up later. We have

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-25 Thread via cfe-commits
cor3ntin wrote: Can you add a release note for this change? It looks good otherwise https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61663: [clang-format] Fix a JavaScript import order bug.

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
owenpan commandeered this revision. owenpan edited reviewers, added: bowenni; removed: owenpan. owenpan added a comment. The test case doesn't pass. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61663/new/ https://reviews.llvm.org/D61663

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70213)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 84d8ace51a5afb07b528f65cde091cf3dbd7c326 183209f71b08a1fdba335d89c906cd26483115c1 --

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From c75c3729bac054b72caa502b464a24de2b63068b Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax

[clang] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

2023-10-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman, hope the WG14 meeting went well? I've essentially done what I > planned to do here, so I was wondering if you're ready to take it from here? > I can try to incorporate the review feedback myself, but it's quite likely > I'd make a mess of it (not familiar

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/70152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [tooling/include-mapping] Add missing localtime_r symbols (PR #66091)

2023-10-25 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/66091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #70024)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/70024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #70024)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Some additional comments and suggestions - you should also add a release note to clang/docs/ReleaseNotes.rst so users know about the new functionality. https://github.com/llvm/llvm-project/pull/70024 ___

[clang] [clang] Catch missing format attributes (PR #70024)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -936,6 +936,9 @@ def err_opencl_invalid_param : Error< def err_opencl_invalid_return : Error< "declaring function return value of type %0 is not allowed %select{; did you forget * ?|}1">; def warn_enum_value_overflow : Warning<"overflow in enumeration value">; +def

[clang] [clang] Catch missing format attributes (PR #70024)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -10615,6 +10615,8 @@ class Sema final { ChangedStateAtExit }; + void DiagnoseMissingFormatAttributes(NamedDecl *FDecl, SourceLocation Loc); AaronBallman wrote: ```suggestion void DiagnoseMissingFormatAttributes(const NamedDecl *FDecl,

[clang] 80db833 - [tooling/include-mapping] Add missing localtime_r symbols (#66091)

2023-10-25 Thread via cfe-commits
Author: Haojian Wu Date: 2023-10-25T15:37:04+02:00 New Revision: 80db833c75f5ea514f331b50372a1baf520b887e URL: https://github.com/llvm/llvm-project/commit/80db833c75f5ea514f331b50372a1baf520b887e DIFF: https://github.com/llvm/llvm-project/commit/80db833c75f5ea514f331b50372a1baf520b887e.diff

[clang] [tooling/include-mapping] Add missing localtime_r symbols (PR #66091)

2023-10-25 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/66091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6687c57 - [NFC][Clang] Make GetSDLFromOffloadArchive return void

2023-10-25 Thread Juan Manuel MARTINEZ CAAMAÑO via cfe-commits
Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-10-25T15:57:22+02:00 New Revision: 6687c5725cd51ff5c69a8ed90dceaf86c361ae6d URL: https://github.com/llvm/llvm-project/commit/6687c5725cd51ff5c69a8ed90dceaf86c361ae6d DIFF:

[clang] [clang]improve diagnosing redefined defaulted constructor with different exception specs (PR #69688)

2023-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/69688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Skip RecordDecl when checking scope of declarations (PR #69432)

2023-10-25 Thread via cfe-commits
cor3ntin wrote: The change looks good to me, but it is missing a release note in clang/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/69432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 7c94603 - [NFC][Clang] Make read-only arguments of GetSDLFromOffloadArchive and SDLSearch read-only references instead of copying them

2023-10-25 Thread Juan Manuel MARTINEZ CAAMAÑO via cfe-commits
Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-10-25T15:57:22+02:00 New Revision: 7c946031b2f4e8b2e0cf23af503a25a2c92be1a0 URL: https://github.com/llvm/llvm-project/commit/7c946031b2f4e8b2e0cf23af503a25a2c92be1a0 DIFF:

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-25 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/70046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d1f5954 - [clang][dataflow] Add `Environment::allows()`. (#70046)

2023-10-25 Thread via cfe-commits
Author: martinboehme Date: 2023-10-25T16:02:22+02:00 New Revision: d1f59544cf31488d84a2daff0020af2f8e366ed8 URL: https://github.com/llvm/llvm-project/commit/d1f59544cf31488d84a2daff0020af2f8e366ed8 DIFF: https://github.com/llvm/llvm-project/commit/d1f59544cf31488d84a2daff0020af2f8e366ed8.diff

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -55,6 +56,7 @@ #include "llvm/Target/TargetOptions.h" #include "llvm/TargetParser/SubtargetFeature.h" #include "llvm/TargetParser/Triple.h" +#include "llvm/Transforms/HipStdPar/HipStdPar.h" ZequanWu wrote: It's not added. It's reordered by

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/70190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread via cfe-commits
https://github.com/elizabethandrews created https://github.com/llvm/llvm-project/pull/70224 CXXDeductionGuideDecl inherits from FunctionDecl. For FunctionDecls, the JSONVisitor includes a call to visit NamedDecl in order to provide mangled names in the dump. This did not correctly exclude

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/70170 >From 44a9b1cc4a526b69c78aaed739df99af6c94bd79 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Wed, 25 Oct 2023 14:58:55 +0800 Subject: [PATCH] [clang][analyzer][NFC] Combine similar methods of StreamChecker

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69360 >From be3f5faa6cd17d76f26fb1bc6d6b59a8a78ffe82 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 17 Oct 2023 19:37:28 +0200 Subject: [PATCH 1/2] Lifetime bound check for coroutine ---

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69360 >From be3f5faa6cd17d76f26fb1bc6d6b59a8a78ffe82 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 17 Oct 2023 19:37:28 +0200 Subject: [PATCH 1/2] Lifetime bound check for coroutine ---

[clang] 078ae8c - [Offloading][NFC] Move creation of offloading entries from OpenMP (#70116)

2023-10-25 Thread via cfe-commits
Author: Joseph Huber Date: 2023-10-25T09:25:43-04:00 New Revision: 078ae8cd64b44f2ead538c45cf7fb4c4b63fdcaa URL: https://github.com/llvm/llvm-project/commit/078ae8cd64b44f2ead538c45cf7fb4c4b63fdcaa DIFF: https://github.com/llvm/llvm-project/commit/078ae8cd64b44f2ead538c45cf7fb4c4b63fdcaa.diff

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2005f48 - [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (#69916)

2023-10-25 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-25T17:37:56+04:00 New Revision: 2005f484f6c021318848cffda2c3d97c58615bb5 URL: https://github.com/llvm/llvm-project/commit/2005f484f6c021318848cffda2c3d97c58615bb5 DIFF:

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-25 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/69916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,78 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library -x hlsl \ +// RUN: -finclude-default-header -ast-dump %s | FileCheck %s + + +// CHECK: ExtVectorElementExpr {{.*}} 'int __attribute__((ext_vector_type(2)))' xx +// CHECK-NEXT: ImplicitCastExpr {{.*}}

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library -x hlsl -finclude-default-header -verify %s + + +int2 ToTwoInts(int V) { + return V.xy; // expected-error{{vector component access exceeds type 'int __attribute__((ext_vector_type(1)))' (vector of 1

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,78 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library -x hlsl \ +// RUN: -finclude-default-header -ast-dump %s | FileCheck %s + + +// CHECK: ExtVectorElementExpr {{.*}} 'int __attribute__((ext_vector_type(2)))' xx +// CHECK-NEXT: ImplicitCastExpr {{.*}}

[PATCH] D61663: [clang-format] Fix a JavaScript import order bug.

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 557879. owenpan added a comment. Make the test case pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61663/new/ https://reviews.llvm.org/D61663 Files: clang/lib/Format/SortJavaScriptImports.cpp clang/unittests/Format/SortImportsTestJS.cpp

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/70217 The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself,

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70216)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/70216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-25 Thread Arseny Kapoulkine via cfe-commits
zeux wrote: Let me know if I need to do anything else here -- I don't have commit rights so someone else will need to press the merge button :) https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 9bdeab1 - [LinkerWrapper][Obvious] Fix dangling stringref on Xcuda-ptxas options

2023-10-25 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-10-25T10:42:34-05:00 New Revision: 9bdeab1e7b25240d9282dbdc3617aaade195d62e URL: https://github.com/llvm/llvm-project/commit/9bdeab1e7b25240d9282dbdc3617aaade195d62e DIFF: https://github.com/llvm/llvm-project/commit/9bdeab1e7b25240d9282dbdc3617aaade195d62e.diff

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread Tom Honermann via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, tahonermann wrote: It looks like a

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread Matthias Braun via cfe-commits
MatzeB wrote: The internal services I tried here tended to slightly improve or stay neutral. We can revert, but could you please share some details on how your clang built / tested so I have a chance to address things and bring these changes back?

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-25 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm edited https://github.com/llvm/llvm-project/pull/67299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-25 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm approved this pull request. I'm going to approve this patch. I don't think that removing the mask `__fpscr_save.__fpscr &= 0x70007f0ffL;` in `smmintrin.h` with have issues but I don't feel strongly enough about it to block this patch. If you are not convinced

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-25 Thread Stefan Pintilie via cfe-commits
@@ -68,10 +68,10 @@ extern __inline __m128d __asm__("mffsce %0" : "=f"(__fpscr_save.__fr)); __enables_save.__fpscr = __fpscr_save.__fpscr & 0xf8; #else -__fpscr_save.__fr = __builtin_mffs(); +__fpscr_save.__fr = __builtin_ppc_mffs();

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-25 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm approved this pull request. I'm going to approve this patch. I don't think that removing the mask `__fpscr_save.__fpscr &= 0x70007f0ffL;` in `smmintrin.h` with have issues but I don't feel strongly enough about it to block this patch. If you are not convinced

[clang-tools-extra] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-25 Thread Stefan Pintilie via cfe-commits
@@ -68,10 +68,10 @@ extern __inline __m128d __asm__("mffsce %0" : "=f"(__fpscr_save.__fr)); __enables_save.__fpscr = __fpscr_save.__fpscr & 0xf8; #else -__fpscr_save.__fr = __builtin_mffs(); +__fpscr_save.__fr = __builtin_ppc_mffs();

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-25 Thread via cfe-commits
@@ -930,7 +930,11 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, // and FP constants (specifically, the 'pp-number' regex), and assumes that // the byte at "*end" is both valid and not part of the regex. Because of // this, it doesn't have to

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70216)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/70216 The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself,

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM assuming the requested codegen tests don't bring up any surprises for you. https://github.com/llvm/llvm-project/pull/67805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/67805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -fsyntax-only -triple x86_64-linux-gnu -verify %s AaronBallman wrote: Yeah, a codegen test would make sense (just to show that we actually do emit code for that monstrosity). https://github.com/llvm/llvm-project/pull/67805

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself,

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile ) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-25 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Thanks for your patience, I should have looked at this sooner. The change to our downstream test looks expected; the `` buffer changed ```diff -#import "/^tc/lib/clang/18/include/stdbool.h" +#import "stdbool.h" ``` But the actual resolution of which header is used is

[clang] [clang] Non-object types are non-trivially relocatable (PR #69734)

2023-10-25 Thread via cfe-commits
cor3ntin wrote: an you add tests / release notes? (the change itself looks fine to me) https://github.com/llvm/llvm-project/pull/69734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/70170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 00b7979 - [clang][analyzer][NFC] Combine similar methods of StreamChecker (#70170)

2023-10-25 Thread via cfe-commits
Author: Ben Shi Date: 2023-10-25T22:00:02+08:00 New Revision: 00b7979946e55ae291dc3e57112d3e5e7892b547 URL: https://github.com/llvm/llvm-project/commit/00b7979946e55ae291dc3e57112d3e5e7892b547 DIFF: https://github.com/llvm/llvm-project/commit/00b7979946e55ae291dc3e57112d3e5e7892b547.diff LOG:

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70216)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes The namespace lookup should give a matching friend operator!= as friend functions belong to the namespace scope (as opposed to the lexical class scope). Thus to resolve ambiguity of operator== with itself,

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70213)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/70213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cc2fbc648d7babbfa612f4f5eda3160212ef6ca7 26b9570fadf428e2f55efe0f2d9433cf18305239 --

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-25 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: Maybe a clang documentation can be added for this generic offloading toolchain for OpenMP/CUDA/HIP. Could be a brief description about the offloading entries and registration mechanism in the beginning then buffy it up later. https://github.com/llvm/llvm-project/pull/70116

[clang] 6c0ceae - [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static (#70201)

2023-10-25 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2023-10-25T15:31:04+02:00 New Revision: 6c0ceaeccc1358cc3478e832c86615f92801a657 URL: https://github.com/llvm/llvm-project/commit/6c0ceaeccc1358cc3478e832c86615f92801a657 DIFF:

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static (PR #70201)

2023-10-25 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/70201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. https://github.com/llvm/llvm-project/pull/70170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-25 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. Thanks for confirming, Ben! I don't have other concerns, this should be good to land. https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, elizabethandrews wrote: Yes I did.

[clang] Disable memtag sanitization for global fnptrs going into .ctors (PR #70186)

2023-10-25 Thread Victor Signaevskyi via cfe-commits
https://github.com/P1119r1m approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/69916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Thanks for bringing this! I didn't notice the post in discourse and I'll put higher level comments there. https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,184 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + + +#define CORO_TYPE

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recognize friend operator != to fix ambiguity with operator== (PR #70217)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/70217 >From 26b9570fadf428e2f55efe0f2d9433cf18305239 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 25 Oct 2023 16:55:15 +0200 Subject: [PATCH 1/2] friend operator!= --- clang/lib/Sema/SemaOverload.cpp

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/69656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Fold xored one-complemented operand comparisons (PR #69882)

2023-10-25 Thread Nikita Popov via cfe-commits
nikic wrote: @elhewaty This is due to an incorrect rebase around the processUMulZExtIdiom() call. Can you please rebase another time over https://github.com/llvm/llvm-project/commit/ea99df2e84d5f1da7f04bfa9f13844c44e0f1f78, which should remove all the diffs unrelated to your change?

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 updated https://github.com/llvm/llvm-project/pull/69567 >From ebc8ebdebf707f94723b1fe0ee1a1b6afe5dff49 Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Thu, 19 Oct 2023 12:52:13 +0530 Subject: [PATCH] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cd29e19 - [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (#69126)

2023-10-25 Thread via cfe-commits
Author: Arseny Kapoulkine Date: 2023-10-25T11:58:28-04:00 New Revision: cd29e19e9476e221015d895618512717d872a83b URL: https://github.com/llvm/llvm-project/commit/cd29e19e9476e221015d895618512717d872a83b DIFF:

[clang-tools-extra] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From aa31606a9d391682046bca3276e8c135c956f196 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-25 Thread via cfe-commits
https://github.com/elizabethandrews updated https://github.com/llvm/llvm-project/pull/70224 >From 21ecdfb97ff2e8152cec7b4fa3c2fd8913244889 Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Wed, 25 Oct 2023 09:17:09 -0700 Subject: [PATCH 1/2] [Clang] Fix a crash when using ast-dump=json

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if

[clang] Bfi precision (PR #66285)

2023-10-25 Thread Nikita Popov via cfe-commits
nikic wrote: It looks like this has made clang 0.7% slower (in the sense that the clang stage2 binary is optimized worse -- there is no negative impact on stage1). The binary is also 0.7% larger. It looks like this change has significant impact on inlining heuristics. Not really sure what to

[clang-tools-extra] Bfi precision (PR #66285)

2023-10-25 Thread David Li via cfe-commits
david-xl wrote: This is concerning. Can this be reverted for now and we can help with some internal performance testing. @xur-llvm https://github.com/llvm/llvm-project/pull/66285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 53705dd - [clang]improve diagnosing redefined defaulted constructor with different exception specs (#69688)

2023-10-25 Thread via cfe-commits
Author: Congcong Cai Date: 2023-10-25T22:22:13+08:00 New Revision: 53705ddcb73b15393a48c868864522d23aef7884 URL: https://github.com/llvm/llvm-project/commit/53705ddcb73b15393a48c868864522d23aef7884 DIFF: https://github.com/llvm/llvm-project/commit/53705ddcb73b15393a48c868864522d23aef7884.diff

[clang] [clang]improve diagnosing redefined defaulted constructor with different exception specs (PR #69688)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/69688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >