[llvm] [clang] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-05 Thread via cfe-commits
koute wrote: > Can you fire a PR for these changes? I think we should support it in > compiler-rt once we have merged this PR. Once this PR is merged, sure, I can make a PR. https://github.com/llvm/llvm-project/pull/76777 ___ cfe-commits mailing

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -215,11 +208,15 @@ class ActionFactory : public tooling::FrontendActionFactory { : HeaderFilter(HeaderFilter) {} std::unique_ptr create() override { -return std::make_unique(HeaderFilter); +return std::make_unique(HeaderFilter, EditFiles); } + const

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/77056 Parameter variable which is forwarded in lambda capture list or in body by reference is reasonable and current version of this check produces false positive on these cases. This patch try to fix the

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/76960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks, lgtm! https://github.com/llvm/llvm-project/pull/76960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/76811 >From 1164c705a8515d39bc9d4404e8523da8876d81cf Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 3 Jan 2024 19:33:01 +0800 Subject: [PATCH 1/3] [Clang] Correctly construct template arguments for file-scope

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Freddy Ye via cfe-commits
@@ -18,7 +18,7 @@ This test serves two purposes: The list of warnings below should NEVER grow. It should gradually shrink to 0. -CHECK: Warnings without flags (65): FreddyLeaf wrote: Will fix https://github.com/llvm/llvm-project/pull/75580

[libcxx] [lldb] [openmp] [llvm] [mlir] [clang] [clang-tools-extra] [SEH] Fix register liveness verification for EHa (PR #76933)

2024-01-05 Thread Phoebe Wang via cfe-commits
@@ -3347,10 +3348,37 @@ void MachineVerifier::verifyLiveRangeSegment(const LiveRange , OwnerLI.computeSubRangeUndefs(Undefs, LaneMask, *MRI, *Indexes); } + bool IsEHa = MF->getMMI().getModule()->getModuleFlag("eh-asynch"); while (true) {

[clang] [clang][analyzer] Add missing stream related functions to StdCLibraryFunctionsChecker. (PR #76979)

2024-01-05 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/76979 From e24b90eebfff7a352dd2c0df7f948ffef26ea3b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 4 Jan 2024 18:16:12 +0100 Subject: [PATCH 1/2] [clang][analyzer] Add missing stream

[clang] [Clang] Correctly construct template arguments for file-scope template template parameters (PR #76811)

2024-01-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/76811 >From 1164c705a8515d39bc9d4404e8523da8876d81cf Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 3 Jan 2024 19:33:01 +0800 Subject: [PATCH 1/2] [Clang] Correctly construct template arguments for file-scope

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/76811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/76960 >From 6cc7141f1f182763ccec8a4801d3b866cc839324 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 4 Jan 2024 14:59:22 +0100 Subject: [PATCH 1/3] [include-cleaner] Fix a race issue when editing multiple files.

[clang] [coroutines] Introduce [[clang::coro_disable_lifetimebound]] (PR #76818)

2024-01-05 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. I agree we could add parameter attributes later! LGTM! https://github.com/llvm/llvm-project/pull/76818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Phoebe Wang via cfe-commits
@@ -18,7 +18,7 @@ This test serves two purposes: The list of warnings below should NEVER grow. It should gradually shrink to 0. -CHECK: Warnings without flags (65): phoebewang wrote: Maybe it's not a good example. The test is to prevent adding warnings

[llvm] [clang] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-05 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: > > As for your diffs, it seems that you only handle the > > `__riscv_save/restore_[2|1|0]`, which is incomplete. And the code is not > > different with non-rve cases? > > Yes, I mostly copy-pasted the existing code and removed all of the code > dealing with registers not

[clang-tools-extra] 67963d3 - [include-cleaner] Fix a race issue when editing multiple files. (#76960)

2024-01-05 Thread via cfe-commits
Author: Haojian Wu Date: 2024-01-05T10:13:33+01:00 New Revision: 67963d384b23a2d46967b8f39ec2df3375731f4f URL: https://github.com/llvm/llvm-project/commit/67963d384b23a2d46967b8f39ec2df3375731f4f DIFF: https://github.com/llvm/llvm-project/commit/67963d384b23a2d46967b8f39ec2df3375731f4f.diff

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/76960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Freddy Ye via cfe-commits
@@ -69,7 +69,10 @@ // RUN: %clang_cl -m32 -arch:avx2 --target=i386-pc-windows -### -- 2>&1 %s | FileCheck -check-prefix=avx2 %s // avx2: invalid /arch: argument -// RUN: %clang_cl -m32 -arch:AVX512F --target=i386-pc-windows /c /Fo%t.obj -Xclang -verify

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

2024-01-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/77066 This came up in the discussion with seastar folks on RFC Fixes https://github.com/llvm/llvm-project/issues/76995 >From 3e0d0ab6c4fc6cba68285816a95e423bc18e8e55 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date:

[clang] 0eefcaf - [Clang][SME] Add IsStreamingOrSVE2p1 (#76975)

2024-01-05 Thread via cfe-commits
Author: Sam Tebbs Date: 2024-01-05T09:55:50Z New Revision: 0eefcaf96d2900a4f3009026a3673ed3b7793fcc URL: https://github.com/llvm/llvm-project/commit/0eefcaf96d2900a4f3009026a3673ed3b7793fcc DIFF: https://github.com/llvm/llvm-project/commit/0eefcaf96d2900a4f3009026a3673ed3b7793fcc.diff LOG:

[clang] [Clang][SME] Add IsStreamingOrSVE2p1 (PR #76975)

2024-01-05 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 closed https://github.com/llvm/llvm-project/pull/76975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/76811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: ping for review https://github.com/llvm/llvm-project/pull/75580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [clang] Disable missing definition warning on pure virtual functions (PR #74510)

2024-01-05 Thread Charalampos Mitrodimas via cfe-commits
https://github.com/charmitro updated https://github.com/llvm/llvm-project/pull/74510 >From 83d29e896b7ae0b5b259cbf179143e526dc37b1c Mon Sep 17 00:00:00 2001 From: Charalampos Mitrodimas Date: Tue, 5 Dec 2023 11:46:56 +0200 Subject: [PATCH] [clang] Disable missing definition warning on pure

[clang] Improve modeling of 'getcwd' in the StdLibraryFunctionsChecker (PR #77040)

2024-01-05 Thread Balázs Kéri via cfe-commits
@@ -2516,12 +2516,15 @@ void StdLibraryFunctionsChecker::initFunctionSummaries( .ArgConstraint(NotNull(ArgNo(0; // char *getcwd(char *buf, size_t size); -// FIXME: Improve for errno modeling. addToFunctionSummaryMap( "getcwd",

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/76960 >From 6cc7141f1f182763ccec8a4801d3b866cc839324 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 4 Jan 2024 14:59:22 +0100 Subject: [PATCH 1/4] [include-cleaner] Fix a race issue when editing multiple files.

[clang] [clang][analyzer] Support 'fdopen' in the StreamChecker (PR #76776)

2024-01-05 Thread Balázs Kéri via cfe-commits
balazske wrote: Documentation is in **checkers.rst** but not accurate now. It must be updated with more information. https://github.com/llvm/llvm-project/pull/76776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[lldb] [clang] [llvm] [libcxx] [clang-tools-extra] [mlir] [openmp] [SEH] Fix register liveness verification for EHa (PR #76933)

2024-01-05 Thread Phoebe Wang via cfe-commits
@@ -3347,10 +3348,37 @@ void MachineVerifier::verifyLiveRangeSegment(const LiveRange , OwnerLI.computeSubRangeUndefs(Undefs, LaneMask, *MRI, *Indexes); } + bool IsEHa = MF->getMMI().getModule()->getModuleFlag("eh-asynch"); while (true) {

[lldb] [openmp] [compiler-rt] [libcxx] [llvm] [libc] [flang] [clang-tools-extra] [mlir] [clang] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-05 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/74994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [openmp] [compiler-rt] [libcxx] [llvm] [libc] [flang] [lld] [clang-tools-extra] [mlir] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-05 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/76632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

2024-01-05 Thread via cfe-commits
Yaraslaut wrote: ping https://github.com/llvm/llvm-project/pull/75545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c458f92 - [NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (#75254)

2024-01-05 Thread via cfe-commits
Author: Duo Wang Date: 2024-01-05T09:59:26Z New Revision: c458f928fad7bbcf08ab1da9949eb2969fc9f89c URL: https://github.com/llvm/llvm-project/commit/c458f928fad7bbcf08ab1da9949eb2969fc9f89c DIFF: https://github.com/llvm/llvm-project/commit/c458f928fad7bbcf08ab1da9949eb2969fc9f89c.diff LOG:

[clang] [NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (PR #75254)

2024-01-05 Thread via cfe-commits
https://github.com/goussepi closed https://github.com/llvm/llvm-project/pull/75254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

2024-01-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (PR #75254)

2024-01-05 Thread via cfe-commits
https://github.com/goussepi approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/75254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

2024-01-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Freddy Ye via cfe-commits
@@ -18,7 +18,7 @@ This test serves two purposes: The list of warnings below should NEVER grow. It should gradually shrink to 0. -CHECK: Warnings without flags (65): FreddyLeaf wrote: Emm, seems like increased six months ago:

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/77056 >From 043fc62485293f5cdc41ed8e4afd056671b0ea06 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 3 Jan 2024 09:44:26 +0800 Subject: [PATCH] [clang-tidy] fix false positive in

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Qizhi Hu (jcsxky) Changes Parameter variable which is forwarded in lambda capture list or in body by reference is reasonable and current version of this check produces false positive on these cases. This patch try to fix the

[clang] [clang][analyzer] Add missing stream related functions to StdCLibraryFunctionsChecker. (PR #76979)

2024-01-05 Thread Balázs Kéri via cfe-commits
balazske wrote: Next step is to add all functions to the non-POSIX part that exist in the C standard (at least the stream functions), and change `fread` and `fwrite` too (currently `errno` is always modeled but should be only in POSIX mode). https://github.com/llvm/llvm-project/pull/76979

[clang] [clang-format] Fix crash involving array designators and dangling comma (PR #77045)

2024-01-05 Thread Owen Pan via cfe-commits
@@ -1444,7 +1444,8 @@ WhitespaceManager::CellDescriptions WhitespaceManager::getCells(unsigned Start, } else if (C.Tok->is(tok::comma)) { if (!Cells.empty()) Cells.back().EndIndex = i; -if (C.Tok->getNextNonComment()->isNot(tok::r_brace)) //

[clang] [clang-format] Fix crash involving array designators and dangling comma (PR #77045)

2024-01-05 Thread Owen Pan via cfe-commits
@@ -21084,6 +21084,12 @@ TEST_F(FormatTest, CatchAlignArrayOfStructuresLeftAlignment) { "};", Style); + verifyNoCrash("Foo f[] = {\n" +"[0] = { 1, },\n" +"[1] { 1, },\n" +"};", +Style);

[clang] 190a75b - [coroutines] Introduce [[clang::coro_disable_lifetimebound]] (#76818)

2024-01-05 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2024-01-05T10:07:04+01:00 New Revision: 190a75b5f12d3872a5a26d6079d62adae40f147d URL: https://github.com/llvm/llvm-project/commit/190a75b5f12d3872a5a26d6079d62adae40f147d DIFF:

[clang] [coroutines] Introduce [[clang::coro_disable_lifetimebound]] (PR #76818)

2024-01-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/76818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [llvm] [libcxx] [clang-tools-extra] [mlir] [openmp] [SEH] Fix register liveness verification for EHa (PR #76933)

2024-01-05 Thread via cfe-commits
https://github.com/HaohaiWen edited https://github.com/llvm/llvm-project/pull/76933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Phoebe Wang via cfe-commits
@@ -69,7 +69,10 @@ // RUN: %clang_cl -m32 -arch:avx2 --target=i386-pc-windows -### -- 2>&1 %s | FileCheck -check-prefix=avx2 %s // avx2: invalid /arch: argument -// RUN: %clang_cl -m32 -arch:AVX512F --target=i386-pc-windows /c /Fo%t.obj -Xclang -verify

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Phoebe Wang via cfe-commits
@@ -18,7 +18,7 @@ This test serves two purposes: The list of warnings below should NEVER grow. It should gradually shrink to 0. -CHECK: Warnings without flags (65): phoebewang wrote: The comment says we should not increase it.

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/75580 >From e16afbdc9f0c04bad0e8f80f90c0eb26c13d3326 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 15 Dec 2023 16:50:23 +0800 Subject: [PATCH 1/7] [X86] Emit Warnings for frontend options to enable knl/knm.

[clang] [clang-format] Break after string literals with trailing line breaks (PR #76795)

2024-01-05 Thread Owen Pan via cfe-commits
@@ -5151,6 +5151,14 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine , return true; if (Left.IsUnterminatedLiteral) return true; + // FIXME: Breaking after newlines seems useful in general. Turn this into an + // option and Recognize more cases like

[clang] [clang-format] Break after string literals with trailing line breaks (PR #76795)

2024-01-05 Thread Owen Pan via cfe-commits
@@ -2499,6 +2499,15 @@ TEST_F(TokenAnnotatorTest, BraceKind) { EXPECT_BRACE_KIND(Tokens[6], BK_Block); } +TEST_F(TokenAnnotatorTest, StreamOperator) { + auto Tokens = annotate("\"foo\\n\" << aux << \"foo\\n\" << \"foo\";"); + ASSERT_EQ(Tokens.size(), 9u) << Tokens; +

[libcxxabi] [lldb] [compiler-rt] [mlir] [flang] [libc] [clang-tools-extra] [llvm] [libcxx] [lld] [clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2024-01-05 Thread Hristo Hristov via cfe-commits
H-G-Hristov wrote: Just a gentle reminder. You should probably also update the release notes, the status page and the feature test macro: `#define __cpp_lib_ranges_contains 20L // also in ` https://github.com/llvm/llvm-project/pull/66963 ___

[clang] [coroutines] Introduce [[clang::coro_disable_lifetimebound]] (PR #76818)

2024-01-05 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. I feel good with this. We can do other improvements in other patches. https://github.com/llvm/llvm-project/pull/76818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [clang-tools-extra] [AMDGPU][GFX12] Default component broadcast store (PR #76212)

2024-01-05 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd updated https://github.com/llvm/llvm-project/pull/76212 >From 06117c6124e94953f62eff3b1b87d98146f9e25e Mon Sep 17 00:00:00 2001 From: Mateja Marjanovic Date: Wed, 10 May 2023 16:24:38 +0200 Subject: [PATCH 1/2] [AMDGPU][GFX12] Default component

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/76811 >From 1164c705a8515d39bc9d4404e8523da8876d81cf Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 3 Jan 2024 19:33:01 +0800 Subject: [PATCH 1/3] [Clang] Correctly construct template arguments for file-scope

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

2024-01-05 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/76960 >From 6cc7141f1f182763ccec8a4801d3b866cc839324 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 4 Jan 2024 14:59:22 +0100 Subject: [PATCH 1/2] [include-cleaner] Fix a race issue when editing multiple files.

[lldb] [clang] [llvm] [libcxx] [clang-tools-extra] [mlir] [openmp] [SEH] Fix register liveness verification for EHa (PR #76933)

2024-01-05 Thread via cfe-commits
@@ -3347,10 +3348,37 @@ void MachineVerifier::verifyLiveRangeSegment(const LiveRange , OwnerLI.computeSubRangeUndefs(Undefs, LaneMask, *MRI, *Indexes); } + bool IsEHa = MF->getMMI().getModule()->getModuleFlag("eh-asynch"); while (true) {

[clang] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

2024-01-05 Thread Freddy Ye via cfe-commits
@@ -18,7 +18,7 @@ This test serves two purposes: The list of warnings below should NEVER grow. It should gradually shrink to 0. -CHECK: Warnings without flags (65): FreddyLeaf wrote: agree. Will add a warning group. sorry for misleading info above.

[clang] [CLANG][NFC] Modify test cases to suit assigned default sysroot path (PR #77075)

2024-01-05 Thread via cfe-commits
https://github.com/Yunzezhu94 created https://github.com/llvm/llvm-project/pull/77075 When using cmake with option -DDEFAULT_SYSROOT, a default sysroot path is assigned. However, some test cases use a relative path to indicate sysroot path, but the path goes wrong with default sysroot path

[clang] [clang] Disable missing definition warning on pure virtual functions (PR #74510)

2024-01-05 Thread Charalampos Mitrodimas via cfe-commits
https://github.com/charmitro updated https://github.com/llvm/llvm-project/pull/74510 >From f60f12f8e4e8b70a8fdf2aa9398b94849a863fff Mon Sep 17 00:00:00 2001 From: Charalampos Mitrodimas Date: Tue, 5 Dec 2023 11:46:56 +0200 Subject: [PATCH] [clang] Disable missing definition warning on pure

[clang] [Serialization] Load Specializations Lazily (1/2) (PR #76774)

2024-01-05 Thread Jonas Hahnfeld via cfe-commits
@@ -1249,3 +1249,5 @@ void ODRHash::AddQualType(QualType T) { void ODRHash::AddBoolean(bool Value) { Bools.push_back(Value); } + +void ODRHash::AddInteger(unsigned Value) { ID.AddInteger(Value); } hahnjo wrote: The review related to `ODRHash` is this one:

[clang] [clang][ASTImporter] Only reorder fields of RecordDecls (PR #77079)

2024-01-05 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/77079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Only reorder fields of RecordDecls (PR #77079)

2024-01-05 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/77079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME] Add IsStreamingOrSVE2p1 (PR #76975)

2024-01-05 Thread Sam Tebbs via cfe-commits
@@ -50,6 +50,7 @@ class LLVM_LIBRARY_VISIBILITY AArch64TargetInfo : public TargetInfo { bool HasMatMul = false; bool HasBFloat16 = false; bool HasSVE2 = false; + bool HasSVE2p1 = false; SamTebbs33 wrote: Thanks I saw this too. Testing the fix as we

[clang] 20a0567 - [clang] Accept recursive non-dependent calls to functions with deduced return type (#75456)

2024-01-05 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2024-01-05T13:14:51+01:00 New Revision: 20a05677f9394d4bc9467fe7bc93a4ebd3aeda61 URL: https://github.com/llvm/llvm-project/commit/20a05677f9394d4bc9467fe7bc93a4ebd3aeda61 DIFF:

[flang] [mlir] [libc] [compiler-rt] [polly] [lld] [llvm] [openmp] [libcxx] [clang-tools-extra] [clang] [CostModel][X86] Fix fpext conversion cost for 16 elements (PR #76278)

2024-01-05 Thread via cfe-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/76278 >From 87f3d68e82dcc752aa727f62b8b1b56b1257b343 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Sat, 23 Dec 2023 13:16:02 +0800 Subject: [PATCH 1/4] [CostModel][X86] Track fpext conversion for 16 elements ---

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. Missing release notes & some mention about this in documentation. https://github.com/llvm/llvm-project/pull/77056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Piotr Zegar via cfe-commits
@@ -53,18 +53,76 @@ AST_MATCHER(ParmVarDecl, isTemplateTypeParameter) { FuncTemplate->getTemplateParameters()->getDepth(); } +AST_MATCHER_P(NamedDecl, hasSameNameAsBoundNode, std::string, BindingID) { + const auto = Node.getNameAsString(); PiotrZSL

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/77056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Piotr Zegar via cfe-commits
@@ -53,18 +53,76 @@ AST_MATCHER(ParmVarDecl, isTemplateTypeParameter) { FuncTemplate->getTemplateParameters()->getDepth(); } +AST_MATCHER_P(NamedDecl, hasSameNameAsBoundNode, std::string, BindingID) { + const auto = Node.getNameAsString(); + + return

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-05 Thread Piotr Zegar via cfe-commits
@@ -147,4 +147,24 @@ class AClass { T data; }; +template +void lambda_value_reference(T&& t) { + [&]() { T other = std::forward(t); }; +} + +template +void lambda_value_reference_capture_list_ref_1(T&& t) { +[=, ] { T other = std::forward(t); }; +} + +template +void

[clang] [clang] Correctly implement CWG 2672 (PR #75001)

2024-01-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/75001 >From 8681b3c9f5e19b6ae977321d5d4154113273c2a0 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 12 Nov 2023 13:21:03 +0800 Subject: [PATCH 1/2] [clang] Correctly implement CWG 2672 This is a follow-up

[clang] [X86] Add ABI handling for __float128 (PR #75156)

2024-01-05 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. LGTM - please mention in the commit message + release notes that this matches GCC behaviour https://github.com/llvm/llvm-project/pull/75156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libc] [compiler-rt] [clang] [llvm] [clang-tools-extra] [flang] [libcxx] [clang] Accept recursive non-dependent calls to functions with deduced return type (PR #75456)

2024-01-05 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/75456 >From 0e190f131862dd8f4b07891c3ee712a0a163f936 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 14 Dec 2023 01:33:17 -0800 Subject: [PATCH 1/2] [clang] Accept recursive non-dependent calls to

[clang] [CLANG][NFC] Modify test cases to suit assigned default sysroot path (PR #77075)

2024-01-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-risc-v Author: None (Yunzezhu94) Changes When using cmake with option -DDEFAULT_SYSROOT, a default sysroot path is assigned. However, some test cases use a relative path to indicate sysroot path, but the path goes

[compiler-rt] [clang] [libc] [llvm] [libcxx] [clang-tools-extra] [lldb] [flang] [libunwind] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,123 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [compiler-rt] [libunwind] [flang] [llvm] [libcxx] [libc] [lldb] [clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,123 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [libcxx] [libunwind] [lldb] [clang] [compiler-rt] [libc] [flang] [llvm] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,123 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [libunwind] [lldb] [libc] [compiler-rt] [libcxx] [flang] [llvm] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,123 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[compiler-rt] [clang] [flang] [libunwind] [libc] [clang-tools-extra] [llvm] [libcxx] [lldb] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -13,7 +13,7 @@ // Range algorithms should return `std::ranges::dangling` when given a dangling range. philnik777 wrote: The formatting changes in here are nice, but would be better handled in a separate PR, just to make it clear what actually changed.

[lldb] [libunwind] [libcxx] [llvm] [libc] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,123 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[libunwind] [libc] [compiler-rt] [llvm] [clang] [lldb] [clang-tools-extra] [flang] [libcxx] [libc++] Implement ranges::iota (PR #68494)

2024-01-05 Thread Nikolas Klauser via cfe-commits
@@ -46,7 +46,7 @@ "`P2255R2 `__","LWG","A type trait to detect reference binding to temporary","February 2022","","" "`P2273R3 `__","LWG","Making ``std::unique_ptr`` constexpr","February 2022","|Complete|","16.0"

[clang] [clang][ExtractAPI] Record availability information only for the target platform (PR #76823)

2024-01-05 Thread Sofía Rodríguez via cfe-commits
sofiaromorales wrote: @QuietMisdreavus https://github.com/llvm/llvm-project/pull/76823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 567941b - [Clang][SME] Remove unused HasSVE2p1 variable

2024-01-05 Thread Sam Tebbs via cfe-commits
Author: Sam Tebbs Date: 2024-01-05T11:17:56Z New Revision: 567941bcc3b1fc3b1d2a902cf7ae2e173247a45f URL: https://github.com/llvm/llvm-project/commit/567941bcc3b1fc3b1d2a902cf7ae2e173247a45f DIFF: https://github.com/llvm/llvm-project/commit/567941bcc3b1fc3b1d2a902cf7ae2e173247a45f.diff LOG:

[lld] [llvm] [libcxx] [compiler-rt] [clang] [clang-tools-extra] [mlir] [openmp] [polly] [flang] [libc] [CostModel][X86] Fix fpext conversion cost for 16 elements (PR #76278)

2024-01-05 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: Got it thanks - given znver4 now has the worst cost, we should be setting the cost to 4 https://github.com/llvm/llvm-project/pull/76278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Add readability-use-builtin-literals check (PR #76065)

2024-01-05 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,161 @@ +//===--- UseBuiltinLiteralsCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Add readability-use-builtin-literals check (PR #76065)

2024-01-05 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,161 @@ +//===--- UseBuiltinLiteralsCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang][analyzer] Add missing stream related functions to StdCLibraryFunctionsChecker. (PR #76979)

2024-01-05 Thread Balázs Kéri via cfe-commits
balazske wrote: > Why do we need to keep these two checkers in-sync? Technically the checkers work independently. There is a functionality that is added by `StdLibraryFunctionsChecker`, the modeling of `errno` (this works even if `StreamChecker` is not used), and maybe some preconditions are

[clang] [clang][ASTImporter] Only reorder fields of RecordDecls (PR #77079)

2024-01-05 Thread Michael Buch via cfe-commits
Michael137 wrote: Need to sort out some test failures https://github.com/llvm/llvm-project/pull/77079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-05 Thread via cfe-commits
@@ -2604,19 +2604,22 @@ bool QualType::isTrivialType(const ASTContext ) const { return false; } -bool QualType::isTriviallyCopyableType(const ASTContext ) const { - if ((*this)->isArrayType()) -return Context.getBaseElementType(*this).isTriviallyCopyableType(Context);

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-05 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-05 Thread via cfe-commits
https://github.com/cor3ntin commented: Looking good beside a small nitpick https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -508,7 +508,8 @@ static bool mayBeValidIdentifier(llvm::StringRef Ident) { !isAsciiIdentifierStart(Ident.front(), AllowDollar)) return false; for (char C : Ident) { -if (llvm::isASCII(C) && !isAsciiIdentifierContinue(C, AllowDollar)) +if

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -338,6 +338,10 @@ inline bool isReservedName(llvm::StringRef Name) { SourceLocation translatePreamblePatchLocation(SourceLocation Loc, const SourceManager ); +clangd::Range tokenRangeForLoc(SourceLocation TokLoc,

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -53,13 +55,38 @@ struct RenameInputs { struct RenameResult { // The range of the symbol that the user can attempt to rename. Range Target; + // Placeholder text for the rename operation, if set. + std::optional Placeholder; kadircet wrote: same here,

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -71,8 +98,8 @@ llvm::Expected rename(const RenameInputs ); /// REQUIRED: Occurrences is sorted and doesn't have duplicated ranges. llvm::Expected buildRenameEdit(llvm::StringRef AbsFilePath, llvm::StringRef InitialCode, -

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -569,8 +571,43 @@ renameWithinFile(ParsedAST , const NamedDecl , // } if (!isInsideMainFile(RenameLoc, SM)) continue; +Locs.push_back(RenameLoc); + } + if (const auto *MD = dyn_cast()) { +auto Code = SM.getBufferData(SM.getMainFileID()); +auto

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -1187,6 +1187,16 @@ bool fromJSON(const llvm::json::Value , RenameParams , O.map("position", R.position) && O.map("newName", R.newName); } +llvm::json::Value toJSON(const PrepareRenameResult ) { + if (!PRR.placeholder) { kadircet wrote: nit:

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -1436,6 +1436,14 @@ struct RenameParams { }; bool fromJSON(const llvm::json::Value &, RenameParams &, llvm::json::Path); +struct PrepareRenameResult { + /// Range of the string to rename. + Range range; + /// Placeholder text to use in the editor, if set. +

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -53,13 +55,38 @@ struct RenameInputs { struct RenameResult { // The range of the symbol that the user can attempt to rename. Range Target; + // Placeholder text for the rename operation, if set. + std::optional Placeholder; // Rename occurrences for the current

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-01-05 Thread kadir çetinkaya via cfe-commits
@@ -183,6 +185,8 @@ bool isSpelled(SourceLocation Loc, const NamedDecl ) { if (clang::Lexer::getRawToken(Loc, Tok, SM, LO)) return false; auto StrName = Name.getAsString(); + if (const auto *MD = dyn_cast()) +StrName = MD->getSelector().getNameForSlot(0).str();

  1   2   3   4   5   >