Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Александр Шапошников via cfe-commits
>What's the purpose of this change PaddingChecker generates a report on it, yeah, you are right that it won't save too much (just a little), but it was easy to fix. Another reason why i am doing this - it reduces the number of reports produced by static analyzer (less noisy) - and since it saves sm

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

2016-09-10 Thread Александр Шапошников via cfe-commits
@ioeric: 1. regarding B: i apologize in advance, i am not sure if it's directly related to your patch, but i'm kinda afraid that the current approach will shadow the issue (if it's considered to be an issue). For simplicity let's take a look at the following example: Point.h: struct Point {};