[PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 created this revision. ashi1 added a reviewer: Anastasia. ashi1 added subscribers: yaxunl, cfe-commits, pxli168, bader, rsmith, nhaustov. Allow -cl-std and other standard -cl- options from cc1 to driver. Added a test for the options moved. http://reviews.llvm.org/D21031 Files:

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61574. ashi1 marked 4 inline comments as done. ashi1 added a comment. Revised to Anastasia's comments. http://reviews.llvm.org/D21031 Files: include/clang/Basic/DiagnosticFrontendKinds.td include/clang/Driver/CC1Options.td

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61423. ashi1 marked 2 inline comments as done. ashi1 added a comment. Revised based on Anastasia's comments. Also clang-test run passes, the testcases should be working correctly. http://reviews.llvm.org/D21031 Files:

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61275. ashi1 marked 2 inline comments as done. ashi1 added a comment. Revised with Anastasia's comments. Please take a look at the diagnostic to see if it is what we want. http://reviews.llvm.org/D21031 Files:

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 marked 6 inline comments as done. ashi1 added a comment. F2085685: D21031.patch Comment at: include/clang/Driver/CC1Options.td:670 @@ -669,21 +669,3 @@ -def cl_opt_disable : Flag<["-"], "cl-opt-disable">, - HelpText<"OpenCL only. This

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 updated this revision to Diff 49219. ashi1 marked an inline comment as done. ashi1 added a comment. Revised with Xiuli Pan's comments. http://reviews.llvm.org/D17578 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp test/CodeGenOpenCL/event_t.cl

[PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 created this revision. ashi1 added reviewers: Anastasia, pxli168, yaxunl. ashi1 added subscribers: pekka.jaaskelainen, tstellarAMD, cfe-commits. This patch will allow the cast of 0 to event_t type. http://reviews.llvm.org/D17578 Files: include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 added a comment. Xiuli, are you OK with this patch? http://reviews.llvm.org/D17578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 marked 5 inline comments as done. ashi1 added a comment. http://reviews.llvm.org/D17578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 updated this revision to Diff 56615. ashi1 added a comment. Modified the testcase. Tested this diff on clang-test and it passes. http://reviews.llvm.org/D17578 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp test/CodeGenOpenCL/event_t.cl

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 updated this revision to Diff 56599. ashi1 added a comment. Added changes for comments from majnemer. http://reviews.llvm.org/D17578 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp test/CodeGenOpenCL/event_t.cl test/SemaOpenCL/event_t.cl Index:

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 updated this revision to Diff 65582. ashi1 added a comment. Revised based on Anastasia's comments. Restructured the if statements in test cases. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

[PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Adding extension cl_khr_mipmap_image to clang's OpenCL Extensions and initiated inside AMDGPU Target. Repository: rL LLVM

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 updated this revision to Diff 65118. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Added to tests Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl Repository: rL LLVM https://reviews.llvm.org/D22637 Files:

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 updated this revision to Diff 65126. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

[PATCH] D22767: [OpenCL] Added CLK_ABGR definition for get_image_channel_order return value

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Added CLK_ABGR definition for get_image_channel_order return value inside opencl-c.h file Repository: rL LLVM

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else yaxunl wrote: > Anastasia wrote: > > Can you move this error

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 updated this revision to Diff 65773. ashi1 marked an inline comment as done. ashi1 added a comment. Removed indentation as per Anastasia's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

Re: [PATCH] D22424: [OpenCL] Fixes bug of missing OCL related metadata on the AMDGCN target

ashi1 updated this revision to Diff 64513. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Anastasia's comments. Now using new function name appendOpenCLVersionMD( Repository: rL LLVM https://reviews.llvm.org/D22424 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Allows AMDGCN target to generate images (such as %opencl.image2d_t) in constant address space. Images will still be generated in

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

ashi1 updated this revision to Diff 64538. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Also updated test file to changes with using triple spir-unknown-unknown. Repository: rL LLVM https://reviews.llvm.org/D22523 Files:

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

ashi1 updated this revision to Diff 64706. ashi1 marked an inline comment as done. ashi1 added a comment. Removed excess semicolon by Anastasia's comments Repository: rL LLVM https://reviews.llvm.org/D22523 Files: lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/TargetInfo.cpp

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 updated this revision to Diff 63539. ashi1 marked 2 inline comments as done. ashi1 added a comment. Moved cl-strict-aliasing testing to a new file cl-strict-aliasing.cl Repository: rL LLVM http://reviews.llvm.org/D22170 Files: lib/Frontend/CompilerInvocation.cpp

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 updated this revision to Diff 63722. ashi1 marked 4 inline comments as done. ashi1 added a comment. Revised to Anastasia's comments. Removed opencl-blocks.cl, and created a generic opencl.cl inside test/Frontend folder. This change passes clang-test. Repository: rL LLVM

[PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

ashi1 created this revision. ashi1 added reviewers: Anastasia, jvesely. ashi1 added subscribers: yaxunl, nhaustov, rsmith, bader, pxli168, cfe-commits. ashi1 set the repository for this revision to rL LLVM. Add OCL option -cl-no-signed-zeros to driver options. Also added to opencl.cl testcases.

[PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 created this revision. ashi1 added reviewers: Anastasia, bkramer. ashi1 added subscribers: nhaustov, rsmith, bader, pxli168, cfe-commits, yaxunl. ashi1 set the repository for this revision to rL LLVM. Fixes failures in test/Driver/opencl.cl. Also fixes strict-aliasing option to only be

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

ashi1 added a reviewer: yaxunl. ashi1 removed rL LLVM as the repository for this revision. ashi1 updated this revision to Diff 63143. ashi1 added a comment. Revised base on Sam's comments. Added no-signed-zeros as an attribute no-signed-zeros-fp-math. Added a test for no-signed-zeros-fp-math.

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 marked an inline comment as done. Comment at: cfe/trunk/include/clang/Driver/Options.td:381 @@ +380,3 @@ +def cl_unsafe_math_optimizations : Flag<["-"], "cl-unsafe-math-optimizations">, Group, Flags<[CC1Option]>, + HelpText<"OpenCL only. Allow unsafe floating-point

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 marked 4 inline comments as done. Comment at: lib/Frontend/CompilerInvocation.cpp:1681 @@ -1692,1 +1680,3 @@ + // -cl-strict-aliasing needs to emit diagnostic in the case where CL > 1.0. + // This option should be deprecated for CL > 1.0 because

[PATCH] D23071: [OpenCL] Remove extra native_ functions from opencl-c.h

ashi1 created this revision. ashi1 added reviewers: Anastasia, yaxunl, nhaustov. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. There should be no native_ builtin functions with double type arguments. Repository: rL LLVM

[PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

ashi1 created this revision. ashi1 added reviewers: bader, Anastasia, yaxunl. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. ndrange_t needs to be emitted as a struct type since it has to be allocated on a stack as a local variable or function

[PATCH] D23573: [OpenCL] Add extension cl_khr_subgroups to clang

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Adding extension cl_khr_subgroups to clang's OpenCL Extensions and initiated inside AMDGPU Target. Similar to

[clang] 8d2a0c1 - [HIP] NFC Add comments to cmath functions

Author: Aaron En Ye Shi Date: 2020-10-06T15:26:56Z New Revision: 8d2a0c115e245e86bba4ea1c70e6d34b552031a9 URL: https://github.com/llvm/llvm-project/commit/8d2a0c115e245e86bba4ea1c70e6d34b552031a9 DIFF: https://github.com/llvm/llvm-project/commit/8d2a0c115e245e86bba4ea1c70e6d34b552031a9.diff

[clang] aa2b593 - [HIP] Restructure hip headers to add cmath

Author: Aaron En Ye Shi Date: 2020-10-06T14:48:53Z New Revision: aa2b593f1495a972a4a592952760ec9d5f7c01f1 URL: https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1 DIFF: https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1.diff

[clang] 3700556 - [HIP][NFC] Use correct max in cuda_complex_builtins

Author: Aaron En Ye Shi Date: 2020-10-27T19:35:09Z New Revision: 3700556ecb062abf786ad52a5474c27b22c19107 URL: https://github.com/llvm/llvm-project/commit/3700556ecb062abf786ad52a5474c27b22c19107 DIFF: https://github.com/llvm/llvm-project/commit/3700556ecb062abf786ad52a5474c27b22c19107.diff

[clang] 96c2d5e - [HIP] Ignore invalid ar linker options

Author: Aaron En Ye Shi Date: 2020-08-06T17:39:41Z New Revision: 96c2d5e99e32340be1379959977f2d6247788db6 URL: https://github.com/llvm/llvm-project/commit/96c2d5e99e32340be1379959977f2d6247788db6 DIFF: https://github.com/llvm/llvm-project/commit/96c2d5e99e32340be1379959977f2d6247788db6.diff

[clang] c64bb3f - [HIP] Use default triple in llvm-mc for system ld

Author: Aaron En Ye Shi Date: 2020-07-07T16:44:51Z New Revision: c64bb3f7367a924e9d17dfc1c92897e6cbe1 URL: https://github.com/llvm/llvm-project/commit/c64bb3f7367a924e9d17dfc1c92897e6cbe1 DIFF: https://github.com/llvm/llvm-project/commit/c64bb3f7367a924e9d17dfc1c92897e6cbe1.diff

[clang] 4bafb0a - Add Statically Linked Libraries

Author: Aaron En Ye Shi Date: 2020-06-22T19:48:49Z New Revision: 4bafb0adcf38cf268208ea58eb7e11402d5632e2 URL: https://github.com/llvm/llvm-project/commit/4bafb0adcf38cf268208ea58eb7e11402d5632e2 DIFF: https://github.com/llvm/llvm-project/commit/4bafb0adcf38cf268208ea58eb7e11402d5632e2.diff

[clang] 77df5a8 - [HIP] Move HIP Linking Logic into HIP ToolChain

Author: Aaron En Ye Shi Date: 2020-06-22T19:48:48Z New Revision: 77df5a8283edbfc33ad3b12df3bd42d54d7ba4f4 URL: https://github.com/llvm/llvm-project/commit/77df5a8283edbfc33ad3b12df3bd42d54d7ba4f4 DIFF: https://github.com/llvm/llvm-project/commit/77df5a8283edbfc33ad3b12df3bd42d54d7ba4f4.diff

[clang] ba2612c - [HIP] cmath demote long double args to double

Author: Aaron En Ye Shi Date: 2020-12-03T23:00:14Z New Revision: ba2612ce01eae5859ae7adb99161775fb2c4e0b2 URL: https://github.com/llvm/llvm-project/commit/ba2612ce01eae5859ae7adb99161775fb2c4e0b2 DIFF: https://github.com/llvm/llvm-project/commit/ba2612ce01eae5859ae7adb99161775fb2c4e0b2.diff

[clang] f89e9c8 - [HIP] Fix HIP test on windows due to lld suffix

Author: Aaron En Ye Shi Date: 2020-11-30T21:05:26Z New Revision: f89e9c8201ea5a5b63af854c92ed26bc7ab4b8db URL: https://github.com/llvm/llvm-project/commit/f89e9c8201ea5a5b63af854c92ed26bc7ab4b8db DIFF: https://github.com/llvm/llvm-project/commit/f89e9c8201ea5a5b63af854c92ed26bc7ab4b8db.diff

[clang] cd5897d - [HIP] Fix static-lib test CHECK bug

Author: Aaron En Ye Shi Date: 2020-12-01T15:49:39Z New Revision: cd5897d55908827faf3e16c505bd79732a8f6eb6 URL: https://github.com/llvm/llvm-project/commit/cd5897d55908827faf3e16c505bd79732a8f6eb6 DIFF: https://github.com/llvm/llvm-project/commit/cd5897d55908827faf3e16c505bd79732a8f6eb6.diff

[clang] ca5b315 - [HIP] Math Headers to use type promotion

Author: Aaron En Ye Shi Date: 2020-11-03T18:40:26Z New Revision: ca5b31502c828f8e7160a77f54a5a131dc298005 URL: https://github.com/llvm/llvm-project/commit/ca5b31502c828f8e7160a77f54a5a131dc298005 DIFF: https://github.com/llvm/llvm-project/commit/ca5b31502c828f8e7160a77f54a5a131dc298005.diff

[clang] b2524eb - [HIP] Fix HIP rounding math intrinsics

Author: Aaron En Ye Shi Date: 2020-10-22T15:57:09Z New Revision: b2524eb9445a4487115c8f94fd946d2c4c95f652 URL: https://github.com/llvm/llvm-project/commit/b2524eb9445a4487115c8f94fd946d2c4c95f652 DIFF: https://github.com/llvm/llvm-project/commit/b2524eb9445a4487115c8f94fd946d2c4c95f652.diff

[clang] be40c12 - [HIP] Add signbit(long double) decl

Author: Aaron En Ye Shi Date: 2021-01-14T18:23:37Z New Revision: be40c12040a0d5551bf3430cbb184b5ef23e25fd URL: https://github.com/llvm/llvm-project/commit/be40c12040a0d5551bf3430cbb184b5ef23e25fd DIFF: https://github.com/llvm/llvm-project/commit/be40c12040a0d5551bf3430cbb184b5ef23e25fd.diff

[clang] f2cc042 - [HIP] Fix --hip-version flag with 0 as component

Author: Aaron En Ye Shi Date: 2021-06-11T16:25:03Z New Revision: f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9 URL: https://github.com/llvm/llvm-project/commit/f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9 DIFF: https://github.com/llvm/llvm-project/commit/f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9.diff

[clang] 6a67e05 - [HIP] Add __builtin_amdgcn_groupstaticsize

Author: Aaron En Ye Shi Date: 2021-05-13T15:50:08Z New Revision: 6a67e05a26eb5f58665bd6d063b9f389e7dd28a7 URL: https://github.com/llvm/llvm-project/commit/6a67e05a26eb5f58665bd6d063b9f389e7dd28a7 DIFF: https://github.com/llvm/llvm-project/commit/6a67e05a26eb5f58665bd6d063b9f389e7dd28a7.diff

[clang] a249ffa - [HIP] Clean up llvm intrinsics using __asm

Author: Aaron En Ye Shi Date: 2021-05-13T18:55:51Z New Revision: a249ffa42137431d44d7db1d04f122300bc51533 URL: https://github.com/llvm/llvm-project/commit/a249ffa42137431d44d7db1d04f122300bc51533 DIFF: https://github.com/llvm/llvm-project/commit/a249ffa42137431d44d7db1d04f122300bc51533.diff

[clang] ccb1026 - [HIP] Move std headers after device malloc/free

Author: Aaron En Ye Shi Date: 2021-07-09T21:20:16Z New Revision: ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc URL: https://github.com/llvm/llvm-project/commit/ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc DIFF: https://github.com/llvm/llvm-project/commit/ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc.diff

[clang] df59850 - [HIP] Fix rocm-detect.hip test path

Author: Aaron En Ye Shi Date: 2021-04-07T17:20:59Z New Revision: df59850038d800e8e8b062a5fc2e3d4ed624b526 URL: https://github.com/llvm/llvm-project/commit/df59850038d800e8e8b062a5fc2e3d4ed624b526 DIFF: https://github.com/llvm/llvm-project/commit/df59850038d800e8e8b062a5fc2e3d4ed624b526.diff

[clang] 9ce931b - [HIP] Fix no matching constructor for init of shared_ptr and malloc

Author: Aaron En Ye Shi Date: 2021-07-22T14:32:41Z New Revision: 9ce931bd71855ced2146f77120df07e4bf381cec URL: https://github.com/llvm/llvm-project/commit/9ce931bd71855ced2146f77120df07e4bf381cec DIFF: https://github.com/llvm/llvm-project/commit/9ce931bd71855ced2146f77120df07e4bf381cec.diff