Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-20 Thread Abe Skolnik via cfe-commits
Abe updated this revision to Diff 71953. Abe added a comment. Removed some comments that I felt were good for clarity but at least 2 people disagreed. https://reviews.llvm.org/D24481 Files: cfe/trunk/lib/Frontend/CompilerInvocation.cpp cfe/trunk/test/CodeGen/aarch64-neon-fma.c cfe/trunk/

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-20 Thread Abe Skolnik via cfe-commits
Abe added a comment. In https://reviews.llvm.org/D24481#547694, @yaxunl wrote: > Is it possible to merge > cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O[0-3]___aarch64-backend.c > as one and remove > cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O1...3___aarch64

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-20 Thread Abe Skolnik via cfe-commits
Abe updated this revision to Diff 71959. Abe added a comment. Collapsed 4 test-case files that didn`t really need to be separate into 1 file, as suggested by Yaxun Liu. https://reviews.llvm.org/D24481 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/aarch64-neon-fma.c

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-21 Thread Abe Skolnik via cfe-commits
Abe updated this revision to Diff 72103. Abe added a comment. Combined "fp-contract-pragma___on-by-default___-O0___aarch64-backend.c" and "fp-contract-pragma___on-by-default___-O1...3___aarch64-backend.c" into a single file ["fp-contract-pragma___on-by-default.c"]. https://reviews.llvm.org/D24

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-22 Thread Abe Skolnik via cfe-commits
Abe updated this revision to Diff 72186. Abe added a comment. Minor edits for style-guidelines conformance. https://reviews.llvm.org/D24481 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/aarch64-neon-fma.c clang/test/CodeGen/aarch64-scalar-fma.c clang/test/CodeGen/f

Re: [PATCH] D25254: test-suite: Change extension used for reference outputs by Makefile-based harness so we can start improving how the CMake-based harness works without breaking the old system or the

2016-10-05 Thread Abe Skolnik via cfe-commits
Can you expand on how you plan to add the second set of reference outputs? I plan to {either re-target or replace with normal files} the new symlinks in upcoming patches. The patch proposal to which you referred in the above is just "stage 1" of a large clean-up. We [Sebastian and I] have CMa