[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

alekseyshl added a comment. http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/2437 is broken by this revision. Repository: rL LLVM https://reviews.llvm.org/D29886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31399: [coroutines] Handle get_return_object_on_allocation_failure

alekseyshl added a comment. Seems like this bot is not happy about this change: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3771 Repository: rL LLVM https://reviews.llvm.org/D31399 ___ cfe-commits mailing list

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839209, @gtbercea wrote: > I have re-enabled the previous offloading tests and moved the new GPU > offloading tests to a new file which is disabled for linux (for now). > > 310718 > > Alex thanks so much for the logs, they have been

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. While I do get the time pressure and such, doing it at the expense of others is not cool. Many teams work process is broken for days, folks are busy looking into it, investigating and reverting, other breakages are masked by these failures etc. If your test depend

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > First of all, I apologize if I've upset you with my previous post. I am > actively working on understanding what is causing these issues. It is not my > intention to write tests that work on local

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after all the reverts in r310580, our tests are still failing (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7080). not surprising, but very disrupting. Please have a plan to fix it soon, otherwise I'll have to revert it even further.

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838305, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#838219, @gtbercea wrote: > > > In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > > > > > The failures were very widespread, e.g. there's a linux buildbot

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838219, @gtbercea wrote: > In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > > > The failures were very widespread, e.g. there's a linux buildbot that was > > red until the revert:

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 failed on r310718, please fix. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > failed on r310718, please fix. In https://reviews.llvm.org/D29660#839647, @gtbercea wrote: > In

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > > failed on r310718, please fix. > > > > > In

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

alekseyshl added a comment. Driver/openmp-offload.c still fails on http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7038, please fix. https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after r310505, openmp-offload.c continues to haunt our bots, for example http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. Can you please fix this test? Repository: rL LLVM https://reviews.llvm.org/D29660

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. r310519 did not fix the problem, see http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7062. I would suggest to revert and fix it properly, our bots are broken for a few days already. Repository: rL LLVM https://reviews.llvm.org/D29660

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

alekseyshl added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7010 is unhappy about this change, please fix. https://reviews.llvm.org/D34784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

alekseyshl added a comment. vectorLoadStore.cl is failing on our bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, please check it out Repository: rL LLVM https://reviews.llvm.org/D37804 ___ cfe-commits mailing

[PATCH] D38277: [compiler-rt][CMake] Fix configuration on PowerPC with sanitizers

alekseyshl added a comment. http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/4004 is broken by this change Repository: rL LLVM https://reviews.llvm.org/D38277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38277: [compiler-rt][CMake] Fix configuration on PowerPC with sanitizers

alekseyshl added inline comments. Comment at: compiler-rt/trunk/cmake/base-config-ix.cmake:154 + cmake_push_check_state() + string(REPLACE "-nodefaultlibs" "" CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS}) TEST_BIG_ENDIAN(HOST_IS_BIG_ENDIAN)

[PATCH] D38277: [compiler-rt}[CMake] Fix configuration on PowerPC with sanitizers

alekseyshl added a comment. I wonder what's the error message? Comment at: cmake/base-config-ix.cmake:153 + # will fail with this option when building with a sanitizer. + set(OLD_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS}) + string(REPLACE "-nodefaultlibs" ""

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

alekseyshl accepted this revision. alekseyshl added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528 StringRef Sanitizer) { + // Solaris ld doesn't need this. Inhibit use

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

alekseyshl added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528 StringRef Sanitizer) { + // Solaris ld doesn't need this. Inhibit use of non-existant + // --export-dynamic. Can you elaborate why

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

alekseyshl added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684 if (AddExportDynamic) -CmdArgs.push_back("-export-dynamic"); +CmdArgs.push_back("--export-dynamic"); If it does not exist on Solaris, why change it then? For the

[PATCH] D40936: Hardware-assisted AddressSanitizer (clang part).

alekseyshl accepted this revision. alekseyshl added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:47 +SANITIZER("hwaddress", HWAddress) + Why didn't we follow KASan style and name it "hw-address"? Comment at:

[PATCH] D39312: [LSan] Enable -fsanitize=leak for PPC64 Linux.

alekseyshl created this revision. . https://reviews.llvm.org/D39312 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@

[PATCH] D39312: [LSan] Enable -fsanitize=leak for PPC64 Linux.

This revision was automatically updated to reflect the committed changes. Closed by commit rL316636: [LSan] Enable -fsanitize=leak for PPC64 Linux. (authored by alekseyshl). Repository: rL LLVM https://reviews.llvm.org/D39312 Files: cfe/trunk/lib/Driver/ToolChains/Linux.cpp

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

alekseyshl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:706 // to be dynamic to be sure we export sanitizer interface functions. - if (AddExportDynamic) + if (AddExportDynamic && TC.getTriple().getVendor() != llvm::Triple::Myriad)

[PATCH] D47600: [UBSan] DO NOT COMMIT: precise UBSan checks experiment

alekseyshl created this revision. clang part of the two part patch (LLVM + clang) LLVM part: https://reviews.llvm.org/D47599 Refer to https://reviews.llvm.org/D47599 for the detailed description. Repository: rC Clang https://reviews.llvm.org/D47600 Files: include/clang/Driver/Options.td

[PATCH] D47600: [UBSan] DO NOT COMMIT: precise UBSan checks experiment

alekseyshl abandoned this revision. alekseyshl added a comment. Experimental. Repository: rC Clang https://reviews.llvm.org/D47600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

This revision was automatically updated to reflect the committed changes. Closed by commit rC324296: [Sanitizers] Basic Solaris sanitizer support (PR 33274) (authored by alekseyshl, committed by ). Repository: rC Clang https://reviews.llvm.org/D40903 Files: include/clang/Driver/ToolChain.h

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

alekseyshl added a comment. Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add test cases for Solaris to test/Driver/sanitizer-ld.c too. Repository: rC Clang https://reviews.llvm.org/D40903 ___ cfe-commits mailing

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

This revision was automatically updated to reflect the committed changes. Closed by commit rC330745: [HWASan] Update HWASan assembly snippet in the docs (authored by alekseyshl, committed by ). Changed prior to commit: https://reviews.llvm.org/D45996?vs=143671=143782#toc Repository: rL LLVM

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL330745: [HWASan] Update HWASan assembly snippet in the docs (authored by alekseyshl, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45996

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

alekseyshl created this revision. alekseyshl added a reviewer: eugenis. To complement https://reviews.llvm.org/D45840 Repository: rC Clang https://reviews.llvm.org/D45996 Files: docs/HardwareAssistedAddressSanitizerDesign.rst Index: docs/HardwareAssistedAddressSanitizerDesign.rst

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl updated this revision to Diff 139469. alekseyshl added a comment. - Add tests to verify that HWASan requires "-pie". Repository: rC Clang https://reviews.llvm.org/D44745 Files: lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Linux.cpp

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl added inline comments. Comment at: test/Driver/asan.c:12 -// RUN: %clang -O2 -target aarch64-unknown-linux -fsanitize=hwaddress %s -S -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-HWASAN -// RUN: %clang -O3 -target aarch64-unknown-linux -fsanitize=hwaddress %s

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl added inline comments. Comment at: test/Driver/asan.c:12 -// RUN: %clang -O2 -target aarch64-unknown-linux -fsanitize=hwaddress %s -S -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-HWASAN -// RUN: %clang -O3 -target aarch64-unknown-linux -fsanitize=hwaddress %s

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl updated this revision to Diff 139513. alekseyshl added a comment. - Revert triple change in asan.cc test Repository: rC Clang https://reviews.llvm.org/D44745 Files: lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Linux.cpp

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl created this revision. alekseyshl added a reviewer: eugenis. Herald added a subscriber: cryptoad. Porting HWASan to Linux x86-64, the third of the three patches, clang part. Repository: rC Clang https://reviews.llvm.org/D44745 Files: lib/Driver/SanitizerArgs.cpp

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC328361: [HWASan] Port HWASan to Linux x86-64 (clang) (authored by alekseyshl, committed by ). Changed prior to commit: https://reviews.llvm.org/D44745?vs=139513=139640#toc Repository: rC Clang