Author: abataev
Date: Tue Aug 18 01:47:21 2015
New Revision: 245268
URL: http://llvm.org/viewvc/llvm-project?rev=245268view=rev
Log:
[OPENMP 4.1] Allow variables with reference types in private clauses.
OpenMP 4.1 allows to use variables with reference types in all private clauses
(private,
ABataev created this revision.
ABataev added reviewers: hans, fraggamuffin, ejstotzer, hfinkel.
ABataev added a subscriber: cfe-commits.
http://reviews.llvm.org/D12152
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
ABataev created this revision.
ABataev added reviewers: echristo, rjmccall, rsmith.
ABataev added a subscriber: cfe-commits.
When variables are implicitly captured in lambdas, debug info generated for
captured variables points to location where they are used first. This patch
makes debug info
Author: abataev
Date: Tue Aug 18 23:49:01 2015
New Revision: 245414
URL: http://llvm.org/viewvc/llvm-project?rev=245414view=rev
Log:
[OPENMP] Link libomp.lib on Windows
Adds libomp.lib for -fopenmp=libomp and libiomp5md.lib for -fopenmp=libiomp5 on
Windows
Differential Revision:
Author: abataev
Date: Fri Aug 21 06:32:42 2015
New Revision: 245693
URL: http://llvm.org/viewvc/llvm-project?rev=245693view=rev
Log:
[OPENMP 4.1] Add ast-print tests for 'val', 'uval' and 'ref' modifiers.
Modified:
cfe/trunk/test/OpenMP/simd_ast_print.cpp
Modified:
Author: abataev
Date: Fri Aug 21 06:14:16 2015
New Revision: 245692
URL: http://llvm.org/viewvc/llvm-project?rev=245692view=rev
Log:
[OPENMP 4.1] Initial support for 'simdlen' clause.
Add parsing/sema analysis for 'simdlen' clause in simd directives. Also add
check that if both 'safelen' and
ABataev marked 15 inline comments as done.
ABataev added a comment.
Richard, thanks for the review!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680
@@ +7679,3 @@
+def err_omp_section_length_undefined : Error
+ section length is unspecified, but subscripted value is
ABataev updated this revision to Diff 32974.
ABataev marked 10 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D10732
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
ABataev updated this revision to Diff 32790.
ABataev added a comment.
Update after review from Kelvin
http://reviews.llvm.org/D12152
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs/UsersManual.rst
+++
Author: abataev
Date: Fri Aug 21 01:41:23 2015
New Revision: 245674
URL: http://llvm.org/viewvc/llvm-project?rev=245674view=rev
Log:
[OPENMP 4.1] Improved codegen for 'uval' qualifier of 'linear' clause.
According to standard the 'uval' modifier declares the address of the original
list item to
Author: abataev
Date: Thu Aug 20 07:15:57 2015
New Revision: 245556
URL: http://llvm.org/viewvc/llvm-project?rev=245556view=rev
Log:
[OPENMP 4.1] Allow to use 'uval' and 'ref' modifiers for reference types only.
Standard allows to use 'uval' and 'ref' modifiers in 'linear' clause for
variables
Author: abataev
Date: Thu Aug 20 05:54:39 2015
New Revision: 245550
URL: http://llvm.org/viewvc/llvm-project?rev=245550view=rev
Log:
[OPENMP 4.1] Initial support for modifiers in 'linear' clause.
OpenMP 4.1 adds 3 optional modifiers to 'linear' clause.
Format of 'linear' clause has changed to:
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2887
@@ +2886,3 @@
+llvm::Value *
+CGOpenMPRuntime::emitTargetOutlinedFunction(CodeGenFunction CGF,
+const OMPExecutableDirective D,
I don't
ABataev added a comment.
Another one thing I forget to mention. Current implementation of
CGOpenMPRuntime is libomp-specific. You're trying to add functionality that is
libtarget-specific. Maybe it is a good idea to separate support for libomp and
libtarget runtime libraries?
ABataev added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1969
@@ -1945,3 +1968,3 @@
else
- return EmitCapturedFieldLValue(*this, CapturedStmtInfo-lookup(VD),
- CapturedStmtInfo-getContextValue());
+
Author: abataev
Date: Mon Aug 24 00:31:10 2015
New Revision: 245823
URL: http://llvm.org/viewvc/llvm-project?rev=245823view=rev
Log:
[OPENMP] Info about OpenMP Support in Users Manual, NFC.
Differential Revision: http://reviews.llvm.org/D12152
Modified:
cfe/trunk/docs/UsersManual.rst
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245823: [OPENMP] Info about OpenMP Support in Users Manual,
NFC. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D12152?vs=32790id=32933#toc
Repository:
rL LLVM
ABataev updated this revision to Diff 32653.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D12152
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs/UsersManual.rst
+++
ABataev created this revision.
ABataev added reviewers: chandlerc, rsmith.
ABataev added a subscriber: cfe-commits.
Adds libomp.lib for -fopenmp=libomp and libiomp5md.lib for -fopenmp=libiomp5 on
Windows
http://reviews.llvm.org/D11932
Files:
lib/Driver/Tools.cpp
test/OpenMP/linking.c
ABataev updated this revision to Diff 31792.
ABataev added a comment.
Test fix
http://reviews.llvm.org/D11932
Files:
lib/Driver/Tools.cpp
test/OpenMP/linking.c
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244428: [MSVC] Crash fix: assigning of overloaded member
function pointer caused… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11828?vs=31631id=31632#toc
Repository:
rL
Author: abataev
Date: Fri Aug 14 07:25:37 2015
New Revision: 245041
URL: http://llvm.org/viewvc/llvm-project?rev=245041view=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender 2.75.
blender uses statements expression in condition of the loop under control of
the
Author: abataev
Date: Tue Aug 25 09:24:04 2015
New Revision: 245937
URL: http://llvm.org/viewvc/llvm-project?rev=245937view=rev
Log:
[OPENMP 4.0] Initial support for array sections.
Adds parsing/sema analysis/serialization/deserialization for array sections in
OpenMP constructs (introduced in
Author: abataev
Date: Tue Aug 25 10:15:12 2015
New Revision: 245939
URL: http://llvm.org/viewvc/llvm-project?rev=245939view=rev
Log:
Fix possible crash on null base or type for array elements.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/OpenMP/task_depend_messages.cpp
ABataev updated this revision to Diff 38232.
ABataev marked 4 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13336
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
ABataev added reviewers: hans, tstellarAMD.
ABataev updated this revision to Diff 38374.
ABataev marked an inline comment as done.
http://reviews.llvm.org/D13802
Files:
autoconf/configure.ac
configure
docs/GettingStarted.rst
docs/ReleaseProcess.rst
utils/release/test-release.sh
Index:
ABataev marked an inline comment as done.
ABataev added a comment.
Hi Chandler, thanks for the review.
In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
> Some minor issues below. Also, Hans and Tom should have a glance at the
> release bits of this, I don't know any of that stuff.
>
ABataev added a comment.
In http://reviews.llvm.org/D13802#276755, @hfinkel wrote:
> In http://reviews.llvm.org/D13802#275471, @chandlerc wrote:
>
> > In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
> >
> > > Hi Chandler, thanks for the review.
> > >
> > > In
ABataev added a comment.
In http://reviews.llvm.org/D13802#277270, @jhowarth wrote:
> The proposed patches here to change the default behavior of -fopenmp from
> -fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based
> build. The following change required to switch over
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2628
@@ +2627,3 @@
+ friend class OMPClauseWriter;
+ friend class Sema;
+
I don't like the idea of friend Sema. If Sema needs some interfaces, they must
be public.
ABataev updated this revision to Diff 40253.
ABataev marked 3 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13336
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
ABataev updated this revision to Diff 40255.
ABataev marked 4 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
ABataev updated this revision to Diff 40262.
ABataev marked 2 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2660-2662
@@ +2659,5 @@
+ ///
+ /// \param StartLoc Starting location of the clause.
+ /// \param EndLoc Ending location of the clause.
+ /// \param N Number of the variables in the clause.
+ ///
Author: abataev
Date: Mon Oct 19 01:40:17 2015
New Revision: 250684
URL: http://llvm.org/viewvc/llvm-project?rev=250684=rev
Log:
[OPENMP] Fix for http://llvm.org/PR25221: Infinite loop while parsing OpenMP
directive
Clang skipped annot_pragma_openmp token, while it should be considered as a
ABataev added reviewers: rjmccall, dblaikie.
ABataev updated this revision to Diff 37476.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13582
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprAgg.cpp
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/CGExprComplex.cpp
Author: abataev
Date: Tue Oct 13 23:05:42 2015
New Revision: 250265
URL: http://llvm.org/viewvc/llvm-project?rev=250265=rev
Log:
[MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double
invocations of foo() when compiling foo()->propertyName
Removes extra codegen for base expression
ABataev added a comment.
I see, no problems, thanks!
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
Intel Corp.
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev added a comment.
In http://reviews.llvm.org/D13336#257628, @rnk wrote:
> I think fundamentally we are doing too much declspec property lowering in
> Sema. We might want to back up and figure out how to do it in IRGen. Right
> now we have bugs like this, which are probably more
ABataev updated this revision to Diff 37321.
ABataev marked 16 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
ABataev marked 40 inline comments as done.
ABataev added a comment.
Richard, thanks for the review! Tried to fix all your comments.
Comment at: include/clang/AST/DeclOpenMP.h:95
@@ +94,3 @@
+/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in)
+///
ABataev created this revision.
ABataev added a reviewer: aaron.ballman.
ABataev added a subscriber: cfe-commits.
Automatically insert line feed after pretty printing of all pragma-like
attributes.
http://reviews.llvm.org/D13546
Files:
include/clang/Basic/Attr.td
Author: abataev
Date: Thu Oct 8 04:10:53 2015
New Revision: 249672
URL: http://llvm.org/viewvc/llvm-project?rev=249672=rev
Log:
[OPENMP 4.1] Codegen for array sections/subscripts in 'reduction' clause.
OpenMP 4.1 adds support for array sections/subscripts in 'reduction' clause.
Patch adds
ABataev created this revision.
ABataev added a reviewer: chandlerc.
ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits,
llvm-commits.
Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots.
http://reviews.llvm.org/D13802
Files:
configure
ABataev created this revision.
ABataev added a reviewer: chandlerc.
ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits.
Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots.
http://reviews.llvm.org/D13803
Files:
CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250795: [DEBUG INFO] Emit debug info for type used in
explicit cast only. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13582?vs=37476=37825#toc
Repository:
rL LLVM
ABataev updated this revision to Diff 37854.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13336
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Serialization/ASTBitCodes.h
lib/AST/ASTContext.cpp
lib/AST/Type.cpp
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962
@@ +1961,3 @@
+[LineNum][ColNum];
+assert(Entry.Order != -1u && "Entry not initialized!");
+assert(!Entry.Addr && !Entry.ID && "Entry registered
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250017: [ATTR] Automatic line feed after pragma-like
attribute. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13546?vs=36924=37080#toc
Repository:
rL LLVM
Author: abataev
Date: Mon Oct 12 01:59:48 2015
New Revision: 250017
URL: http://llvm.org/viewvc/llvm-project?rev=250017=rev
Log:
[ATTR] Automatic line feed after pragma-like attribute.
Automatically insert line feed after pretty printing of all pragma-like
attributes + fix printing of
Author: abataev
Date: Wed Oct 7 05:22:08 2015
New Revision: 249534
URL: http://llvm.org/viewvc/llvm-project?rev=249534=rev
Log:
Fix crash in codegen on casting to `bool &`.
Currently codegen crashes trying to emit casting to bool &. It happens because
bool type is converted to i1 and later then
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249534: Fix crash in codegen on casting to `bool &`.
(authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13325?vs=36179=36725#toc
Repository:
rL LLVM
ABataev updated this revision to Diff 37218.
ABataev marked 3 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
ABataev marked 3 inline comments as done.
Comment at: include/clang/Basic/Attr.td:2098-2102
@@ +2097,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream , const PrintingPolicy ) const {
+OS << "\n";
+ }
+ }];
ABataev updated this revision to Diff 33181.
ABataev marked 7 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
ABataev marked 7 inline comments as done.
ABataev added a comment.
Richard, thanks for the review!
Comment at: include/clang/Basic/Attr.td:2074-2078
@@ +2073,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream
Author: abataev
Date: Mon Aug 31 02:32:19 2015
New Revision: 246422
URL: http://llvm.org/viewvc/llvm-project?rev=246422=rev
Log:
[OPENMP 4.0] Codegen for array sections.
Added codegen for array section in 'depend' clause of 'task' directive. It
emits to pointers, one for the begin of array
ABataev added a comment.
Seems good to me, but it would be good if John McCall could look at the patch.
http://reviews.llvm.org/D11361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Fri Sep 4 06:26:21 2015
New Revision: 246846
URL: http://llvm.org/viewvc/llvm-project?rev=246846=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24674: assertion failed and and abort trap
Fix processing of shared variables with reference types in OpenMP constructs.
Previously,
ABataev added a comment.
LG
http://reviews.llvm.org/D11619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Thu Sep 3 03:45:56 2015
New Revision: 246748
URL: http://llvm.org/viewvc/llvm-project?rev=246748=rev
Log:
[OPENMP 4.1] Codegen for extended format of 'if' clause.
Fixed codegen for extended format of 'if' clauses with special
'directive-name-modifier' + ast-print tests for
Author: abataev
Date: Thu Sep 3 02:23:48 2015
New Revision: 246747
URL: http://llvm.org/viewvc/llvm-project?rev=246747=rev
Log:
[OPENMP 4.1] Parsing/sema analysis for extended format of 'if' clause.
OpenMP 4.1 added special 'directive-name-modifier' to the 'if' clause.
Format of 'if' clause is
ABataev added a comment.
LGTM
http://reviews.llvm.org/D12262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246835: [X86-64] Allow additional register names in inline
assembler. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D12594?vs=33926=34011#toc
Repository:
rL LLVM
ABataev added a subscriber: ABataev.
ABataev added a comment.
Yes, I know. Fixing it right now. Will be fixed in few minutes, thanks.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
10.09.2015 11:46, NAKAMURA Takumi пишет:
> chapuni added subscribers:
Author: abataev
Date: Thu Sep 10 04:06:59 2015
New Revision: 247255
URL: http://llvm.org/viewvc/llvm-project?rev=247255=rev
Log:
[OPENMP] Fix test incompatibility with 32-bit platforms
Modified:
cfe/trunk/test/OpenMP/parallel_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_codegen.cpp
Author: abataev
Date: Thu Sep 10 04:48:30 2015
New Revision: 247260
URL: http://llvm.org/viewvc/llvm-project?rev=247260=rev
Log:
[OPENMP] Propagate alignment from original variables to the private copies.
Currently private copies of captured variables have default alignment. Patch
makes private
Author: abataev
Date: Thu Sep 10 07:06:58 2015
New Revision: 247273
URL: http://llvm.org/viewvc/llvm-project?rev=247273=rev
Log:
[OPENMP] Generate threadprivates as TLS variables by default.
If target supports TLS all threadprivates are generated as TLS. If target does
not support TLS, use
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
Author: abataev
Date: Fri Sep 11 05:29:41 2015
New Revision: 247401
URL: http://llvm.org/viewvc/llvm-project?rev=247401=rev
Log:
[OPENMP] Preserve alignment of the original variables for the captured
references.
Patch makes codegen to preserve alignment of the shared variables captured and
used
ABataev added a comment.
Richard?
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Tue Sep 15 12:23:56 2015
New Revision: 247706
URL: http://llvm.org/viewvc/llvm-project?rev=247706=rev
Log:
[OPENMP] Emit an additional note during analysis of 'if' clause.
Patch adds emission of additional note for 'if' clauses with name modifiers in
case if 'if' clause
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
Author: abataev
Date: Wed Sep 30 04:22:36 2015
New Revision: 248880
URL: http://llvm.org/viewvc/llvm-project?rev=248880=rev
Log:
[OPENMP 4.1] Sema analysis for array sections in 'reduction' clause.
OpenMP 4.1 allows to use array sections|subscript expressions in 'reduction'
clauses. Added sema
ABataev created this revision.
ABataev added a reviewer: rjmccall.
ABataev added a subscriber: cfe-commits.
Currently codegen crashes trying to emit casting to `bool &`. It happens
because `bool` type is converted to `i1` and later then lvalue for reference is
converted to `i1*`. But when
ABataev created this revision.
ABataev added a reviewer: rnk.
ABataev added a subscriber: cfe-commits.
MSVC supports 'property' attribute and allows to apply it to the declaration of
an empty array in a class or structure definition.
For example:
```
__declspec(property(get=GetX, put=PutX)) int
ABataev created this revision.
ABataev added a reviewer: rnk.
ABataev added a subscriber: cfe-commits.
Removes extra codegen for base expression of MS property call
http://reviews.llvm.org/D13375
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
Index:
Author: abataev
Date: Mon Sep 28 01:39:35 2015
New Revision: 248696
URL: http://llvm.org/viewvc/llvm-project?rev=248696=rev
Log:
[OPENMP 4.1] Add 'simd' clause for 'ordered' directive.
Parsing and sema analysis for 'simd' clause in 'ordered' directive.
Description
If the simd clause is specified,
Author: abataev
Date: Fri Sep 18 03:07:34 2015
New Revision: 247976
URL: http://llvm.org/viewvc/llvm-project?rev=247976=rev
Log:
[OPENMP 4.0] Add 'if' clause for 'cancel' directive.
Add parsing, sema analysis and codegen for 'if' clause in 'cancel' directive.
Added:
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev created this revision.
ABataev added a reviewer: chandlerc.
ABataev added a subscriber: cfe-commits.
If stdout is used as an output file for several outputs (like dep file, output
file, etc.) , it causes a crash in llvm::raw_fd_ostream::~raw_fd_ostream(),
when destructor tries to close
ABataev added a comment.
In http://reviews.llvm.org/D13128#252630, @yaron.keren wrote:
> When stdout goes elsewhere the console, the shell creates the the output file
> (pipe) and will close it when clang terminates so so why clang should close
> it at all ? it did not open it.
>
>
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+Sizes.push_back(Size);
+MapTypes.push_back(MapType);
+ }
+
+ // Keep track on whether the host function has to be executed.
+ auto OffloadErrorQType =
+
ABataev updated the summary for this revision.
ABataev updated this revision to Diff 35698.
ABataev added a comment.
Reworked patch after some discussion
http://reviews.llvm.org/D13128
Files:
lib/Support/raw_ostream.cpp
test/Other/empty.ll
Index: lib/Support/raw_ostream.cpp
Author: abataev
Date: Fri Sep 25 05:37:12 2015
New Revision: 248569
URL: http://llvm.org/viewvc/llvm-project?rev=248569=rev
Log:
[OPENMP 4.1] Add 'threads' clause for '#pragma omp ordered'.
OpenMP 4.1 extends format of '#pragma omp ordered'. It adds 3 additional
clauses: 'threads', 'simd' and
ABataev added a comment.
I think we'd better to try to use attributes for declare target. I think it
will be much easier and correct solution rather than adding a new declaration
Comment at: include/clang/AST/DeclBase.h:164
@@ -163,3 +163,3 @@
/// has been declared
ABataev added a comment.
Michael, please provide full diff log, as described in
http://llvm.org/docs/Phabricator.html (with full context)
Repository:
rL LLVM
http://reviews.llvm.org/D15321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev updated this revision to Diff 42140.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15174
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
test/SemaCXX/ms-property-error.cpp
test/SemaCXX/ms-property.cpp
Index:
Author: abataev
Date: Tue Dec 8 06:06:20 2015
New Revision: 255008
URL: http://llvm.org/viewvc/llvm-project?rev=255008=rev
Log:
[OPENMP 4.5] Parsing/sema for 'num_tasks' clause.
OpenMP 4.5 adds directives 'taskloop' and 'taskloop simd'. These directives
support clause 'num_tasks'. Patch adds
ABataev created this revision.
ABataev added reviewers: rnk, rjmccall.
ABataev added a subscriber: cfe-commits.
All problems described in http://llvm.org/PR25636 are implemented except for
return value of the 'put' property. This patch fixes this problem with the
indexed properties
John,
the result is always the result of Put operation. For pre-increment we
have to return new value, for the post-increment - previous value
returned by Get (checked it on MSVC).
So, currently postincrement works correctly, pre-increment and
assignment not. For pre-increment and assignment we
ABataev added inline comments.
Comment at: include/clang-c/Index.h:2263-2267
@@ -2262,3 +2262,7 @@
- CXCursor_LastStmt = CXCursor_OMPTaskLoopDirective,
+ /** \brief OpenMP distribute directive.
+ */
+ CXCursor_OMPDistributeDirective= 259,
+
+
John,
Actually both, subscripts and references.
Ok, got will do.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
04.12.2015 12:00, John McCall пишет:
> rjmccall added a comment.
>
> In http://reviews.llvm.org/D15174#302248, @ABataev wrote:
>
>> John,
>> the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254596: PR25575: Make GCC 4.4+ comatible layout for packed
bit-fileds of char type… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D14872?vs=41648=41724#toc
Repository:
rL
Author: abataev
Date: Thu Dec 3 03:34:49 2015
New Revision: 254596
URL: http://llvm.org/viewvc/llvm-project?rev=254596=rev
Log:
PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type,
patch by D. Polukhin
This CL is for discussion how to better fix bit-filed layout
ABataev updated this revision to Diff 41848.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15174
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
test/SemaCXX/ms-property-error.cpp
test/SemaCXX/ms-property.cpp
Index:
ABataev updated this revision to Diff 42026.
ABataev marked 2 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15174
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
test/SemaCXX/ms-property-error.cpp
ABataev added a comment.
Tests?
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
John,
Your example won't be compiled at all. Clang and MSVC emit error
messages in this case.
The next code
struct A {
__declspec(property(get=GetX,put=SetX)) int x;
int GetX() const { return 0; }
void SetX(long y) {}
};
a.x = 5;
compiled fine by MSVC and clang and provides
1 - 100 of 1593 matches
Mail list logo
