balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When a CXXRecordDecl under ClassTemplateDecl is imported, check
the templated record decl for similarity instead of the template.
Repository:
rC Clang
balazske added a comment.
Problem: This change interferes with https://reviews.llvm.org/D47445. Probably
that should be committed, it is approved already.
Repository:
rC Clang
https://reviews.llvm.org/D47946
___
cfe-commits mailing list
balazske added a comment.
I want this change to be committed by somebody. I have no commit right.
Repository:
rC Clang
https://reviews.llvm.org/D47445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
balazske added a comment.
The new `ASTUnit::beginSourceFile` is only there to simplify the code. It is
possible to get `Ctx`, `PP` and `getDiagnostic()` from outside of `ASTUnit` and
call the same thing, but requires more code to write. Probably a more smart
place to call `BeginSourceFile` can
balazske added a comment.
If `BeginSourceFile` is not called on the diagnostic client object, it is not
possible to have compiler warnings or errors that come from the "To" context
while importing something (there is some assertion if a source file related
warning is to be emitted but no
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:88
+ llvm::SmallVector getCanonicalForwardRedeclChain(Decl* D) {
+// Currently only FunctionDecl is supported
+auto FD = cast(D);
Assert for FunctionDecl?
Comment at:
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: a.sidorin.
When running the ASTTests test, warnings produced by the compiler can be
distracting when looking for test errors. A part of the warnings is
balazske added a comment.
Original idea was to not modify the test code to keep it as simple as possible.
If you like it better I will change the test code.
Repository:
rC Clang
https://reviews.llvm.org/D47459
___
cfe-commits mailing list
balazske updated this revision to Diff 149079.
balazske added a comment.
[ASTImporter] Fixed test code in ASTImporter tests.
Test code is fixed instead of turn off the warnings.
For this to work change of match expressions was needed.
Repository:
rC Clang
https://reviews.llvm.org/D47459
balazske added a comment.
From API point of view if there is a `enableSourceFileDiagnostics` there should
be a `disableSourceFileDiagnostics` too (that calls the `EndSourceFile`). But I
am not sure how and if to use it at all. In the unit tests it is not needed,
the ASTUnit contains a single
balazske updated this revision to Diff 149412.
balazske added a comment.
- Added comment, renamed beginSourceFile, removed check for PP.
Check for PP is removed because it is allowed to be nullptr.
Repository:
rC Clang
https://reviews.llvm.org/D47445
Files:
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
At import of a record describing a template set its type to
InjectedClassNameType (instead of RecordType).
Repository:
rC Clang
https://reviews.llvm.org/D47450
Files:
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2139
+ CXXRecordDecl *Injected = nullptr;
+ for (NamedDecl *Found : D2CXX->noload_lookup(Name)) {
+auto *Record = dyn_cast(Found);
r.stahl wrote:
> The only thing
balazske added a comment.
Yes, I have no commit permissions.
Repository:
rC Clang
https://reviews.llvm.org/D47313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
balazske requested review of this revision.
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2131
D2CXX->setDescribedClassTemplate(ToDescribed);
+if (!DCXX->isInjectedClassName()) {
+ // In a record describing a template the type
balazske accepted this revision.
balazske added a comment.
This revision is now accepted and ready to land.
Found no big problems. But not all extra options are applicable to all
languages (template related things to C) so there may be redundant tests.
Repository:
rC Clang
balazske added inline comments.
Comment at: test/ASTMerge/injected-class-name-decl-1/Inputs/inject1.cpp:16
+} // namespace google
+namespace a {
+template class g;
a.sidorin wrote:
> This looks like raw creduce output. Is there a way to simplify this or make
>
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
ASTImporter tests may produce source file related warnings, the diagnostic
client should be in correct state to handle it. Added 'beginSourceFile' to set
the client state.
balazske updated this revision to Diff 152632.
balazske added a comment.
[ASTImporter] Fixed test code in ASTImporter tests.
Reformatted some test code, changed to use isDescendant.
Repository:
rC Clang
https://reviews.llvm.org/D47459
Files:
unittests/AST/ASTImporterTest.cpp
Index:
balazske marked 2 inline comments as done.
balazske added a comment.
Some of the source code was reformatted for more consistency. At least a part
of the code is now better formatted.
Repository:
rC Clang
https://reviews.llvm.org/D47459
___
balazske updated this revision to Diff 152634.
balazske added a comment.
Small fixes.
Repository:
rC Clang
https://reviews.llvm.org/D47450
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/injected-class-name-decl/Inputs/inject1.cpp
test/ASTMerge/injected-class-name-decl/Inputs/inject2.cpp
balazske created this revision.
Herald added a subscriber: cfe-commits.
Added structural equivalence check for C++ methods.
Improved structural equivalence tests.
Added related ASTImporter tests.
Repository:
rC Clang
https://reviews.llvm.org/D48628
Files:
balazske updated this revision to Diff 153015.
balazske added a comment.
Rebase to newest master.
Repository:
rC Clang
https://reviews.llvm.org/D47459
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D48631
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/std-initializer-list/Inputs/il.cpp
balazske added a comment.
Originally this change was made after the patch in
https://reviews.llvm.org/D47632 was done. It is here back-ported to the state
before it. I like the idea of integrating this change into
https://reviews.llvm.org/D47632. (This is a new functionality: Attributes are
balazske added inline comments.
Comment at: lib/AST/ASTStructuralEquivalence.cpp:958
+ if (D1->isTemplated() != D2->isTemplated())
+return false;
a_sidorin wrote:
> I think we can move the changes for both RecordDecl and FunctionDecl into
> `Finish()`
balazske updated this revision to Diff 159458.
balazske marked an inline comment as done.
balazske added a comment.
- Renamed methods, simplified code, comments updated.
Repository:
rC Clang
https://reviews.llvm.org/D49223
Files:
include/clang/AST/ASTStructuralEquivalence.h
balazske updated this revision to Diff 159659.
balazske added a comment.
- Added common getFieldIndex.
- Corrected test ImportUnnamedFieldsInCorrectOrder.
Repository:
rC Clang
https://reviews.llvm.org/D49796
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339226: [ASTImporter] Load external Decls when getting field
index. (authored by balazske, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49796
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339256: [AST] Check described template at structural
equivalence check. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49223?vs=159458=159725#toc
Repository:
balazske updated this revision to Diff 160972.
balazske added a comment.
- Renamed variables, corrected a variable type.
Repository:
rC Clang
https://reviews.llvm.org/D49798
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske updated this revision to Diff 160548.
balazske added a comment.
- Corrected the code in tests.
Repository:
rC Clang
https://reviews.llvm.org/D49798
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske updated this revision to Diff 159467.
balazske added a comment.
- Added common getFieldIndex.
Repository:
rC Clang
https://reviews.llvm.org/D49796
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
test/ASTMerge/unnamed_fields/Inputs/il.cpp
balazske updated this revision to Diff 159279.
balazske added a comment.
- Rebase, common checks at ASTStructuralEquivalenceContext
Repository:
rC Clang
https://reviews.llvm.org/D49223
Files:
include/clang/AST/ASTStructuralEquivalence.h
lib/AST/ASTStructuralEquivalence.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339560: [ASTImporter] Improved import of friend templates.
(authored by balazske, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50516
Files:
balazske updated this revision to Diff 160335.
balazske added a comment.
- replaced ASSERT in test
Repository:
rC Clang
https://reviews.llvm.org/D50516
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When importing a friend class template declaration,
this declaration should not be merged with any other existing declaration
for the same type. Otherwise the getFriendDecl of the
balazske added a comment.
This change is in conflict with our similar patch to introduce error handling
in `ASTImporter`. That patch would be a much bigger one, because (almost) every
import can fail, return of every `Import` (not only Decl) is changed from `X`
to `Expected`. After every
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340277: [ASTImporter] Adding some friend function related
unittests. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49798?vs=160972=161715#toc
Repository:
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:6741
+
+ auto *Ctor = dyn_cast(Importer.Import(
+ E->getConstructor()));
a_sidorin wrote:
> cast_or_null?
dyn_cast_or_null: Import may return nullptr, but if not, the cast should
succeed
balazske added inline comments.
Comment at: lib/AST/ASTStructuralEquivalence.cpp:913
- if (D1->isAnonymousStructOrUnion() && D2->isAnonymousStructOrUnion()) {
+ if (!D1->getDeclName() && !D2->getDeclName()) {
// If both anonymous structs/unions are in a record context,
balazske updated this revision to Diff 155625.
balazske added a comment.
- Small style and comment changes.
Repository:
rC Clang
https://reviews.llvm.org/D49245
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2715
+if (auto *ToFT = dyn_cast(Importer.Import(FromFT)))
+ ToFunction->setDescribedFunctionTemplate(ToFT);
+else
a_sidorin wrote:
> The function template should be already set
balazske updated this revision to Diff 155630.
balazske added a comment.
- Removed setDescribedFunctionTemplate call.
Repository:
rC Clang
https://reviews.llvm.org/D49235
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:615
+ ASSERT_TRUE(R0);
+ ASSERT_TRUE(R1);
+ ASSERT_NE(R0, R1);
These asserts can be removed too.
Repository:
rC Clang
https://reviews.llvm.org/D49296
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337162: [ASTImporter] Import implicit methods of existing
class. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49245?vs=155625=155648#toc
Repository:
rC
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337898: [ASTImporter] Add support for import of
CXXInheritedCtorInitExpr. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49293?vs=155838=157212#toc
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
At equality check of fields without name the index of fields is compared.
At determining the index of a field all fields of the parent context
should be loaded from external source
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D49798
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
balazske updated this revision to Diff 155838.
balazske added a comment.
- Using cast_or_null
Repository:
rC Clang
https://reviews.llvm.org/D49293
Files:
lib/AST/ASTImporter.cpp
test/Import/inherited-ctor-init-expr/Inputs/A.cpp
test/Import/inherited-ctor-init-expr/test.cpp
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337260: [ASTImporter] Import described template (if any) of
function. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49235?vs=155630=155832#toc
Repository:
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+ auto t = makeNamedDecls(
a_sidorin wrote:
> Could you add a
balazske updated this revision to Diff 154175.
balazske added a comment.
- Added comment into test StructuralEquivalenceRecordTest.DISABLED_Methods.
Repository:
rC Clang
https://reviews.llvm.org/D48628
Files:
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
balazske updated this revision to Diff 154073.
balazske added a comment.
- Updates according to review comments
Repository:
rC Clang
https://reviews.llvm.org/D48628
Files:
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
unittests/AST/ASTImporterTest.cpp
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2454
+ if (IsStructuralMatch(D, FoundFunction)) {
+const FunctionDecl *Definition = nullptr;
+if (D->doesThisDeclarationHaveABody() &&
This change with
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336776: [AST] Structural equivalence of methods (authored by
balazske, committed by ).
Herald added a subscriber:
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D49293
Files:
lib/AST/ASTImporter.cpp
test/Import/inherited-ctor-init-expr/Inputs/A.cpp
balazske created this revision.
Herald added a subscriber: cfe-commits.
When checking a class or function the described class or function template
is checked too.
Improved test with symmetric check, added new tests.
Repository:
rC Clang
https://reviews.llvm.org/D49223
Files:
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When a function is imported, check if it has a described template.
The name lookup is corrected to find the templated entity in this case.
The described template of the function is
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: a.sidorin.
When an already existing class is encountered during import,
check if it has implicit methods that are missing in the existing one,
and import
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:6905
Decl *ToD = Pos->second;
+// FIXME: remove this call from this function
ASTNodeImporter(*this).ImportDefinitionIfNeeded(FromD, ToD);
I think this comment is not needed (or
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+ auto t = makeNamedDecls(
a_sidorin wrote:
> balazske wrote:
>
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2085
}
+ } else {
+if (!IsStructuralMatch(D, FoundRecord, false))
martong wrote:
> a_sidorin wrote:
> > Is it possible to use the added code for the entire
balazske added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:1534
+}
+TEST_P(ASTImporterTestBase, ImportSourceLocs) {
+ Decl *FromTU = getTuDecl(
This test causes every case for expansion (macro, macro arg) to be executed at
import?
balazske added inline comments.
Comment at: lib/AST/ASTStructuralEquivalence.cpp:873
+
+ if (auto *Constructor1 = dyn_cast(Method1)) {
+if (auto *Constructor2 = dyn_cast(Method2)) {
a.sidorin wrote:
> ```if (Method1->getStmtKind() != Method2->getStmtKind())
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When a Decl is imported over an already existing similar one,
the isUsed flag is updated if it is set in the imported Decl.
This can happen if the Decl is used somewhere in the
balazske marked 9 inline comments as done.
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2683
+continue;
+ } else if (isa(Found))
+continue;
a_sidorin wrote:
> Same here.
I do not know exactly why this was made, it
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:8197
-void ASTImporter::ImportDefinition(Decl *From) {
+Error ASTImporter::ImportDefinition_New(Decl *From) {
Decl *To = Import(From);
a_sidorin wrote:
> ImportDefinitionOrError?
The
balazske added a comment.
In the current version all clang tests do pass and most of the LLDB tests. Some
LLDB tests do not work on my machine, the problems exist on master too.
This code is still a temporary version (possible to commit now or wait until
every change is made?). Later the
balazske added a comment.
To the reviewers: Please accept this patch formally if you do not find any
problems. This is an intermediate state of the code and there is more work that
is dependent on this change.
Repository:
rC Clang
https://reviews.llvm.org/D51633
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:7716
}
}
This can be simplified by removing brace characters and removing `ToD`.
Repository:
rC Clang
https://reviews.llvm.org/D53755
balazske created this revision.
Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D53757
Files:
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
balazske updated this revision to Diff 171292.
balazske added a comment.
- Added missing Import_New with Selector and DeclarationName.
Repository:
rC Clang
https://reviews.llvm.org/D53751
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
balazske created this revision.
Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp.
Herald added a reviewer: a.sidorin.
These Import_New functions should be used in the ASTImporter,
and the old Import functions should not be used. Later the
Import_New should be renamed to Import
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5054
+if (!ToTemplated->getPreviousDecl()) {
+ auto *PrevTemplated =
FoundByLookup->getTemplatedDecl()->getMostRecentDecl();
+ if (ToTemplated != PrevTemplated)
This is a long
balazske created this revision.
Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
balazske added a comment.
The Import functions are replaced by Import_New and error handling is added.
This is done in the implementation of the Import_New functions itself, and in
importInto. (Code of old Import functions is moved to the Import_New and
updated to use Import_New.) Some other
balazske updated this revision to Diff 171278.
balazske added a comment.
- Corrected Import_New(const Attr *)
Repository:
rC Clang
https://reviews.llvm.org/D53751
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
balazske updated this revision to Diff 174168.
balazske added a comment.
- Small style corrections.
Repository:
rC Clang
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
balazske added inline comments.
Comment at: include/clang/AST/ASTImporter.h:192
///
-/// \returns the equivalent declaration in the "to" context, or a NULL type
-/// if an error occurred.
+/// \returns The equivalent declaration in the "to" context, or the
balazske marked 3 inline comments as done.
balazske added a comment.
If we change signature of `Import` now, other parts of the code (in clang and
LLDB) would not compile (without changing to use the new kind of Import). If
there is a `Import_New` the old code can still compile and can be
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:194
+ // FIXME: This should be the final code.
+ //auto ToOrErr = Importer.Import(From);
+ //if (ToOrErr) {
a_sidorin wrote:
> Do I understand correctly that we have to use the
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:3046
+if (!D->doesThisDeclarationHaveABody())
+ return cast(const_cast(FoundByLookup));
+else {
The `cast` should not be needed here (and is not done at the other return
balazske updated this revision to Diff 182866.
balazske added a comment.
- Small style corrections.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53818/new/
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
balazske added a comment.
So the problem is that there are references to `ParmVarDecl` from inside
function body and at import of `ParmVarDecl` always a new one is created even
if there is an already existing (in the existing function prototype)? Maybe it
works in `VisitParmVarDecl` to search
balazske updated this revision to Diff 179249.
balazske added a comment.
Rebase.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53818/new/
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index:
balazske added a comment.
It is really "ugly" thing to have a Import_New and a Import for the same
functionality. Without these a single large patch would have been needed for
clang and another smaller one for LLDB that must be committed "at the same
time". Now 1 dependent patch is under
balazske updated this revision to Diff 175649.
balazske added a comment.
Rebase to newest master.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53818/new/
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index:
balazske updated this revision to Diff 175821.
balazske added a comment.
- Changed every use of ASTImporter::Import to Import_New
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53757/new/
https://reviews.llvm.org/D53757
Files:
lib/AST/ASTImporter.cpp
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, martong, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Repository:
rC Clang
https://reviews.llvm.org/D55049
Files:
lib/AST/ExternalASTMerger.cpp
balazske updated this revision to Diff 175822.
balazske added a comment.
Removing previous wrong update.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53757/new/
https://reviews.llvm.org/D53757
Files:
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
balazske added inline comments.
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:121
+ /// \return Returns a pointer to the ASTUnit that contains the definition of
+ /// the looked up function. The pointer should not be a nullptr.
///
Return value
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, martong, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Import type location in case of TypeSpec and TypeSpecWithTemplate.
Without this fix the imported
balazske reopened this revision.
balazske added a comment.
This revision is now accepted and ready to land.
Reopening to fix failing lldb tests.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53818/new/
https://reviews.llvm.org/D53818
balazske updated this revision to Diff 175864.
balazske added a comment.
- Changed some missing Import calls.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55049/new/
https://reviews.llvm.org/D55049
Files:
lib/AST/ASTImporter.cpp
balazske accepted this revision.
balazske added a comment.
This revision is now accepted and ready to land.
Do not forget that there is a fix the to use getMostRecentDecl in
ASTImporter.cpp line 2666 here.
Repository:
rC Clang
https://reviews.llvm.org/D53655
balazske added a comment.
I see that now everything is reverted, the "good" things too (change to
indirectFieldDecl and a line split)?
Repository:
rC Clang
https://reviews.llvm.org/D53655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
balazske updated this revision to Diff 175207.
balazske added a comment.
- Split long lines.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53751/new/
https://reviews.llvm.org/D53751
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index:
balazske updated this revision to Diff 175212.
balazske marked an inline comment as done.
balazske added a comment.
- Split long lines (ASTImporter.cpp).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53751/new/
https://reviews.llvm.org/D53751
Files:
balazske updated this revision to Diff 175529.
balazske added a comment.
- Corrected Import_New(const Attr *)
- Added missing Import_New with Selector and DeclarationName.
- Split long lines.
- Split long lines (ASTImporter.cpp).
Rebase to newest master.
Repository:
rC Clang
CHANGES SINCE
1 - 100 of 1563 matches
Mail list logo