r339031 - [Fixed Point Arithmetic] Remove unused include.

2018-08-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Aug 6 09:53:21 2018 New Revision: 339031 URL: http://llvm.org/viewvc/llvm-project?rev=339031&view=rev Log: [Fixed Point Arithmetic] Remove unused include. lib/Basic cannot depend on lib/AST. Modified: cfe/trunk/lib/Basic/FixedPoint.cpp Modified: cfe/trunk/lib/Basic/Fi

r332400 - Move helper classes into anonymous namespaces. NFCI.

2018-05-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 15 14:26:47 2018 New Revision: 332400 URL: http://llvm.org/viewvc/llvm-project?rev=332400&view=rev Log: Move helper classes into anonymous namespaces. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modifie

[clang-tools-extra] r314119 - [clangd] Fix missing "message" key when responding with unsupported method

2017-09-25 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Sep 25 10:16:47 2017 New Revision: 314119 URL: http://llvm.org/viewvc/llvm-project?rev=314119&view=rev Log: [clangd] Fix missing "message" key when responding with unsupported method The language server protocol dictates that a ResponseError should have a [message string][1]

r314391 - Use std::is_trivial instead of is_trivially_copyable.

2017-09-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Sep 28 01:50:30 2017 New Revision: 314391 URL: http://llvm.org/viewvc/llvm-project?rev=314391&view=rev Log: Use std::is_trivial instead of is_trivially_copyable. The oldest versions of GCC we support (before 5) didn't support that trait. is_trivial is stronger superset that

r315185 - Remove unused variables. No functionality change.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 12:11:02 2017 New Revision: 315185 URL: http://llvm.org/viewvc/llvm-project?rev=315185&view=rev Log: Remove unused variables. No functionality change. Modified: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp cfe/trunk/lib/CodeGen/CGExprComplex.cpp cfe/trunk/lib

r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 13:53:36 2017 New Revision: 315194 URL: http://llvm.org/viewvc/llvm-project?rev=315194&view=rev Log: Make SourceLocation, QualType and friends have constexpr constructors. No functionality change intended. Modified: cfe/trunk/include/clang/AST/CharUnits.h cfe

r315196 - Remove unused variables. No functionality change.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 14:23:02 2017 New Revision: 315196 URL: http://llvm.org/viewvc/llvm-project?rev=315196&view=rev Log: Remove unused variables. No functionality change. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/lib/CodeGen/CGOp

r315197 - Certain versions of clang require an explicit initialization for literal const members.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 14:28:47 2017 New Revision: 315197 URL: http://llvm.org/viewvc/llvm-project?rev=315197&view=rev Log: Certain versions of clang require an explicit initialization for literal const members. include/clang/Lex/PreprocessorLexer.h:79:3: error: constructor for 'clang::Pre

Re: r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

2017-10-09 Thread Benjamin Kramer via cfe-commits
gt; warning C4709: comma operator within array index expression > > Please have a look? > > Thanks > > Galina > > On Sun, Oct 8, 2017 at 1:53 PM, Benjamin Kramer via cfe-commits > wrote: >> >> Author: d0k >> Date: Sun Oct 8 13:53:36 2017 >> New Rev

r315276 - [ASTMatchers] Don't create a copy of a std::set when iterating over it.

2017-10-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 10 00:21:34 2017 New Revision: 315276 URL: http://llvm.org/viewvc/llvm-project?rev=315276&view=rev Log: [ASTMatchers] Don't create a copy of a std::set when iterating over it. This is a bit awkward because lookup returns a copy instead of a reference. No functionality ch

[clang-tools-extra] r315277 - [clang-tidy] Use a more efficient map for the virtual near miss check.

2017-10-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 10 00:21:51 2017 New Revision: 315277 URL: http://llvm.org/viewvc/llvm-project?rev=315277&view=rev Log: [clang-tidy] Use a more efficient map for the virtual near miss check. DenseMap performs better here. No functionality change intended. Modified: clang-tools-extr

r315772 - [Sema] Avoid iterator invalidation when code completing.

2017-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 13 15:14:34 2017 New Revision: 315772 URL: http://llvm.org/viewvc/llvm-project?rev=315772&view=rev Log: [Sema] Avoid iterator invalidation when code completing. It's possible for the code completion consumer to add new decls to the current scope while lookup happens on i

r315787 - [Sema] Warn about unused variables if we can constant evaluate the initializer.

2017-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 13 18:30:49 2017 New Revision: 315787 URL: http://llvm.org/viewvc/llvm-project?rev=315787&view=rev Log: [Sema] Warn about unused variables if we can constant evaluate the initializer. If the variable construction can be constant evaluated it doesn't have side effects, so

[libcxx] r315809 - Placate unused variable warnings uncovered by improvements to clang's -Wunused-variable

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 08:52:38 2017 New Revision: 315809 URL: http://llvm.org/viewvc/llvm-project?rev=315809&view=rev Log: Placate unused variable warnings uncovered by improvements to clang's -Wunused-variable Modified: libcxx/trunk/test/libcxx/depr/depr.c.headers/complex.h.pass.cpp

r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 08:59:34 2017 New Revision: 315811 URL: http://llvm.org/viewvc/llvm-project?rev=315811&view=rev Log: Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer." The warnings in libc++ tests were fixed in the meantime. Modified:

r315845 - [Lex] Remove unused variables. No functionality change.

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 21:27:37 2017 New Revision: 315845 URL: http://llvm.org/viewvc/llvm-project?rev=315845&view=rev Log: [Lex] Remove unused variables. No functionality change. Modified: cfe/trunk/include/clang/Lex/VariadicMacroSupport.h cfe/trunk/lib/Lex/TokenLexer.cpp Modified

r316127 - [Driver] Fix use after free in Hexagon toolchain code.

2017-10-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 18 14:43:42 2017 New Revision: 316127 URL: http://llvm.org/viewvc/llvm-project?rev=316127&view=rev Log: [Driver] Fix use after free in Hexagon toolchain code. No functionality change intended. Modified: cfe/trunk/lib/Driver/ToolChains/Hexagon.cpp Modified: cfe/trun

Re: r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-19 Thread Benjamin Kramer via cfe-commits
We should check VD->getInit()->isValueDependent() before we call evaluateValue. I wasn't able to come up with a test case that triggers the assert though :( On Thu, Oct 19, 2017 at 5:45 PM, Alexander Kornienko wrote: > > > On Sat, Oct 14, 2017 at 5:59 PM, Benjamin Kramer via

r316177 - [Sema] Fix assertion failure when checking for unused variables in a dependent context.

2017-10-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 19 12:07:13 2017 New Revision: 316177 URL: http://llvm.org/viewvc/llvm-project?rev=316177&view=rev Log: [Sema] Fix assertion failure when checking for unused variables in a dependent context. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/SemaCXX/warn-

Re: r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-19 Thread Benjamin Kramer via cfe-commits
45 PM, Alexander Kornienko > wrote: >> >> >> On Sat, Oct 14, 2017 at 5:59 PM, Benjamin Kramer via cfe-commits >> wrote: >>> >>> Author: d0k >>> Date: Sat Oct 14 08:59:34 2017 >>> New Revision: 315811 >>> >>> URL: http

r316301 - Create fewer copies of StringMaps. No functionality change intended.

2017-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 22 13:16:28 2017 New Revision: 316301 URL: http://llvm.org/viewvc/llvm-project?rev=316301&view=rev Log: Create fewer copies of StringMaps. No functionality change intended. Modified: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp cfe/trunk/lib/Parse/ParseStmtAsm.

r316344 - [ASTMatchers] Expose forEachOverriden in dynamic AST matchers.

2017-10-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 23 09:48:46 2017 New Revision: 316344 URL: http://llvm.org/viewvc/llvm-project?rev=316344&view=rev Log: [ASTMatchers] Expose forEachOverriden in dynamic AST matchers. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynami

[clang-tools-extra] r341643 - [clang-tidy] Abseil: Allow macros inside of absl to use internal absl things

2018-09-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Sep 7 02:25:23 2018 New Revision: 341643 URL: http://llvm.org/viewvc/llvm-project?rev=341643&view=rev Log: [clang-tidy] Abseil: Allow macros inside of absl to use internal absl things Modified: clang-tools-extra/trunk/clang-tidy/abseil/AbseilMatcher.h clang-tools-ex

[clang-tools-extra] r341925 - [clang-tidy] Add a missing comma after "flags"

2018-09-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Sep 11 03:37:08 2018 New Revision: 341925 URL: http://llvm.org/viewvc/llvm-project?rev=341925&view=rev Log: [clang-tidy] Add a missing comma after "flags" Added: clang-tools-extra/trunk/test/clang-tidy/Inputs/absl/flags/ clang-tools-extra/trunk/test/clang-tidy/Inputs

[clang-tools-extra] r341929 - [clang-tidy] Insert absl::StrAppend when replacing StrCat.

2018-09-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Sep 11 05:19:45 2018 New Revision: 341929 URL: http://llvm.org/viewvc/llvm-project?rev=341929&view=rev Log: [clang-tidy] Insert absl::StrAppend when replacing StrCat. There might be no using decl for StrAppend around, inserting the qualified name is less likely to break thin

[clang-tools-extra] r342041 - [clang-tidy] Abseil: Add more directories that are slated for future absl expansion.

2018-09-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Sep 12 03:04:16 2018 New Revision: 342041 URL: http://llvm.org/viewvc/llvm-project?rev=342041&view=rev Log: [clang-tidy] Abseil: Add more directories that are slated for future absl expansion. Modified: clang-tools-extra/trunk/clang-tidy/abseil/AbseilMatcher.h Modified

[clang-tools-extra] r342252 - [modernize-use-transparent-functors] TypeLocs can be implicitly created, don't crash when encountering those.

2018-09-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Sep 14 11:05:30 2018 New Revision: 342252 URL: http://llvm.org/viewvc/llvm-project?rev=342252&view=rev Log: [modernize-use-transparent-functors] TypeLocs can be implicitly created, don't crash when encountering those. Modified: clang-tools-extra/trunk/clang-tidy/moderni

[clang-tools-extra] r337601 - [clangd] Fix racy use-after-scope in unittest

2018-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jul 20 11:45:25 2018 New Revision: 337601 URL: http://llvm.org/viewvc/llvm-project?rev=337601&view=rev Log: [clangd] Fix racy use-after-scope in unittest This only shows up with asan when the stars align in a bad way. Modified: clang-tools-extra/trunk/unittests/clangd/T

r337607 - [AST] Various micro-optimizations in CXXInheritance

2018-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jul 20 13:13:08 2018 New Revision: 337607 URL: http://llvm.org/viewvc/llvm-project?rev=337607&view=rev Log: [AST] Various micro-optimizations in CXXInheritance 1. Pack std::pair in CXXBasePaths::ClassSubobjects. 2. Use a SmallPtrSet instead of a SmallDenseSet for CXXBasePat

[clang-tools-extra] r337655 - [clangd] Unbreak fuzzer build.

2018-07-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jul 22 08:55:57 2018 New Revision: 337655 URL: http://llvm.org/viewvc/llvm-project?rev=337655&view=rev Log: [clangd] Unbreak fuzzer build. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp U

r337688 - [AST] Use llvm::TrailingObjects in CXXTryStmt

2018-07-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jul 23 05:45:24 2018 New Revision: 337688 URL: http://llvm.org/viewvc/llvm-project?rev=337688&view=rev Log: [AST] Use llvm::TrailingObjects in CXXTryStmt 1. Use llvm::TrailingObjects in CXXTryStmt instead of manually doing the reinterpret_casts + pointer arithmetic. This is

[clang-tools-extra] r337860 - [clangd] Guard fuzzer against empty inputs.

2018-07-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jul 24 14:50:06 2018 New Revision: 337860 URL: http://llvm.org/viewvc/llvm-project?rev=337860&view=rev Log: [clangd] Guard fuzzer against empty inputs. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/Clang

r337862 - [Sema] Destroy tokens in DeclaratorChunk params

2018-07-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jul 24 15:47:16 2018 New Revision: 337862 URL: http://llvm.org/viewvc/llvm-project?rev=337862&view=rev Log: [Sema] Destroy tokens in DeclaratorChunk params Otherwise this leaks in some edge cases. Modified: cfe/trunk/include/clang/Sema/DeclSpec.h Modified: cfe/trunk/in

Re: r338299 - [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

2018-07-30 Thread Benjamin Kramer via cfe-commits
On Mon, Jul 30, 2018 at 10:37 PM Scott Linder via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: scott.linder > Date: Mon Jul 30 13:31:11 2018 > New Revision: 338299 > > URL: http://llvm.org/viewvc/llvm-project?rev=338299&view=rev > Log: > [DebugInfo][OpenCL] Generate correct block lit

Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-01 Thread Benjamin Kramer via cfe-commits
It's pretty easy to make this crash $ cat memcpy.c void foo() { int a[1], b; memcpy((char*)a, (const char*)&b, (unsigned long)4); } $ clang memcpy.c llvm/include/llvm/ADT/SmallVector.h:178: const_reference llvm::SmallVectorTemplateCommon::back() const [T = clang::APValue::LValue PathEntry]: A

[clang-tools-extra] r324277 - [clangd] Add a cstring include for strerror.

2018-02-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 5 14:10:39 2018 New Revision: 324277 URL: http://llvm.org/viewvc/llvm-project?rev=324277&view=rev Log: [clangd] Add a cstring include for strerror. Apparently this doesn't get included transitively on some systems. Modified: clang-tools-extra/trunk/clangd/Context.c

[clang-tools-extra] r324389 - [clangd] Make the premble tremble.

2018-02-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 6 12:08:23 2018 New Revision: 324389 URL: http://llvm.org/viewvc/llvm-project?rev=324389&view=rev Log: [clangd] Make the premble tremble. No functionality change. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/Clan

[clang-tools-extra] r325298 - [include-fixer] Add more debug headers to the STL header list

2018-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Feb 15 13:37:29 2018 New Revision: 325298 URL: http://llvm.org/viewvc/llvm-project?rev=325298&view=rev Log: [include-fixer] Add more debug headers to the STL header list These are used for std::map/std::set in STL debug mode. Modified: clang-tools-extra/trunk/include-f

[clang-tools-extra] r325467 - [tidy] Move private ast matchers into anonymous namespaces to avoid ODR conflicts.

2018-02-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Feb 18 11:02:35 2018 New Revision: 325467 URL: http://llvm.org/viewvc/llvm-project?rev=325467&view=rev Log: [tidy] Move private ast matchers into anonymous namespaces to avoid ODR conflicts. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy

r325468 - [Analyzer] Move UnexploredFirstStack into an anonymous namespace.

2018-02-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Feb 18 11:08:27 2018 New Revision: 325468 URL: http://llvm.org/viewvc/llvm-project?rev=325468&view=rev Log: [Analyzer] Move UnexploredFirstStack into an anonymous namespace. No functionality change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp Mo

r304028 - Make helper functions static. NFC.

2017-05-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri May 26 15:08:24 2017 New Revision: 304028 URL: http://llvm.org/viewvc/llvm-project?rev=304028&view=rev Log: Make helper functions static. NFC. Modified: cfe/trunk/lib/AST/DeclBase.cpp cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp cfe/trunk/lib/Frontend/TextDiagn

r304030 - Remove unused diagnostics. NFC.

2017-05-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri May 26 15:14:12 2017 New Revision: 304030 URL: http://llvm.org/viewvc/llvm-project?rev=304030&view=rev Log: Remove unused diagnostics. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

r304167 - Unbreak long test after r304127.

2017-05-29 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon May 29 13:11:11 2017 New Revision: 304167 URL: http://llvm.org/viewvc/llvm-project?rev=304167&view=rev Log: Unbreak long test after r304127. Modified: cfe/trunk/test/CodeGen/arm_neon_intrinsics.c Modified: cfe/trunk/test/CodeGen/arm_neon_intrinsics.c URL: http://llvm.o

r304205 - [PPC] Make altivec conversion function macros.

2017-05-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 30 06:37:29 2017 New Revision: 304205 URL: http://llvm.org/viewvc/llvm-project?rev=304205&view=rev Log: [PPC] Make altivec conversion function macros. The second argument must be a constant, otherwise instruction selection will fail. always_inline is not enough for isel

r304568 - [Modules] Fix use after scope.

2017-06-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 2 12:30:24 2017 New Revision: 304568 URL: http://llvm.org/viewvc/llvm-project?rev=304568&view=rev Log: [Modules] Fix use after scope. Found by asan. Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp URL: http:

Re: r304515 - Support lazy stat'ing of files referenced by module maps.

2017-06-02 Thread Benjamin Kramer via cfe-commits
I committed a workaround in r304568. On Fri, Jun 2, 2017 at 6:59 PM, Alexander Kornienko via cfe-commits wrote: > I've not yet figured out exactly, but I have a suspicion that this commit > causes crashes when run under asan. Specifically, when running > test/Modules/preprocess-module.cpp > > The

r304892 - [Sema] Silence unused variable warning.

2017-06-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 7 05:23:17 2017 New Revision: 304892 URL: http://llvm.org/viewvc/llvm-project?rev=304892&view=rev Log: [Sema] Silence unused variable warning. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-proj

r305094 - [ASTMatchers] Fix use after free.

2017-06-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 9 12:55:42 2017 New Revision: 305094 URL: http://llvm.org/viewvc/llvm-project?rev=305094&view=rev Log: [ASTMatchers] Fix use after free. Found by asan. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Parser.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Parser.cpp UR

r305103 - Bringt back -triple so the test passes on non-x86.

2017-06-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 9 14:47:36 2017 New Revision: 305103 URL: http://llvm.org/viewvc/llvm-project?rev=305103&view=rev Log: Bringt back -triple so the test passes on non-x86. Modified: cfe/trunk/test/Sema/2010-05-31-palignr.c Modified: cfe/trunk/test/Sema/2010-05-31-palignr.c URL: htt

Re: r304207 - Allow for unfinished #if blocks in preambles

2017-06-23 Thread Benjamin Kramer via cfe-commits
Since this change went in I'm seeing spurious errors whenever editing a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574 for that. On Tue, May 30, 2017 at 1:54 PM, Erik Verbruggen via cfe-commits wrote: > Author: erikjv > Date: Tue May 30 06:54:55 2017 > New Revision: 304207 > > URL

r320954 - Refactor overridden methods iteration to avoid double lookups.

2017-12-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 17 15:52:45 2017 New Revision: 320954 URL: http://llvm.org/viewvc/llvm-project?rev=320954&view=rev Log: Refactor overridden methods iteration to avoid double lookups. Convert most uses to range-for loops. No functionality change intended. Modified: cfe/trunk/include

[clang-tools-extra] r321286 - [clangd] Fix use after free.

2017-12-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 21 09:51:35 2017 New Revision: 321286 URL: http://llvm.org/viewvc/llvm-project?rev=321286&view=rev Log: [clangd] Fix use after free. Found by asan. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/Sym

r321425 - Make helpers static. No functionality change.

2017-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 24 04:46:22 2017 New Revision: 321425 URL: http://llvm.org/viewvc/llvm-project?rev=321425&view=rev Log: Make helpers static. No functionality change. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.org/viewvc/l

r321429 - [AST] Inline CompoundStmt contents into the parent allocation.

2017-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 24 08:24:20 2017 New Revision: 321429 URL: http://llvm.org/viewvc/llvm-project?rev=321429&view=rev Log: [AST] Inline CompoundStmt contents into the parent allocation. Saves a pointer on every CompoundStmt. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/l

r321428 - [AST] Convert AttributedStmt to llvm::TrailingObjects.

2017-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 24 08:24:11 2017 New Revision: 321428 URL: http://llvm.org/viewvc/llvm-project?rev=321428&view=rev Log: [AST] Convert AttributedStmt to llvm::TrailingObjects. No functionality change intended. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/lib/AST/Stmt.c

[clang-tools-extra] r321523 - [clangd] Simplify code. No functionality change intended.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 06:47:01 2017 New Revision: 321523 URL: http://llvm.org/viewvc/llvm-project?rev=321523&view=rev Log: [clangd] Simplify code. No functionality change intended. Modified: clang-tools-extra/trunk/clangd/index/FileIndex.cpp clang-tools-extra/trunk/clangd/index/Fil

[clang-tools-extra] r321525 - [clangd] Get rid of unnecessary global variable. No functionality change.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 07:03:02 2017 New Revision: 321525 URL: http://llvm.org/viewvc/llvm-project?rev=321525&view=rev Log: [clangd] Get rid of unnecessary global variable. No functionality change. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp clang-tools-extra/trunk/clangd/

r321526 - Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 08:58:54 2017 New Revision: 321526 URL: http://llvm.org/viewvc/llvm-project?rev=321526&view=rev Log: Avoid int to string conversion in Twine or raw_ostream contexts. Some output changes from uppercase hex to lowercase hex, no other functionality change intended. Mod

[clang-tools-extra] r321526 - Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 08:58:54 2017 New Revision: 321526 URL: http://llvm.org/viewvc/llvm-project?rev=321526&view=rev Log: Avoid int to string conversion in Twine or raw_ostream contexts. Some output changes from uppercase hex to lowercase hex, no other functionality change intended. Mod

r321626 - [Sema] Fix build with GCC

2018-01-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 1 09:07:23 2018 New Revision: 321626 URL: http://llvm.org/viewvc/llvm-project?rev=321626&view=rev Log: [Sema] Fix build with GCC tools/clang/lib/Sema/DeclSpec.cpp: In member function 'void clang::DeclSpec::Finish(clang::Sema&, const clang::PrintingPolicy&)': tools/clan

r321948 - Add support for a limited subset of TS 18661-3 math builtins.

2018-01-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jan 6 13:49:54 2018 New Revision: 321948 URL: http://llvm.org/viewvc/llvm-project?rev=321948&view=rev Log: Add support for a limited subset of TS 18661-3 math builtins. These just overloads for _Float128. They're supported by GCC 7 and used by glibc. APFloat support is alre

r321960 - Remove outdated doxygen comment [-Wdocumentation]

2018-01-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jan 7 01:11:16 2018 New Revision: 321960 URL: http://llvm.org/viewvc/llvm-project?rev=321960&view=rev Log: Remove outdated doxygen comment [-Wdocumentation] No functionality change. Modified: cfe/trunk/include/clang/Lex/ModuleMap.h Modified: cfe/trunk/include/clang/Le

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018-03-01 Thread Benjamin Kramer via cfe-commits
Frontend depends on StaticAnalyzerCore by including "clang/StaticAnalyzer/Core/Analyses.def". That's a clear layering violation, but cmake doesn't model header dependencies. Maybe Analyses.def should move into its own library. On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth via llvm-commits < llvm-c

r334619 - [Basic] Fix -Wreorder warning

2018-06-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 13 09:45:12 2018 New Revision: 334619 URL: http://llvm.org/viewvc/llvm-project?rev=334619&view=rev Log: [Basic] Fix -Wreorder warning Just use field initializers that don't suffer from this problem Modified: cfe/trunk/lib/Basic/Targets/PPC.h Modified: cfe/trunk/lib

r335330 - [hmaptool] Turn %hmaptool into a proper substitution

2018-06-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 22 02:46:40 2018 New Revision: 335330 URL: http://llvm.org/viewvc/llvm-project?rev=335330&view=rev Log: [hmaptool] Turn %hmaptool into a proper substitution This is still super ugly, but at least it doesn't require working directories to just line up perfectly for python

r335382 - Reinstate quotes around the path to python that I accidentaly removed in r335330

2018-06-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 22 13:03:32 2018 New Revision: 335382 URL: http://llvm.org/viewvc/llvm-project?rev=335382&view=rev Log: Reinstate quotes around the path to python that I accidentaly removed in r335330 This broke users with spaces in the path, like C:\Program Files\Python Modified:

[clang-tools-extra] r344468 - Move some helpers from the global namespace into anonymous ones.

2018-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 13 15:18:22 2018 New Revision: 344468 URL: http://llvm.org/viewvc/llvm-project?rev=344468&view=rev Log: Move some helpers from the global namespace into anonymous ones. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clang

r344468 - Move some helpers from the global namespace into anonymous ones.

2018-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 13 15:18:22 2018 New Revision: 344468 URL: http://llvm.org/viewvc/llvm-project?rev=344468&view=rev Log: Move some helpers from the global namespace into anonymous ones. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp cfe/trunk/lib/Static

[clang-tools-extra] r344968 - [clang-tidy] Fix typo abls->absl.

2018-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 22 15:43:17 2018 New Revision: 344968 URL: http://llvm.org/viewvc/llvm-project?rev=344968&view=rev Log: [clang-tidy] Fix typo abls->absl. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-str-cat-append.rst Modified: clang-tools-extra/trunk/docs/clang

r351007 - [analyzer] Fix unused variable warnings in Release builds

2019-01-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jan 12 04:43:53 2019 New Revision: 351007 URL: http://llvm.org/viewvc/llvm-project?rev=351007&view=rev Log: [analyzer] Fix unused variable warnings in Release builds This was just an inlined version of isa. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
I'm seeing breakages on v8 with this, it defines its own _xgetbv. Any ideas what do do about this? https://chromium.googlesource.com/v8/v8.git/+/master/src/x64/assembler-x64.cc#36 src/x64/assembler-x64.cc:35:1: error: inline variables are incompatible with C++ standards before C++17 [-Werror,-Wc+

[clang-tools-extra] r351208 - Revert "Update clang-tools-extra for r350891 from Clang."

2019-01-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 15 09:20:04 2019 New Revision: 351208 URL: http://llvm.org/viewvc/llvm-project?rev=351208&view=rev Log: Revert "Update clang-tools-extra for r350891 from Clang." This reverts commit r350892. Modified: clang-tools-extra/trunk/test/modularize/ProblemsInconsistent.modu

r351209 - Revert "Correct the source range returned from preprocessor callbacks."

2019-01-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 15 09:20:05 2019 New Revision: 351209 URL: http://llvm.org/viewvc/llvm-project?rev=351209&view=rev Log: Revert "Correct the source range returned from preprocessor callbacks." This reverts commit r350891. Also add a test case that would return an empty string with r35089

Re: r350891 - Correct the source range returned from preprocessor callbacks.

2019-01-15 Thread Benjamin Kramer via cfe-commits
With this patch some ranges just come back empty. I rolled the change back in r351209, which also includes a test case that shows the empty ranges with this patch. On Thu, Jan 10, 2019 at 10:26 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Th

r351210 - Revert "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 15 09:23:36 2019 New Revision: 351210 URL: http://llvm.org/viewvc/llvm-project?rev=351210&view=rev Log: Revert "[X86] Make _xgetbv/_xsetbv on non-windows platforms" This reverts commit r351160. Breaks building v8. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
I rolled it back for now in r351210, this pattern seems to be quite common even outside of v8. Let's figure out if we can keep the code working or if it needs to be fixed all over the place :( On Tue, Jan 15, 2019 at 3:02 PM Benjamin Kramer wrote: > I'm seeing breakages on v8 with this, it defin

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
to make the patch work? > > ~Craig > > > On Tue, Jan 15, 2019 at 9:28 AM Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I rolled it back for now in r351210, this pattern seems to be quite >> common even outside of v8. Let's figur

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
_xgetbv a macro to make the patch work? >>> >>> ~Craig >>> >>> >>> On Tue, Jan 15, 2019 at 9:28 AM Benjamin Kramer via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>>> I rolled it back for now i

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-16 Thread Benjamin Kramer via cfe-commits
udes x86intrin.h >>>> transitively from . That's probably broken with all compilers :( >>>> >>>> On Tue, Jan 15, 2019 at 7:31 PM Craig Topper >>>> wrote: >>>> >>>>> Does V8 work with gcc which also has _xgetbv? Or is it

Re: r345833 - Logging: add CMake dependency so libAST can use OSLog analysis.

2018-11-01 Thread Benjamin Kramer via cfe-commits
This doesn't work. AST cannot depend on Analysis because Analysis already depends on AST. On Thu, Nov 1, 2018 at 3:24 PM Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tnorthover > Date: Thu Nov 1 07:22:20 2018 > New Revision: 345833 > > URL: http://llvm.org/viewvc/

r346130 - Reapply "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX"

2018-11-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Nov 5 04:46:02 2018 New Revision: 346130 URL: http://llvm.org/viewvc/llvm-project?rev=346130&view=rev Log: Reapply "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX" This reverts commit r345963. We have a path forward now. Original commit message: The dr

[clang-tools-extra] r346608 - [clangd] Make ClangdFuzzer compile again.

2018-11-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Nov 11 03:09:58 2018 New Revision: 346608 URL: http://llvm.org/viewvc/llvm-project?rev=346608&view=rev Log: [clangd] Make ClangdFuzzer compile again. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdF

Re: r347189 - [OpenCL] Fix address space deduction in template args.

2018-11-19 Thread Benjamin Kramer via cfe-commits
clang gives me this: llvm/tools/clang/lib/Sema/SemaType.cpp:7230:11: error: variable 'ImpAddr' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (D.getContext() == DeclaratorContext::TemplateArgContext) { ^~

[clang-tools-extra] r347460 - [clangd] Fix use-after-scope in unit test

2018-11-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Nov 22 04:54:25 2018 New Revision: 347460 URL: http://llvm.org/viewvc/llvm-project?rev=347460&view=rev Log: [clangd] Fix use-after-scope in unit test The scheduler holds a reference to `Proceed`, so it has to be destroyed after the scheduler. Found by asan. Modified: cl

[clang-tools-extra] r347496 - Remove the optional dependency from libclang to clang-tidy/include-fixer

2018-11-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Nov 23 07:02:33 2018 New Revision: 347496 URL: http://llvm.org/viewvc/llvm-project?rev=347496&view=rev Log: Remove the optional dependency from libclang to clang-tidy/include-fixer clangd does a better job on both of these, so don't slow down everyone's build for a poorly wo

r347496 - Remove the optional dependency from libclang to clang-tidy/include-fixer

2018-11-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Nov 23 07:02:33 2018 New Revision: 347496 URL: http://llvm.org/viewvc/llvm-project?rev=347496&view=rev Log: Remove the optional dependency from libclang to clang-tidy/include-fixer clangd does a better job on both of these, so don't slow down everyone's build for a poorly wo

r355816 - [Serialization] Add missing include

2019-03-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Mar 11 03:30:51 2019 New Revision: 355816 URL: http://llvm.org/viewvc/llvm-project?rev=355816&view=rev Log: [Serialization] Add missing include forward decl is not sufficient for destroying a unique_ptr. Modified: cfe/trunk/include/clang/Serialization/InMemoryModuleCach

r355819 - Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC.

2019-03-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Mar 11 03:44:10 2019 New Revision: 355819 URL: http://llvm.org/viewvc/llvm-project?rev=355819&view=rev Log: Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC. Modified: cfe/trunk/test/Modules/relative-import-path.c Modified: cfe/trunk/test/Module

r356250 - Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

2019-03-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Mar 15 04:09:41 2019 New Revision: 356250 URL: http://llvm.org/viewvc/llvm-project?rev=356250&view=rev Log: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types We already handle pointers and references, member ptrs are just another specia

r357187 - Make helper functions static. NFC.

2019-03-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Mar 28 10:18:42 2019 New Revision: 357187 URL: http://llvm.org/viewvc/llvm-project?rev=357187&view=rev Log: Make helper functions static. NFC. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/lib/Sema/SemaOpenMP.cpp cfe/trunk/lib/StaticAnalyzer/Core/BugR

r342909 - Fix the type of 1<<31 integer constants.

2018-09-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Sep 24 10:51:15 2018 New Revision: 342909 URL: http://llvm.org/viewvc/llvm-project?rev=342909&view=rev Log: Fix the type of 1<<31 integer constants. Shifting into the sign bit is technically undefined behavior. No known compiler exploits it though. Modified: cfe/trunk/i

r353705 - Make some helper functions static. NFC.

2019-02-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 11 06:52:15 2019 New Revision: 353705 URL: http://llvm.org/viewvc/llvm-project?rev=353705&view=rev Log: Make some helper functions static. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCount

[clang-tools-extra] r312166 - [cppcoreguidelines] Don't rely on SmallPtrSet iteration order.

2017-08-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Aug 30 13:18:40 2017 New Revision: 312166 URL: http://llvm.org/viewvc/llvm-project?rev=312166&view=rev Log: [cppcoreguidelines] Don't rely on SmallPtrSet iteration order. The fixit emission breaks if the iteration order changes and also missed to emit fixits for some edge ca

r312186 - [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet.

2017-08-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Aug 30 15:51:50 2017 New Revision: 312186 URL: http://llvm.org/viewvc/llvm-project?rev=312186&view=rev Log: [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet. We have enough spare bits in the alignment of CXXRecordDecl. No functionality chan

r312336 - std::function -> llvm::function_ref. NFC.

2017-09-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Sep 1 09:51:51 2017 New Revision: 312336 URL: http://llvm.org/viewvc/llvm-project?rev=312336&view=rev Log: std::function -> llvm::function_ref. NFC. Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h cfe/trunk/include/clang/Parse/Parser.h cfe/trunk/lib/

r312710 - Fixing incorrectly capitalised regexps.

2017-09-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Sep 7 02:54:03 2017 New Revision: 312710 URL: http://llvm.org/viewvc/llvm-project?rev=312710&view=rev Log: Fixing incorrectly capitalised regexps. Patch by Sam Allen! Modified: cfe/trunk/test/CodeGen/x86_32-xsave.c cfe/trunk/test/CodeGen/x86_64-xsave.c cfe/trun

r314066 - Silence unused variable warning in Release builds.

2017-09-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Sep 23 09:08:48 2017 New Revision: 314066 URL: http://llvm.org/viewvc/llvm-project?rev=314066&view=rev Log: Silence unused variable warning in Release builds. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp URL: http://

r362062 - [AST] asm goto labels don't have constraints, don't try to copy them.

2019-05-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 30 00:21:08 2019 New Revision: 362062 URL: http://llvm.org/viewvc/llvm-project?rev=362062&view=rev Log: [AST] asm goto labels don't have constraints, don't try to copy them. Found by asan. Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp UR

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

2019-05-30 Thread Benjamin Kramer via cfe-commits
Is this still necessary after r362062? On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Thu May 30 01:03:02 2019 > New Revision: 362067 > > URL: http://llvm.org/viewvc/llvm-project?rev=362067&view=rev > Log: > asm goto: f

r362597 - Revert "Factor out duplicated code building a MemberExpr and marking it" and "Convert MemberExpr creation and serialization to work the same way as"

2019-06-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 5 04:46:57 2019 New Revision: 362597 URL: http://llvm.org/viewvc/llvm-project?rev=362597&view=rev Log: Revert "Factor out duplicated code building a MemberExpr and marking it" and "Convert MemberExpr creation and serialization to work the same way as" This reverts comm

  1   2   3   4   5   6   7   8   9   10   >