Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

2020-02-26 Thread Blower, Melanie I via cfe-commits
Rumeet, Thanks for the additional info. At some point we'd like to re-commit this patch. LNT testing showed execution time regressions on arch including x86 and aarch. I didn't capture the test names each time but it appeared to be approximately the same tests regressing everywhere. Andy

RE: [PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-14 Thread Blower, Melanie I via cfe-commits
I reverted MaskRay's "reland" since the original patch is causing trouble on PowerPC, check-all is passing on my box. Sorry for the trouble. > -Original Message- > From: Andy Kaylor via Phabricator > Sent: Thursday, February 13, 2020 9:20 PM > To: Blower, Melanie I ;

RE: [PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-03-11 Thread Blower, Melanie I via cfe-commits
Sorry I don't understand. I have to add "final" onto BinaryOperator in order to use Trailing storage. But when I do that I can't derive CompoundAssignmentOperator from BinaryOperator. So I think I must fold these 2 classes together. Is there another way? > -Original Message- > From:

RE: [PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-10-27 Thread Blower, Melanie I via cfe-commits
Actually kludging it by just removing the assert isn't going to work. I'll ping Pengfei to see about developing a patch for this problem. > -Original Message- > From: dmajor via Phabricator > Sent: Tuesday, October 27, 2020 11:58 AM > To: Blower, Melanie I ; sepavl...@gmail.com; >

RE: [PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-10-27 Thread Blower, Melanie I via cfe-commits
Thank you. I don't know the solution but I can remove the assert and create a bug report to have it resolved. > -Original Message- > From: dmajor via Phabricator > Sent: Tuesday, October 27, 2020 11:58 AM > To: Blower, Melanie I ; sepavl...@gmail.com; > rjmcc...@gmail.com;