[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-04-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 144336. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp clang-tidy/cert/ProperlySeededRandomGeneratorCheck.h docs/ReleaseNotes.rst

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 153169. boga95 marked 3 inline comments as done. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 153172. boga95 marked 3 inline comments as done. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-25 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 152778. boga95 marked 3 inline comments as done. boga95 added a comment. Add std::srand check to C++ tests. Format patch. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-24 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 12 inline comments as done. boga95 added a comment. I think I resolved all of the comments. Do I forget anything? Comment at: clang-tidy/cert/CERTTidyModule.cpp:44 "cert-dcl54-cpp"); -CheckFactories.registerCheck( -"cert-dcl58-cpp"); +

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-07-01 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 153655. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp clang-tidy/cert/ProperlySeededRandomGeneratorCheck.h docs/ReleaseNotes.rst

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-07-04 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. How can I commit it? Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:7 +This check flags all pseudo-random number engines, engine adaptor +instantiations and `srand()` when initialized or seeded with default argument, +constant expression or any

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-03-12 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a subscriber: szepet. boga95 marked 4 inline comments as done. boga95 added inline comments. Comment at: test/clang-tidy/cert-properly-seeded-random-generator.cpp:76 + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: random number generator must be seeded with a

[PATCH] D44143: Create properly seeded random generator check

2018-03-10 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 137915. boga95 marked an inline comment as done. boga95 added a comment. Add capability to provide a user-configurable list of disallowed types which will trigger warning. Now it also detects C srand function. Rename check to cert-msc51-cpp. Add cert-msc32-c

[PATCH] D44143: Create properly seeded random generator check

2018-03-06 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added a reviewer: clang-tools-extra. boga95 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. This check flags all pseudo-random number engines and engine adaptors instantiations when it initialized or seeded with default

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

2018-10-02 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 167991. boga95 marked 7 inline comments as done. https://reviews.llvm.org/D52281 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp

[PATCH] D52281: Use std::invoke in generic code

2018-09-19 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. In generic code (e.g.: in a type dependent expression), the `std::invoke` should be used, in order to support functors, function pointers, pointers to members, regular

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

2018-09-22 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 166604. https://reviews.llvm.org/D52281 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp clang-tidy/modernize/ReplaceGenericFunctorCallCheck.h

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

2018-09-25 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 166994. boga95 marked 12 inline comments as done. https://reviews.llvm.org/D52281 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

2018-12-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 178537. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index:

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

2018-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 178373. boga95 added a comment. Rebase patch on the earlier version. Remove unnecessary inline specifiers. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files:

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. I don't have commit access. Can you please do it on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 ___ cfe-commits mailing list

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

2018-12-23 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 179436. boga95 marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index:

[PATCH] D55734: Refactoring GenericTaintChecker.cpp

2018-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: gerazo, xazax.hun, Szelethus, a_sidorin, dcoughlin, george.karpenkov. Herald added subscribers: cfe-commits, rnkovacs. Use a more optimal data structure to represent taint propagation rules. Repository: rC Clang

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

2018-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 178351. boga95 added a comment. Upload diff with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index:

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

2018-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. I use std::move which is in the ``. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

2018-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 178368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D54918: Apply clang-format to GenericTaintChecker.cpp

2018-11-29 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. If you find it ok, can you please commit it? @xazax.hun Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 ___ cfe-commits mailing list

[PATCH] D54918: Apply clang-format to GenericTaintChecker.cpp

2018-11-26 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added a reviewer: gerazo. boga95 added a project: clang. Herald added a subscriber: cfe-commits. I would like to add some patch for this checker later and I found that it isn't well formatted. Repository: rC Clang https://reviews.llvm.org/D54918 Files:

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

2019-01-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 4 inline comments as done. boga95 added a comment. Is it ready to land? Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:212 + llvm::StringSwitch(Name) + .Case("atoi", TaintPropagationRule({0}, {ReturnValueIndex})) +

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-03-25 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked an inline comment as done. boga95 added a comment. Why is it better not to use `static` functions/variables? Has it any performance impact? Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75 static const unsigned InvalidArgIndex = UINT_MAX;

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

2019-03-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. Thanks, it will make my changes more cleaner. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59861/new/ https://reviews.llvm.org/D59861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-03-21 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus, xazax.hun, dkrupp. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. The `TaintPropagationRule` deduction

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-03-21 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 191668. boga95 retitled this revision from "[analyzer] Make GenericTaintChecker configurable" to "[analyzer] Add custom filter functions for GenericTaintChecker". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-04-04 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 193676. boga95 added a comment. Rebase after https://reviews.llvm.org/D59861. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-04-04 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 193705. boga95 added a comment. Rebase after https://reviews.llvm.org/D59861. Fix custom filter test case: functions without definition always remove taintedness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-04-01 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 193175. boga95 marked an inline comment as done. boga95 added a comment. Rebase after https://reviews.llvm.org/D59861. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files:

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-03-26 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. I add a new taint type, which represents a lack of taintedness. That's why I changed the name of `addTaint()` to `setTaint()`. Of course, it's not an important change, I can move it to another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

2019-03-06 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: gerazo, xazax.hun, Szelethus, a_sidorin, dcoughlin, george.karpenkov, NoQ. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,

[PATCH] D58828: [analyzer] Fix taint propagation in GenericTaintChecker

2019-03-01 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: gerazo, xazax.hun, Szelethus, a_sidorin, dcoughlin, george.karpenkov, NoQ. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

2019-03-08 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. Yes, they do. Thanks for the review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59055/new/ https://reviews.llvm.org/D59055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-03-19 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: Szelethus, xazax.hun, dkrupp, NoQ. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Parse the yaml configuration file and

[PATCH] D59516: [analyzer] Make GenericTaintChecker configurable

2019-03-18 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus, xazax.hun, dkrupp. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. One can pass a configuration file to

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

2019-01-28 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. Yes, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-05-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 10. boga95 edited the summary of this revision. boga95 added a comment. I changed the parsing, therefore the return value index is represented by -1. I added a test configuration file and parse it when testing to prove the configuration doesn't break the

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-06-06 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 203339. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp lib/StaticAnalyzer/Checkers/Yaml.h

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-05-23 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 3 inline comments as done. boga95 added a comment. I already thought about it. It would make the code much cleaner, but it would have a little performance impact (Does it matter?). It's straightforward to read the supported functions from another yaml file. Besides that, it can

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-05-16 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. Sorry for the late answer, I was working on my thesis which is about taint analysis. During that, I implemented several cool features (namespaces, std::cin, std::string, etc.) for the checker. I will share them soon. I thought about the API notes and I think it will fit

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-07-16 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 210073. boga95 marked 11 inline comments as done. boga95 added a comment. Report diagnostic error in case of an invalid filename or an ill-formed yaml file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-08-14 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 215268. boga95 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp test/Analysis/taint-generic.c Index:

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-08-30 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. Should I do anything or it is ready? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-09-02 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 218395. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp test/Analysis/taint-generic.c Index: test/Analysis/taint-generic.c

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-09-06 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 219172. boga95 marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/test/Analysis/taint-generic.c Index:

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-09-12 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 219981. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-09-16 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 220385. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

2019-09-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 abandoned this revision. boga95 marked 4 inline comments as done. boga95 added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:72 + +const Expr *Obj = BinOp->getLHS(); +const std::string ObjName = I found an

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

2019-09-18 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked an inline comment as done. boga95 added a comment. Resolving the problems properly seemed quite difficult. I just finished university and started to work, therefore I don't have enough free time to finish the checker. Sorry about that. CHANGES SINCE LAST ACTION

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-09-08 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 closed this revision. boga95 marked 10 inline comments as done. boga95 added a comment. Closed by 080ecafdd8b3e990e5ad19202d089c91c9c9b164 . Comment at:

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-07-28 Thread Borsik Gábor via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367190: [analyzer] Add yaml parser to GenericTaintChecker (authored by boga95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-07-31 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 2 inline comments as done. boga95 added a comment. I think it shouldn't give compile error in case of incorrect configuration now (maybe warning) because: - Without qualified names, I can create a code which cannot be configured properly. - It can throw an error without

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-07-28 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 212119. boga95 added a subscriber: steakhal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/test/Analysis/taint-generic.c Index:

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-07-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 212065. boga95 marked 16 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-07-18 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 210540. boga95 marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-07-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 210260. boga95 marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

2019-07-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 210258. boga95 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-11-16 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 2 inline comments as done. boga95 added a comment. I did the required changes and tried to commit it, but I couldn't. I heard the codebase was migrated to GitHub. Maybe it affected my commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D70878: [analyzer] Add support for namespaces to GenericTaintChecker

2019-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. boga95 marked 2 inline comments as done. Closed by commit rG273e67425243: [analyzer] Add support for namespaces to GenericTaintChecker (authored by boga95). Changed prior to commit:

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2019-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: clang. I extended the supported C++ features: - The `this` pointer can be tainted

[PATCH] D70878: [analyzer] Add support for namespaces to GenericTaintChecker

2019-12-01 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Now the user can define a `Scope` for every configured function: - Functions

[PATCH] D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker

2019-11-23 Thread Borsik Gábor via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG79e2325f145d: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker (authored by boga95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-11-23 Thread Borsik Gábor via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. boga95 marked 2 inline comments as done. Closed by commit rG89bc4c662c6c: [analyzer] Add custom filter functions for GenericTaintChecker (authored by boga95). Changed prior to commit:

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-10-09 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 2 inline comments as done. boga95 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

2019-10-03 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 7 inline comments as done. boga95 added a comment. Ping Comment at: clang/test/Analysis/taint-generic.c:393-397 +void testConfigurationFilter3() { + int x = mySource1(); + myFilter3(); + Buffer[x] = 1; // no-warning +} NoQ wrote: > In this

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-24 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 6 inline comments as done. boga95 added a comment. @steakhal's revision is on the top of this. Changing the order will only cause unnecessary work on both sides. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:103-132 struct FunctionData

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-01-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-23 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 246120. boga95 marked 5 inline comments as done. Herald added a subscriber: martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-03-08 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 249019. boga95 marked 2 inline comments as done. boga95 added a comment. Rebase to master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-04-12 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 256839. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-09-30 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked an inline comment as done. boga95 added a comment. In D71524#2291925 , @steakhal wrote: > In D71524#2284386 , @Szelethus wrote: > >> I figured you're still working on this, sorry! I'd really like to

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-09-20 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 9 inline comments as done. boga95 added a comment. Ping Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:289-293 + {"c_str", {"std::__cxx11::basic_string", {{0}, {ReturnValueIndex, + {"data", {"std::__cxx11::basic_string", {{0},