modocache created this revision.
modocache added a reviewer: cfe-commits.
Depends on http://reviews.llvm.org/D12047.
Add a unit test which demonstrates the bug reported in
https://llvm.org/bugs/show_bug.cgi?id=24404.
If the macro is enclosed within parentheses, the warning is reported as
modocache created this revision.
modocache added a reviewer: cfe-commits.
The tests that verify that accessing a property without using the result
emits a warning were needlessly complicated. Remove several layers of
abstraction to make the tests much simpler to read and reason about.
modocache added a comment.
Why do you think it's a cruft? Seems it's a bit more verbose than it should be
The verbosity is the cruft, in my opinion. Why spend thirty lines of code to
demonstrate behavior that could be demonstrated in just five?
but what is missing in your test is
modocache added a comment.
Cool, thanks @compnerd!
http://reviews.llvm.org/D11772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache accepted this revision.
modocache added a reviewer: modocache.
modocache added a comment.
This revision is now accepted and ready to land.
Looks good to me! I don't have commit access, though, so you'll probably have
to find a committer to review/commit for you, @skalinichev.
Author: modocache
Date: Thu Aug 10 08:30:35 2017
New Revision: 310609
URL: http://llvm.org/viewvc/llvm-project?rev=310609=rev
Log:
[Parse] Document PrintStats, SkipFunctionBodies
Summary:
Add documentation for `clang::ParseAST` parameters `PrintStats` and
`SkipFunctionBodies`. Also, remove a
Author: modocache
Date: Thu Aug 10 10:02:04 2017
New Revision: 310627
URL: http://llvm.org/viewvc/llvm-project?rev=310627=rev
Log:
[Parse] Document Parser::SkipFunctionBodies
Reviewers: erikjv, doug.gregor
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D36531
Author: modocache
Date: Mon Aug 14 07:29:11 2017
New Revision: 310838
URL: http://llvm.org/viewvc/llvm-project?rev=310838=rev
Log:
[Parse] Fix typo in header docs (NFC)
Summary:
Fix typo "delcarations", added in rL310609 and rL310627.
Modified:
cfe/trunk/include/clang/Parse/ParseAST.h
Author: modocache
Date: Mon Jul 17 12:22:57 2017
New Revision: 308205
URL: http://llvm.org/viewvc/llvm-project?rev=308205=rev
Log:
[Basic] Detect Git submodule version in CMake
Summary:
When searching for Git version control information, libBasic's CMake
checks for the path '.git/logs/HEAD'.
Author: modocache
Date: Fri Jun 30 12:37:11 2017
New Revision: 306862
URL: http://llvm.org/viewvc/llvm-project?rev=306862=rev
Log:
[ORE] Use LLVM's "diagnostics hotness" spelling
Summary:
Depends on https://reviews.llvm.org/D34864.
To unify Clang and LLVM's spelling of "diagnostic[s] hotness",
Author: modocache
Date: Fri Jun 30 21:44:38 2017
New Revision: 306945
URL: http://llvm.org/viewvc/llvm-project?rev=306945=rev
Log:
[Driver] Add -fdiagnostics-hotness-threshold
Summary:
Depends on https://reviews.llvm.org/D34867.
Add a Clang frontend option to enable optimization remark hotness
Author: modocache
Date: Fri Jun 30 21:54:53 2017
New Revision: 306946
URL: http://llvm.org/viewvc/llvm-project?rev=306946=rev
Log:
Revert "[Driver] Add -fdiagnostics-hotness-threshold"
Summary:
The commit caused a documentation breakage.
Modified:
cfe/trunk/docs/UsersManual.rst
Author: modocache
Date: Fri Jun 30 22:45:26 2017
New Revision: 306948
URL: http://llvm.org/viewvc/llvm-project?rev=306948=rev
Log:
Un-revert "[Driver] Add -fdiagnostics-hotness-threshold"
Summary:
Un-revert https://reviews.llvm.org/D34868, but with a slight tweak to the
documentation to fix an
Author: modocache
Date: Wed Jul 5 12:55:51 2017
New Revision: 307193
URL: http://llvm.org/viewvc/llvm-project?rev=307193=rev
Log:
Add docs for -foptimization-record-file=
Summary: The Clang option was previously not included in the User's Manual.
Reviewers: anemet, davidxl, hfinkel
Reviewed
Author: modocache
Date: Thu Jun 22 21:38:45 2017
New Revision: 306079
URL: http://llvm.org/viewvc/llvm-project?rev=306079=rev
Log:
[Frontend] 'Show hotness' can be used with a sampling profile
Summary:
Prior to this change, using `-fdiagnostics-show-hotness` with a sampling
profile specified via
Author: modocache
Date: Fri May 4 07:02:37 2018
New Revision: 331519
URL: http://llvm.org/viewvc/llvm-project?rev=331519=rev
Log:
[Coroutines] Catch exceptions in await_resume
Summary:
http://wg21.link/P0664r2 section "Evolution/Core Issues 24" describes a
proposed change to Coroutines TS that
Author: modocache
Date: Sat May 19 04:46:58 2018
New Revision: 332804
URL: http://llvm.org/viewvc/llvm-project?rev=332804=rev
Log:
[Driver] Loosen test for LLVM findNearest
Summary:
When https://reviews.llvm.org/D46776 landed to improve the behavior of
`llvm::OptTable::findNearest`, a PS4
Author: modocache
Date: Sat May 19 05:44:02 2018
New Revision: 332806
URL: http://llvm.org/viewvc/llvm-project?rev=332806=rev
Log:
[Driver] Temporarily remove test for LLVM findNearest
Summary:
This fixes a failure caused by the revert of https://reviews.llvm.org/rL332805.
Modified:
Author: modocache
Date: Tue Jun 26 13:05:18 2018
New Revision: 335655
URL: http://llvm.org/viewvc/llvm-project?rev=335655=rev
Log:
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Modified:
cfe/trunk/include/clang/AST/ExternalASTSource.h
Modified:
Author: modocache
Date: Sat Jun 23 11:01:02 2018
New Revision: 335420
URL: http://llvm.org/viewvc/llvm-project?rev=335420=rev
Log:
[Sema] isValidCoroutineContext FIXME and citations
Summary:
Add citations to the Coroutines TS to the `isValidCoroutineContext`
function, as well as a FIXME and test
Author: modocache
Date: Sat Jun 23 11:57:26 2018
New Revision: 335422
URL: http://llvm.org/viewvc/llvm-project?rev=335422=rev
Log:
[Coroutines] Less IR for noexcept await_resume
Summary:
In his review of https://reviews.llvm.org/D45860, @GorNishanov suggested
avoiding generating additional
Author: modocache
Date: Fri Jan 5 16:25:40 2018
New Revision: 321917
URL: http://llvm.org/viewvc/llvm-project?rev=321917=rev
Log:
[Driver] Suggest correctly spelled driver options
Summary:
Depends on https://reviews.llvm.org/D41732.
Utilities such as `opt`, when invoked with arguments that are
Author: modocache
Date: Tue Jan 9 13:26:47 2018
New Revision: 322118
URL: http://llvm.org/viewvc/llvm-project?rev=322118=rev
Log:
[Frontend] Remove unused FileMgr in pp arg parse
Summary:
A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203
mentioned that a FileManager should
Author: modocache
Date: Wed Jan 10 12:23:45 2018
New Revision: 30
URL: http://llvm.org/viewvc/llvm-project?rev=30=rev
Log:
[Driver] Test for correct '--version' suggestion
Summary:
The `llvm::OptTable::findNearest` bug fixed in
https://reviews.llvm.org/D41873 manifested itself as the
Author: modocache
Date: Mon Jan 15 13:05:40 2018
New Revision: 322517
URL: http://llvm.org/viewvc/llvm-project?rev=322517=rev
Log:
[Driver] Suggest valid integrated tools
Summary:
There are only two valid integrated Clang driver tools: `-cc1` and
`-cc1as`. If a user asks for an unknown tool,
Author: modocache
Date: Sat Jan 13 09:09:11 2018
New Revision: 322445
URL: http://llvm.org/viewvc/llvm-project?rev=322445=rev
Log:
[Driver] Add "did you mean?" suggestions to -cc1as
Summary:
In https://reviews.llvm.org/D41733, the driver was modified such that,
when a user provided a mispelled
Author: modocache
Date: Sat Jan 13 10:34:07 2018
New Revision: 322447
URL: http://llvm.org/viewvc/llvm-project?rev=322447=rev
Log:
[docs] Use monospace for PCH option flags
Summary:
Use monospace for option flags in the PCH section, instead of the
italics that were being used previously.
I
Author: modocache
Date: Fri Feb 16 06:11:27 2018
New Revision: 325342
URL: http://llvm.org/viewvc/llvm-project?rev=325342=rev
Log:
[Coroutines] Use target-agnostic size_t in test
Summary:
Fix a test failure on ARM hosts that was caused by a difference in the type of
size_t, by using a
ave/clang-cmake-armv7-a15/llvm/tools
>>> /clang/test/SemaCXX/coroutines.cpp:815): candidate function not viable:
>>> requires 2 arguments, but 1 was provided
>>> File /home/buildslave/buildslave/clang-cmake-armv7-a15/llvm/tools
>>> /clang/test/SemaCXX/corouti
s
>> /clang/test/SemaCXX/coroutines.cpp:838): candidate function not viable:
>> requires 4 arguments, but 1 was provided
>> 8 errors generated.
>>
>> Can you take a look?
>>
>> Douglas Yung
>>
>> > -Original Message-
>> > From: c
Author: modocache
Date: Thu Feb 15 12:37:22 2018
New Revision: 325291
URL: http://llvm.org/viewvc/llvm-project?rev=325291=rev
Log:
[Coroutines] Use allocator overload when available
Summary:
Depends on https://reviews.llvm.org/D42605.
An implementation of the behavior described in
Author: modocache
Date: Thu Feb 15 12:09:25 2018
New Revision: 325288
URL: http://llvm.org/viewvc/llvm-project?rev=325288=rev
Log:
[Sema] Toggle diags when finding allocators (NFCI)
Summary:
Many methods in Sema take a `bool Diagnose` parameter. Examples of such
methods include
ovided
> 8 errors generated.
>
> Can you take a look?
>
> Douglas Yung
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of
> > Brian Gesiak via cfe-commits
> > Sent: Thursday, February 15, 2018 12
Author: modocache
Date: Sat Jul 14 11:21:44 2018
New Revision: 337103
URL: http://llvm.org/viewvc/llvm-project?rev=337103=rev
Log:
Add caching when looking up coroutine_traits
Summary:
Currently clang looks up the coroutine_traits ClassTemplateDecl
everytime it looks up the promise type. This is
Author: modocache
Date: Tue Jul 10 18:00:53 2018
New Revision: 336750
URL: http://llvm.org/viewvc/llvm-project?rev=336750=rev
Log:
[SemaCXX] Remove comment from coroutines test, NFC
Summary:
The file name was accidentally included when the test file was added.
Test Plan: check-clang
Modified:
Author: modocache
Date: Tue Jul 10 17:45:48 2018
New Revision: 336748
URL: http://llvm.org/viewvc/llvm-project?rev=336748=rev
Log:
Remove qualtype qualifier in coroutine error to prevent assert in debug
Summary:
A forward-declared coroutine_traits should trip an error; we need
a complete type.
Author: modocache
Date: Sat Apr 21 17:04:35 2018
New Revision: 330530
URL: http://llvm.org/viewvc/llvm-project?rev=330530=rev
Log:
Add tests for llvm-bcanalyzer stream types
Summary:
Add tests for the improved stream type detection added to
`llvm-bcanalyzer` in https://reviews.llvm.org/D41979.
Author: modocache
Date: Sun Apr 1 15:59:22 2018
New Revision: 328949
URL: http://llvm.org/viewvc/llvm-project?rev=328949=rev
Log:
[Coroutines] Find custom allocators in class scope
Summary:
https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723
section [dcl.fct.def.coroutine]/7, but
Author: modocache
Date: Sun Apr 1 16:55:21 2018
New Revision: 328951
URL: http://llvm.org/viewvc/llvm-project?rev=328951=rev
Log:
[Coroutines] Schedule coro-split before asan
Summary:
The docs for the LLVM coroutines intrinsic `@llvm.coro.id` state that
"The second argument, if not null,
Author: modocache
Date: Sun Oct 7 20:08:39 2018
New Revision: 343949
URL: http://llvm.org/viewvc/llvm-project?rev=343949=rev
Log:
[coro]Pass rvalue reference for named local variable to return_value
Summary:
Addressing https://bugs.llvm.org/show_bug.cgi?id=37265.
Implements [class.copy]/33 of
Author: modocache
Date: Sat Nov 3 15:35:17 2018
New Revision: 346074
URL: http://llvm.org/viewvc/llvm-project?rev=346074=rev
Log:
[coroutines] Fix fallthrough warning on try/catch
Summary:
The test case added in this diff would incorrectly warn that control
flow may fall through without
Author: modocache
Date: Mon Sep 3 09:55:02 2018
New Revision: 341327
URL: http://llvm.org/viewvc/llvm-project?rev=341327=rev
Log:
Removing -debug-info-macros from option suggestions test
Summary:
https://reviews.llvm.org/D46776 added better support for prefixes for the
"did you mean ...?"
Author: modocache
Date: Sun Jan 6 19:25:59 2019
New Revision: 350501
URL: http://llvm.org/viewvc/llvm-project?rev=350501=rev
Log:
[SemaCXX] Fix ICE for unexpanded parameter pack
Summary:
The documentation for RecursiveASTVisitor::TraverseDecl states that the
Decl being traversed may be null. In
Author: modocache
Date: Thu Jan 10 17:54:53 2019
New Revision: 350914
URL: http://llvm.org/viewvc/llvm-project?rev=350914=rev
Log:
[AST] Remove ASTContext from getThisType (NFC)
Summary:
https://reviews.llvm.org/D54862 removed the usages of `ASTContext&` from
within the
Author: modocache
Date: Thu Jan 10 18:12:31 2019
New Revision: 350916
URL: http://llvm.org/viewvc/llvm-project?rev=350916=rev
Log:
Adapt to CXXMethodDecl::getThisType change (NFC)
Summary:
https://reviews.llvm.org/D56509 changed the API of the
CXXMethodDecl::getThisType method. Adapt to the
Author: modocache
Date: Sun Mar 24 17:53:10 2019
New Revision: 356865
URL: http://llvm.org/viewvc/llvm-project?rev=356865=rev
Log:
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Summary:
https://reviews.llvm.org/D59076 added a new coroutine error that
prevented
Author: modocache
Date: Fri Mar 15 13:25:49 2019
New Revision: 356296
URL: http://llvm.org/viewvc/llvm-project?rev=356296=rev
Log:
[coroutines][PR40978] Emit error for co_yield within catch block
Summary:
As reported in https://bugs.llvm.org/show_bug.cgi?id=40978, it's an
error to use the
Author: modocache
Date: Fri Mar 22 09:08:29 2019
New Revision: 356774
URL: http://llvm.org/viewvc/llvm-project?rev=356774=rev
Log:
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
The commit https://reviews.llvm.org/rC356296 is causing a regression in nested
catch
Author: modocache
Date: Thu Jan 31 19:30:29 2019
New Revision: 352831
URL: http://llvm.org/viewvc/llvm-project?rev=352831=rev
Log:
[SemaCXX] Param diagnostic matches overload logic
Summary:
Given the following test program:
```
class C {
public:
int A(int a, int& b);
};
int C::A(const int a,
Author: modocache
Date: Sun Jun 2 17:47:32 2019
New Revision: 362348
URL: http://llvm.org/viewvc/llvm-project?rev=362348=rev
Log:
[coroutines][PR41909] Don't build dependent coroutine statements for generic
lambda
Summary:
https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in which
Author: modocache
Date: Tue Aug 13 05:02:25 2019
New Revision: 368675
URL: http://llvm.org/viewvc/llvm-project?rev=368675=rev
Log:
[CodeGen] Disable UBSan for coroutine functions
Summary:
As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html,
the LLVM coroutines
Author: Brian Gesiak
Date: 2019-11-22T11:39:13-05:00
New Revision: 0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f
URL:
https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f
DIFF:
https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f.diff
Author: Brian Gesiak
Date: 2019-12-16T17:43:04-05:00
New Revision: 376cf43729c8025eecbd2969522c5687f2a3919f
URL:
https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f
DIFF:
https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f.diff
Author: modocache
Date: Fri Oct 18 09:59:02 2019
New Revision: 375258
URL: http://llvm.org/viewvc/llvm-project?rev=375258=rev
Log:
[Format] Add format check for throwing negative numbers
Summary:
The code `throw -1;` is currently formatted by clang-format as
`throw - 1;`. This diff adds a fix
Author: Brian Gesiak
Date: 2019-11-30T15:47:58-05:00
New Revision: 8682d29a28772bab0283a141b8701bfaea8881a6
URL:
https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6
DIFF:
https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6.diff
Author: Brian Gesiak
Date: 2020-02-19T01:03:28-05:00
New Revision: 048239e46e490d441f21f3e26073ec38f19e8a10
URL:
https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10
DIFF:
https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10.diff
Author: Brian Gesiak
Date: 2020-04-02T21:44:54-04:00
New Revision: 627e01feb718dd1aa8e184545976b7229de312a2
URL:
https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2
DIFF:
https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2.diff
57 matches
Mail list logo
