[PATCH] D25241: [libcxx] Improve code generation for vector::clear().

brucem added a comment. This was accepted long ago, and then I got sidetracked for a while. Is this still okay to land? https://reviews.llvm.org/D25241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25241: [libcxx] Improve code generation for vector::clear().

This revision was automatically updated to reflect the committed changes. Closed by commit rL298601: [libcxx] Improve code generation for vector::clear(). (authored by brucem). Changed prior to commit: https://reviews.llvm.org/D25241?vs=73790=92796#toc Repository: rL LLVM

[PATCH] D42945: [libc++] Fix misleading indentation.

brucem created this revision. Herald added a reviewer: EricWF. This was picked up via clang-tidy's readability-misleading-indentation check. Repository: rCXX libc++ https://reviews.llvm.org/D42945 Files: include/__string include/algorithm Index: include/algorithm

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 133778. brucem added a comment. More nullptr usage. Repository: rCXX libc++ https://reviews.llvm.org/D43159 Files: include/__locale include/__sso_allocator include/__string include/__threading_support include/algorithm include/bitset

[PATCH] D43167: Fix incorrect indentation.

brucem created this revision. brucem added a reviewer: mclow.lists. Repository: rCXX libc++ https://reviews.llvm.org/D43167 Files: include/ios Index: include/ios === --- include/ios +++ include/ios @@ -670,7 +670,7 @@

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. This fixes a clang-tidy warning when building something that uses this file. Repository: rCXX libc++ https://reviews.llvm.org/D43226 Files: include/__threading_support Index: include/__threading_support

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. In https://reviews.llvm.org/D43159#1004639, @dim wrote: > In https://reviews.llvm.org/D43159#1004625, @EricWF wrote: > > > So my main concern with this patch is that `nullptr` is actually > > `#defined`'ed in C++03 mode. That definition comes from the `__nullptr` > >

[PATCH] D43224: Fix typos.

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. Repository: rCXX libc++ https://reviews.llvm.org/D43224 Files: docs/DesignDocs/AvailabilityMarkup.rst docs/DesignDocs/CapturingConfigInfo.rst Index: docs/DesignDocs/CapturingConfigInfo.rst

[PATCH] D43224: Fix typos.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324989: Fix typos. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43224 Files:

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 133996. brucem added a comment. Addressed minor issues. - Addressed missing __end_ initialization from valarray. - Removed cast that was no longer needed. - Added nullptr usage to include/regex. Repository: rCXX libc++ https://reviews.llvm.org/D43159

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. In https://reviews.llvm.org/D43159#1004617, @jroelofs wrote: > Is it worth adding `-Werror=zero-as-null-pointer-constant` to the build? I'll look at this as a follow up. Repository: rCXX libc++ https://reviews.llvm.org/D43159

[PATCH] D43167: Fix incorrect indentation.

brucem updated this revision to Diff 134002. brucem added a comment. Rebased forward. Repository: rCXX libc++ https://reviews.llvm.org/D43167 Files: include/ios Index: include/ios === --- include/ios +++ include/ios @@

[PATCH] D43167: Fix incorrect indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325087: Fix incorrect indentation. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43167 Files: libcxx/trunk/include/ios

[PATCH] D43277: limits: Use `false` instead of `type(0)`.

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. This fixes warnings when using clang-tidy and the `modernize-use-bool-literals` check. Repository: rCXX libc++ https://reviews.llvm.org/D43277 Files: include/limits Index: include/limits

[PATCH] D43159: Modernize: Use nullptr more.

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. Repository: rCXX libc++ https://reviews.llvm.org/D43159 Files: include/__locale include/__string include/__threading_support include/algorithm include/bitset include/chrono include/fstream

[PATCH] D43277: limits: Use `false` instead of `type(0)`.

brucem added a comment. Herald added a subscriber: christof. Without this, anyone using `clang-tidy` with this check gets 6 system header warnings whenever they transitively have included `limits`. Repository: rCXX libc++ https://reviews.llvm.org/D43277

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

brucem added a comment. This is `modernize-redundant-void-arg`: https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html Repository: rCXX libc++ https://reviews.llvm.org/D43226 ___ cfe-commits mailing list

[PATCH] D62782: Fix -Wdouble-promotion warnings.

brucem added a comment. I'd modified `CMakeLists.txt` to add `-Wdouble-promotion` and removed this line: `-Wno-double-promotion # FIXME: remove me` ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62782/new/ https://reviews.llvm.org/D62782

[PATCH] D43159: Modernize: Use nullptr more.

brucem marked an inline comment as done. brucem added a comment. In D43159#1526215 , @mclow.lists wrote: > What was the result of testing with `-std=c++98` and/or `-std=gnu++98` ? > The code changes look fine; but as @Ericwf said It seems to work

[PATCH] D62782: Fix -Wdouble-promotion warnings.

brucem created this revision. brucem added a reviewer: mclow.lists. Herald added subscribers: ldionne, christof. Repository: rCXX libc++ https://reviews.llvm.org/D62782 Files: include/limits include/utility Index: include/utility

[PATCH] D43159: Modernize: Use nullptr more.

brucem marked 2 inline comments as done. brucem added inline comments. Comment at: include/memory:1259 template static __two __test(...); template static char __test(typename _Xp::template rebind<_Up>::other* = 0); public: zoecarver wrote: > This

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 202554. brucem added a comment. Herald added a subscriber: mgorny. Updated to current master and added more nullptr usage. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 Files:

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. Herald added subscribers: libcxx-commits, jfb, ldionne, christof. Can we revive this review? I'd still like to land this ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

brucem added a comment. Herald added subscribers: libcxx-commits, ldionne. Can we revive this review? I'd still like to land it ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43226/new/ https://reviews.llvm.org/D43226

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 202555. brucem added a comment. Remove CMakeLists.txt change. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 Files: include/__functional_base include/__locale

[PATCH] D62782: Fix -Wdouble-promotion warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364798: Fix -Wdouble-promotion warnings. (authored by brucem, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

This revision was automatically updated to reflect the committed changes. Closed by commit rL364799: __threading_support: Remove (void) in favor of (). (authored by brucem, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 207356. brucem added a comment. Updating to current master. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 Files: include/__locale include/__sso_allocator include/__string

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. In addition to my previous explanation for the concerns about using `nullptr` more ... it should be noted that many of these files already use `nullptr`. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/