Re: [PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

2016-09-19 Thread Daphne Pfister via cfe-commits
daphnediane updated this revision to Diff 71767. daphnediane added a comment. Adds test case, changes to suggested fix allowing break after template opener that is not immediately followed by template closer. https://reviews.llvm.org/D24703 Files: lib/Format/TokenAnnotator.cpp

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

2016-09-18 Thread Daphne Pfister via cfe-commits
daphnediane created this revision. daphnediane added a reviewer: djasper. daphnediane added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fix for the formatting options combination of BreakBeforeBinaryOperators: All, AlignAfterOpenBracket: AlwaysBreak not handling long templates

Re: [PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

2016-09-19 Thread Daphne Pfister via cfe-commits
daphnediane added a comment. In https://reviews.llvm.org/D24703#545917, @djasper wrote: > Looks good. Thank you! Thanks. Are there additional steps I need to get it commited or do I just wait for a commiter to notice? https://reviews.llvm.org/D24703

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

2016-10-30 Thread Daphne Pfister via cfe-commits
daphnediane added a comment. ping. FYI I have found some additional similar cases when AlignConsecutiveDeclarations is also true, that I'll see if I can document/test case etc. at some point. https://reviews.llvm.org/D24703 ___ cfe-commits