[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 145352. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c === --- /dev/null +++

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1485 + state = CheckOverlap(C, state, CE->getArg(2), Dst, srcExpr); + NoQ wrote: > This crashes on the old tests for the checker. I guess that's because the > normal

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. ping https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. Thanks ! I would be grateful if anybody could land it for me. https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1103781, @alexfh wrote: > In https://reviews.llvm.org/D45177#1103774, @devnexen wrote: > > > In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > > > > > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. > > > >

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1560-1566 // If the size is known to be zero, we're done. if (StateZeroSize && !StateNonZeroSize) { StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

devnexen created this revision. devnexen added reviewers: NoQ, george.karpenkov. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Again strlc* does not return a pointer so the zero size case does not fit. Repository: rC Clang

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1102887, @alexfh wrote: > This is reproducible in r332425. I posted this PR https://reviews.llvm.org/D47007 hopes it helps. Repository: rC Clang https://reviews.llvm.org/D45177 ___

[PATCH] D47007: [analyzer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

This revision was automatically updated to reflect the committed changes. Closed by commit rC333060: [analyzer] CStringChecker fix for strlcpy when no bytes are copied to the dest… (authored by devnexen, committed by ). Repository: rC Clang https://reviews.llvm.org/D47007 Files:

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. I admit I do not due to much longer compilation time, I ll recompile all with and will see tomorrow if I can reproduce. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. I was unable to reproduce both FreeBSD and Linux. Plus my changes come after checkNonNull. Repository: rC Clang

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

devnexen added a comment. In https://reviews.llvm.org/D47007#1103551, @george.karpenkov wrote: > Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ? Nope. more for last NoQ comment. Will try for this one once I finish setting it up. Repository: rC Clang

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen created this revision. devnexen added a reviewer: dberris. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Base GNU ld is pretty old and does not support --dynamic-list flag. - For conveniency we can add it automatically when compile

[PATCH] D45149: MallocChecker, adding specific BSD calls

devnexen added a comment. In https://reviews.llvm.org/D45149#1062279, @jdenny wrote: > Hi David. While I did make some superficial changes here recently, I'm no > authority on what belongs here. However, I would suggest that the > refactoring patch be split from the original patch. Thanks.

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 144981. devnexen added a comment. New test to check the length https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. Sure ! looking into it. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 144952. devnexen added a comment. The returned value is the number of character copied to the dst buffer. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index:

[PATCH] D41809: Clang counterpart change for buzzer FreeBSD support

devnexen created this revision. Herald added subscribers: cfe-commits, emaste. Repository: rC Clang https://reviews.llvm.org/D41809 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === ---

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

devnexen updated this revision to Diff 129364. https://reviews.llvm.org/D41809 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === --- lib/Driver/ToolChains/FreeBSD.cpp +++

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

devnexen updated this revision to Diff 131356. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp === ---

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

devnexen updated this revision to Diff 131358. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp === ---

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

devnexen added a comment. In https://reviews.llvm.org/D42467#987140, @krytarowski wrote: > I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now > an option to rebuild these libraries against sanitizers and so stop teaching > the world how to handle its API. > > Please

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

devnexen updated this revision to Diff 131359. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

devnexen added a comment. In https://reviews.llvm.org/D41809#969475, @kimgr wrote: > Typo in the commit title: buzzer :) Changed ... just to follow-up the now accepted change of this one https://reviews.llvm.org/D41642 https://reviews.llvm.org/D41809

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132024. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132054. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132578. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Updated. I ve tried (with few personal code) called as f/ptr, prots set via variable as well. Might sounds obvious to you though this is my first contribution to this :-) Any chance it get pushed ? Just asking I test constantly/carry patches between 3 machines :-)

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Another example with pcre2, more specifically its JIT engine In file included from /home/dcarlier/Contribs/php-src/ext/pcre/pcre2lib/pcre2_jit_compile.c:78: In file included from /home/dcarlier/Contribs/php-src/ext/pcre/pcre2lib/sljit/sljitLir.c:261:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132727. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132728. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#997062, @NoQ wrote: > This failed on the buildbots (for example > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - > committer gets notified of those), so i reverted it for now as r324167. > > I guess the reason

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#996668, @NoQ wrote: > All right, so the code looks good now, but in order to commit this, we also > need tests. We've got those automatic tests of ours in `test/Analysis/` that > feed small code snippets into the analyzer and verify

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132715. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132713. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen created this revision. devnexen added reviewers: dcoughlin, dergachev.a. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, hintonda, mgorny. This new checker tests if both PROT_WRITE and PROT_EXEC have been set. Repository: rC Clang

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132459. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#990771, @a.sidorin wrote: > Hello David, > > Do you have any results of this checker on the real code? If yes, could you > please share them? > There are also some inline comments regarding implementation. I did a quick test on the

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Your remarks make sense. Ok will update the general "tone" accordingly. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132826. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132829. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Correcting last typos in unit test. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132850. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:10 +// +// This checker detects a common memory allocation security flaw. +// Suppose 'unsigned int n' comes from an untrusted source. If the jroelofs wrote: > This

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 131813. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132873. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133008. devnexen added a comment. Both Linux/Darwin unit tests passed. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132969. Herald added a subscriber: emaste. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/ToolChains/FreeBSD.cpp lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#998732, @a.sidorin wrote: > Hello David, > > I have looked into mmap constant definitions in different implementations and > found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and > I even found 0x00 in some

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133010. devnexen added a comment. Will work on most modern Linux/Glibc versions, BSD variants and Illumos. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D43148: Adding msan support for FreeBSD

devnexen created this revision. devnexen added a reviewer: krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Enabling memory sanitiser for X86_64 arch only. To match the sanitiser counterpart. Repository: rC Clang

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen created this revision. devnexen added reviewers: vitalybuka, krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, dberris, emaste. Similarly to the GNU driver version, adding proper compile and linker flags. Repository: rC

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added a comment. Counterpart of the compiler-rt work here https://reviews.llvm.org/D43278 Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); krytarowski wrote: > `-pthread`? Did not seem needed maybe it s different for NetBSD ?

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen updated this revision to Diff 134244. devnexen added a comment. Changing to pthread flag. https://reviews.llvm.org/D43279 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === ---

[PATCH] D43148: Adding msan support for FreeBSD

devnexen updated this revision to Diff 134331. https://reviews.llvm.org/D43148 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === --- lib/Driver/ToolChains/FreeBSD.cpp +++

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133564. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. None of the possible solutions are ideal, but I think I chose the least complex (e.g. via analyzer-config), less edgy one, and 4 is the most common value I ve found so far for PROT_EXEC. Repository: rC Clang https://reviews.llvm.org/D42645

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133164. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134586. devnexen edited the summary of this revision. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp ===

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen created this revision. devnexen added reviewers: krytarowski, vitalybuka, dberris. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. devnexen edited the summary of this revision. -pthread was into linkage step. -Warning about the

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135027. devnexen added a comment. Moving back the checker to alpha.security level. https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135067. devnexen added a comment. Updating tests accordingly https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added inline comments. Comment at: lib/Driver/XRayArgs.cpp:56 +<< (std::string(XRayInstrumentOption) + " only on " +"FreeBSD x86_64"); +} krytarowski wrote: > krytarowski wrote: > > I think it's better to not

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134634. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index:

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134622. devnexen added a comment. Reusing generic message/reformating. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134628. devnexen added a comment. Herald added a subscriber: srhines. Enabling one test for FreeBSD https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134605. devnexen added a comment. Updating the warning messages. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134659. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index: lib/Driver/XRayArgs.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added a comment. In https://reviews.llvm.org/D43378#1010464, @emaste wrote: > LGTM with one small note. > > What will it take for us to enable this on the rest of the platforms > Clang/FreeBSD supports? As I see only x86_64 arch implements everything (e.g. custom event), making

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added inline comments. Comment at: lib/Driver/XRayArgs.cpp:54 +if (Triple.getArch() != llvm::Triple::x86_64) { + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on " + Triple.str());

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135258. devnexen added a comment. Rephrasing Checkers.td comment https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D49873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49906: [Docs] Sanitizer update

devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D49906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 158062. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === ---

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen created this revision. devnexen added a reviewer: pcc. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49873 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D49906: [Docs] Sanitizer update

devnexen created this revision. devnexen added a reviewer: eugenis. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Adding new option detect_write_exec=1 available. Repository: rC Clang https://reviews.llvm.org/D49906 Files:

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 157381. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === ---

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping but will be for 8.0 :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

This revision was automatically updated to reflect the committed changes. Closed by commit rL339641: [CStringSyntaxChecker] Check strlcat sizeof check (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D49906: [Docs] Sanitizer update

devnexen abandoned this revision. devnexen added a comment. Commited in the branch. Repository: rC Clang https://reviews.llvm.org/D49906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen abandoned this revision. devnexen added a comment. Committed in the branch. Repository: rC Clang https://reviews.llvm.org/D49873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 160272. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === ---

[PATCH] D51269: [Xray] Darwin - Enable in the driver side

This revision was automatically updated to reflect the committed changes. Closed by commit rL340712: [Xray] Darwin - Enable in the driver side (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51269: [Xray] Darwin - Enable in the driver side

devnexen added a comment. Good point :-) Repository: rL LLVM https://reviews.llvm.org/D51269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51269: [Xray] Enable in the driver side

devnexen created this revision. devnexen added a reviewer: dberris. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51269 Files: lib/Driver/ToolChains/Darwin.cpp lib/Driver/ToolChains/Darwin.h

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 162139. devnexen added a comment. - Returns immediately for both case when sizeof destination. - Adding few more cases. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index:

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen created this revision. devnexen added reviewers: george.karpenkov, NoQ. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Assuming strlcat is used with strlcpy we check as we can if the last argument does not equal os not larger than the

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. Hopefully will try to push it before the freeze just announced, that s my last change in this area (except potential fixes) :) Repository: rC Clang https://reviews.llvm.org/D49722 ___ cfe-commits mailing list

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen created this revision. devnexen added reviewers: morehouse, krytarowski. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49788 Files: docs/AddressSanitizer.rst

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen added a comment. This is the first time I m involved into a release so I do not know if it s too early to update those docs but with the freeze incoming, I thought it was worth before it get forgotten. Repository: rC Clang https://reviews.llvm.org/D49788

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen added a comment. Ah I forgot NetBSD sorry yes you re right. Repository: rC Clang https://reviews.llvm.org/D49788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen updated this revision to Diff 157237. https://reviews.llvm.org/D49788 Files: docs/AddressSanitizer.rst docs/MemorySanitizer.rst docs/SafeStack.rst docs/ThreadSanitizer.rst docs/UndefinedBehaviorSanitizer.rst Index: docs/UndefinedBehaviorSanitizer.rst

  1   2   3   >