[PATCH] D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion

dgoldman created this revision. Herald added subscribers: cfe-commits, arphaman. Similar to auto-completion for ObjC methods, inherited properties should be penalized / direct class and category properties should be prioritized. Note that currently, the penalty for using a result from a base clas

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric, ilya-biryukov. With ObjCPropertyDecl, ASTNode.OrigD can be a ObjCPropertyImplDecl which is not a NamedDecl, leading to a crash since the code incorrectly assumes ASTNode.OrigD will always b

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182562. dgoldman marked an inline comment as done. dgoldman added a comment. - FIXME and dyn_cast Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: clangd/index/

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman created this revision. Herald added a subscriber: cfe-commits. Since class extensions do not have a name, (class extension) is used instead. Repository: rC Clang https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp Index: lib/AST/Decl.cpp =

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1365357 , @ilya-biryukov wrote: > Good point, @aaron.ballman! @dgoldman, could you please add a test case? Unfortunately I can't get ninja check-clangd to build: /Users/davg/dev/llvm/source/llvm/tools/clang/tools/

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182921. dgoldman marked an inline comment as done. dgoldman added a comment. - use auto Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: clangd/index/SymbolColl

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182942. dgoldman added a comment. Herald added a subscriber: jfb. - FIXME and dyn_cast - use auto - Add test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: cl

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1366456 , @ilya-biryukov wrote: > > Unfortunately I can't get ninja check-clangd to build: > > Looks like `clang-tools-extra` uses an old revision. Rebasing after rL350916 > should d

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 182971. dgoldman added a comment. Herald added a subscriber: jfb. - Add test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedDeclPrinte

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1367559 , @ilya-biryukov wrote: > It looks like `Container::_magic` is a platform-dependent completion, I don't > have it on Linux, but > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/bu

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1367450 , @sammccall wrote: > This is definitely an improvement, though I don't know if it's *right*. > @akyrtzi, thoughts? Yeah, I'm not sure what the desired behavior is. When writing up the test I noticed there is

[PATCH] D53934: [clangd] Improve code completion for ObjC methods

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Previously code completion did not work well for Objective-C methods which contained multiple arguments as clangd did not

[PATCH] D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion

dgoldman added a comment. Since I don't have commit access, sammccall will land this Repository: rC Clang https://reviews.llvm.org/D53900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D53934: [clangd] Improve code completion for ObjC methods

dgoldman updated this revision to Diff 173737. dgoldman added a comment. CodeCompleteTests fixes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53934 Files: clangd/CodeCompletionStrings.cpp unittests/clangd/CodeCompleteTests.cpp unittests/clangd/CodeCompletionStringsTests

[PATCH] D53934: [clangd] Improve code completion for ObjC methods

dgoldman added a comment. Since I don't have commit access, @sammccall will land this. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion

dgoldman added a comment. @sammccall to land this Repository: rC Clang https://reviews.llvm.org/D53900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58062: Support framework import/include auto-completion

dgoldman closed this revision. dgoldman added a comment. Closed via rL355008 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 ___ cfe-commit

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. friendly ping, think this is good to go now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. Friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. In D57965#1417361 , @jkorous wrote: > Hi David, > I am just wondering - while you're here would you mind adding couple more > tests? It would be great to have a test for each attribute. > > Also, what do you think about Ben's su

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 189317. dgoldman added a comment. - Add more tests and improved printing of pointers Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp test/AST/ast-p

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 189318. dgoldman added a comment. - Fix broken test by last change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp test/AST/ast-print-objc-property

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. Herald added a subscriber: dexonsmith. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman updated this revision to Diff 193769. dgoldman added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedDeclPrinterTest.cpp Index: unittests/AST/Nam

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman closed this revision. dgoldman added a comment. Closed via rL357720 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commit

[PATCH] D60326: Fix error in NamedDeclPrinterTest

dgoldman created this revision. dgoldman added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Caused by D56924 , shouldn't use raw string literals in macros. Repository: rC Clang https://reviews

[PATCH] D60326: Fix error in NamedDeclPrinterTest

This revision was automatically updated to reflect the committed changes. Closed by commit rC357799: Fix error in NamedDeclPrinterTest (authored by dgoldman, committed by ). Changed prior to commit: https://reviews.llvm.org/D60326?vs=193917&id=193935#toc Repository: rC Clang CHANGES SINCE L

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 194195. dgoldman added a comment. Herald added a subscriber: dexonsmith. - Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp test/AST/ast-prin

[PATCH] D57965: Clean up ObjCPropertyDecl printing

This revision was automatically updated to reflect the committed changes. Closed by commit rL357937: Clean up ObjCPropertyDecl printing (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 185341. dgoldman added a comment. Herald added a project: clang. - Output class scope for ObjCPropertyDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1379342 , @arphaman wrote: > Do you know if this have an effect on the output of completion results or > other tooling-based output? > > A couple of requests: > > - This behavior should be controlled by a printing polic

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. - `@property(attr, attr2)` instead of `@property ( attr,attr2 )`. - Change priority of attributes (see code/comments inline). - Support for printing weak and unsafe_unretained attri

[PATCH] D58062: Support framework import/include auto-completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Frameworks filesystem representations: UIKit.framework/Headers/%header% Framework import format: #import Thus the completion code must map the input

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186524. dgoldman marked 9 inline comments as done. dgoldman added a comment. Herald added a subscriber: jdoerfert. - Misc fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 Files:

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186904. dgoldman added a comment. - Add test and fix subfolder bug Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/includ

[PATCH] D58062: Support framework import/include auto-completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. added test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D58062: Support framework import/include auto-completion

dgoldman added a comment. In D58062#1399499 , @sammccall wrote: > Great, thank you! Want me to land this? > > (You can certainly get your own commit access at this point if you like: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. ping, looking to get this in to fix a clangd assertion failure Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commi

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 188213. dgoldman added a comment. - Remove (class extension) as it's no longer needed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedD

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. In D56924#1407836 , @arphaman wrote: > Please add a test that covers the '(class extension)' output as well. Removed the `(class extension)` output as the property getter if statement should now handle this. Repository: rC

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As Typo Resolution can create new TypoExprs while resolving typos, it is necessary to recurse through the expression to search for more typos. This should fix the assertion failure in `clang::Se

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202772. dgoldman added a comment. - Fix diagnostics for ignored TypoExprs Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correctio

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7713-7714 + // Add the newly created typos to the TypoExprs list, even if they + // failed to apply. This allows them to be reaped although they won't

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202775. dgoldman marked an inline comment as done. dgoldman added a comment. - Fix discarded correction test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExp

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7762-7787 // Ensure none of the TypoExprs have multiple typo correction candidates // with the same edit length that pass all the checks and filters. //

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202938. dgoldman added a comment. - Remove unused State variable Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursi

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 203011. dgoldman added a comment. - Move if empty check back Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.c

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 210862. dgoldman added a comment. - Minor fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp test/Sem

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 211184. dgoldman added a comment. - Bug fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp Index: test

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman added a comment. In D62648#1596535 , @rsmith wrote: > Thanks, LGTM. Do you need someone to commit this for you? Nope, I can commit it. There's still one outstanding issue though: typo-correction-cxx11.cpp is still failing with the `DelayedTypos

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 211757. dgoldman added a comment. - Fix test failure: typo-correction-cxx11.cpp Make sure that `TryTransform` clears any TypoExprs that are created if it returns an invalid ExprResult (as the new TypoExprs are unreachable from the result). Repository: rC

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 213437. dgoldman added a comment. Fix test failure via `TransformTypos` - Add a new property on Sema to track newly created Typos and use this from within TransformTypos in order to delete any Typos that are unreachable (tested in typo-correction-cxx11.cpp

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 213438. dgoldman added a comment. - remove extra newline Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp lib/Sema/Sema

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 206009. dgoldman added a comment. - Fix ambiguity handling and add more tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-corre

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 206011. dgoldman added a comment. - Add another test and fix up comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 206870. dgoldman marked 9 inline comments as done. dgoldman added a comment. - Minor fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Se

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7762-7764 + llvm::SmallDenseMap NewTransformCache; + auto SavedTransformCache = TransformCache; + TransformCache = NewTransformCache; Should I do the same `std::move` and `clear`

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug introduced in D62648 , where Clang could infinite loop if it became stuck on a single TypoCorrection when it

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman updated this revision to Diff 219978. dgoldman added a comment. - Fix method name in test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67515/new/ https://reviews.llvm.org/D67515 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-ambiguity.cp

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman updated this revision to Diff 220097. dgoldman added a comment. - Fix typo in test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67515/new/ https://reviews.llvm.org/D67515 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-ambiguity.cpp Ind

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL371859: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

dgoldman added a comment. Herald added a subscriber: usaxena95. In D64799#1651908 , @vsapsai wrote: > For the record, there was another change regarding the delayed typos in > `clang::Sema::~Sema()`: D62648 [Sema][Typo]

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Instead of `AppDelegate::application:didFinishLaunchingWithOptions:` you will now see

[PATCH] D69060: [Sema][Typo Correction] Fix another infinite loop on ambiguity

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. See also: D67515 - For the given call expression we would end up repeatedly trying to transform the same expression over and

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. - Similar to that of `clang-fuzzer` itself but instead only targets Objective-C source files via cc1 - Also adds an example corpus directory containing some input for Objective-C

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} dexonsmith wrote: > gribozavr wrote: > > I don't think that `Obj::property` is the preferred syntax. `Obj.property`? > > I'd want a

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. In D69171#1714624 , @sammccall wrote: > Rather than adding a new fuzzer binary, can we make the language an option? > The whole implementation seems almost identical down to > handleobjc/handlecxx... It's similar at the moment

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. Not sure who is best to review, feel free to add someone else instead. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___ cfe-commits mailing list c

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225898. dgoldman added a comment. - Refactor to use handle-cxx Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ClangFu

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225899. dgoldman added a comment. - Swap to reinterpret_cast Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ClangFuzz

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman marked 4 inline comments as done. dgoldman added inline comments. Comment at: tools/clang-fuzzer/handle-objc/handle_objc.cpp:50 +&Diags); +} + morehouse wrote: > Since this is ~identical to handle_cxx, I'd like to reuse the implem

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe5ecba4f53e7: [clang-fuzzer] Add new fuzzer target for Objective-C (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D69171?vs=225899&i

[PATCH] D69060: [Sema][Typo Correction] Fix another infinite loop on ambiguity

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2b704bf0cf: [Sema][Typo Correction] Fix another infinite loop on ambiguity (authored by dgoldman). Changed prior to com

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 7 inline comments as done. dgoldman added a comment. In D83501#2157957 , @sammccall wrote: > In D83501#2154300 , @dgoldman wrote: > > > In D83501#2153605 , @s

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 278752. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor test and formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to detect when certain TypoExprs are not being transformed due to invalid trees, otherwise we risk endlessly trying to fix it. Repository: rG LLVM G

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278876. dgoldman added a comment. - Minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h clang/lib/Sema

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278881. dgoldman added a comment. - CheckAndAdvanceTypoExprCorrectionStreams comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/S

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278890. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h clang/lib/Sema/SemaExprCXX.

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde98c82c0ad: Fix issue in typo handling which could lead clang to hang (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ htt

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 280086. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/XR

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added a comment. In D83501#2173534 , @sammccall wrote: > (Sorry this has been pending a while - I think it's basically there. Only > things we really need to address to land this is have a consistent view of > what the canonical decl is for the

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 280930. dgoldman marked 7 inline comments as done. dgoldman added a comment. - More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-too

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman created this revision. dgoldman added reviewers: sammccall, yvvan. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Exempt ObjC from arrow/dot fixits since this has lim

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/test/CodeCompletion/objc-member-access.m Index:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 268818. dgoldman added a comment. - Fix broken diff base (due to lint fixes maybe?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeCom

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269189. dgoldman added a comment. Check AccessOpFixIt.hasValue() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/t

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269192. dgoldman marked 4 inline comments as done. dgoldman added a comment. Remove stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Se

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5153 - auto DoCompletion = [&](Expr *Base, bool IsArrow, + auto DoCompletion = [&](Expr *Base, bool IsArrow, bool IncludeObjC, Optional AccessOpFixIt) -> bool {

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269269. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/S

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199 + // Objective-C property reference. Bail if we're performing fix-it code + // completion since we don't handle forwarding the fix-it for Objective-C + // objects. Since Objective-

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269271. dgoldman added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/o

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ef65adb6f9d: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ htt

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously clangd would jump to forward declarations for protocols and classes instead of the

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:88-92 + if (const auto *ID = dyn_cast(D)) { +if (const auto *IMD = ID->getImplementation()) + return IMD; +return ID->getDefinition(); + } Let me know if there's a bette

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:276 getDeclAtPosition(AST, CurLoc, Relations, NodeKind)) { // Special case: void foo() ^override: jump to the overridden method. if (const auto *CMD = llvm::dyn_cast(D)) { ---

  1   2   3   4   5   6   >