[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

2020-05-11 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Hi Kerry, I think we do already have some suitable test files where perhaps you could add your tests instead of creating new files? For example, there are: CodeGen/AArch64/sve-int-arith.ll (perhaps integer divides and shifts could live there?)

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

2020-05-11 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Hi @efriedma, is there a target-independent equivalent of SUNPKHI? From a quick glance at the codebase where X86 uses ISD::SIGN_EXTEND_VECTOR_INREG it seems vector shuffles are still required for the Hi part, which is fine for fixed length vectors I guess.

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

2020-05-29 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Hi @efriedma, at least amongst all the tests in llvm/test/CodeGen/AArch64/sve-* there are still 66 with warnings. @sdesmalen and I discussed this and our reason for adding checks for warnings is mainly to do with the fact we are still fixing up cases and implementing

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

2020-05-29 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Hi Kerry, just a couple of comments about the use of getVectorNumElements() - we're trying to remove calls to this function so it would be good if you could use getVectorElementCount() instead. Thanks! Comment at:

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

2020-05-29 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Sorry I forgot to mention I think we have an existing test file for extends: llvm/test/CodeGen/AArch64/sve-sext-zext.ll It might be worth adding these cases to that file instead of creating a new one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread David Sherwood via Phabricator via cfe-commits
david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82182/new/ https://reviews.llvm.org/D82182

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

2020-06-23 Thread David Sherwood via Phabricator via cfe-commits
david-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE_BF16 -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread David Sherwood via Phabricator via cfe-commits
david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. Can you remove the duplicate tests before submitting? Otherwise LGTM! Comment at: llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll:8 + +define @bitcast_bfloat_to_i8(

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

2020-06-16 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Hi @sdesmalen @efriedma , hopefully I've addressed your review comments with my latest patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80712/new/ https://reviews.llvm.org/D80712 ___ cfe-commits mailing list

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-25 Thread David Sherwood via Phabricator via cfe-commits
david-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c:5 + +#include + Hi @fpetrogalli, in the same way that you asked @kmclaughlin if she could add the ASM-NOT check line in her patch, are you

[PATCH] D82746: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR

2020-06-30 Thread David Sherwood via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc02332a69399: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR (authored by david-arm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

2020-07-01 Thread David Sherwood via Phabricator via cfe-commits
david-arm created this revision. david-arm added reviewers: sdesmalen, ctetreau, kmclaughlin. Herald added subscribers: llvm-commits, cfe-commits, psnobl, arphaman, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. There

[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

2020-07-07 Thread David Sherwood via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9a1a7d888b53: [SVE] Add more warnings checks to clang and LLVM SVE tests (authored by david-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82943/new/

[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

2020-07-07 Thread David Sherwood via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9a1a7d888b53: [SVE] Add more warnings checks to clang and LLVM SVE tests (authored by david-arm). Repository: rG LLVM

[PATCH] D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute

2020-08-14 Thread David Sherwood via Phabricator via cfe-commits
david-arm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1342 + if (SrcSize.getKnownMinSize() <= DstSize.getKnownMinSize() || + (isa(SrcTy) || + isa(DstTy))) { I think if you restructure the code here you could do: if (isa(SrcTy) ||