[PATCH] D12110: [SemaExpr] Re-enable missing assertion

davide created this revision. davide added a reviewer: rsmith. davide added a subscriber: cfe-commits. This has been disabled for a long time, but: 1) Initializers work (and apparently they're re reason why this was disabled). 2) various tests happen to hit this code path and the invariant seems

r245404 - [SemaExpr] Re-enable missing assertion.

Author: davide Date: Tue Aug 18 21:21:12 2015 New Revision: 245404 URL: http://llvm.org/viewvc/llvm-project?rev=245404view=rev Log: [SemaExpr] Re-enable missing assertion. This has been disabled for a long time, but: 1) Initializers work (and apparently they're re reason why this was disabled).

r245051 - [Sema] main can't be declared as global variable, in C++.

Author: davide Date: Fri Aug 14 09:13:29 2015 New Revision: 245051 URL: http://llvm.org/viewvc/llvm-project?rev=245051view=rev Log: [Sema] main can't be declared as global variable, in C++. So, we now reject that. We also warn for any external-linkage global variable named main in C, because it

r245162 - [Sema] Be consistent about diagnostic wording: always use cannot.

Author: davide Date: Sat Aug 15 10:23:14 2015 New Revision: 245162 URL: http://llvm.org/viewvc/llvm-project?rev=245162view=rev Log: [Sema] Be consistent about diagnostic wording: always use cannot. Discussed with Richard Smith. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D11658: [Sema] main can't be declared as global variable

davide updated this revision to Diff 31932. davide added a comment. - Refactored check - Added test for -ffreestanding in C - Changed the diagnostic emitted Also, thanks for your time and guidance. http://reviews.llvm.org/D11658 Files: include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

davide added a comment. Gentle Monday morning ping :) Repository: rL LLVM http://reviews.llvm.org/D13854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252793 - [SemaDeclCXX] Use isTemplateParamScope() rather than accessing raw bits.

Author: davide Date: Wed Nov 11 14:06:35 2015 New Revision: 252793 URL: http://llvm.org/viewvc/llvm-project?rev=252793=rev Log: [SemaDeclCXX] Use isTemplateParamScope() rather than accessing raw bits. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

davide added a comment. Gentle ping. Repository: rL LLVM http://reviews.llvm.org/D13854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

davide created this revision. davide added a reviewer: rsmith. davide added a subscriber: cfe-commits. davide set the repository for this revision to rL LLVM. Richard, this implements what you proposed in https://llvm.org/bugs/show_bug.cgi?id=25223 , hopefully in the correct way. This is what we

r250605 - [Frontend] Name variable correctly.

Author: davide Date: Sat Oct 17 01:46:39 2015 New Revision: 250605 URL: http://llvm.org/viewvc/llvm-project?rev=250605=rev Log: [Frontend] Name variable correctly. Reported by: Kim Grasman! Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified:

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

davide added a comment. In http://reviews.llvm.org/D15899#319918, @dim wrote: > In http://reviews.llvm.org/D15899#319902, @davide wrote: > > > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 > > if backported) -- what about people running <= 10.2 ? Isn't this a

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Hmm, probably they can use the new frontend options so it's fine. LGTM. http://reviews.llvm.org/D15899 ___ cfe-commits mailing list

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

davide added a comment. I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 if backported) -- what about people running <= 10.2 ? Isn't this a problem for them? http://reviews.llvm.org/D15899 ___ cfe-commits mailing list

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

davide added a subscriber: davide. davide accepted this revision. davide added a reviewer: davide. davide added a comment. This revision is now accepted and ready to land. The patch looks good, and the changes are localized to the DflyBSD driver so if you tested and works, I'm fine with it. I'll

r256641 - Disable generating movt on FreeBSD.

Author: davide Date: Wed Dec 30 07:53:25 2015 New Revision: 256641 URL: http://llvm.org/viewvc/llvm-project?rev=256641=rev Log: Disable generating movt on FreeBSD. It's sort of an hack, but we have no choice. The linker in the base system doesn't handle that correctly (yet). Once FreeBSD will

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide accepted this revision. davide added a reviewer: davide. davide added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/Tools.cpp:941 @@ -940,3 +940,3 @@ - // The kext linker doesn't know how to deal with movw/movt. - if

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide added a comment. In http://reviews.llvm.org/D15791#317172, @dim wrote: > @davide, any idea whether lld will be able to handle movt correctly? If so, > we might want to make this dependent on `-fuse-ld=bfd` or `-fuse-ld=lld` ? lld/AArch64 can't still handle that properly, so I'd rather

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide closed this revision. davide added a comment. Close, this went in a while ago. Repository: rL LLVM http://reviews.llvm.org/D15791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide added a comment. In http://reviews.llvm.org/D21006#449365, @mehdi_amini wrote: > I'm not sure it is consistent with how we handle -flto, for instance -c means > usually to output an object file, but adding -flto indicates to dump bitcode > instead. I see two alternative approaches:

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide updated this revision to Diff 59679. davide added a comment. Add a test, fix a typo. http://reviews.llvm.org/D21006 Files: lib/Driver/Driver.cpp test/CodeGen/2009-10-20-GlobalDebug.c test/CodeGen/emit-asm.c test/CodeGenCXX/cxx-apple-kext.cpp

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide added a comment. In http://reviews.llvm.org/D21006#449409, @dexonsmith wrote: > I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c > -flto`. > > In effect, with this change, `-flto -S` would silently ignore the `-flto` > flag. That doesn't make sense to me. I

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide added a comment. In http://reviews.llvm.org/D21006#449380, @rafael wrote: > Can you check what GCC does? Sure. $ gcc flto.c -o flto.o -flto -S && cat flto.o |head -n 15 .file "flto.c" .section.gnu.lto_.inline.513e7babbe55b1f8,"e",@progbits .string

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

I agree with Rafael. I ran with -ftime-report for a couple of weeks on a lot of tests and never hit this problem. It actually seems weird we have to handle the timer recursively here as well (I'd like to avoid it at all), but let's see what Richard has to say when he gets to this review. On Wed,

[PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide created this revision. davide added reviewers: rafael, vsk. davide added a subscriber: cfe-commits. See http://reviews.llvm.org/D20735 for more context. Implementing this clang-side is not as terrible as I originally thought. Maybe needs a test case, but I wasn't able to reduce one easily

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide added a comment. ping? http://reviews.llvm.org/D20748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259302 - assert(false) -> llvm_unreachable().

Author: davide Date: Sat Jan 30 02:03:54 2016 New Revision: 259302 URL: http://llvm.org/viewvc/llvm-project?rev=259302=rev Log: assert(false) -> llvm_unreachable(). Modified: cfe/trunk/lib/AST/Expr.cpp cfe/trunk/lib/AST/StmtPrinter.cpp cfe/trunk/lib/Serialization/ASTWriterStmt.cpp

[PATCH] D17787: [Modules] Don't swallow errors when parsing optional attributes

davide created this revision. davide added reviewers: silvas, doug.gregor. davide added a subscriber: cfe-commits. I found this by visual inspection while trying to get up-to-speed on modules, so I'm still uncertain how to test it. If the current one is really the actual behaviour, then parse

Re: [PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

davide added a comment. Hmm, I think you're right. It's not actually that silent (it fails with a fatal error when trying to load/read). That said, I think it might still be valuable to emit a diagnostic -- Richard what do you think? I noticed you reported a very similar problem here:

Re: [PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

davide updated this revision to Diff 50181. davide added a comment. Typo. http://reviews.llvm.org/D18011 Files: include/clang/Basic/DiagnosticFrontendKinds.td lib/Frontend/FrontendActions.cpp test/Modules/Inputs/insufficient-privileges.modulemap Index: lib/Frontend/FrontendActions.cpp

r263060 - [modules] Simplify code logic. NFC.

Author: davide Date: Wed Mar 9 15:09:51 2016 New Revision: 263060 URL: http://llvm.org/viewvc/llvm-project?rev=263060=rev Log: [modules] Simplify code logic. NFC. Modified: cfe/trunk/lib/Basic/Module.cpp Modified: cfe/trunk/lib/Basic/Module.cpp URL:

[PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

davide created this revision. davide added reviewers: rsmith, silvas, doug.gregor. davide added a subscriber: cfe-commits. I stumbled upon this yesterday. Without this patch in palce, the module map load is silently ignored, and this might cause subtle breakages. http://reviews.llvm.org/D18011

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

davide added a subscriber: davide. davide added a comment. LGTM. Repository: rL LLVM http://reviews.llvm.org/D19029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

LGTM. On Tue, Apr 12, 2016 at 2:17 PM, Ed Maste wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for > -static (authored by emaste). > > Changed prior to commit: >

r262789 - [Modules] Don't swallow errors when parsing optional attributes.

Author: davide Date: Sat Mar 5 22:20:05 2016 New Revision: 262789 URL: http://llvm.org/viewvc/llvm-project?rev=262789=rev Log: [Modules] Don't swallow errors when parsing optional attributes. Differential Revision: http://reviews.llvm.org/D17787 Added:

Re: [PATCH] D17787: [Modules] Don't swallow errors when parsing optional attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL262789: [Modules] Don't swallow errors when parsing optional attributes. (authored by davide). Changed prior to commit: http://reviews.llvm.org/D17787?vs=49575=49888#toc Repository: rL LLVM

[PATCH] D17794: [modules] addHeaderInclude() can't fail.

davide created this revision. davide added reviewers: silvas, rsmith, christof. davide added a subscriber: cfe-commits. I noticed that addHeaderInclude() returns bool although it can never fail. I find this a little bit weird from a semantic point of view. My best guess is that the 'bool'

Re: [PATCH] D17794: [modules] addHeaderInclude() can't fail.

davide added a comment. As an added bonus, this simplifies the code a little bit. http://reviews.llvm.org/D17794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17787: [Modules] Don't swallow errors when parsing optional attributes

davide added a reviewer: rsmith. davide updated this revision to Diff 49575. davide added a comment. Added a test. Yes, with the patch we stop immediately if we fail to parse attributes, while the old code kept emitting diagnostics. I like the new behaviour better, but I'll defer the decision

Re: [PATCH] D17794: [modules] addHeaderInclude() can't fail.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262463: [modules] addHeaderInclude() can't fail. (authored by davide). Changed prior to commit: http://reviews.llvm.org/D17794?vs=49578=49581#toc Repository: rL LLVM http://reviews.llvm.org/D17794

r262463 - [modules] addHeaderInclude() can't fail.

Author: davide Date: Wed Mar 2 00:09:18 2016 New Revision: 262463 URL: http://llvm.org/viewvc/llvm-project?rev=262463=rev Log: [modules] addHeaderInclude() can't fail. Differential Revision:http://reviews.llvm.org/D17794 Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp Modified:

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide added a comment. Richard, can you please take a look at this? The more I look at it the more it seems weird that we can recurse in this case, but I may miss something https://reviews.llvm.org/D20748 ___ cfe-commits mailing list

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

This revision was automatically updated to reflect the committed changes. Closed by commit rL276242: [CodeGen] Handle recursion in LLVMIRGeneration Timer. (authored by davide). Changed prior to commit: https://reviews.llvm.org/D20748?vs=58833=64826#toc Repository: rL LLVM

r276242 - [CodeGen] Handle recursion in LLVMIRGeneration Timer.

Author: davide Date: Thu Jul 21 01:28:48 2016 New Revision: 276242 URL: http://llvm.org/viewvc/llvm-project?rev=276242=rev Log: [CodeGen] Handle recursion in LLVMIRGeneration Timer. This can happen when emitting a local decl, which triggers loading a decl imported from an AST file, which we then

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

davide added a comment. The `Sema` bits look fine to me. I'll let Filipe comment on the sanitizer part. https://reviews.llvm.org/D23498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r293848 - [CodeGen] Update test after recent changes in llvm (r293846).

Author: davide Date: Wed Feb 1 18:47:53 2017 New Revision: 293848 URL: http://llvm.org/viewvc/llvm-project?rev=293848=rev Log: [CodeGen] Update test after recent changes in llvm (r293846). Modified: cfe/trunk/test/CodeGen/link-bitcode-file.c Modified:

r293810 - [CodeGen] Update test after recent changes in llvm (r293799).

Author: davide Date: Wed Feb 1 14:43:28 2017 New Revision: 293810 URL: http://llvm.org/viewvc/llvm-project?rev=293810=rev Log: [CodeGen] Update test after recent changes in llvm (r293799). Modified: cfe/trunk/test/CodeGen/link-bitcode-file.c Modified:

r294623 - [CodeGen] Remove unneeded `private`. NFCI.

Author: davide Date: Thu Feb 9 15:19:51 2017 New Revision: 294623 URL: http://llvm.org/viewvc/llvm-project?rev=294623=rev Log: [CodeGen] Remove unneeded `private`. NFCI. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

Re: r294879 - [Driver] Use stem() and not filename().

On Sat, Feb 11, 2017 at 4:19 PM, Rui Ueyama <r...@google.com> wrote: > On Sat, Feb 11, 2017 at 3:44 PM, Davide Italiano via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: davide >> Date: Sat Feb 11 17:44:37 2017 >> New Revision: 294

r294879 - [Driver] Use stem() and not filename().

Author: davide Date: Sat Feb 11 17:44:37 2017 New Revision: 294879 URL: http://llvm.org/viewvc/llvm-project?rev=294879=rev Log: [Driver] Use stem() and not filename(). On Windows the filename might have an extension, namely `.exe`, so the search will fail. Sorry, I don't have a good way to test

r294961 - [PM] Add support for instrumented PGO in the new pass manager (clang-side)

Author: davide Date: Mon Feb 13 10:07:05 2017 New Revision: 294961 URL: http://llvm.org/viewvc/llvm-project?rev=294961=rev Log: [PM] Add support for instrumented PGO in the new pass manager (clang-side) Differential Revision: https://reviews.llvm.org/D29309 Modified:

r279479 - [AST] Remove unused function, to silence a GCC7 warning.

Author: davide Date: Mon Aug 22 16:33:12 2016 New Revision: 279479 URL: http://llvm.org/viewvc/llvm-project?rev=279479=rev Log: [AST] Remove unused function, to silence a GCC7 warning. Modified: cfe/trunk/lib/AST/StmtProfile.cpp Modified: cfe/trunk/lib/AST/StmtProfile.cpp URL:

r283217 - [ThinLTO] Spell `llvm-ar` correctly.

Author: davide Date: Tue Oct 4 08:16:00 2016 New Revision: 283217 URL: http://llvm.org/viewvc/llvm-project?rev=283217=rev Log: [ThinLTO] Spell `llvm-ar` correctly. Modified: cfe/trunk/docs/ThinLTO.rst Modified: cfe/trunk/docs/ThinLTO.rst URL:

[PATCH] D25190: [ThinLTO doc] Fix typo

davide created this revision. davide added reviewers: mehdi_amini, tejohnson. davide added a subscriber: cfe-commits. This looks like an obvious typo to me, but I don't know the whole ThinLTO story, so. https://reviews.llvm.org/D25190 Files: clang/docs/ThinLTO.rst Index:

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Was going to commit the same. Thanks. LGTM. Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

davide added a comment. And yes, if you can add a test case that will be great (there's no bot that caught this upstream) but one of our internal bots did. Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list

r284137 - [ThinLTO] Update doc to include lld (now supported).

Author: davide Date: Thu Oct 13 12:42:38 2016 New Revision: 284137 URL: http://llvm.org/viewvc/llvm-project?rev=284137=rev Log: [ThinLTO] Update doc to include lld (now supported). Differential Revision: https://reviews.llvm.org/D25537 Modified: cfe/trunk/docs/ThinLTO.rst Modified:

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva wrote: > Nice to see this land! > > One nit: > Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user > uses the "gold syntax" then LLD will silently ignore it, which isn't good. > At the very least, can we

[PATCH] D25537: [ThinLTO] Update doc to include lld

davide updated this revision to Diff 74459. davide added a comment. I mentioned that's ELF only. Are you OK with that or you want me to put more detailed info? https://reviews.llvm.org/D25537 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst

[PATCH] D25537: [ThinLTO] Update doc to include lld

davide created this revision. davide added reviewers: tejohnson, mehdi_amini. davide added a subscriber: cfe-commits. https://reviews.llvm.org/D25537 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst === --- docs/ThinLTO.rst +++

r284419 - [Coverage] Update test after r284418.

Author: davide Date: Mon Oct 17 15:06:32 2016 New Revision: 284419 URL: http://llvm.org/viewvc/llvm-project?rev=284419=rev Log: [Coverage] Update test after r284418. We now strip coverage metadata if debug info are not present. Modified: cfe/trunk/test/CodeGen/code-coverage.c Modified:

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

ansparently Do The Right Thing >> when LLD is invoked as if it were gold, so clearly gold compatibility is >> important enough for that. This suggests it is important enough to be >> compatible from a ThinLTO perspective too. >> >> -- Sean Silva >> >> On Thu, Oct

r298160 - [Sema] Unbreak GCC -Werror build (enum compare).

Author: davide Date: Fri Mar 17 17:19:20 2017 New Revision: 298160 URL: http://llvm.org/viewvc/llvm-project?rev=298160=rev Log: [Sema] Unbreak GCC -Werror build (enum compare). Modified: cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp Modified: cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp URL:

r299315 - [Driver] Don't crash on invalid values of -mrelocation-model=.

Author: davide Date: Sat Apr 1 16:07:07 2017 New Revision: 299315 URL: http://llvm.org/viewvc/llvm-project?rev=299315=rev Log: [Driver] Don't crash on invalid values of -mrelocation-model=. This is handled in a similar way we handle invalid -mcode-model. PR: 31840 Added:

r299364 - [TargetInfo] Use llvm::alignOf() instead of rewriting it. NFCI.

Author: davide Date: Mon Apr 3 11:51:39 2017 New Revision: 299364 URL: http://llvm.org/viewvc/llvm-project?rev=299364=rev Log: [TargetInfo] Use llvm::alignOf() instead of rewriting it. NFCI. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

r301339 - [PGO] Update test now that we don't call IndirectCallPromotion.

Author: davide Date: Tue Apr 25 12:48:10 2017 New Revision: 301339 URL: http://llvm.org/viewvc/llvm-project?rev=301339=rev Log: [PGO] Update test now that we don't call IndirectCallPromotion. Modified: cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c Modified:

r301344 - [PGO/tests] Update comment to reflect reality.

Author: davide Date: Tue Apr 25 13:04:31 2017 New Revision: 301344 URL: http://llvm.org/viewvc/llvm-project?rev=301344=rev Log: [PGO/tests] Update comment to reflect reality. Modified: cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c Modified:

r304499 - [CodeGen] Surround assertion with parentheses.

Author: davide Date: Thu Jun 1 18:55:18 2017 New Revision: 304499 URL: http://llvm.org/viewvc/llvm-project?rev=304499=rev Log: [CodeGen] Surround assertion with parentheses. This should placate GCC's -Wparentheses. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified:

r304322 - [CodeGen] Surround assertion with parens and format.

Author: davide Date: Wed May 31 13:51:36 2017 New Revision: 304322 URL: http://llvm.org/viewvc/llvm-project?rev=304322=rev Log: [CodeGen] Surround assertion with parens and format. This should placate GCC7 with -Werror. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified:

r315621 - [SemaChecking] Suppress a GCC warning. NFCI.

Author: davide Date: Thu Oct 12 14:08:29 2017 New Revision: 315621 URL: http://llvm.org/viewvc/llvm-project?rev=315621=rev Log: [SemaChecking] Suppress a GCC warning. NFCI. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL:

r314605 - [Analysis] Remove unused makeLvalueToRValue variant.

Author: davide Date: Sat Sep 30 14:49:15 2017 New Revision: 314605 URL: http://llvm.org/viewvc/llvm-project?rev=314605=rev Log: [Analysis] Remove unused makeLvalueToRValue variant. Modified: cfe/trunk/lib/Analysis/BodyFarm.cpp Modified: cfe/trunk/lib/Analysis/BodyFarm.cpp URL:

r314367 - [Targets/X86] Remove unneded `return` in setMaxAtomicWidth(). NFCI.

Author: davide Date: Wed Sep 27 17:24:20 2017 New Revision: 314367 URL: http://llvm.org/viewvc/llvm-project?rev=314367=rev Log: [Targets/X86] Remove unneded `return` in setMaxAtomicWidth(). NFCI. Modified: cfe/trunk/lib/Basic/Targets/X86.h Modified: cfe/trunk/lib/Basic/Targets/X86.h URL:

Re: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

g:8011/builders/clang-cmake-armv7-a15/builds/15940/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-info-section-macho.c > > Thanks > Yvan > > On 23 February 2018 at 02:25, Davide Italiano via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> Author: davide

r325850 - [Darwin] Add a test to check clang produces accelerator tables.

Author: davide Date: Thu Feb 22 17:25:03 2018 New Revision: 325850 URL: http://llvm.org/viewvc/llvm-project?rev=325850=rev Log: [Darwin] Add a test to check clang produces accelerator tables. This test was previously in lldb, and was only checking that clang was emitting the correct section. So,

Re: [PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via Phabricator wrote: > > dexonsmith added a comment. > > In https://reviews.llvm.org/D48892#1153473, @davide wrote: > > > The lldb bot started failing very recently and the blamelist hints at this > > change. > > > >

Re: [PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

On Thu, Jul 5, 2018 at 11:46 AM Louis Dionne via Phabricator wrote: > > ldionne added a comment. > > I reverted this commit. Sorry for the blunder. I'll take a look at why LLDB's > tests are doing this. > No need to revert this immediately. I can probably take a look and fix what the lldb tests

Re: [PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

On Thu, Jul 5, 2018 at 11:49 AM Davide Italiano via llvm-commits wrote: > > On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via > Phabricator wrote: > > > > dexonsmith added a comment. > > > > In https://reviews.llvm.org/D48892#1153473, @davide wrote: > > > > > The lldb bot started

r345643 - Revert "[ASTImporter] Reorder fields after structure import is finished"

Author: davide Date: Tue Oct 30 13:46:29 2018 New Revision: 345643 URL: http://llvm.org/viewvc/llvm-project?rev=345643=rev Log: Revert "[ASTImporter] Reorder fields after structure import is finished" This reverts commit r345545 because it breaks some lldb tests. Modified:

r347794 - Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter."

Author: davide Date: Wed Nov 28 11:15:23 2018 New Revision: 347794 URL: http://llvm.org/viewvc/llvm-project?rev=347794=rev Log: Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter." This broke the lldb bots. Modified: cfe/trunk/include/clang/AST/ASTImporter.h

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/dcci approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

https://github.com/dcci commented: LG https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

dcci wrote: Hitting the same problem on a bunch of services. I am going to revert this to unblock people, our repro is similar enough to the one Jeremy shared. ``` $ ./exe clang -cc1 version 18.0.0git based upon LLVM 18.0.0git default target x86_64-redhat-linux-gnu clang++:

[clang] b6f922f - Revert "[CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (#75385)"

Author: Davide Italiano Date: 2024-01-16T17:01:01-08:00 New Revision: b6f922fbf5e983122271aa12acb33f6172046d4d URL: https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d DIFF:

[clang] [llvm] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

dcci wrote: Reverted in https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d https://github.com/llvm/llvm-project/pull/75385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org