Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 61567. dberris added a comment. - Merge branch 'master' of http://llvm.org/git/clang into xray - Merge branch 'master' of http://llvm.org/git/clang into xray - Add runtime support for XRay http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td

Re: [PATCH] D20352: Add XRay flags to Clang

dberris added inline comments. Comment at: include/clang/Basic/Attr.td:436 @@ +435,3 @@ + CXX11<"clang", "xray_never_instrument">]; + let Subjects = SubjectList<[CXXMethod, ObjCMethod, Function], WarnDiag, +

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 62056. dberris marked 2 inline comments as done. dberris added a comment. - Undo formatting changes - Re-apply changes post-review - Address more comments http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 61932. dberris marked 2 inline comments as done. dberris added a comment. - Address review comments; see details. http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td

Re: [PATCH] D20352: Add XRay flags to Clang

dberris marked an inline comment as done. Comment at: include/clang/Basic/Attr.td:432 @@ +431,3 @@ + CXX11<"clang", "xray_always_instrument">]; + let Subjects = SubjectList<[CXXMethod, Function], WarnDiag, +

[PATCH] D21830: Remove -mrelax-all from Clang -O0

dberris created this revision. dberris added reviewers: echristo, rafael, grosbach. dberris added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Remove the -mrelax-all options passed onto the integrated assembler in -O0. http://reviews.llvm.org/D21830 Files:

Re: r275368 - Add C++ dependencies to xray runtime

Thanks Mikael -- this has been fixed in r275377 ( http://reviews.llvm.org/rL275377). On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén wrote: > Hi, > > Your commit > > Add C++ dependencies to xray runtime > > Doesn't compile with gcc. At least 5.3 and 4.8.4

Re: [PATCH] D20352: Add XRay flags to Clang

dberris added a comment. It looks like I was using `hasArg` instead of `hasFlag`. The dangerous part here is that OptSpecifier has an unsigned non-explicit argument, and I suspect `bool` is being promoted to `unsigned` silently with clang/gcc. http://reviews.llvm.org/D20352

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 63775. dberris added a comment. - Use hasFlag instead of hasArg http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 63771. dberris added a comment. Rebase http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

r275368 - Add C++ dependencies to xray runtime

Author: dberris Date: Wed Jul 13 23:58:44 2016 New Revision: 275368 URL: http://llvm.org/viewvc/llvm-project?rev=275368=rev Log: Add C++ dependencies to xray runtime Summary: Depends on D21982 which implements the in-memory logging implementation of the XRay runtime. These additional changes

Re: [PATCH] D21983: Add C++ dependencies to xray runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rL275368: Add C++ dependencies to xray runtime (authored by dberris). Changed prior to commit: http://reviews.llvm.org/D21983?vs=63917=63919#toc Repository: rL LLVM http://reviews.llvm.org/D21983

[PATCH] D22338: Use hasFlag instead of hasArg

dberris created this revision. dberris added a reviewer: echristo. dberris added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Fix the build to use hasFlag instead of hasArg for checking some flags. http://reviews.llvm.org/D22338 Files: lib/Driver/Tools.cpp Index:

Re: [PATCH] D21983: Add C++ dependencies to xray runtime

dberris updated this revision to Diff 63916. dberris added a comment. Rebase http://reviews.llvm.org/D21983 Files: lib/CodeGen/CodeGenFunction.cpp lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp

Re: [PATCH] D21983: Add C++ dependencies to xray runtime

dberris updated this revision to Diff 63917. dberris added a comment. - Undo unnecessary formatting change http://reviews.llvm.org/D21983 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp +++

Re: [PATCH] D22338: Use hasFlag instead of hasArg

This revision was automatically updated to reflect the committed changes. Closed by commit rL275377: Use hasFlag instead of hasArg (authored by dberris). Changed prior to commit: http://reviews.llvm.org/D22338?vs=63922=63923#toc Repository: rL LLVM http://reviews.llvm.org/D22338 Files:

r275377 - Use hasFlag instead of hasArg

Author: dberris Date: Thu Jul 14 01:37:46 2016 New Revision: 275377 URL: http://llvm.org/viewvc/llvm-project?rev=275377=rev Log: Use hasFlag instead of hasArg Summary: Fix the build to use hasFlag instead of hasArg for checking some flags. Reviewers: echristo Subscribers: mehdi_amini,

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

dberris added a subscriber: dberris. dberris added a comment. Mostly wording comments, thank you for writing this up! Comment at: docs/Proposals/GitHub.rst:78 @@ +77,3 @@ + +GitHub, like GitLab and BitBucket, provide FREE code hosting for open source +projects. Essentially,

r275570 - XRay: Remove duplicate checks for xray instrumentation flags

Author: dberris Date: Fri Jul 15 10:46:39 2016 New Revision: 275570 URL: http://llvm.org/viewvc/llvm-project?rev=275570=rev Log: XRay: Remove duplicate checks for xray instrumentation flags Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

[PATCH] D21983: Add C++ dependencies to xray runtime

dberris created this revision. dberris added reviewers: echristo, rnk, aaron.ballman. dberris added a subscriber: cfe-commits. dberris added dependencies: D20352: Add XRay flags to Clang, D21982: WIP: Implement a per-thread inmemory log. Herald added a subscriber: mehdi_amini. Depends on D21982

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 62720. dberris added a comment. Rebase harder. http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D20352: Add XRay flags to Clang

dberris marked 2 inline comments as done. Comment at: include/clang/Basic/Attr.td:436 @@ +435,3 @@ + CXX11<"clang", "xray_never_instrument">]; + let Subjects = SubjectList<[CXXMethod, ObjCMethod, Function], WarnDiag, +

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 62824. dberris marked an inline comment as done. dberris added a comment. - Formatting changes http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 63039. dberris added a comment. Undo previous change -- updated the wrong patch. :( http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td

Re: [PATCH] D21983: Add C++ dependencies to xray runtime

dberris updated this revision to Diff 63040. dberris added a comment. - Check first whether `D` is actually not nullptr http://reviews.llvm.org/D21983 Files: lib/CodeGen/CodeGenFunction.cpp lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 63038. dberris added a comment. - Check first whether `D` is actually not nullptr http://reviews.llvm.org/D20352 Files: lib/CodeGen/CodeGenFunction.cpp lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 63041. dberris added a comment. - Check D is valid before using it http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D21983: Add C++ dependencies to xray runtime

dberris updated this revision to Diff 63042. dberris added a comment. Rebase http://reviews.llvm.org/D21983 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp +++ lib/Driver/Tools.cpp @@

Re: [PATCH] D20352: Add XRay flags to Clang

dberris added a comment. Thanks -- I don't have commit powers yet, do either of you mind landing this for me? Cheers http://reviews.llvm.org/D20352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

dberris added a comment. Changed the description to provide a justification. http://reviews.llvm.org/D21830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

dberris added a comment. Landing this one now. https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280889 - [XRay] ARM 32-bit no-Thumb support in Clang

Author: dberris Date: Wed Sep 7 19:23:28 2016 New Revision: 280889 URL: http://llvm.org/viewvc/llvm-project?rev=280889=rev Log: [XRay] ARM 32-bit no-Thumb support in Clang Just a test for now, adapted from x86_64 tests of XRay. This is one of 3 commits to different repositories of XRay ARM

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

dberris closed this revision. dberris added a comment. This has been landed as https://reviews.llvm.org/rL280889. https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. See comments in https://reviews.llvm.org/D23931 for more details. https://reviews.llvm.org/D23932 ___ cfe-commits mailing list

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

dberris reopened this revision. dberris added a comment. This revision is now accepted and ready to land. Reverted in https://reviews.llvm.org/rL280968 -- we should resolve https://reviews.llvm.org/D23931 before attempting to land again. https://reviews.llvm.org/D23932

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added inline comments. Comment at: lib/Driver/Tools.cpp:4777-4780 @@ +4776,6 @@ +{ + std::string Feature(XRayInstrumentOption); + Feature += " on "; + Feature += Triple.getArchName().data(); + D.Diag(diag::err_drv_clang_unsupported) << Feature; +

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. Are we sure this will not fail on Windows? i.e. have you built/run the tests on Windws ARM or X86_64? > Tools.cpp:4787 > options::OPT_fnoxray_instrument,

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris requested changes to this revision. dberris added a subscriber: rengolin. dberris added a comment. This revision now requires changes to proceed. I'm not sure whether the exhaustive list scales though... is there a better way of doing this? Maybe @rengolin has better ideas here?

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

This revision was automatically updated to reflect the committed changes. Closed by commit rL283193: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument… (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D24799?vs=72554=73424#toc Repository:

r283193 - [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

Author: dberris Date: Tue Oct 4 03:22:47 2016 New Revision: 283193 URL: http://llvm.org/viewvc/llvm-project?rev=283193=rev Log: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed Added the code which explicitly emits an error in Clang in case

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris reopened this revision. dberris added a comment. This revision is now accepted and ready to land. This broke the build on i686. TEST 'Clang :: Driver/xray-instrument.c' FAILED Script: --

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added inline comments. > rSerge wrote in Tools.cpp:4787 > Is there any advantage over `const char* const` here? This same value is turned into a string later on anyway. You can make it a std::string and std::move(...) it at the call to CmdArgs.push_back(...). > rSerge wrote in

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. In https://reviews.llvm.org/D24799#561106, @rSerge wrote: > My mistake was that initially I only enumerated the unsupported targets from > llvm\include\llvm\ADT\Triple.h . Now I've added also the cases from > llvm\lib\Support\Triple.cpp . > `XFAIL` requires a list of

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL281879: [XRay] ARM 32-bit no-Thumb support in Clang (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D23932?vs=71635=71765#toc Repository: rL LLVM

r281879 - [XRay] ARM 32-bit no-Thumb support in Clang

Author: dberris Date: Sun Sep 18 19:59:19 2016 New Revision: 281879 URL: http://llvm.org/viewvc/llvm-project?rev=281879=rev Log: [XRay] ARM 32-bit no-Thumb support in Clang Just a test for now, adapted from x86_64 tests of XRay. This is one of 3 commits to different repositories of XRay ARM

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. In https://reviews.llvm.org/D24799#549634, @rSerge wrote: > In https://reviews.llvm.org/D24799#549442, @dberris wrote: > > > What does the error actually look like? Can you add a test for it? It's > > unclear to me how this would read... for example does it say "XRay

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

dberris accepted this revision. dberris added a comment. Concur 100% with @rengolin here -- please land after the LLVM changes land. :) https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. In https://reviews.llvm.org/D24799#55, @rSerge wrote: > @dberris , could you deliver this patch to mainline? Or do we need approval > from more reviewers? Yes, I can do this -- sorry it was the long weekend for me down under. I'll get to this today. :)

[PATCH] D26024: [Xray] Don't generate output for xray tests

dberris accepted this revision. dberris added a comment. Yes, thanks (and sorry for missing this). https://reviews.llvm.org/D26024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Thanks @rSerge -- I'll land this now. https://reviews.llvm.org/D24799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. Actually I tried again, but still the patch doesn't apply cleanly through git (and it still complains of whitespace issues). Let me go through this manually again, and see whether there are still failures that come up. https://reviews.llvm.org/D24799

r285266 - [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

Author: dberris Date: Wed Oct 26 23:56:14 2016 New Revision: 285266 URL: http://llvm.org/viewvc/llvm-project?rev=285266=rev Log: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed Summary: Added the code which explicitly emits an error in Clang in case

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

This revision was automatically updated to reflect the committed changes. Closed by commit rL285266: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument… (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D24799?vs=75452=75980#toc Repository:

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. It was in the .cpp file, and was mostly trailing whitespace. This is what I did: curl https://reviews.llvm.org/file/data/d72xn56ybspvx3ovex36/PHID-FILE-vzd63mvia62eq7e32iho/D24799.diff | git apply - -p0 --whitespace=fix And I got the following: :6: trailing

[PATCH] D26415: [XRay] Support AArch64 in Clang

dberris added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 if (Triple.getOS() == llvm::Triple::Linux && (Triple.getArch() == llvm::Triple::arm || - Triple.getArch() == llvm::Triple::x86_64)) { + Triple.getArch() ==

[PATCH] D26415: [XRay] Support AArch64 in Clang

dberris added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 +if (Triple.getOS() != llvm::Triple::Linux) + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on non-Linux target OS."); +switch (Triple.getArch())

[PATCH] D26415: [XRay] Support AArch64 in Clang

dberris added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 if (Triple.getOS() == llvm::Triple::Linux && (Triple.getArch() == llvm::Triple::arm || - Triple.getArch() == llvm::Triple::x86_64)) { + Triple.getArch() ==

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. In https://reviews.llvm.org/D24799#566507, @rSerge wrote: > I have extended this feature to check for OS support too (currently Linux > only). I can't commit it so far because I don't know how to implement a test. > XFAIL cannot check for both CPU and OS: it can only

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. Sorry for the delay, I had thought I pointed to some potentially helpful documentation. :/ BTW, did the test get removed from the latest change? I don't see it being added anymore. https://reviews.llvm.org/D24799 ___

[PATCH] D26415: [XRay] Support AArch64 in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL287518: [XRay] Support AArch64 in Clang (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D26415?vs=78216=78685#toc Repository: rL LLVM https://reviews.llvm.org/D26415

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. Sorry, I forgot to update the status. I made a few more comments to make this part a little more readable. https://reviews.llvm.org/D24799

r298670 - [XRay] Do not depend on C++ stdlib for XRay builds

Author: dberris Date: Thu Mar 23 19:20:05 2017 New Revision: 298670 URL: http://llvm.org/viewvc/llvm-project?rev=298670=rev Log: [XRay] Do not depend on C++ stdlib for XRay builds Summary: Now that XRay doesn't require a runtime dependency on a C++ standard library, we remove that dependency

r298835 - [XRay][clang] Remove dependency on libatomic for XRay builds

Author: dberris Date: Mon Mar 27 02:14:11 2017 New Revision: 298835 URL: http://llvm.org/viewvc/llvm-project?rev=298835=rev Log: [XRay][clang] Remove dependency on libatomic for XRay builds Summary: This change depends on D31381 where we change the implementation to use sanitizer_common provided

r299127 - fixup: use CHECK for non-atttribute sets

Author: dberris Date: Thu Mar 30 17:46:49 2017 New Revision: 299127 URL: http://llvm.org/viewvc/llvm-project?rev=299127=rev Log: fixup: use CHECK for non-atttribute sets Modified: cfe/trunk/test/CodeGen/xray-instruction-threshold.cpp Modified:

r299126 - [XRay][clang] Fix the -fxray-instruction-threshold flag processing

Author: dberris Date: Thu Mar 30 17:46:45 2017 New Revision: 299126 URL: http://llvm.org/viewvc/llvm-project?rev=299126=rev Log: [XRay][clang] Fix the -fxray-instruction-threshold flag processing Summary: The refactoring introduced a regression in the flag processing for

r299041 - [XRay] Add -fxray-{always, never}-instrument= flags to clang

Author: dberris Date: Wed Mar 29 19:29:36 2017 New Revision: 299041 URL: http://llvm.org/viewvc/llvm-project?rev=299041=rev Log: [XRay] Add -fxray-{always,never}-instrument= flags to clang Summary: The -fxray-always-instrument= and -fxray-never-instrument= flags take filenames that are used to

Re: [PATCH] D30388: [XRay] Add -fxray-{always,never}-instrument= flags to clang

Oops, thanks -- yes, I'll make that change now. On Thu, Mar 30, 2017 at 12:03 PM Andrew Ford via Phabricator < revi...@reviews.llvm.org> wrote: > andrewford added a comment. > > Hi, this breaks the android build due to use of std::to_string. > llvm::to_string should be used instead. I would fix

Re: [PATCH] D30388: [XRay] Add -fxray-{always,never}-instrument= flags to clang

Fix committed in r299044. On Thu, Mar 30, 2017 at 12:12 PM Dean Michael Berris wrote: > Oops, thanks -- yes, I'll make that change now. > > On Thu, Mar 30, 2017 at 12:03 PM Andrew Ford via Phabricator < > revi...@reviews.llvm.org> wrote: > > andrewford added a comment. > >

r299044 - [XRay][clang] Use llvm::to_string instead of std::string

Author: dberris Date: Wed Mar 29 20:05:09 2017 New Revision: 299044 URL: http://llvm.org/viewvc/llvm-project?rev=299044=rev Log: [XRay][clang] Use llvm::to_string instead of std::string This should unbreak some bots. Follow-up on D30388. Modified: cfe/trunk/lib/Driver/XRayArgs.cpp

Re: r298976 - [OpenCL] Added parsing for OpenCL vector types.

This seems to have broken multiple builds. On Wed, Mar 29, 2017 at 4:20 PM Egor Churaev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echuraev > Date: Wed Mar 29 00:08:18 2017 > New Revision: 298976 > > URL: http://llvm.org/viewvc/llvm-project?rev=298976=rev > Log: > [OpenCL]

Re: r298976 - [OpenCL] Added parsing for OpenCL vector types.

Thanks Egor! On Wed, Mar 29, 2017 at 4:51 PM Egor Churaev wrote: > I see it. I'm reverting this patch and I'll investigate why it has happend. > > 2017-03-29 8:43 GMT+03:00 Dean Michael Berris : > > This seems to have broken multiple builds. > > On

r296999 - [XRay] [clang] Allow logging the first argument of a function call.

Author: dberris Date: Mon Mar 6 01:08:21 2017 New Revision: 296999 URL: http://llvm.org/viewvc/llvm-project?rev=296999=rev Log: [XRay] [clang] Allow logging the first argument of a function call. Summary: Functions with the "xray_log_args" attribute will tell LLVM to emit a special XRay sled

r305544 - [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

Author: dberris Date: Thu Jun 15 22:22:09 2017 New Revision: 305544 URL: http://llvm.org/viewvc/llvm-project?rev=305544=rev Log: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions Summary: Before this change, we couldn't capture the `this` pointer that's

r302492 - [XRay] Add __xray_customeevent(...) as a clang-supported builtin

Author: dberris Date: Mon May 8 19:45:40 2017 New Revision: 302492 URL: http://llvm.org/viewvc/llvm-project?rev=302492=rev Log: [XRay] Add __xray_customeevent(...) as a clang-supported builtin Summary: We define the `__xray_customeevent` builtin that gets translated to IR calls to the correct

r314177 - [XRay][Driver] Do not link in XRay runtime in shared libs

Author: dberris Date: Mon Sep 25 16:40:33 2017 New Revision: 314177 URL: http://llvm.org/viewvc/llvm-project?rev=314177=rev Log: [XRay][Driver] Do not link in XRay runtime in shared libs Summary: This change ensures that we don't link in the XRay runtime when building shared libraries with

r314178 - Revert "[XRay][Driver] Do not link in XRay runtime in shared libs"

Author: dberris Date: Mon Sep 25 17:41:08 2017 New Revision: 314178 URL: http://llvm.org/viewvc/llvm-project?rev=314178=rev Log: Revert "[XRay][Driver] Do not link in XRay runtime in shared libs" Reverts r314177. Removed: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp Modified:

r314193 - [XRay] Run command once without piping to FileCheck

Author: dberris Date: Mon Sep 25 21:17:37 2017 New Revision: 314193 URL: http://llvm.org/viewvc/llvm-project?rev=314193=rev Log: [XRay] Run command once without piping to FileCheck This allows us to debug the failures that come up from the build bots. Follow-up to D38226. Modified:

r314190 - [XRay] Remove -fPIC from shared build test.

Author: dberris Date: Mon Sep 25 21:00:41 2017 New Revision: 314190 URL: http://llvm.org/viewvc/llvm-project?rev=314190=rev Log: [XRay] Remove -fPIC from shared build test. Follow-up to D38226. Modified: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp Modified:

r314194 - [XRay] Avoid actual linking when testing the driver

Author: dberris Date: Mon Sep 25 21:29:25 2017 New Revision: 314194 URL: http://llvm.org/viewvc/llvm-project?rev=314194=rev Log: [XRay] Avoid actual linking when testing the driver Use -### in the command to see just look for the output of -v. Follow-up to D38226. Modified:

r314188 - [XRay][Driver] Do not link in XRay runtime in shared libs

Author: dberris Date: Mon Sep 25 20:18:11 2017 New Revision: 314188 URL: http://llvm.org/viewvc/llvm-project?rev=314188=rev Log: [XRay][Driver] Do not link in XRay runtime in shared libs Summary: This change ensures that we don't link in the XRay runtime when building shared libraries with

r314189 - [XRay] Stop running tests for 'amd64', and remove -fPIE from tests.

Author: dberris Date: Mon Sep 25 20:45:37 2017 New Revision: 314189 URL: http://llvm.org/viewvc/llvm-project?rev=314189=rev Log: [XRay] Stop running tests for 'amd64', and remove -fPIE from tests. Follow-up to D38226. Modified: cfe/trunk/test/Driver/XRay/lit.local.cfg

r314191 - [XRay] Only run shared tests when 'enable_shared' is true

Author: dberris Date: Mon Sep 25 21:07:45 2017 New Revision: 314191 URL: http://llvm.org/viewvc/llvm-project?rev=314191=rev Log: [XRay] Only run shared tests when 'enable_shared' is true Follow-up to D38226. Modified: cfe/trunk/test/Driver/XRay/lit.local.cfg

r319388 - [XRay][clang] Introduce -fxray-always-emit-customevents

Author: dberris Date: Wed Nov 29 16:04:54 2017 New Revision: 319388 URL: http://llvm.org/viewvc/llvm-project?rev=319388=rev Log: [XRay][clang] Introduce -fxray-always-emit-customevents Summary: The -fxray-always-emit-customevents flag instructs clang to always emit the LLVM IR for calls to the

r317875 - [XRay][darwin] Initial XRay in Darwin Support

Author: dberris Date: Thu Nov 9 21:50:13 2017 New Revision: 317875 URL: http://llvm.org/viewvc/llvm-project?rev=317875=rev Log: [XRay][darwin] Initial XRay in Darwin Support Summary: This change implements the changes required in both clang and compiler-rt to allow building XRay-instrumented

r317877 - Revert "[XRay][darwin] Initial XRay in Darwin Support"

Author: dberris Date: Thu Nov 9 23:00:55 2017 New Revision: 317877 URL: http://llvm.org/viewvc/llvm-project?rev=317877=rev Log: Revert "[XRay][darwin] Initial XRay in Darwin Support" This reverts r317875. Modified: cfe/trunk/include/clang/Driver/XRayArgs.h

r339662 - [XRay][clang] Add more test cases of -fxray-modes= (NFC)

Author: dberris Date: Tue Aug 14 02:16:37 2018 New Revision: 339662 URL: http://llvm.org/viewvc/llvm-project?rev=339662=rev Log: [XRay][clang] Add more test cases of -fxray-modes= (NFC) This confirms expectations for multiple values provided through the driver when selecting specific modes and

r329376 - [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

Author: dberris Date: Thu Apr 5 22:28:54 2018 New Revision: 329376 URL: http://llvm.org/viewvc/llvm-project?rev=329376=rev Log: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly Summary: This change introduces `-fxray-link-deps` and `-fnoxray-link-deps`. The

r329372 - [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

Author: dberris Date: Thu Apr 5 20:53:04 2018 New Revision: 329372 URL: http://llvm.org/viewvc/llvm-project?rev=329372=rev Log: [XRay][clang] Consolidate runtime and link-time flag processing (NFC) Summary: This change fixes http://llvm.org/PR36985 to define a single place in CommonArgs.{h,cpp}

r329378 - [XRay][clang] Only run driver test for Linux and FreeBSD

Author: dberris Date: Thu Apr 5 23:09:57 2018 New Revision: 329378 URL: http://llvm.org/viewvc/llvm-project?rev=329378=rev Log: [XRay][clang] Only run driver test for Linux and FreeBSD This is a follow-up to D45354, which we should have only been running on Linux and FreeBSD for specific

r329779 - Adding fuzzer flags support to OpenBSD driver

Author: dberris Date: Tue Apr 10 22:40:47 2018 New Revision: 329779 URL: http://llvm.org/viewvc/llvm-project?rev=329779=rev Log: Adding fuzzer flags support to OpenBSD driver Summary: - Following-up the sanitizer's part commit https://reviews.llvm.org/rCRT329631, we enable fuzzer flags.

r329183 - [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD

Author: dberris Date: Wed Apr 4 05:47:49 2018 New Revision: 329183 URL: http://llvm.org/viewvc/llvm-project?rev=329183=rev Log: [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD Summary: This patch was originally reviewed in D45126. It enables clang to add the XRay

r329543 - [XRay][llvm+clang] Consolidate attribute list files

Author: dberris Date: Sun Apr 8 21:02:09 2018 New Revision: 329543 URL: http://llvm.org/viewvc/llvm-project?rev=329543=rev Log: [XRay][llvm+clang] Consolidate attribute list files Summary: This change consolidates the always/never lists that may be provided to clang to externally control which

r329989 - [XRay][clang] Make -fxray-modes= additive

Author: dberris Date: Thu Apr 12 22:59:57 2018 New Revision: 329989 URL: http://llvm.org/viewvc/llvm-project?rev=329989=rev Log: [XRay][clang] Make -fxray-modes= additive Summary: This allows us to do the following: clang -fxray-modes=none ... -fxray-modes=xray-basic It's important to be

r329985 - [XRay][clang] Add flag to choose instrumentation bundles

Author: dberris Date: Thu Apr 12 19:31:58 2018 New Revision: 329985 URL: http://llvm.org/viewvc/llvm-project?rev=329985=rev Log: [XRay][clang] Add flag to choose instrumentation bundles Summary: This change addresses http://llvm.org/PR36926 by allowing users to pick which instrumentation bundles

r329773 - [XRay][clang] Only enable test for supported platforms

Author: dberris Date: Tue Apr 10 18:47:40 2018 New Revision: 329773 URL: http://llvm.org/viewvc/llvm-project?rev=329773=rev Log: [XRay][clang] Only enable test for supported platforms This is a follow-up to D45474. Modified: cfe/trunk/test/Driver/XRay/xray-mode-flags.cpp Modified:

r329772 - [XRay][clang+compiler-rt] Support build-time mode selection

Author: dberris Date: Tue Apr 10 18:28:25 2018 New Revision: 329772 URL: http://llvm.org/viewvc/llvm-project?rev=329772=rev Log: [XRay][clang+compiler-rt] Support build-time mode selection Summary: This patch implements the `-fxray-modes=` flag which allows users building with XRay

r330310 - OpenBSD add C++ runtime in a driver's standpoint

Author: dberris Date: Wed Apr 18 23:55:30 2018 New Revision: 330310 URL: http://llvm.org/viewvc/llvm-project?rev=330310=rev Log: OpenBSD add C++ runtime in a driver's standpoint Summary: - Since 6.2 release, on supporters platforms clang is shipped with both libcxx and libcxxabi. Reviewers:

r342715 - [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1

Author: dberris Date: Fri Sep 21 01:32:49 2018 New Revision: 342715 URL: http://llvm.org/viewvc/llvm-project?rev=342715=rev Log: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1 Summary: Add a test and ensure that we propagate the -fxray-instrumentation-bundle flag from the driver

r342200 - [XRay][clang] Emit "never-instrument" attribute

Author: dberris Date: Thu Sep 13 18:59:12 2018 New Revision: 342200 URL: http://llvm.org/viewvc/llvm-project?rev=342200=rev Log: [XRay][clang] Emit "never-instrument" attribute Summary: Before this change, we only emit the XRay attributes in LLVM IR when the -fxray-instrument flag is provided.