Author: ioeric
Date: Thu Aug 9 02:05:45 2018
New Revision: 339320
URL: http://llvm.org/viewvc/llvm-project?rev=339320&view=rev
Log:
[clangd] Record the file being processed in a TUScheduler thread in context.
Summary:
This allows implementations like different symbol indexes to know what
the cur
Author: ioeric
Date: Thu Aug 9 02:25:26 2018
New Revision: 339322
URL: http://llvm.org/viewvc/llvm-project?rev=339322&view=rev
Log:
[clangd] Try to fix buildbot after r339320.
http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5487
Modified:
clang-tools-extra/trunk/clangd/TUSc
Author: ioeric
Date: Wed May 9 14:35:52 2018
New Revision: 331923
URL: http://llvm.org/viewvc/llvm-project?rev=331923&view=rev
Log:
Add SourceManagerForFile helper which sets up SourceManager and dependencies
for a single file with code snippet
Summary: This can be used to create a virtual envi
Author: ioeric
Date: Fri May 11 05:12:08 2018
New Revision: 332089
URL: http://llvm.org/viewvc/llvm-project?rev=332089&view=rev
Log:
[clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek, MaskRay, jko
Author: ioeric
Date: Mon May 14 05:07:56 2018
New Revision: 332236
URL: http://llvm.org/viewvc/llvm-project?rev=332236&view=rev
Log:
Redirect output to /dev/null in the tests added in r332160.
Modified:
cfe/trunk/test/Driver/clang-abi-compat.cpp
Modified: cfe/trunk/test/Driver/clang-abi-comp
Author: ioeric
Date: Mon May 14 05:19:16 2018
New Revision: 332237
URL: http://llvm.org/viewvc/llvm-project?rev=332237&view=rev
Log:
[clangd] Add helper for collecting #include directives in file.
Summary: Separate unit tests for the new function will be added in followup
patch which will furthe
Author: ioeric
Date: Mon May 14 12:51:33 2018
New Revision: 332284
URL: http://llvm.org/viewvc/llvm-project?rev=332284&view=rev
Log:
[clang-format] Move #include related style to libToolingCore
Summary: This will be shared by include insertion/deletion library.
Reviewers: ilya-biryukov
Reviewed
Author: ioeric
Date: Mon May 14 13:17:53 2018
New Revision: 332287
URL: http://llvm.org/viewvc/llvm-project?rev=332287&view=rev
Log:
[Tooling] Pull #include manipulation code from clangFormat into libToolingCore.
Summary: Also pull #include related style out of FormatStyle as
tooling::IncludeSty
Author: ioeric
Date: Tue May 15 08:23:53 2018
New Revision: 332362
URL: http://llvm.org/viewvc/llvm-project?rev=332362&view=rev
Log:
[clangd] Remove LSP command-based #include insertion.
Summary:
clangd will populate #include insertions as addtionalEdits in completion items.
The code completion
Author: ioeric
Date: Tue May 15 08:29:32 2018
New Revision: 332363
URL: http://llvm.org/viewvc/llvm-project?rev=332363&view=rev
Log:
[clangd] Populate #include insertions as additional edits in completion items.
Summary:
o Remove IncludeInsertion LSP command.
o Populate include insertion edits sy
Author: ioeric
Date: Tue May 15 09:22:43 2018
New Revision: 332366
URL: http://llvm.org/viewvc/llvm-project?rev=332366&view=rev
Log:
[clangd] Log error message instead write to errs(). NFC
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-tools-extra/trunk/cl
Author: ioeric
Date: Wed May 16 05:12:30 2018
New Revision: 332456
URL: http://llvm.org/viewvc/llvm-project?rev=332456&view=rev
Log:
[clangd] Filter out private proto symbols in SymbolCollector.
Summary:
This uses heuristics to identify private proto symbols. For example,
top-level symbols whose
I can also reproduce on my local machine (Debian).
On Wed, May 16, 2018 at 1:01 PM David Zarzycki via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red
> Hat Fedora 28. Was this expected?
>
> > On May 16, 2018, at 4:25 AM, F
OK, I'll send a fix for the index test. Please make sure you run all clang
tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a
patch! Thanks!
On Wed, May 16, 2018 at 2:32 PM Eric Liu wrote:
> I can also reproduce on my local machine (Debian).
>
> On Wed, May 16, 2018 at 1:
Author: ioeric
Date: Wed May 16 05:58:13 2018
New Revision: 332465
URL: http://llvm.org/viewvc/llvm-project?rev=332465&view=rev
Log:
Fix an Index test caused by a clang-format change (r332436).
Modified:
cfe/trunk/test/Index/overriding-ftemplate-comments.cpp
Modified: cfe/trunk/test/Index/ov
This should be fixed by r332465
On Wed, May 16, 2018 at 2:50 PM Eric Liu wrote:
> OK, I'll send a fix for the index test. Please make sure you run all clang
> tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a
> patch! Thanks!
>
> On Wed, May 16, 2018 at 2:32 PM Eric Liu
> Please have a look?
>
> It is not good idea to keep the bot red for too long. This hides new
> problem which later hard to track down.
>
> Thanks
>
>
> Galina
>
>
>
> On Tue, May 15, 2018 at 8:29 AM, Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.or
Author: ioeric
Date: Wed May 16 12:59:49 2018
New Revision: 332515
URL: http://llvm.org/viewvc/llvm-project?rev=332515&view=rev
Log:
Attempt to fix buildbot failure caused by r332363
Log: http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26399
Modified:
clang-tools-extra/t
Author: ioeric
Date: Wed May 16 13:10:10 2018
New Revision: 332518
URL: http://llvm.org/viewvc/llvm-project?rev=332518&view=rev
Log:
[clang-move] Fix a potential bug where realpath doesn't work on VFS.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/tru
Author: ioeric
Date: Wed May 16 13:31:38 2018
New Revision: 332520
URL: http://llvm.org/viewvc/llvm-project?rev=332520&view=rev
Log:
Second attempt to fix buildbot failure caused by r332363
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26501
Modified:
clang-tools-extra
gument 3 of ‘bool
>> clang::clangd::{anonymous}::semaCodeComplete(std::unique_ptr,
>> const clang::CodeCompleteOptions&, const
>> clang::clangd::{anonymous}::SemaCompleteInput&,
>> std::unique_ptr*)’
>>
>> bool semaCodeComplete(std::unique_ptr Consumer,
>&
Author: ioeric
Date: Thu May 17 03:26:23 2018
New Revision: 332590
URL: http://llvm.org/viewvc/llvm-project?rev=332590&view=rev
Log:
Add vfs::FileSystem::getRealPath
Summary: And change `FileManager::getCanonicalName` to use getRealPath.
Reviewers: bkramer
Reviewed By: bkramer
Subscribers: cfe
Author: ioeric
Date: Thu May 17 05:40:50 2018
New Revision: 332603
URL: http://llvm.org/viewvc/llvm-project?rev=332603&view=rev
Log:
Attempt to fix clang-move tests broken by r332590 on windows
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12007
Modified:
clang-tools-ex
Author: ioeric
Date: Thu May 17 07:59:15 2018
New Revision: 332612
URL: http://llvm.org/viewvc/llvm-project?rev=332612&view=rev
Log:
Second attempt to fix clang-move tests broken by r332590 on windows
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12010
Add back a path conve
Author: ioeric
Date: Thu May 17 09:13:36 2018
New Revision: 332620
URL: http://llvm.org/viewvc/llvm-project?rev=332620&view=rev
Log:
Disable a failing clang-move test on windows.
This was broken by r332590 but is likely caused by a bug in clang-move.
http://lab.llvm.org:8011/builders/clang-x86-w
Author: ioeric
Date: Fri May 18 02:25:36 2018
New Revision: 332701
URL: http://llvm.org/viewvc/llvm-project?rev=332701&view=rev
Log:
Re-enable a clang-move test on windows.
This was fixed by r332612.
Modified:
clang-tools-extra/trunk/test/clang-move/move-class.cpp
Modified: clang-tools-extr
Author: ioeric
Date: Fri May 18 06:22:49 2018
New Revision: 332717
URL: http://llvm.org/viewvc/llvm-project?rev=332717&view=rev
Log:
[VFS] Implement getRealPath for OverlayFileSystem.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D47060
Modified:
Author: ioeric
Date: Fri May 18 07:16:37 2018
New Revision: 332720
URL: http://llvm.org/viewvc/llvm-project?rev=332720&view=rev
Log:
Move #include manipulation code to new lib/Tooling/Inclusions.
Summary:
clangToolingCore is linked into almost everything (incl. clang), but
not few tools need #inc
Author: ioeric
Date: Fri May 18 07:17:36 2018
New Revision: 332721
URL: http://llvm.org/viewvc/llvm-project?rev=332721&view=rev
Log:
[clangd] Adapt file migration in r332720
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
clang-tools-extra/trunk/clangd/Headers.h
Modified: clang-t
Author: ioeric
Date: Fri May 18 09:06:19 2018
New Revision: 332731
URL: http://llvm.org/viewvc/llvm-project?rev=332731&view=rev
Log:
[Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS
Summary: ... to support purely VFS-based tools.
Reviewers: bkramer
Subscribers: klimek, cfe-comm
Author: ioeric
Date: Fri May 18 09:08:18 2018
New Revision: 332732
URL: http://llvm.org/viewvc/llvm-project?rev=332732&view=rev
Log:
Trying to fix clang-move tests on windows build bot broken by r332717
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10702
Modified:
clang-tools
Author: ioeric
Date: Fri May 18 09:29:42 2018
New Revision: 332734
URL: http://llvm.org/viewvc/llvm-project?rev=332734&view=rev
Log:
Fix unused variable warning in r332724
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
URL:
: could not build module 'Clang_Format'
> #include "clang/Format/Format.h"
> ^~~
> /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10:10:
> fatal error: could not build module 'Clang_Tooling'
>
g/Tooling/Refactoring/AtomicChange.h:19:10:
>> fatal error: could not build module 'Clang_Format'
>> #include "clang/Format/Format.h"
>> ~~~~^~~
>> /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10:10:
>
Author: ioeric
Date: Fri May 18 11:33:08 2018
New Revision: 332751
URL: http://llvm.org/viewvc/llvm-project?rev=332751&view=rev
Log:
Revert "Move #include manipulation code to new lib/Tooling/Inclusions."
This reverts commit r332720. This break build bot with modules. Need to
investigate. Revert
Author: ioeric
Date: Fri May 18 11:33:21 2018
New Revision: 332752
URL: http://llvm.org/viewvc/llvm-project?rev=332752&view=rev
Log:
Revert "[clangd] Adapt file migration in r332720"
This reverts commit r332721 because the dependency r33270 will be reverted.
Modified:
clang-tools-extra/trunk
e included from /Users/vsk/src/llvm.org
>>> -master/llvm/tools/clang/include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:14:
>>> /Users/vsk/src/llvm.org-master/llvm/tools/clang/include/clang/Tooling/Refactoring/AtomicChange.h:19:10:
>>> fatal error: could not build module 'Clang_Format'
>>>
Thanks a lot for looking into this Bruno! The fix looks promising; I'll
give it a try next week :D
On Fri, May 18, 2018 at 10:33 PM David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I haven't looked in detail here, but in general: Don't split an
> implementation and its headers
Sorry about the bad naming... I hope I could come up with something less
confusing. Thanks for the clarification!
On Fri, May 18, 2018 at 11:25 PM David Blaikie wrote:
>
>
> On Fri, May 18, 2018 at 2:22 PM Eric Liu wrote:
>
>> Thanks a lot for looking into this Bruno! The fix looks promising; I
Author: ioeric
Date: Tue May 22 01:33:30 2018
New Revision: 332959
URL: http://llvm.org/viewvc/llvm-project?rev=332959&view=rev
Log:
[clangd] Correctly handle IWYU prama with verbatim #include header.
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
clang-tools-extra/t
Author: ioeric
Date: Thu May 24 04:17:00 2018
New Revision: 333172
URL: http://llvm.org/viewvc/llvm-project?rev=333172&view=rev
Log:
[VFS] Implement getRealPath in InMemoryFileSystem.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D47262
Modified:
Author: ioeric
Date: Thu May 24 04:20:19 2018
New Revision: 333174
URL: http://llvm.org/viewvc/llvm-project?rev=333174&view=rev
Log:
[clangd] Fix code completion in MACROs with stringification.
Summary:
Currently, we only handle the first callback from sema code completion
and ignore results from
Author: ioeric
Date: Thu May 24 06:52:48 2018
New Revision: 333186
URL: http://llvm.org/viewvc/llvm-project?rev=333186&view=rev
Log:
Disable an in-memory vfs file path test on windows.
The test uses unix paths and doesn't make sense to run on windows.
Fix bot failure caused by r333172:
http://l
Author: ioeric
Date: Thu May 24 07:40:24 2018
New Revision: 333188
URL: http://llvm.org/viewvc/llvm-project?rev=333188&view=rev
Log:
[clangd] Skip .inc headers when canonicalizing header #include.
Summary:
This assumes that .inc files are supposed to be included via headers
that include them.
Re
Author: ioeric
Date: Thu May 24 08:54:32 2018
New Revision: 333197
URL: http://llvm.org/viewvc/llvm-project?rev=333197&view=rev
Log:
[clangd] Add clangDriver dependency after r333188
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.t
Author: ioeric
Date: Wed May 30 02:03:39 2018
New Revision: 333519
URL: http://llvm.org/viewvc/llvm-project?rev=333519&view=rev
Log:
[clangd] Avoid inserting new #include when declaration is present in the main
file.
Summary:
Also fix USR generation for classes in unit tests. The previous USR
on
Hi Richard,
This is breaking the boostrap stage in the internal integration. I'm seeing
"unsupported: typedef changes linkage of anonymous type, but linkage was
already computed" error for many `struct`s defined with typedef. I'm not
sure if it is user code or clang that needs fixing; however, as
I am reverting this commit as it depends on r315251. See r315251 thread for
reason.
On Tue, Oct 10, 2017 at 2:49 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Mon Oct 9 17:49:38 2017
> New Revision: 315256
>
> URL: http://llvm.org/viewvc/llvm-proj
Author: ioeric
Date: Tue Oct 10 06:00:18 2017
New Revision: 315308
URL: http://llvm.org/viewvc/llvm-project?rev=315308&view=rev
Log:
Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext
for a declaration in the global module."
This reverts commit r315256. See the origina
Author: ioeric
Date: Tue Oct 10 06:09:40 2017
New Revision: 315309
URL: http://llvm.org/viewvc/llvm-project?rev=315309&view=rev
Log:
Revert "[Modules TS] Module ownership semantics for redeclarations."
This reverts commit r315251. See the original commit thread for reason.
Removed:
cfe/trunk
No :( I tried reverting only r315256 but still got the errors.
On Tue, Oct 10, 2017 at 6:10 PM Richard Smith wrote:
> On 10 Oct 2017 05:41, "Eric Liu via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
> Hi Richard,
>
> This is breaking the boostrap stag
Hi Yaxun, this is causing failures in ppc build bots (
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/5486).
I'll revert the patch for now. Please take a look. Thanks!
On Fri, Oct 13, 2017 at 5:37 AM Yaxun Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author:
Ah, I saw you already sent a fix in r315678. Thank you for the fix! No
revert! :)
On Fri, Oct 13, 2017 at 4:10 PM Eric Liu wrote:
> Hi Yaxun, this is causing failures in ppc build bots (
> http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/5486).
> I'll revert the patch for
Author: ioeric
Date: Mon Oct 16 01:20:10 2017
New Revision: 315892
URL: http://llvm.org/viewvc/llvm-project?rev=315892&view=rev
Log:
[change-namespace] do not change type locs in defaulted functions.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D388
Author: ioeric
Date: Tue Oct 24 06:10:58 2017
New Revision: 316433
URL: http://llvm.org/viewvc/llvm-project?rev=316433&view=rev
Log:
[Tooling] Add a factory method for CommonOptionsParser
Summary: This returns error instead of exiting the program in case of error.
Reviewers: klimek, hokein
Revi
Author: ioeric
Date: Fri Aug 24 01:59:54 2018
New Revision: 340598
URL: http://llvm.org/viewvc/llvm-project?rev=340598&view=rev
Log:
[FileManager] Do not call 'real_path' in getFile().
Summary:
This partially rolls back the change in D48903:
https://github.com/llvm-mirror/clang/commit/89aa7f45a1f
Author: ioeric
Date: Fri Aug 24 02:53:44 2018
New Revision: 340602
URL: http://llvm.org/viewvc/llvm-project?rev=340602&view=rev
Log:
Fix build bot after r340598.
Revert to the original behavior: only calculate real file path when
file is opened and avoid using InterndPath for real path calculatio
Author: ioeric
Date: Fri Aug 24 04:23:56 2018
New Revision: 340604
URL: http://llvm.org/viewvc/llvm-project?rev=340604&view=rev
Log:
[clangd] Speculative code completion index request before Sema is run.
Summary:
For index-based code completion, send an asynchronous speculative index
request, bas
Author: ioeric
Date: Tue Aug 28 06:15:50 2018
New Revision: 340822
URL: http://llvm.org/viewvc/llvm-project?rev=340822&view=rev
Log:
[clangd] Use buffered llvm::errs() in the clangd binary.
Summary: Unbuffered stream can cause significant (non-deterministic) latency
for the logger.
Reviewers: s
Author: ioeric
Date: Mon Sep 3 03:18:21 2018
New Revision: 341304
URL: http://llvm.org/viewvc/llvm-project?rev=341304&view=rev
Log:
[clangd] Support multiple #include headers in one symbol.
Summary:
Currently, a symbol can have only one #include header attached, which
might not work well if the
Author: ioeric
Date: Wed Sep 5 00:40:38 2018
New Revision: 341449
URL: http://llvm.org/viewvc/llvm-project?rev=341449&view=rev
Log:
[clangd] Tune macro quality scoring for code completion.
x0.2 seems to be too much penalty, macros might be wanted in some cases;
changing to 0.5x instead. The tuni
Author: ioeric
Date: Wed Sep 5 02:45:27 2018
New Revision: 341455
URL: http://llvm.org/viewvc/llvm-project?rev=341455&view=rev
Log:
[VFS] Cache the current working directory for the real FS.
Reviewers: sammccall
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D51641
M
Author: ioeric
Date: Wed Sep 5 07:59:17 2018
New Revision: 341476
URL: http://llvm.org/viewvc/llvm-project?rev=341476&view=rev
Log:
[Sema] Store MacroInfo in CodeCompletionResult for macro results.
Summary:
This provides information about the macro definition. For example, it
can be used to comp
Author: ioeric
Date: Wed Sep 5 12:01:34 2018
New Revision: 341488
URL: http://llvm.org/viewvc/llvm-project?rev=341488&view=rev
Log:
[clang-tidy] minor bug fix to AbseilMatcher.h
This missing directory is not yet released, but is causing some problems
internally. It's gonna be released eventually
Author: ioeric
Date: Thu Sep 6 02:59:37 2018
New Revision: 341534
URL: http://llvm.org/viewvc/llvm-project?rev=341534&view=rev
Log:
[clangd] Set SymbolID for sema macros so that they can be merged with index
macros.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, k
Author: ioeric
Date: Thu Sep 6 11:52:26 2018
New Revision: 341576
URL: http://llvm.org/viewvc/llvm-project?rev=341576&view=rev
Log:
[clangd] Add "Deprecated" field to Symbol and CodeCompletion.
Summary: Also set "deprecated" field in LSP CompletionItem.
Reviewers: sammccall, kadircet
Reviewed
Author: ioeric
Date: Fri Sep 7 02:40:36 2018
New Revision: 341645
URL: http://llvm.org/viewvc/llvm-project?rev=341645&view=rev
Log:
[clangd] Canonicalize include paths in clangd.
Get rid of "../" and "../../".
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
clang-t
Author: ioeric
Date: Wed Sep 12 01:29:47 2018
New Revision: 342028
URL: http://llvm.org/viewvc/llvm-project?rev=342028&view=rev
Log:
[Tooling] Wait for all threads to finish before resetting CWD.
Modified:
cfe/trunk/lib/Tooling/AllTUsExecution.cpp
Modified: cfe/trunk/lib/Tooling/AllTUsExecut
I mean `clangd-symbol-builder`
On Wed, Sep 12, 2018 at 4:32 PM Eric Liu via Phabricator <
revi...@reviews.llvm.org> wrote:
> ioeric accepted this revision.
> ioeric added a comment.
> This revision is now accepted and ready to land.
>
> lgtm
>
> +1 to `clang-symbol-builder`
>
>
> Repository:
>
Author: ioeric
Date: Thu Sep 13 05:53:23 2018
New Revision: 342134
URL: http://llvm.org/viewvc/llvm-project?rev=342134&view=rev
Log:
[clangd] Clarify and hide -index flag.
Summary:
The wording implies global index support, which is confusing.
As most users shouldn't care about this flag, also mak
Author: ioeric
Date: Thu Jul 19 06:32:00 2018
New Revision: 337453
URL: http://llvm.org/viewvc/llvm-project?rev=337453&view=rev
Log:
[CodeComplete] Fix accessibilty of protected members from base class.
Summary:
Currently, protected members from base classes are marked as
inaccessible when comple
Author: ioeric
Date: Fri Jul 20 01:08:56 2018
New Revision: 337529
URL: http://llvm.org/viewvc/llvm-project?rev=337529&view=rev
Log:
[Index] Set OrigD before D is changed.
Reviewers: akyrtzi, arphaman
Reviewed By: akyrtzi
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org
Author: ioeric
Date: Mon Jul 23 03:56:37 2018
New Revision: 337681
URL: http://llvm.org/viewvc/llvm-project?rev=337681&view=rev
Log:
[clangd] Penalize non-instance members when accessed via class instances.
Summary:
The following are metrics for explicit member access completions. There is no
not
Author: ioeric
Date: Tue Jul 24 01:51:52 2018
New Revision: 337816
URL: http://llvm.org/viewvc/llvm-project?rev=337816&view=rev
Log:
[clangd] Tune down quality score for class constructors so that it's ranked
after class types.
Summary:
Currently, class constructors have the same score as the cl
Please also include a link to the test failure in the commit message or
this email thread.
On Tue, Jul 24, 2018 at 10:28 PM Jordan Rupprecht via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rupprecht
> Date: Tue Jul 24 13:28:07 2018
> New Revision: 337850
>
> URL: http://llvm.org/vi
Author: ioeric
Date: Wed Jul 25 04:26:35 2018
New Revision: 337907
URL: http://llvm.org/viewvc/llvm-project?rev=337907&view=rev
Log:
[clangd] Use a sigmoid style function for #usages boost in symbol quality.
Summary:
This has a shape to similar logarithm function but grows much slower for
large #
It would make it easier for your reviewers to look at the new changes if
you just reopen this patch and update the diff :)
On Wed, Jul 25, 2018 at 5:49 PM Simon Marchi via Phabricator <
revi...@reviews.llvm.org> wrote:
> simark added a comment.
>
> I uploaded a new version of this patch here:
> h
Thanks Jordan!
On Wed, Jul 25, 2018 at 6:01 PM Jordan Rupprecht
wrote:
> On Wed, Jul 25, 2018 at 1:40 AM Eric Liu wrote:
>
>> Please also include a link to the test failure in the commit message or
>> this email thread.
>>
> Sorry, I left the failure on the review thread (
> https://reviews.llv
checking,
> passing a possibly unrelated class) and the tests didn't break after
> reverting it.
>
> Let me know if I missed anything.
>
> On Thu, Jul 19, 2018 at 3:37 PM Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ioeric
>&
Author: ioeric
Date: Thu Aug 2 03:30:56 2018
New Revision: 338696
URL: http://llvm.org/viewvc/llvm-project?rev=338696&view=rev
Log:
Replace hardcoded format styles in a few tools with the default style in
libFormat.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
Author: ioeric
Date: Fri Aug 3 02:16:07 2018
New Revision: 338832
URL: http://llvm.org/viewvc/llvm-project?rev=338832&view=rev
Log:
Fully qualify the renamed symbol if the shortened name is ambiguous.
Summary:
For example, when renaming `a::b::x::foo` to `y::foo` below, replacing
`x::foo()` with
Author: ioeric
Date: Tue Feb 6 07:27:43 2018
New Revision: 324354
URL: http://llvm.org/viewvc/llvm-project?rev=324354&view=rev
Log:
[clangd] Remove unused variable. NFC
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.
Author: ioeric
Date: Tue Feb 6 08:10:35 2018
New Revision: 324358
URL: http://llvm.org/viewvc/llvm-project?rev=324358&view=rev
Log:
[clangd] Use URIs in index symbols.
Reviewers: hokein, sammccall
Reviewed By: sammccall
Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits
Differenti
Author: ioeric
Date: Wed Feb 7 04:12:06 2018
New Revision: 324475
URL: http://llvm.org/viewvc/llvm-project?rev=324475&view=rev
Log:
[clangd] Do not precent-encode numbers in URI.
Reviewers: ilya-biryukov
Subscribers: klimek, jkorous-apple, cfe-commits, sammccall
Differential Revision: https://
Author: ioeric
Date: Fri Feb 16 06:15:55 2018
New Revision: 325343
URL: http://llvm.org/viewvc/llvm-project?rev=325343&view=rev
Log:
[clangd] collect symbol #include & insert #include in global code completion.
Summary:
o Collect suitable #include paths for index symbols. This also does smart
ma
Author: ioeric
Date: Fri Feb 16 06:47:08 2018
New Revision: 325346
URL: http://llvm.org/viewvc/llvm-project?rev=325346&view=rev
Log:
[clangd] remove redundant ';' introduced in r325343
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/trunk/clan
Hi Carlos, did this fail on a Windows build bot? Would you mind pointing me
to the broken test? Thanks!
On Fri, Feb 16, 2018 at 4:23 PM Carlos Alberto Enciso via Phabricator <
revi...@reviews.llvm.org> wrote:
> CarlosAlbertoEnciso added a comment.
>
> Hi @ioeric:
>
> Just to let you know that you
Author: ioeric
Date: Mon Feb 19 02:45:48 2018
New Revision: 325482
URL: http://llvm.org/viewvc/llvm-project?rev=325482&view=rev
Log:
[clangd] Try to fix build bot failure caused by r325343: escape regex string.
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: cl
I've sent r325482 which (hopefully) fixes the failure. I'll keep an eye on
the bot to make sure this is fixed ASAP.
Sorry about the inconvenience!
o Eric
On Mon, Feb 19, 2018 at 11:39 AM Carlos Alberto Enciso via Phabricator <
revi...@reviews.llvm.org> wrote:
> CarlosAlbertoEnciso added a subs
Author: ioeric
Date: Mon Feb 19 10:48:44 2018
New Revision: 325523
URL: http://llvm.org/viewvc/llvm-project?rev=325523&view=rev
Log:
[clangd] Fixes for #include insertion.
Summary:
o Avoid inserting a header include into the header itself.
o Avoid inserting non-header files (by not indexing symbo
Author: ioeric
Date: Wed Feb 21 05:51:27 2018
New Revision: 325678
URL: http://llvm.org/viewvc/llvm-project?rev=325678&view=rev
Log:
[ASTMatchers] isTemplateInstantiation: also match explicit instantiation
declaration.
Summary:
Example:
template class X {}; class A {};
// Explicit instantiation
Oops, I only saw this after landing the patch. I'll send another one to
update the doc. Sorry about that!
On Wed, Feb 21, 2018 at 2:54 PM Aaron Ballman
wrote:
> On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits
> wrote:
> > Author: ioeric
> > Date: Wed Feb 2
Author: ioeric
Date: Wed Feb 21 06:22:42 2018
New Revision: 325682
URL: http://llvm.org/viewvc/llvm-project?rev=325682&view=rev
Log:
[ASTMatchers] Regenerate documentation after r325678
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.htm
Author: ioeric
Date: Wed Feb 21 08:17:25 2018
New Revision: 325694
URL: http://llvm.org/viewvc/llvm-project?rev=325694&view=rev
Log:
[clangd] Update canonical header mapping for STL
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/trunk/clangd/
Author: ioeric
Date: Thu Feb 22 02:14:05 2018
New Revision: 325764
URL: http://llvm.org/viewvc/llvm-project?rev=325764&view=rev
Log:
[clangd] Not collect include headers for dynamic index for now.
Summary:
The new behaviors introduced by this patch:
o When include collection is enabled, we always
Author: ioeric
Date: Thu Feb 22 10:40:39 2018
New Revision: 325813
URL: http://llvm.org/viewvc/llvm-project?rev=325813&view=rev
Log:
[clangd] Extend textDocument/didChange to specify whether diagnostics should be
generated.
Summary:
This would allow us to disable diagnostics when didChange is ca
Author: ioeric
Date: Mon Feb 26 00:32:13 2018
New Revision: 326070
URL: http://llvm.org/viewvc/llvm-project?rev=326070&view=rev
Log:
[clangd] don't insert new includes if either original header or canonical
header is already included.
Summary:
Changes:
o Store both the original header and the ca
Author: ioeric
Date: Thu Dec 14 03:25:49 2017
New Revision: 320688
URL: http://llvm.org/viewvc/llvm-project?rev=320688&view=rev
Log:
[clangd] Symbol index interfaces and an in-memory index implementation.
Summary:
o Index interfaces to support using different index sources (e.g. AST index,
globa
Author: ioeric
Date: Thu Dec 14 04:31:04 2017
New Revision: 320695
URL: http://llvm.org/viewvc/llvm-project?rev=320695&view=rev
Log:
[clangd] Fix a potential use-after-move bug.
Modified:
clang-tools-extra/trunk/unittests/clangd/IndexTests.cpp
Modified: clang-tools-extra/trunk/unittests/clan
Author: ioeric
Date: Thu Dec 14 06:50:58 2017
New Revision: 320701
URL: http://llvm.org/viewvc/llvm-project?rev=320701&view=rev
Log:
[clangd] Add a FileSymbols container that manages symbols from multiple files.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: klimek, mgorny, ilya-biryu
1 - 100 of 970 matches
Mail list logo
