Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko added inline comments. Comment at: include/clang/AST/ASTVector.h:385 @@ -383,3 +384,3 @@ // Allocate the memory from the ASTContext. - T *NewElts = new (C, llvm::alignOf()) T[NewCapacity]; + auto *NewElts = new (C, llvm::alignOf()) T[NewCapacity];

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

Eugene.Zelenko added a comment. I'm adept of consistency :-) It's also easier to fix all similar patterns in code then do such cleanups selectively. Actually, similar fixes were made recently in Decl.cpp when casts were involved, but not new. Comment at:

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko updated the summary for this revision. Eugene.Zelenko added a reviewer: aaron.ballman. Eugene.Zelenko updated this revision to Diff 39778. Eugene.Zelenko added a comment. Synchronize with current code. Repository: rL LLVM http://reviews.llvm.org/D13759 Files:

r252081 - Fix some Clang-tidy modernize warnings, other minor fixes.

Author: eugenezelenko Date: Wed Nov 4 15:37:17 2015 New Revision: 252081 URL: http://llvm.org/viewvc/llvm-project?rev=252081=rev Log: Fix some Clang-tidy modernize warnings, other minor fixes. Differential revision: http://reviews.llvm.org/D14311 Modified: cfe/trunk/lib/AST/ASTContext.cpp

[PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added subscribers: dschuff, jfb. Fixed warnings are: modernize-use-override, modernize-use-nullptr

Re: [PATCH] D13871: Add modernize-use-default check to clang-tidy.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Will be good idea to add handling of cases where default constructor is empty and only call base class(es) default constructor/members default constructors (see

[PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Regressions were OK.

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

Eugene.Zelenko added a comment. I think it'll be fine to rename check without leaving traces of misc. Same thing happened with modernize-shrink-to-fit. http://reviews.llvm.org/D13510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. What is preventing to add this check to Clang-tidy? Just found another piece of fresh C++ code in LLDB with (void) as argument list... http://reviews.llvm.org/D7639

Re: [PATCH] D14779: Adding checker to detect excess padding in records

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I may be mistaken, but this check looks more appropriate for Clang-tidy. http://reviews.llvm.org/D14779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a comment. Just for reference: - Previous attempt: http://reviews.llvm.org/D7639. - Bugzilla request https://llvm.org/bugs/show_bug.cgi?id=21980. http://reviews.llvm.org/D12473 ___ cfe-commits mailing list

Re: [PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Why static was removed from getMostNullable() and getNullabilityString()? If these functions are not intended to be used outside this source file, it's good idea to limit their scope. Same should be done for

[PATCH] D12919: [clang-format] Make configure installation consistent with CMake

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. During D12700 review I was asked to make configure installation consistent with CMake. Since I modeled

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko set the repository for this revision to rL LLVM. Eugene.Zelenko updated this revision to Diff 34953. Eugene.Zelenko added a comment. I added installation in configure. See also http://reviews.llvm.org/D12919 for further configure improvements idea. Repository: rL LLVM

[PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Please check it in if it's OK, because

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko added a comment. On my understanding share contains architecture-independent files. clang-format files installation is also part of CMake build only. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Will be good idea to review checks one by one. Checks should be named after function, not after author. If existing categories too wide, new one could be introduced, like performance

[PATCH] D13187: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Also fixed Clang-tidy readability-simplify-boolean-expr in tools/libclang/CIndex.cpp. I checked this patch

r255033 - Use range loops and autos in lib/Serialization/ASTWriter.cpp.

Author: eugenezelenko Date: Tue Dec 8 12:00:11 2015 New Revision: 255033 URL: http://llvm.org/viewvc/llvm-project?rev=255033=rev Log: Use range loops and autos in lib/Serialization/ASTWriter.cpp. Differential revision: http://reviews.llvm.org/D15311 Modified:

Re: [PATCH] D15313: [Clang] Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp

Eugene.Zelenko removed rL LLVM as the repository for this revision. Eugene.Zelenko updated this revision to Diff 42192. Eugene.Zelenko added a comment. Replaced const auto with auto as suggested by Aaron. http://reviews.llvm.org/D15313 Files: utils/TableGen/ClangAttrEmitter.cpp Index:

[PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-use-auto warnings. Autos are also used for pointer variables

Re: [PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

Eugene.Zelenko added inline comments. Comment at: lib/AST/ASTContext.cpp:429 @@ -432,2 +428,3 @@ + auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo); return CFC; } jroelofs wrote: > return new ... Will fix in commit. Repository:

r255042 - Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp and generated code.

Author: eugenezelenko Date: Tue Dec 8 12:49:01 2015 New Revision: 255042 URL: http://llvm.org/viewvc/llvm-project?rev=255042=rev Log: Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp and generated code. Differential revision: http://reviews.llvm.org/D15313 Modified:

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This check partially implements PR19419. Could it be extended to variables? http://reviews.llvm.org/D15332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Autos are also used for pointer variables assigned via casts or memory allocation. Patch

[PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-loop-convert. Autos are used for pointer variables assigned via

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

Eugene.Zelenko removed rL LLVM as the repository for this revision. Eugene.Zelenko updated this revision to Diff 42087. Eugene.Zelenko added a comment. I fixed two loops and don't use auto instead of bool. Auto is also used for results of new. http://reviews.llvm.org/D15251 Files:

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

Eugene.Zelenko added inline comments. Comment at: lib/Serialization/ASTReader.cpp:5074 @@ -5087,3 +5073,3 @@ bool operator()(ModuleFile ) { - HeaderFileInfoLookupTable *Table + auto *Table = static_cast(M.HeaderFileInfoTable); I don't

[PATCH] D15311: [Clang] Use range loops and autos in lib/Serialization/ASTWriter.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are also used for

[PATCH] D15313: [Clang] Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are also used for

[PATCH] D15400: [Clang] Use autos in lib/AST/Type.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Autos are also used for pointer variables assigned via casts or memory allocation. Patch

Re: [PATCH] D15366: [Clang] Use autos in lib/AST/ASTImporter.cpp

Eugene.Zelenko added inline comments. Comment at: lib/AST/ASTImporter.cpp:5855 @@ -5888,3 +5854,3 @@ } - else if (ObjCProtocolDecl *PD = dyn_cast(D)) { + else if (auto *PD = dyn_cast(D)) { if (!PD->getDefinition()) aaron.ballman wrote: > Can you fix the

Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

Eugene.Zelenko added inline comments. Comment at: lib/AST/Expr.cpp:1956 @@ -1967,1 +1955,3 @@ +for (const auto : InitExprs) { + if (Stmt *S = I) { Beg = S->getLocStart(); aaron.ballman wrote: > Is this line still required? I thought InitExprs

Re: [PATCH] D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D15444#308573, @adek05 wrote: > I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy > linking everything that clang-modernizer has? If so, I can create another > patch which just moves these tests over.

Re: [PATCH] D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Should be moved to Clang-tidy, since clang-modernize is deprecated. http://reviews.llvm.org/D15444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15814: Implicit conversion from float->bool

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This seems to me as specific case of Clang-tidy readability-implicit-bool-cast. May be this check should be entirely moved to Clang? http://reviews.llvm.org/D15814

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be great to finalize fix before 3.8 branching (planned at January 13). http://reviews.llvm.org/D15506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This check is duplicate of clang-analyzer-alpha.cplusplus.VirtualCall. From my point of view, Clang-tidy is better place, since such calls doesn't depend of run-time paths. I think will be good idea to try to

[PATCH] D14964: [clang-tidy] Fix problem with parallel configure build

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, probinson. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix should solve problem with parallel configure build introduced in D12700 as suggested

[clang-tools-extra] r254081 - Fix problem with Clang-tidy parallel configure build.

Author: eugenezelenko Date: Wed Nov 25 13:16:34 2015 New Revision: 254081 URL: http://llvm.org/viewvc/llvm-project?rev=254081=rev Log: Fix problem with Clang-tidy parallel configure build. Differential revision: http://reviews.llvm.org/D14964 Modified:

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko added a comment. I think will be good idea to ask specialist in configure build to look on make file. I used other Clang or LLVM make file as example. Frankly, I don't see anything bad with it. However this fix was backported to 3.7.x and configure build is still supported

r257562 - Install scan-build and scan-view only if Static Analyzer was enabled.

Author: eugenezelenko Date: Tue Jan 12 20:03:50 2016 New Revision: 257562 URL: http://llvm.org/viewvc/llvm-project?rev=257562=rev Log: Install scan-build and scan-view only if Static Analyzer was enabled. Modified: cfe/trunk/tools/CMakeLists.txt Modified: cfe/trunk/tools/CMakeLists.txt URL:

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to try this check with LLVM STL too. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:47 @@ +46,3 @@ + +In this case the calls of push_back won't be

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rL LLVM http://reviews.llvm.org/D21134 ___ cfe-commits mailing list

[clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

Author: eugenezelenko Date: Tue Jun 7 13:29:15 2016 New Revision: 272038 URL: http://llvm.org/viewvc/llvm-project?rev=272038=rev Log: [Clang-tidy] Documentation style consistency. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:262 @@ -261,1 +261,3 @@ +- Updated `readability-identifier-naming-check + `_ Please put this not in

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-tidy/tool/clang-tidy-diff.py:42 @@ -41,3 +41,3 @@ help='path to clang-tidy binary') parser.add_argument('-p', metavar='NUM', default=0, help='strip the smallest

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be good idea to mention improvement in docs/ReleaseNotes.rst. Please close PR23198 after commit. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. See also http://reviews.llvm.org/D20964. I think modernize is better place for such check. http://reviews.llvm.org/D21185 ___ cfe-commits mailing list

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. There are alternative implementation in http://reviews.llvm.org/D21185. Will be good idea to how one which take the best from both :-) http://reviews.llvm.org/D20964 ___ cfe-commits mailing list

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D20964#448525, @Prazek wrote: > In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > > > I think will be good idea to try this check with LLVM STL too. > > > You mean llvm::SmallVector stuff? No, I meant to build example

Re: [PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added a comment. Will be good idea to change some if statements in regression test to (p != nullptr) (for C++11) and (p != NULL) (pre-C+11). See http://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-cast.html. Repository: rL LLVM

Re: [PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). I think misc-delete-null-pointer will be better name. Repository: rL LLVM http://reviews.llvm.org/D21298

[clang-tools-extra] r272042 - [Clang-tidy] Alphabetical checks order in release notes.

Author: eugenezelenko Date: Tue Jun 7 13:38:42 2016 New Revision: 272042 URL: http://llvm.org/viewvc/llvm-project?rev=272042=rev Log: [Clang-tidy] Alphabetical checks order in release notes. Highlight return statement in misc-unconventional-assign-operator documentation. Modified:

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. Point of Include What You Use suggestions to rely on explicit dependencies, not implicit ones. Comment at: clang-tidy/utils/OptionsUtils.cpp:1 @@ -1,2 +1,2 @@ //===--- DanglingHandleCheck.cpp - clang-tidy--===// //

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 58803. Eugene.Zelenko added a comment. More diff content. Repository: rL LLVM http://reviews.llvm.org/D20714 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

Eugene.Zelenko added a comment. I think single check will be better from user's point of view. Comment at: docs/clang-tidy/checks/modernize-explicit-operator-bool.rst:12 @@ +11,3 @@ +have no ``operator ==`` overloads, an implicit ``operator bool`` would allow +``a == b`` to

Re: [PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/clang-tidy/checks/modernize-use-auto.rst:155 @@ +154,3 @@ +-- +If the option is set to non-zero (default is ``0``), the check will remove stars +from the non-typedef pointer types when replacing

[PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, etienneb. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. There is a way to tell IWYU about compound headers with pragmas . I also suggested to make this possible via file with compound headers list. But person who knows

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. See https://github.com/include-what-you-use/include-what-you-use/issues/292 and https://github.com/include-what-you-use/include-what-you-use/issues/301. Repository: rL LLVM http://reviews.llvm.org/D20714 ___

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Eugene.Zelenko added a comment. Since http://reviews.llvm.org/D20964 was committed, I think we should close this. http://reviews.llvm.org/D21185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:1 @@ -1,2 +1,2 @@ -.. title:: clang-tidy - misc-inefficient-algorithm +.. title:: clang-tidy - performance-inefficient-algorithm alexfh wrote: > I'd

[PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Just to reduce number of uncategorized checks, since Clang-tidy has dedicated

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16259#328834, @LegalizeAdulthood wrote: > I didn't know about the bug reports. I created this check because I have > encountered such redundant control flow in real code bases. Bug report was reflection on my code base, but I also

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Thank you for this check! https://llvm.org/bugs/show_bug.cgi?id=21984 waited to be implemented for so looong time :-) By the word, other return related readability check idea:

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko updated the summary for this revision. Eugene.Zelenko removed rL LLVM as the repository for this revision. Eugene.Zelenko updated this revision to Diff 45209. Eugene.Zelenko added a comment. Add redirect documentation for old check name. http://reviews.llvm.org/D16248 Files:

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Please see PR28334. I'm not sure if Krystyna has Bugzilla account, so I report problem here. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r260414 - Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Wed Feb 10 13:11:58 2016 New Revision: 260414 URL: http://llvm.org/viewvc/llvm-project?rev=260414=rev Log: Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17060 Modified:

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Obsoleted by http://reviews.llvm.org/D16953. Repository: rL LLVM http://reviews.llvm.org/D16786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 47415. Eugene.Zelenko added a comment. More fixes. Repository: rL LLVM http://reviews.llvm.org/D17060 Files: include/clang/Analysis/Analyses/ThreadSafetyUtil.h lib/ARCMigrate/ObjCMT.cpp lib/AST/ASTDiagnostic.cpp lib/AST/CommentLexer.cpp

[libcxx] r259091 - Remove autoconf support.

Author: eugenezelenko Date: Thu Jan 28 15:00:21 2016 New Revision: 259091 URL: http://llvm.org/viewvc/llvm-project?rev=259091=rev Log: Remove autoconf support. Differential revision: http://reviews.llvm.org/D16651 Removed: libcxx/trunk/Makefile Removed: libcxx/trunk/Makefile URL:

[PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, piotrdz, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This is fix for PR26295. I added configuration option to

[PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix for PR25894. I checked it on my work code base. Build and

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16786#342074, @aaron.ballman wrote: > In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > > > I think proper solution will be to create tests for included files ot the > > fly, bu renaming main test to .h and creating

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. I'll wait for global options implementation. Repository: rL LLVM http://reviews.llvm.org/D16700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16794

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16794

[PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix for PR26332. I checked it on my work code base. Build and

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16794#343652, @LegalizeAdulthood wrote: > Again, isn't this already assigned to me in the bug tracker? > > In general, my assumption in bug trackers is that if someone has assigned the > bug to themselves, then they are working on it.

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32 @@ -30,1 +31,3 @@ +Options.get("NullPointerLiteral", +Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {} void

[clang-tools-extra] r259393 - Sort checks alphabetically in ReadabilityTidyModule.cpp.

Author: eugenezelenko Date: Mon Feb 1 13:47:24 2016 New Revision: 259393 URL: http://llvm.org/viewvc/llvm-project?rev=259393=rev Log: Sort checks alphabetically in ReadabilityTidyModule.cpp. Modified: clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp Modified:

Re: [PATCH] D17586: Add a new check, readability-redundant-string-init, that checks unnecessary string initializations.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Sorry for arriving late to party :-) Thank you for great check! I found a quite lot of such problems in my code base, but I'd like to make suggestion for further improvements: PR26756. Repository: rL LLVM

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

Eugene.Zelenko added a comment. Clang-tidy has 6 cast related checks. May be this is good time to introduce dedicated category for them? Repository: rL LLVM http://reviews.llvm.org/D16310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/clang-tidy/checks/misc-long-cast.rst:6 @@ +5,3 @@ + +This checker will warn when there is a explicit redundant cast of a calculation +result to a bigger type. If the intention of the cast is to avoid loss of

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:3 @@ -2,3 +2,3 @@ -misc-inefficient-algorithm +performance-inefficient-algorithm == alexfh wrote: > After reading this check

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

Eugene.Zelenko added a comment. Just encountered next situation in my work code base: void Function() { ... if (Condition) { } else return; } http://reviews.llvm.org/D16259 ___ cfe-commits mailing list

r258836 - Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 13:01:06 2016 New Revision: 258836 URL: http://llvm.org/viewvc/llvm-project?rev=258836=rev Log: Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D16567 Modified:

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

[PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

[PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. While working with LLDB code I noticed that readability-container-size-empty

Re: [PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

Eugene.Zelenko added a comment. Also I agree that testing is good idea, it doesn't make sense in current incarnation which test only vector and set and only with containers' code snippets instead of real implementations. I wrote about last issue in cfe-dev, but idea was rejected. Other issue

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

Eugene.Zelenko added a comment. Thank you for implementing this check! However, I think will be good idea to always wrap header name in <> for warning and FixIt. http://reviews.llvm.org/D17484 ___ cfe-commits mailing list

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

Eugene.Zelenko added a comment. Another idea: to replace limits.h with limits and also replace its defines with their C++ counterparts. For example, INT_MIN with numeric_limits::min(). Will be definitely useful for LLDB code modernization. http://reviews.llvm.org/D17484

r260757 - Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Fri Feb 12 16:53:10 2016 New Revision: 260757 URL: http://llvm.org/viewvc/llvm-project?rev=260757=rev Log: Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17218 Modified:

[PATCH] D17218: [Clang] Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

[clang-tools-extra] r263726 - Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes.

Author: eugenezelenko Date: Thu Mar 17 12:02:25 2016 New Revision: 263726 URL: http://llvm.org/viewvc/llvm-project?rev=263726=rev Log: Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D18231 Modified:

  1   2   3   4   5   >