[PATCH] D48894: [AST] Rename some Redeclarable functions to reduce confusion

MaskRay updated this revision to Diff 154044. MaskRay added a comment. Rename `Next` to `Link` as per rsmith Repository: rC Clang https://reviews.llvm.org/D48894 Files: include/clang/AST/Redeclarable.h Index: include/clang/AST/Redeclarable.h

[PATCH] D48894: [AST] Rename some Redeclarable functions to reduce confusion

MaskRay created this revision. MaskRay added reviewers: rsmith, akyrtzi, Eugene.Zelenko. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48894 Files: include/clang/AST/Redeclarable.h Index: include/clang/AST/Redeclarable.h

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D41575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. In https://reviews.llvm.org/D41575#970412, @akyrtzi wrote: > Ah, sorry I mislead you. To test this try using `c-index-test -index-file > /path/to/file`, see other examples in `test/Index`, e.g. > `test/Index/index-file.cpp` Thanks for the command. It is really

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. @akyrtzi When I run `c-index-test core -print-source-symbols -- a.cc` on template struct actor; template class Actor = actor> struct terminal; the issue disappears. It emerges only when `clang_indexTranslationUnit` is called with interactions of other

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay updated this revision to Diff 128953. MaskRay added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp

[PATCH] D41575: [index] Return when DC is null in handleReference

This revision was automatically updated to reflect the committed changes. Closed by commit rL322017: [index] Return when DC is null in handleReference (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41575 Files:

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130458. MaskRay added a comment. More Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130493. MaskRay added a comment. More Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130486. MaskRay added a comment. More Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130644. MaskRay added a comment. Revert some changes to address comments Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay added a comment. In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote: > The documentation needs to be regenerated for this patch. One thing that > seems to be inconsistent is with the "what gets matched" messages is that > sometimes it includes extra adornments like curly

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay added a comment. I am also not sure about this function: line 3548 /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a /// specific parameter count. /// /// Given /// \code /// void f(int i) {} /// void g(int i, int j) {} /// void h(int i, int

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay added a comment. In https://reviews.llvm.org/D42213#982261, @aaron.ballman wrote: > In https://reviews.llvm.org/D42213#982256, @MaskRay wrote: > > > I am also not sure about this function: line 3548 > > > > /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a > >

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130672. MaskRay added a comment. Address comment Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130711. MaskRay added a comment. functionProtoType Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130922. MaskRay added a comment. Regenerate HTML docs $ cd docs/tools # yes, cd $ ./dump_ast_matchers.py Repository: rC Clang https://reviews.llvm.org/D42213 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h Index:

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay updated this revision to Diff 132775. MaskRay added a comment. description Repository: rC Clang https://reviews.llvm.org/D42893 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp tools/libclang/libclang.exports Index: tools/libclang/libclang.exports

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay updated this revision to Diff 132774. MaskRay added a comment. Increase CINDEX_VERSION_MINOR Repository: rC Clang https://reviews.llvm.org/D42893 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp tools/libclang/libclang.exports Index: tools/libclang/libclang.exports

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay created this revision. Herald added a subscriber: cfe-commits. clang_getFileName() may return a path relative to WorkingDir. On Arch Linux, during clang_indexTranslationUnit(), clang_getFileName() on CXIdxIncludedIncludedFileInfo::file may return

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay updated this revision to Diff 132773. MaskRay added a comment. description Repository: rC Clang https://reviews.llvm.org/D42893 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp tools/libclang/libclang.exports Index: tools/libclang/libclang.exports

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay created this revision. Herald added a subscriber: cfe-commits. CXIdxEntityRefInfo contains the member `CXIdxEntityRefKind kind;` to differentiate implicit and direct calls. However, there are more roles defined in SymbolRole. Among them, `Read/Write` are probably the most useful ones as

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay added a comment. On Arch Linux, `../lib64/gcc/x86_64-pc-linux-gnu/7.2.1/../../../../include/c++/7.2.1` (Name) resolves to a path that requires leading path components (`/usr/include`), this kind of resembles jailbreak. Repository: rC Clang https://reviews.llvm.org/D42893

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 3 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:26 + + static const llvm::StringMap Mapping{ +// [simd.alg] lebedev.ri wrote: > You probably want to move `Mapping` out of

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; ilya-biryukov wrote: > Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133255. MaskRay marked an inline comment as done. MaskRay added a comment. readability-simd-intrinsics.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay marked 4 inline comments as done. MaskRay added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; ilya-biryukov wrote: > MaskRay wrote: > > ilya-biryukov wrote: > > > Why do we need to store

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133441. MaskRay added a comment. Don't deprecate CXIdxEntityRefInfo Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-decls.m test/Index/index-refs.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133455. MaskRay added a comment. Add option `Enabled` which defaults to 0. Suggest std::simd (-std=c++2a) or std::experimental::std (-std=c++11) only if enabled. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 9 inline comments as done. MaskRay added a comment. The check must be manually enabled now: % clang-tidy -checks='-*,readability-simd-intrinsics' a.cc -- -std=c++2a # Not enabled by default % clang-tidy -checks='-*,readability-simd-intrinsics' -config='{CheckOptions:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133476. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntrinsicsCheck.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133474. MaskRay added a comment. Herald added subscribers: kbarton, nemanjai. Split test/clang-tidy/readability-simd-intrinsics.cpp to x86 and ppc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133457. MaskRay added a comment. Set `Enabled` to 1 in test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. In https://reviews.llvm.org/D42895#998617, @yvvan wrote: > I feel quite ok about this patch. > > Can you please add unit-tests? Added // CHECK: [indexEntityReference]: kind: field | name: y | {{.*}} | loc: 70:5 | {{.*}} | role: ref write // CHECK:

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133050. MaskRay added a comment. Simplify Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133038. MaskRay added a comment. Update c-index-test.c and clang/test/Index tests Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133051. MaskRay added a comment. . Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133109. MaskRay added a comment. Remove private section Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77 +void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( +

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133083. MaskRay added a comment. Add test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133091. MaskRay added a comment. Move CHECK-MESSAGES: to comform to the prevaling style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay added a comment. I haven't used clang-tidy before :) Do you have any suggestions on my workflow? % ninja -C ~/Dev/llvm/build clangTidyReadabilityModule % ~/Dev/llvm/build/bin/clang-tidy -checks='-*,readability-simd-intrinsics' a.cc # for local testing # Ensure tests are

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133107. MaskRay marked 5 inline comments as done. MaskRay added a comment. LLVM Style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay created this revision. Herald added subscribers: cfe-commits, hintonda, kristof.beyls, xazax.hun, mgorny, aemerson, klimek. Many architectures provide SIMD operations (e.g. x86 SSE/AVX, Power AltiVec/VSX, ARM NEON). It is common that SIMD code implementing the same algorithm, is written

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133120. MaskRay added a comment. if (!Result.Context->getLangOpts().CPlusPlus11) return; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133126. MaskRay added a comment. docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133134. MaskRay marked 2 inline comments as done. MaskRay added a comment. Warning messages of operator+ as operator+ operator- .. are free functions on simd objects. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133133. MaskRay marked an inline comment as done. MaskRay added a comment. docs/ReleaseNotes.rst and use StringRef::consume_front Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133902. MaskRay marked an inline comment as done. MaskRay added a comment. Rename `Enabled` to `UseStdExperimental` and only suggest std::experimental:: (not `std::`) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42895?vs=133632=133890#toc Repository: rL

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. Thx! Repository: rL LLVM https://reviews.llvm.org/D42895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133632. MaskRay added a comment. Bring back refkind: Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-refs.cpp test/Index/index-subscripting-literals.m

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. Ping. Now this is a pure API extension to current implicit/direct roles. Is it possible to see this landed before clang+llvm 6 is released? Repository: rC Clang https://reviews.llvm.org/D42895 ___ cfe-commits mailing

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 8 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:46 + + static const llvm::StringMap Mapping{ +// [simd.alg] hokein wrote: > consider using `llvm::StringSwitch`? The list is

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134076. MaskRay marked an inline comment as done. MaskRay added a comment. Remove UseStdExperimental Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134305. MaskRay marked 2 inline comments as done. MaskRay added a comment. Add an option `Suggest`. Only suggest P0214 alternatives if it is true. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133233. MaskRay marked 2 inline comments as done. MaskRay added a comment. Fix word order of readability-simd-intrinsics Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133237. MaskRay added a comment. Add check-specific option `Experimental` StringRef Std; if (Result.Context->getLangOpts().CPlusPlus2a) { Std = "std"; } else if (Result.Context->getLangOpts().CPlusPlus11 && Experimental) { // libcxx

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133239. MaskRay added a comment. Use unnamed namespace to enclose AST_MATCHER and TrySuggest* Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75 + // libcxx implementation of std::experimental::simd requires at least C++11. + if (!Result.Context->getLangOpts().CPlusPlus11) +return;

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added inline comments. Comment at: test/clang-tidy/readability-simd-intrinsics-ppc.cpp:3 +// RUN: -config='{CheckOptions: [ \ +// RUN:{key: readability-simd-intrinsics.Suggest, value: 1} \ +// RUN: ]}' -- -target ppc64le -maltivec -std=c++11 hokein

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134447. MaskRay marked 2 inline comments as done. MaskRay added a comment. Update Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134446. MaskRay marked 4 inline comments as done. MaskRay added a comment. Update .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325272: [clang-tidy] Add `readability-simd-intrinsics` check. (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42983?vs=134447=134448#toc Repository: rCTE

[PATCH] D41575: [index] Return when Parent is null in handleReference

MaskRay updated this revision to Diff 128150. MaskRay added a comment. Sorry for changing this back and forth. But I do not have a powerful workstation and have to reverse engineer this. Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay updated this revision to Diff 128148. MaskRay added a comment. DC -> Parent Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay updated this revision to Diff 128149. MaskRay added a comment. DC -> Parent Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay created this revision. Herald added a subscriber: cfe-commits. DC may sometimes be NULL and getContainerInfo(DC, Container) will fail. Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. HighCommander4 narrowed it down https://github.com/jacobdufault/cquery/issues/219#issuecomment-354903152 to a much simpler reproduce: c++ template struct actor; template class Actor = actor> struct terminal; This may trigger null pointer dereference of

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay abandoned this revision. MaskRay added a comment. https://reviews.llvm.org/D50223 has been changed to improve zlib::compress's current SmallVectorImpl interface. This is no longer relevant. Repository: rC Clang https://reviews.llvm.org/D50267

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay added a comment. This depends on https://reviews.llvm.org/D50223 Repository: rC Clang https://reviews.llvm.org/D50267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay created this revision. MaskRay added reviewers: ruiu, rsmith. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50267 Files: lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

MaskRay created this revision. MaskRay added reviewers: brad, emaste, khng300. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. The imported binutils in base supports DWARF 3. Repository: rC Clang https://reviews.llvm.org/D50294 Files: lib/Driver/ToolChains/FreeBSD.h

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

MaskRay created this revision. MaskRay added reviewers: Eugene.Zelenko, dblaikie. Herald added a subscriber: cfe-commits. unique_ptr makes the ownership clearer than a raw pointer container. Repository: rC Clang https://reviews.llvm.org/D50945 Files: include/clang/Lex/HeaderMap.h

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

This revision was automatically updated to reflect the committed changes. Closed by commit rC340198: [Lex] Make HeaderMaps a unique_ptr vector (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D50945?vs=161391=161530#toc Repository: rC Clang

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

MaskRay added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D50945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

MaskRay created this revision. MaskRay added a reviewer: kzhuravl. Herald added subscribers: cfe-commits, atanasyan, jrtc27, arichardson, sdardis. Repository: rC Clang https://reviews.llvm.org/D51234 Files: lib/Driver/ToolChains/MipsLinux.h Index: lib/Driver/ToolChains/MipsLinux.h

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay updated this revision to Diff 162488. MaskRay added a comment. Sorry I messed up with my branches :( I shall create https://reviews.llvm.org/D51234 but arc diff'ed to a different one Repository: rC Clang https://reviews.llvm.org/D51109 Files:

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay updated this revision to Diff 162478. MaskRay added a comment. Herald added subscribers: atanasyan, jrtc27, sdardis. [Driver] Change MipsLinux default linker from "lld" to "ld.lld" Repository: rC Clang https://reviews.llvm.org/D51109 Files: lib/Driver/ToolChains/MipsLinux.h

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

This revision was automatically updated to reflect the committed changes. Closed by commit rL340709: [Driver] Change MipsLinux default linker from lld to ld.lld (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51234

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay created this revision. MaskRay added reviewers: rupprecht, alexshap, jhenderson. Herald added a subscriber: cfe-commits. This is to accommodate a change in llvm/lib/Option/OptTable.cpp https://reviews.llvm.org/D51009 Repository: rC Clang https://reviews.llvm.org/D51109 Files:

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

MaskRay added a comment. Herald added a subscriber: ldionne. Ping :) Repository: rCXX libc++ https://reviews.llvm.org/D45805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D51109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation

MaskRay created this revision. MaskRay added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. With IndexImplicitInstantiation=true, the following case records an occurrence of B::bar in A::foo, which will benefit cross reference tools. template struct B { void bar() {}};

[PATCH] D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL336606: [Index] Add index::IndexingOptions::IndexImplicitInstantiation (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D48894: [AST] Rename some Redeclarable functions to reduce confusion

This revision was automatically updated to reflect the committed changes. Closed by commit rC336605: [AST] Rename some Redeclarable functions to reduce confusion (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D48894?vs=154044=154698#toc Repository:

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

This revision was automatically updated to reflect the committed changes. Closed by commit rC323157: [ASTMatchers] [NFC] Fix code examples (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42213?vs=130922=130965#toc Repository: rC Clang

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added a comment. In https://reviews.llvm.org/D42983#1028241, @alexfh wrote: > In https://reviews.llvm.org/D42983#1028093, @MaskRay wrote: > > > In https://reviews.llvm.org/D42983#1025179, @alexfh wrote: > > > > > A late comment here: should this check start a new "portability" module? >

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137256. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternative, otherwise point it out it

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137259. MaskRay added a comment. index.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay created this revision. MaskRay added a reviewer: alexfh. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137293. MaskRay marked 2 inline comments as done. MaskRay added a comment. Mention new module `portability` in docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137260. MaskRay added a comment. comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137275. MaskRay added a comment. std::string -> llvm::SmallString Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137262. MaskRay added a comment. . Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.txt

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay added a comment. ping Repository: rC Clang https://reviews.llvm.org/D42893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137406. MaskRay added a comment. ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

  1   2   3   4   5   6   7   8   9   10   >