[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli added a comment. In https://reviews.llvm.org/D27250#609006, @ABataev wrote: > Hi! Thanks for your review! > 1. Please provide full context for your changes (check this document how to > do this http://llvm.org/docs/Phabricator.html). I missed that out, should be done now. > 2.

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli added a comment. In https://reviews.llvm.org/D27250#609063, @ABataev wrote: > You did just some minor changes. The main questions are still unanswered. Hopefully now they are! :) Francesco https://reviews.llvm.org/D27250 ___

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli created this revision. fpetrogalli added a reviewer: cfe-commits. This patch generates a list of global external variables that are passed to the llvm::TargetLibraryInfo (TLI) to enable the vectorization of loops containing calls to function that are marked with a #pragma omp declare

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli updated this revision to Diff 79734. fpetrogalli added a comment. Rebase plus apply clang format. https://reviews.llvm.org/D27250 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. I updated the comments related to code formatting. https://reviews.llvm.org/D27250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

fpetrogalli added a comment. Hi Graham, thank you for working on this. I understand that you are gonna take care of the CodeGen side of things for the new `-fopenmp-simd` option in a separate patch? I am asking because I expect that the tests in `test/OpenMP/declare_simd_*` will give the same

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli planned changes to this revision. fpetrogalli added a comment. Dear all, thank you for reviewing this patch. We found out an error in the spec and would like to fix it before things are used. I will soon update this patch. Thanks, Francesco https://reviews.llvm.org/D30739

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Thanks, I do not have commit rights, can anyone commit this? https://reviews.llvm.org/D30739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. In https://reviews.llvm.org/D30739#706292, @Hahnfeld wrote: > In principal looks good to me although I'm not really familiar with this > part. Does that work for you if you have the `declare simd` in a header file > and the implementation in another file? On x86_64

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6821 + ISADataTy ISAData[] = { + {'n', 64}, // double-word Advanced SIMD + {'n', 128}, // quad-word Advanced SIMD rengolin wrote: > No f32? Sorry, I am not

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Gentle ping. Thanks, Francesco https://reviews.llvm.org/D30739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Alexey, thank you for reviewing this. If you don't mind, I will wait applying the changes you requested, Unfortunately I am not ready yet to send out an update as I am still working on the vector ABI. I will ping you when ready. Francesco

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli created this revision. Herald added subscribers: rengolin, aemerson. This patch enables the code generation of vector function names that are described by attaching a "#pragma omp declare simd" directive to the scalar function definition/declaration, for the Advanced SIMD (NEON)

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli updated this revision to Diff 91035. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Changes: - fixed formatting; - added two tests that were missing. https://reviews.llvm.org/D30739 Files: lib/Basic/Targets.cpp lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

fpetrogalli added a comment. In D60583#1529878 , @jdoerfert wrote: > Why/Where did we decide to clobber the attribute list with "non-existent > function names"? > I don't think an attribute list like this: > `attributes #1 = { "_ZGVsM2v_foo"

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this! I have added some minor comments. Francesco Comment at: clang/lib/CodeGen/CodeGenModule.h:593 + llvm::OpenMPIRBuilder () { +assert(OMPBuilder != nullptr); +return *OMPBuilder;

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23 /// OpenMP directives. -enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, -#define OPENMP_DIRECTIVE_EXT(Name, Str) \ - OMPD_##Name, -#include

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli accepted this revision. fpetrogalli added a comment. LGTM, thank you @huntergr ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/ https://reviews.llvm.org/D75350 ___ cfe-commits

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + Shouldn't you check that the `_ZGV *` name is generated? Repository: rG LLVM

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:327 +// CHECK-DAG: "_ZGVbN2l__Z11constlineari" +// CHECK-DAG: "_ZGVcN4l__Z11constlineari" I think we should add the same checks in the AArch64 test:

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this. I have a couple of high level comments. 1. I am not familiar with `OpenMP technical report 8 (TR8)`. Could you please provide a link in the description? Same for PR42061, PR42798, PR42799. It would be useful to get

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. I think I made a mess with the Actions for this review! I mean to accept it, not to enforce the nit comments! Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

fpetrogalli requested changes to this revision. fpetrogalli added a comment. This revision now requires changes to proceed. Hi @kmclaughlin , thank you for working on this! The patch LGTM, but please consider renaming the multiclass for the non faulting loads like I suggested. The rest of the

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

fpetrogalli created this revision. fpetrogalli added reviewers: ABataev, andwar. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. The linear parameter token in the mangling function must be multiplied by the pointee size

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli created this revision. fpetrogalli added a reviewer: ABataev. Herald added subscribers: cfe-commits, danielkiss, guansong, kristof.beyls, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. fpetrogalli added a comment. Hello reviewers, I know this is not how

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli added a comment. Hello reviewers, I know this is not how the fix should be tested (`fprintf` in debug builds...). This function would benefit of some unitests in the `unittests` folder of clang, but I don't have a way to export it there as it is private to this module. I would

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

fpetrogalli updated this revision to Diff 261225. fpetrogalli added a comment. Address review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78965/new/ https://reviews.llvm.org/D78965 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli added a comment. In D78969#2012591 , @jdoerfert wrote: > Is the NDS and WDS number never visible in the IR, e.g., as part of the name? Hang on, thanks for asking the question, maybe I can work something out here! :) They won't be visible in

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli updated this revision to Diff 261610. fpetrogalli added a comment. I have added (indirect) testing of the values of NDS and WDS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 Files:

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli updated this revision to Diff 261611. fpetrogalli added a comment. Removed single use variable definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 Files:

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7585ba208e67: [clang][OpenMP] Fix mangling of linear parameters. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78965/new/

[PATCH] D78190: Add Bfloat IR type

fpetrogalli added a comment. Hi @stuij, thank you for working on this! Admittedly, I don't know much about the Asm parser, but I have left some comments anyway. 1. Shouldn't we test also that the parser is happy with the following expressions? bfloat * %... = fadd %..., %... similar

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli added a comment. Adding some text here as phabricator refuses to submit with an empty comment... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/ https://reviews.llvm.org/D79639

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli updated this revision to Diff 263239. fpetrogalli marked 4 inline comments as done. fpetrogalli added a comment. Thank you for the review @sdesmalen, I have addressed all your comments. Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, david-arm. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli added a parent revision: D79639: [SveEmitter] Builtins for

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fa13a3dac1e: [clang][OpenMP] Fix getNDSWDS for aarch64. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/

[PATCH] D78190: Add Bfloat IR type

fpetrogalli accepted this revision. fpetrogalli added a comment. Hi @stuij, thank you for adding the vector tests. I can say the patch LGTM now :) Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2cc12e41282: [SveEmitter] Builtins for SVE matrix multiply `mmla`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli updated this revision to Diff 264735. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Fix formatting of code in test. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79877/new/

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone, "aarch64_sve_usdot", [ReverseUSDOT]>; +def SVSUDOT_N_S :

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb593bfd4d8e3: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_mmla.c:17 + // CHECK: ret %[[RET]] + return SVE_ACLE_FUNC(svmmla, _s32, , )(x, y, z); +} sdesmalen wrote: > nit: please remove the whitespace between the commas

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli updated this revision to Diff 264074. fpetrogalli marked 2 inline comments as done. fpetrogalli added a comment. Thank you for the review @sdesmalen! Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone, "aarch64_sve_usdot", [ReverseUSDOT]>; +def SVSUDOT_N_S :

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli added a comment. Hi @stuij , thank you for working on this. Would it make sense to add a test that includes the header file you have created? Regards, Francesco Comment at: clang/include/clang/Basic/arm_neon_incl.td:293 + + string CartesianProductWith = "";

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-getset-intrinsics.c:119-120 +// CHECK-LABEL: test_vduph_laneq_bf16 +// CHECK64: %vgetq_lane = extractelement <8 x bfloat> %v, i32 7 +// CHECK32: %vget_lane = extractelement <8 x bfloat> %v, i32 7

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, kmclaughlin, efriedma. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli added a parent revision: D79638: [llvm][SVE] IR intrinscs

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli updated this revision to Diff 262923. fpetrogalli added a comment. I replaced the lines `Signed = !Signed` in the tablegen emitter with `Signed = false`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2198 +static void emitNeonTypeDefs(const std::string& types, raw_ostream ) { + std::string TypedefTypes(types); stuij wrote: > fpetrogalli wrote: > > Is this related to the

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

fpetrogalli added a comment. In D80323#2048457 , @rjmccall wrote: > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > really invasive change for pretty minimal benefit. Why not leave > `VectorType::get` as meaning a

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, it would be great if you could address the two comments I added, before submitting. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10775 - llvm::VectorType

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:91 Accelerate, // Use Accelerate framework. +LIBMVEC,// GLIBC Vector Math library. MASSV, // IBM MASS vector library. nemanjai wrote: >

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added a comment. Hi, Thank you for modifying the implementation to facilitate the extension to other targets. Please add `libmvec`-specific tests is `clang/Driver/fveclib.c`, and simplify the loop-vectorize tests. Other than that, I only have minor comments. Francesco

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added a comment. LGTM from the perspective of making sure that this solution can be extended to any of the architectures that `libmvec` supports. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:91 Accelerate, // Use Accelerate framework. +LIBMVEC,// GLIBC Vector Math library. MASSV, // IBM MASS vector library. Can we call this

[PATCH] D86065: [SVE] Make ElementCount members private

fpetrogalli added a comment. In D86065#2235434 , @david-arm wrote: > Hi @fpetrogalli, if you don't mind I think I'll stick with Paul's idea for > ogt because this matches the IR neatly, i.e. "fcmp ogt". Also, for me > personally it's much simpler and

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli added a comment. I merged it in the release branch as https://github.com/llvm/llvm-project/commit/7e6bf0bfe6de9e0d0e58764a66f93210f296bbfa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https://reviews.llvm.org/D85977

[PATCH] D86065: [SVE] Make ElementCount members private

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount , const ElementCount ) { +assert(LHS.Scalable == RHS.Scalable && paulwalker-arm wrote: > david-arm wrote: > > ctetreau wrote:

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli updated this revision to Diff 285731. fpetrogalli added a comment. Fix indentation of the code exmaple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https://reviews.llvm.org/D85977 Files:

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli created this revision. Herald added subscribers: llvm-commits, cfe-commits, tschuett. Herald added projects: clang, LLVM. fpetrogalli requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85977 Files:

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli updated this revision to Diff 285678. fpetrogalli added a comment. Added context to the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https://reviews.llvm.org/D85977 Files: clang/test/CodeGen/aarch64-sve-acle-example.cpp llvm/docs/ReleaseNotes.rst

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli updated this revision to Diff 286057. fpetrogalli marked 3 inline comments as done. fpetrogalli added a comment. Thank you for the review @david-arm. I have addressed all your comments, and I also have removed the additional unit tests that was checking that the example in the docs

[PATCH] D86065: [SVE] Make ElementCount members private

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount , const ElementCount ) { +assert(LHS.Scalable == RHS.Scalable && I think that @ctetreau is right on

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Might be worth waiting an extra day or two before submitting to make sure the people who provided extra feedback are happy. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80740: [SveEmitter] Add SVE ACLE for svld1ro.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. fpetrogalli added a parent revision: D80738: [llvm][SVE] IR intrinsic for LD1RO.. Repository: rG LLVM Github Monorepo

[PATCH] D80851: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

fpetrogalli created this revision. fpetrogalli added reviewers: efriedma, sdesmalen, kmclaughlin. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The following intrinsics have been added, guarded by the macro

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

fpetrogalli added a comment. Hi @c-rhodes, Peter asked me to take a look at this. LGTM, I only have minor stuff. In the commit message: > Arm C Language Extensions (ACLE, version 00bet5, section 3.7.3.3) for SVE [1]. It seems that a reference to [1] is missing:

[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you. Comment at: clang/utils/TableGen/SveEmitter.cpp:1265-1279 + OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n"; + OS << "#define svcvtnt_bf16_x

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. This patch is trying to align the interpretation of `-march` on AArch64 to what GCC has, in terms of

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 276204. fpetrogalli added a comment. Addressed code review, moving the code and adding more testing, including the `v8.5` one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:369 + if (llvm::is_contained(Features, "+v8.6a")) { +if (!llvm::is_contained(Features, "-i8mm") && +

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 276106. fpetrogalli added a comment. Removed the unrelated change of the empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/ https://reviews.llvm.org/D83079 Files:

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 277445. fpetrogalli added a comment. Update the `insert` invocation to use initializer list instead of calling it twice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

This revision was automatically updated to reflect the committed changes. Closed by commit rG438e95e95bfc: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 277879. fpetrogalli added a comment. Removed extra tests that are not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/ https://reviews.llvm.org/D83079 Files:

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

fpetrogalli marked an inline comment as done. fpetrogalli added a comment. In D83079#2129371 , @SjoerdMeijer wrote: > I haven't looked into details of these arch extensions yet, will do that > tomorrow, but I don't think there's any disagreement, i.e.,

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 275283. fpetrogalli added a comment. Update the patch to limit its scope to generate the feature macros for `-march=armv8.6a+sve`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

fpetrogalli added inline comments. Herald added a subscriber: danielkiss. Comment at: test/Driver/aarch64-cpus.c:518 +// RUN: %clang -target aarch64 -march=armv8.4-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV84A-NO-FP16FML %s +// GENERICV84A-NO-FP16FML-NOT:

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

fpetrogalli added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:1 -; RUN: llc -mtriple aarch64 -mattr=+sve -asm-verbose=1 < %s | FileCheck %s +; RUN: llc -mtriple aarch64 -mattr=+sve,+bf16 -asm-verbose=1 < %s | FileCheck %s

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82665/new/ https://reviews.llvm.org/D82665 ___ cfe-commits

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

This revision was automatically updated to reflect the committed changes. Closed by commit rG67e4330facfb: [sve][acle] Implement some of the C intrinsics for brain float. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

fpetrogalli updated this revision to Diff 274149. fpetrogalli added a comment. Rebase on top of master. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82345/new/ https://reviews.llvm.org/D82345 Files: clang/include/clang/Basic/arm_sve.td

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

fpetrogalli accepted this revision. fpetrogalli added a comment. Ship it! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82668/new/ https://reviews.llvm.org/D82668 ___ cfe-commits mailing list

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 276542. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. @sdesmalen, I have followed your suggestion to use insert instead of push_back! Code is much nicer now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e59dfc30124: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

fpetrogalli updated this revision to Diff 272480. fpetrogalli added a comment. Formatting changes. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/ https://reviews.llvm.org/D82141 Files: clang/include/clang/Basic/arm_sve.td

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

fpetrogalli requested changes to this revision. fpetrogalli added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef597eda8efc: [sve][acle] Add SVE BFloat16 extensions. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Comment at: clang/utils/TableGen/SveEmitter.cpp:1092 + OS << "#if !defined(__ARM_FEATURE_BF16_SCALAR_ARITHMETIC)\n"; + OS << "#error

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

fpetrogalli added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1092 + OS << "#if !defined(__ARM_FEATURE_BF16_SCALAR_ARITHMETIC)\n"; + OS << "#error \"__ARM_FEATURE_BF16_SCALAR_ARITHMETIC must be defined when " +"__ARM_FEATURE_SVE_BF16 is

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; nit: could create a

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_len.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true) +SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16,

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, kmclaughlin, c-rhodes, ctetreau. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, tschuett. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. The following intrinsics

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82298/new/ https://reviews.llvm.org/D82298 ___ cfe-commits

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; c-rhodes wrote: >

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

fpetrogalli updated this revision to Diff 273411. fpetrogalli added a comment. Removed the run lines that didn't work, as described in https://reviews.llvm.org/D82429#inline-759371 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82429/new/

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

This revision was automatically updated to reflect the committed changes. fpetrogalli marked an inline comment as done. Closed by commit rG7200fa38a912: [sve][acle] Add some C intrinsics for brain float types. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE

  1   2   3   >