Author: ibiryukov
Date: Tue Aug 14 02:36:32 2018
New Revision: 339665
URL: http://llvm.org/viewvc/llvm-project?rev=339665&view=rev
Log:
[clangd] Show non-instantiated decls in signatureHelp
Summary:
To avoid producing very verbose output in substitutions involving
typedefs, e.g.
T -> std::vecto
Author: ibiryukov
Date: Fri Aug 17 02:29:38 2018
New Revision: 340004
URL: http://llvm.org/viewvc/llvm-project?rev=340004&view=rev
Log:
[clangd] Show function documentation in signature help
Summary:
Previously, clangd was trying to show documentation for the active
parameter instead, which is wr
Author: ibiryukov
Date: Fri Aug 17 02:32:30 2018
New Revision: 340005
URL: http://llvm.org/viewvc/llvm-project?rev=340005&view=rev
Log:
[clangd] Fetch documentation from the Index during signature help
Summary:
Sema can only be used for documentation in the current file, other doc
comments should
Author: ibiryukov
Date: Wed Aug 22 04:39:16 2018
New Revision: 340401
URL: http://llvm.org/viewvc/llvm-project?rev=340401&view=rev
Log:
[clangd] Add callbacks on parsed AST in addition to parsed preambles
Summary:
Will be used for updating the dynamic index on updates to the open files.
Currently
Author: ibiryukov
Date: Wed Aug 22 05:43:17 2018
New Revision: 340404
URL: http://llvm.org/viewvc/llvm-project?rev=340404&view=rev
Log:
[clangd] Make FileIndex aware of the main file
Summary:
It was previously only indexing the preamble decls. The new
implementation will index both the preamble a
Author: ibiryukov
Date: Wed Aug 22 06:51:19 2018
New Revision: 340410
URL: http://llvm.org/viewvc/llvm-project?rev=340410&view=rev
Log:
[clangd] Get rid of regexes in CanonicalIncludes
Summary: Replace them with suffix mappings.
Reviewers: ioeric, kbobyrev
Reviewed By: ioeric
Subscribers: Mask
Author: ibiryukov
Date: Thu Aug 23 03:25:07 2018
New Revision: 340523
URL: http://llvm.org/viewvc/llvm-project?rev=340523&view=rev
Log:
[clangd] Increase the timeouts in TUScheduler tests to 10 seconds.
Some of them timeout on our buildbots in certain configurations.
The timeouts are there to avo
Author: ibiryukov
Date: Mon May 14 03:50:04 2018
New Revision: 332226
URL: http://llvm.org/viewvc/llvm-project?rev=332226&view=rev
Log:
[clangd] Don't query index when completing inside classes
Summary:
We used to query the index when completing after class qualifiers,
e.g. 'ClassName::^'. We sho
Author: ibiryukov
Date: Mon May 14 04:47:30 2018
New Revision: 332233
URL: http://llvm.org/viewvc/llvm-project?rev=332233&view=rev
Log:
[clangd] Fix warning after fully covered enum switch. NFC.
By adding llvm_unreachable.
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified:
Author: ibiryukov
Date: Mon May 14 06:50:36 2018
New Revision: 332244
URL: http://llvm.org/viewvc/llvm-project?rev=332244&view=rev
Log:
[CodeComplete] Provide completion in decls even for incomplete types
Summary:
This change fixes lack of completions in the following case
('^'designates completi
Author: ibiryukov
Date: Wed May 16 05:30:01 2018
New Revision: 332457
URL: http://llvm.org/viewvc/llvm-project?rev=332457&view=rev
Log:
[CodeComplete] Expose helpers to get RawComment of completion result.
Summary: Used in clangd, see D45999.
Reviewers: sammccall, hokein, ioeric, arphaman
Revie
Author: ibiryukov
Date: Wed May 16 05:30:09 2018
New Revision: 332458
URL: http://llvm.org/viewvc/llvm-project?rev=332458&view=rev
Log:
[AST] Added a helper to extract a user-friendly text of a comment.
Summary:
The helper is used in clangd for documentation shown in code completion
and storing t
Author: ibiryukov
Date: Wed May 16 05:32:49 2018
New Revision: 332460
URL: http://llvm.org/viewvc/llvm-project?rev=332460&view=rev
Log:
[clangd] Parse all comments in Sema and completion.
Summary:
And add tests for the comment extraction code.
clangd will now show non-doxygen comments in complet
Author: ibiryukov
Date: Wed May 16 05:32:44 2018
New Revision: 332459
URL: http://llvm.org/viewvc/llvm-project?rev=332459&view=rev
Log:
[clangd] Retrieve minimally formatted comment text in completion.
Summary:
Previous implementation used to extract brief text from doxygen comments.
Brief text p
th-lto-ubuntu/llvm.src/tools/clang/unittests/AST/CommentTextTest.cpp
>>> /home/buildslave/buildslave1a/clang-with-lto-ubuntu/llvm.src/tools/clang/unittests/AST/CommentTextTest.cpp:62:1:
>>> error: unterminated raw string
>>> R"cpp(
>>> ^
>>> . . .
>>&
Author: ibiryukov
Date: Tue May 22 06:10:09 2018
New Revision: 332976
URL: http://llvm.org/viewvc/llvm-project?rev=332976&view=rev
Log:
[clangd] Remove ignored Preamble::CanReuse call from completion
Summary:
Now that the clients who relied on stats for files from preamble are
gone.
Reviewers: i
Author: ibiryukov
Date: Tue May 22 06:29:37 2018
New Revision: 332978
URL: http://llvm.org/viewvc/llvm-project?rev=332978&view=rev
Log:
[clangd] Fix a typo. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp
URL:
http://ll
Author: ibiryukov
Date: Thu May 24 07:49:23 2018
New Revision: 333189
URL: http://llvm.org/viewvc/llvm-project?rev=333189&view=rev
Log:
[clangd] Serve comments for headers decls from dynamic index only
Summary:
To fix a crash in code completion that occurrs when reading doc
comments from files th
Author: ibiryukov
Date: Thu May 24 08:50:15 2018
New Revision: 333196
URL: http://llvm.org/viewvc/llvm-project?rev=333196&view=rev
Log:
[clangd] Build index on preamble changes instead of the AST changes
Summary:
This is more efficient and avoids data races when reading files that
come from the p
Author: ibiryukov
Date: Fri May 25 07:55:18 2018
New Revision: 333280
URL: http://llvm.org/viewvc/llvm-project?rev=333280&view=rev
Log:
[clangd] Temporarily disable the test that crashes under asan.
It turns out that our fix did not solve the problem completely and the
crash due to stale preamble
Author: ibiryukov
Date: Mon May 28 02:54:51 2018
New Revision: 69
URL: http://llvm.org/viewvc/llvm-project?rev=69&view=rev
Log:
[clangd] Workaround the comments crash, reenable the test.
This fix is still quite fragile, the underlying problem is that the
code should not rely on source ran
Author: ibiryukov
Date: Mon May 28 05:11:37 2018
New Revision: 70
URL: http://llvm.org/viewvc/llvm-project?rev=70&view=rev
Log:
[clangd] Fix leak sanitizers warnings in clangd
The commit includes two changes:
1. Set DisableFree to false when building the ParsedAST.
This is sane defaul
Author: ibiryukov
Date: Mon May 28 05:23:17 2018
New Revision: 71
URL: http://llvm.org/viewvc/llvm-project?rev=71&view=rev
Log:
[clangd] Remove accessors for top-level decls from preamble
Summary:
They cause lots of deserialization and are not actually used.
The ParsedAST accessor that pr
Author: ibiryukov
Date: Mon May 28 05:43:20 2018
New Revision: 73
URL: http://llvm.org/viewvc/llvm-project?rev=73&view=rev
Log:
[clangd] Remove the outdated comment. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tools-extra/trunk/unittes
Author: ibiryukov
Date: Thu Sep 28 11:39:59 2017
New Revision: 314445
URL: http://llvm.org/viewvc/llvm-project?rev=314445&view=rev
Log:
[clangd] Skip informative qualifier chunks.
Summary:
Completion results look much nicer without them.
Informative qualifiers are stored for every method from a b
Author: ibiryukov
Date: Mon Oct 2 08:10:41 2017
New Revision: 314677
URL: http://llvm.org/viewvc/llvm-project?rev=314677&view=rev
Log:
[clangd] Run clang-format on the source code. NFC.
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.h
Modified: clang-tools-extra/trunk/clangd/Prot
Author: ibiryukov
Date: Mon Oct 2 08:13:20 2017
New Revision: 314678
URL: http://llvm.org/viewvc/llvm-project?rev=314678&view=rev
Log:
[clangd] Command line arg to specify compile_commands.json path
Summary: Adds compileCommands command line argument to specify an absolute path
directly to the
Author: ibiryukov
Date: Thu Oct 5 10:04:13 2017
New Revision: 314989
URL: http://llvm.org/viewvc/llvm-project?rev=314989&view=rev
Log:
[clangd] Added async API to run code completion.
Summary:
ClangdServer now provides async code completion API.
It is still used synchronously by ClangdLSPServer,
Author: ibiryukov
Date: Thu Oct 5 15:15:15 2017
New Revision: 315028
URL: http://llvm.org/viewvc/llvm-project?rev=315028&view=rev
Log:
[clangd] Attempt to fix compilation with MSVC.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.h
Modified: clang-tools-extra/trunk/clangd/ClangdServer
-fast/builds/12525
>
> Can you take a look and fix it?
>
> Douglas Yung
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of
> > Ilya Biryukov via cfe-commits
> > Sent: Thursday, October 05, 2017 10:04
Author: ibiryukov
Date: Fri Oct 6 04:54:17 2017
New Revision: 315055
URL: http://llvm.org/viewvc/llvm-project?rev=315055&view=rev
Log:
[clangd] Add textDocument/signatureHelp
Summary:
Makes clangd respond to a client's "textDocument/signatureHelp" request by
presenting function/method overloads.
Author: ibiryukov
Date: Fri Oct 6 07:39:39 2017
New Revision: 315065
URL: http://llvm.org/viewvc/llvm-project?rev=315065&view=rev
Log:
[clangd] Run clang-format on the source code. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clangd/Clangd
Author: ibiryukov
Date: Mon Oct 9 09:26:26 2017
New Revision: 315210
URL: http://llvm.org/viewvc/llvm-project?rev=315210&view=rev
Log:
[clangd] Added move-only function helpers.
Summary:
They are now used in ClangdScheduler instead of deferred std::async
computations.
The results of `std::async`
Author: ibiryukov
Date: Mon Oct 9 09:52:12 2017
New Revision: 315212
URL: http://llvm.org/viewvc/llvm-project?rev=315212&view=rev
Log:
Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.
Summary:
It was previsouly set only in ASTUnit, but it should be set for all client of
Precomp
Author: ibiryukov
Date: Mon Oct 9 09:53:00 2017
New Revision: 315213
URL: http://llvm.org/viewvc/llvm-project?rev=315213&view=rev
Log:
[clangd] Added a test for r315212.
Added:
clang-tools-extra/trunk/test/clangd/diagnostics-preamble.test
Added: clang-tools-extra/trunk/test/clangd/diagnosti
Author: ibiryukov
Date: Mon Oct 9 09:58:16 2017
New Revision: 315214
URL: http://llvm.org/viewvc/llvm-project?rev=315214&view=rev
Log:
[clangd] Added a command-line arg to mirror clangd input into a file.
Summary: The arg is useful for debugging and creating test cases.
Reviewers: bkramer, kras
t;
> Galina
>
>
> On Mon, Oct 9, 2017 at 9:26 AM, Ilya Biryukov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ibiryukov
>> Date: Mon Oct 9 09:26:26 2017
>> New Revision: 315210
>>
>> URL: http://llvm.org/viewvc/llvm-p
Author: ibiryukov
Date: Tue Oct 10 01:40:57 2017
New Revision: 315284
URL: http://llvm.org/viewvc/llvm-project?rev=315284&view=rev
Log:
[clangd] Fix compilation on gcc.
Modified:
clang-tools-extra/trunk/clangd/Function.h
Modified: clang-tools-extra/trunk/clangd/Function.h
URL:
http://llvm.o
://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-
>> test/builds/16435
>>
>> Please have a look?
>>
>> Thanks
>>
>> Galina
>>
>>
>> On Mon, Oct 9, 2017 at 9:26 AM, Ilya Biryukov via cfe-commits <
>> cfe-commits@lists.llvm.org> wro
Author: ibiryukov
Date: Tue Oct 10 02:08:47 2017
New Revision: 315287
URL: http://llvm.org/viewvc/llvm-project?rev=315287&view=rev
Log:
Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"
This reverts commit r315242 and restores r315214.
To fix original failure, replaced non-
Sorry about that, `diff -b` seems to work. Restored commit and changed to
`diff -b` in r315287.
Thanks for spotting and reverting this.
On Mon, Oct 9, 2017 at 8:45 PM, Bruno Cardoso Lopes wrote:
> Hi,
>
> On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov via cfe-commits
> wrote
Author: ibiryukov
Date: Tue Oct 10 07:21:04 2017
New Revision: 315317
URL: http://llvm.org/viewvc/llvm-project?rev=315317&view=rev
Log:
[clangd] clang-format the source code. NFC.
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
clang-tools-extra/trunk/clangd/Protoco
Author: ibiryukov
Date: Tue Oct 10 09:12:50 2017
New Revision: 315324
URL: http://llvm.org/viewvc/llvm-project?rev=315324&view=rev
Log:
[clangd] Added missing #includes to Function.h
Modified:
clang-tools-extra/trunk/clangd/Function.h
Modified: clang-tools-extra/trunk/clangd/Function.h
URL:
Author: ibiryukov
Date: Tue Oct 10 09:12:47 2017
New Revision: 315323
URL: http://llvm.org/viewvc/llvm-project?rev=315323&view=rev
Log:
[clangd] Added forgotten return in UniqueFunction.
This hasn't bitten us because we only used functions returning
'void'.
Modified:
clang-tools-extra/trunk/
Author: ibiryukov
Date: Tue Oct 10 09:12:54 2017
New Revision: 315325
URL: http://llvm.org/viewvc/llvm-project?rev=315325&view=rev
Log:
[clangd] Use UniqueFunction for deferred computations.
Previsouly, `std::future` that were results of
`std::async(std::launch::deferred, ...` were used.
Modifie
Author: ibiryukov
Date: Sun Oct 22 23:06:21 2017
New Revision: 316311
URL: http://llvm.org/viewvc/llvm-project?rev=316311&view=rev
Log:
[clangd] Report proper kinds for 'Keyword' and 'Snippet' completion items.
Reviewers: rwols, malaperle, krasimir, bkramer, sammccall
Reviewed By: rwols, sammcca
for this?
>
> On Tue, Oct 10, 2017 at 9:12 AM Ilya Biryukov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ibiryukov
>> Date: Tue Oct 10 09:12:47 2017
>> New Revision: 315323
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: ibiryukov
Date: Mon Oct 23 07:08:52 2017
New Revision: 316323
URL: http://llvm.org/viewvc/llvm-project?rev=316323&view=rev
Log:
[clangd] Updated outdated test comment. NFC.
Modified:
clang-tools-extra/trunk/test/clangd/input-mirror.test
Modified: clang-tools-extra/trunk/test/clangd/i
Missed that, will do, thanks.
On Wed, Oct 11, 2017 at 1:39 AM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> On Tue, Oct 10, 2017 at 2:08 AM, Ilya Biryukov via cfe-commits
> wrote:
> > Author: ibiryukov
> > Date: Tue Oct 10 02:08:47 2017
> > New Revi
Author: ibiryukov
Date: Mon Oct 23 07:46:48 2017
New Revision: 316327
URL: http://llvm.org/viewvc/llvm-project?rev=316327&view=rev
Log:
[clangd] Allow to pass code completion opts to ClangdServer.
Reviewers: bkramer, krasimir, sammccall
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Di
Author: ibiryukov
Date: Wed Oct 25 01:45:41 2017
New Revision: 316564
URL: http://llvm.org/viewvc/llvm-project?rev=316564&view=rev
Log:
[clangd] Handle exit notification (proper shutdown)
Summary:
This changes the onShutdown handler to do essentially nothing (for now), and
instead exits the runlo
Author: ibiryukov
Date: Wed Oct 25 02:35:10 2017
New Revision: 316565
URL: http://llvm.org/viewvc/llvm-project?rev=316565&view=rev
Log:
[clangd] Added a callback-based codeComplete in clangd.
Reviewers: klimek, bkramer, sammccall, krasimir
Reviewed By: sammccall
Subscribers: rwols, cfe-commits
Author: ibiryukov
Date: Fri Aug 24 02:03:29 2018
New Revision: 340599
URL: http://llvm.org/viewvc/llvm-project?rev=340599&view=rev
Log:
[Tooling] Add a isSingleProcess() helper to ToolExecutor
Summary:
Used in clangd's symbol builder to optimize for the common
shared-memory executor case.
Review
Author: ibiryukov
Date: Fri Aug 24 02:03:54 2018
New Revision: 340600
URL: http://llvm.org/viewvc/llvm-project?rev=340600&view=rev
Log:
[clangd] Allow to merge symbols on-the-fly in global-symbol-builder
Summary:
The new mode avoids serializing and deserializing YAML.
This results in better perfo
Author: ibiryukov
Date: Tue Aug 28 03:57:45 2018
New Revision: 340815
URL: http://llvm.org/viewvc/llvm-project?rev=340815&view=rev
Log:
[clangd] Add some trace::Spans. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified: c
Author: ibiryukov
Date: Tue Aug 28 04:04:07 2018
New Revision: 340816
URL: http://llvm.org/viewvc/llvm-project?rev=340816&view=rev
Log:
[clangd] Remove unused parameter. NFC
Modified:
clang-tools-extra/trunk/clangd/XRefs.cpp
Modified: clang-tools-extra/trunk/clangd/XRefs.cpp
URL:
http://llv
Author: ibiryukov
Date: Tue Aug 28 09:15:56 2018
New Revision: 340838
URL: http://llvm.org/viewvc/llvm-project?rev=340838&view=rev
Log:
Parse compile commands lazily in InterpolatingCompilationDatabase
Summary:
This greatly reduces the time to read 'compile_commands.json'.
For Chromium on my mach
Author: ibiryukov
Date: Wed Aug 29 09:35:31 2018
New Revision: 340937
URL: http://llvm.org/viewvc/llvm-project?rev=340937&view=rev
Log:
[Tooling] Do not restore working dir in ClangTool
Summary:
Resolve all relative paths before running the tool instead.
This fixes the usage of ClangTool in AllT
Author: ibiryukov
Date: Thu Aug 30 06:08:03 2018
New Revision: 341063
URL: http://llvm.org/viewvc/llvm-project?rev=341063&view=rev
Log:
[CodeComplete] Report location of opening parens for signature help
Summary: Used in clangd.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ioeric,
Author: ibiryukov
Date: Thu Aug 30 06:14:31 2018
New Revision: 341065
URL: http://llvm.org/viewvc/llvm-project?rev=341065&view=rev
Log:
[clangd] Report position of opening paren in singature help
Summary: Only accessible via the C++ API at the moment.
Reviewers: sammccall
Reviewed By: sammccall
Author: ibiryukov
Date: Mon Sep 3 07:39:34 2018
New Revision: 341319
URL: http://llvm.org/viewvc/llvm-project?rev=341319&view=rev
Log:
[clangd] Handle errors before checking for cancelltion
To avoid hitting assertions in llvm::Expected destructor.
Modified:
clang-tools-extra/trunk/clangd/Cl
Author: ibiryukov
Date: Mon Sep 3 08:25:27 2018
New Revision: 341322
URL: http://llvm.org/viewvc/llvm-project?rev=341322&view=rev
Log:
[clangd] Avoid crashes in override completions
Summary: NamedDecl::getName cannot be called on non-identifier names.
Reviewers: kadircet, ioeric, hokein, sammcc
Author: ibiryukov
Date: Tue Sep 4 07:15:53 2018
New Revision: 341366
URL: http://llvm.org/viewvc/llvm-project?rev=341366&view=rev
Log:
Adding HardLink Support to VirtualFileSystem.
Summary:
Added support of creating a hardlink from one file to another file.
After a hardlink is added between two
+1 for consistent style, but why not use enum class everywhere instead?
On Wed, Sep 5, 2018 at 12:41 PM Sam McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sammccall
> Date: Wed Sep 5 03:39:58 2018
> New Revision: 341459
>
> URL: http://llvm.org/viewvc/llvm-project?rev=3414
Any pointers to the GCC bug/breakage mentioned?
On Thu, Sep 6, 2018 at 11:44 AM Ilya Biryukov wrote:
> +1 for consistent style, but why not use enum class everywhere instead?
>
> On Wed, Sep 5, 2018 at 12:41 PM Sam McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: sammcc
Author: ibiryukov
Date: Thu Sep 6 04:04:56 2018
New Revision: 341538
URL: http://llvm.org/viewvc/llvm-project?rev=341538&view=rev
Log:
[clangd] Fix data race in async fuzzyFind tests.
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tools-extra/trunk/
I would generally vouch for strongly typed enums, because there're nicer in
many aspects (no implicit integer conversions, no enumerators thrown into
the namespaces).
With regards to naming conventions, PCHStorage::Memory or
CompletionStyle::Bundled look pretty neat to me, the usual alternative for
Author: ibiryukov
Date: Fri Sep 7 07:04:39 2018
New Revision: 341660
URL: http://llvm.org/viewvc/llvm-project?rev=341660&view=rev
Log:
[CodeComplete] Clearly distinguish signature help and code completion.
Summary:
Code completion in clang is actually a mix of two features:
- Code completion is
Author: ibiryukov
Date: Tue Sep 11 00:29:09 2018
New Revision: 341910
URL: http://llvm.org/viewvc/llvm-project?rev=341910&view=rev
Log:
[Tooling] Restore working dir in ClangTool.
Summary:
And add an option to disable this behavior. The option is only used in
AllTUsExecutor to avoid races when ru
Author: ibiryukov
Date: Thu Sep 13 02:44:11 2018
New Revision: 342123
URL: http://llvm.org/viewvc/llvm-project?rev=342123&view=rev
Log:
[clangd] Rename global-symbol-builder to clangd-indexer.
Summary:
Given that the indexer binary is put directly into ./bin directory
when built, 'clangd-' prefix
This introduced revision introduced a new warning:
../tools/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:62:7:
warning: '(anonymous namespace)::NeedsCastLocField' has virtual functions
but non-virtual destructor [-Wnon-virtual-dtor]
Which is turned into an error o
Ah, the reason why it does not fire on other inheritors is because they're
final. Any reason to remove final from NeedsCastLocField?
On Fri, Sep 14, 2018 at 1:17 PM Ilya Biryukov wrote:
> This introduced revision introduced a new warning:
> ../tools/clang/lib/StaticAnalyzer/Checkers/Uninitialize
Author: ibiryukov
Date: Fri Sep 14 04:28:48 2018
New Revision: 342225
URL: http://llvm.org/viewvc/llvm-project?rev=342225&view=rev
Log:
[analyzer] Restore final on NeedsCastLocField. NFC
To fix compiler warning about non-virtual dtor introduced in r342221.
Modified:
cfe/trunk/lib/StaticAnal
I've sent a quick workaround restoring final (r342225) to unbreak our
internal buildbots.
On Fri, Sep 14, 2018 at 1:20 PM Ilya Biryukov wrote:
> Ah, the reason why it does not fire on other inheritors is because they're
> final. Any reason to remove final from NeedsCastLocField?
>
> On Fri, Sep
Author: ibiryukov
Date: Fri Sep 14 04:39:05 2018
New Revision: 342226
URL: http://llvm.org/viewvc/llvm-project?rev=342226&view=rev
Log:
[clangd] Update IndexerMain.cpp file comment after rename. NFC
Modified:
clang-tools-extra/trunk/clangd/indexer/IndexerMain.cpp
Modified: clang-tools-extra/
Hi Richard,
this commit seems to cause invalid warning in the following example:
struct foo {
foo(char *x) : x_(&x[10]) {} //
private:
char *x_;
};
The warning itself:
1.cpp:2:21: warning: initializing pointer member 'x_' with the stack
address of parameter 'x' [-Wdangling-field]
I'll rever
Author: ibiryukov
Date: Sun Jul 22 23:32:36 2018
New Revision: 337671
URL: http://llvm.org/viewvc/llvm-project?rev=337671&view=rev
Log:
Revert "Fold dangling-field warning into general initialization lifetime
checks."
This reverts commit r337627.
After the change, clang started producing invalid
Reverted in r337671
On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov wrote:
> Hi Richard,
>
> this commit seems to cause invalid warning in the following example:
>
> struct foo {
> foo(char *x) : x_(&x[10]) {} //
> private:
> char *x_;
> };
>
> The warning itself:
> 1.cpp:2:21: warning: initia
Author: ibiryukov
Date: Thu Jul 26 02:21:07 2018
New Revision: 338012
URL: http://llvm.org/viewvc/llvm-project?rev=338012&view=rev
Log:
[clangd] Do not rebuild AST if inputs have not changed
Summary:
If the contents are the same, the update most likely comes from the
fact that compile commands we
Author: ibiryukov
Date: Thu Jul 26 05:05:31 2018
New Revision: 338021
URL: http://llvm.org/viewvc/llvm-project?rev=338021&view=rev
Log:
[clangd] Fix (most) naming warnings from clang-tidy. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-extra/trunk/clangd/ClangdUni
Author: ibiryukov
Date: Thu Jul 26 09:13:52 2018
New Revision: 338037
URL: http://llvm.org/viewvc/llvm-project?rev=338037&view=rev
Log:
[clangd] Use 'const Twine&' instead of 'Twine'. NFC
To fix clang-tidy warning
Modified:
clang-tools-extra/trunk/clangd/Threading.cpp
clang-tools-extra/t
Author: ibiryukov
Date: Fri Jul 27 07:05:39 2018
New Revision: 338124
URL: http://llvm.org/viewvc/llvm-project?rev=338124&view=rev
Log:
[clang-tidy] Fix a crash in fuchsia-multiple-inheritance
Summary: See the test case for a repro.
Reviewers: juliehockett, ioeric, hokein, aaron.ballman
Reviewe
Author: ibiryukov
Date: Mon Jul 30 04:46:25 2018
New Revision: 338241
URL: http://llvm.org/viewvc/llvm-project?rev=338241&view=rev
Log:
[clangd] Fix a comment. NFC
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified: clang-tools-extra/trunk/clangd/TUScheduler.cpp
URL:
http://l
Author: ibiryukov
Date: Mon Jul 30 08:19:05 2018
New Revision: 338255
URL: http://llvm.org/viewvc/llvm-project?rev=338255&view=rev
Log:
[CodeComplete] Fix the crash in code completion on access checking
Started crashing in r337453. See the added test case for the crash repro.
The fix reverts par
Prtially reverted the commit in r338255 to fix a very frequent crash.
The code seemed obviously wrong there (calling accessibility checking,
passing a possibly unrelated class) and the tests didn't break after
reverting it.
Let me know if I missed anything.
On Thu, Jul 19, 2018 at 3:37 PM Eric Li
Author: ibiryukov
Date: Mon Jul 30 08:30:45 2018
New Revision: 338256
URL: http://llvm.org/viewvc/llvm-project?rev=338256&view=rev
Log:
[clangd] Do not remove AST from cache if nothing changed
We were previously clearing the AST cache if the inputs and the
preamble were the same, which is not des
Author: ibiryukov
Date: Mon Jul 30 08:55:13 2018
New Revision: 338260
URL: http://llvm.org/viewvc/llvm-project?rev=338260&view=rev
Log:
[clangd] Remove outdated comment. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.h
Modified: clang-tools-extra/trunk/clangd/ClangdServer.h
URL:
I actually tried to pass the correct derived scope to
CodeCompletionDeclConsumer on construction, it was not a lot of code and I
think this should fix the problem you're describing.
I'll send a patch.
On Tue, Jul 31, 2018 at 11:33 AM Eric Liu wrote:
> Thanks a lot for looking into this!
>
> You
Author: ibiryukov
Date: Tue Jul 31 04:47:52 2018
New Revision: 338361
URL: http://llvm.org/viewvc/llvm-project?rev=338361&view=rev
Log:
[clangd] Report diagnostics even if WantDiags::No AST was reused
Summary:
After r338256, clangd stopped reporting diagnostics if WantDiags::No request
is followe
Author: ibiryukov
Date: Tue Jul 31 06:45:37 2018
New Revision: 338378
URL: http://llvm.org/viewvc/llvm-project?rev=338378&view=rev
Log:
[clangd] Do not build AST if no diagnostics were requested
Summary:
It can be removed from the cache before the first access anyway, so
building it can be a wast
Author: ibiryukov
Date: Wed Aug 1 08:32:56 2018
New Revision: 338578
URL: http://llvm.org/viewvc/llvm-project?rev=338578&view=rev
Log:
[Format] Fix for bug 35641
Summary:
Bug was caused due to comments at the start of scope. For a code like:
```
int func() { //
int b;
int c;
}
```
the commen
It probably tries doing a standalone build of clang without LLVM.
clang/config.h doesn't seem to include the HAVE_PTHREAD_GETSPECIFIC used in
Context.cpp.
We can either add the corresponding macro to clang's config.h or follow
jyknight's suggestions and figure out if we can remove pthread-specific
Author: ibiryukov
Date: Tue Feb 6 07:53:42 2018
New Revision: 324356
URL: http://llvm.org/viewvc/llvm-project?rev=324356&view=rev
Log:
[clangd] The new threading implementation
Summary:
In the new threading model clangd creates one thread per file to manage
the AST and one thread to process each
Author: ibiryukov
Date: Tue Feb 6 08:32:36 2018
New Revision: 324361
URL: http://llvm.org/viewvc/llvm-project?rev=324361&view=rev
Log:
[clangd] Fixed compilation on Windows buildbot.
Modified:
clang-tools-extra/trunk/unittests/clangd/ThreadingTests.cpp
Modified: clang-tools-extra/trunk/unit
Author: ibiryukov
Date: Tue Feb 6 09:22:58 2018
New Revision: 324363
URL: http://llvm.org/viewvc/llvm-project?rev=324363&view=rev
Log:
[clangd] Fixed a bug in the new threading implementation.
This should fix the buildbots.
Modified:
clang-tools-extra/trunk/clangd/Threading.cpp
Modified: c
Author: ibiryukov
Date: Tue Feb 6 11:09:44 2018
New Revision: 324382
URL: http://llvm.org/viewvc/llvm-project?rev=324382&view=rev
Log:
[clangd] Attempt to unbreak windows buildbots.
Some buildbots are breaking on trace.test due to using Linux's path
separators. This commit should unbreak them.
Author: ibiryukov
Date: Tue Feb 6 11:22:40 2018
New Revision: 324386
URL: http://llvm.org/viewvc/llvm-project?rev=324386&view=rev
Log:
Revert "[clangd] The new threading implementation" (r324356)
And the follow-up changes r324361 and r324363.
These changes seem to break two buildbots:
- http:/
Author: ibiryukov
Date: Wed Feb 7 23:37:35 2018
New Revision: 324575
URL: http://llvm.org/viewvc/llvm-project?rev=324575&view=rev
Log:
Resubmit "[clangd] The new threading implementation"
Initially submitted as r324356 and reverted in r324386.
This change additionally contains a fix to crashes
Author: ibiryukov
Date: Thu Feb 8 04:46:34 2018
New Revision: 324599
URL: http://llvm.org/viewvc/llvm-project?rev=324599&view=rev
Log:
[clangd] Update include guard in Annotations.h. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/Annotations.h
Modified: clang-tools-extra/trunk/unitt
Author: ibiryukov
Date: Fri Feb 9 02:17:23 2018
New Revision: 324725
URL: http://llvm.org/viewvc/llvm-project?rev=324725&view=rev
Log:
[clangd] Remove threading-related code from ClangdUnit.h
Reviewers: sammccall, hokein, ioeric
Reviewed By: sammccall
Subscribers: klimek, jkorous-apple, cfe-co
1 - 100 of 1070 matches
Mail list logo
