[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

jaafar added a comment. It's been pointed out to me that 28546 preceded this commit... so it may only //appear// related. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52676/new/ https://reviews.llvm.org/D52676 ___

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

jaafar added a comment. Hi everyone, I've been investigating a bug and bisected it to this commit. The problem, in brief, is that lambdas passed as arguments can cause an extra line break before the first argument, but only if the lambda is neither the first nor the last argument. This

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

jaafar added inline comments. Comment at: cfe/trunk/lib/Format/TokenAnnotator.cpp:3072 + return false; +if (!Next->isOneOf(TT_LambdaLSquare, tok::l_brace, tok::caret)) + return true; This is the clause that triggers the problem. Repository: rL

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar added a comment. "Ping". I hope this can be considered for 10.0.1. If nothing else I think reviewing the test cases has a lot of value - there are some real issues with the current checks and fixits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272580. jaafar added a comment. Applied feedback from Aaron Ballman. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar marked an inline comment as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272674. jaafar added a comment. Applied feedback from Nathan James CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar marked 3 inline comments as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar added a comment. I do need someone to commit this, yes, thank you. I'm Jeff Trull edas...@att.net CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 ___ cfe-commits mailing list

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272813. jaafar marked an inline comment as done. jaafar added a comment. One more simplification from Aaron. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files:

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. Thnaks very much @hokein . The ones I need are: 9a5c448a31bacc08e73fcae4636094f9b6e2be6a eaf0c89ec5f866b6cef296c542c030bb2cf8481d

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

jaafar added a comment. I can confirm that this commit works equally well for the UTF-8 assertion failure. Thank you! Is there some way to easily modify the source to produce a diagnostic pointing to the issue's source location? I would like to file an appropriate bug in Boost. Repository:

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or 10.0.1-rc1 either. Is there any chance it can be released? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74025/new/ https://reviews.llvm.org/D74025

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. Thank you. I'm trying to balance stability with getting the fixes I need and so have been avoiding the "bleeding edge". I find that unfortunately the newest code tends to be "unstable", as those releases are rightfully named, and I need clangd for my daily work. There

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

jaafar added a comment. Thanks for the detailed analysis! I have filed https://github.com/boostorg/spirit/issues/612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81530/new/ https://reviews.llvm.org/D81530

[PATCH] D81769: Repair various issues with modernize-avoid-bind

jaafar created this revision. jaafar added reviewers: aaron.ballman, alexfh, hokein. jaafar added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the process of running this check on a large codebase

[PATCH] D81769: Repair various issues with modernize-avoid-bind

jaafar marked 3 inline comments as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:38 enum BindArgumentKind { BK_Temporary, BK_Placeholder, BK_CallExpr, BK_Other }; -enum CaptureMode { CM_None, CM_ByRef, CM_ByValue,