[PATCH] D42730: Add clang-tidy check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 6 inline comments as done. massberg added a comment. Alex and Aaron, thanks for the comments! Comment at: clang-tidy/modernize/AvoidFunctionalCheck.cpp:21 +void AvoidFunctionalCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( +

[PATCH] D42730: Add clang-tidy check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132137. massberg retitled this revision from "Add clang-tidy check for use of types/classes/functions from functional.h which are deprecated and removed in C++17" to "Add clang-tidy check for use of types/classes/functions from header which are deprecated

[PATCH] D42730: Add clang-tidy check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132169. massberg added a comment. Addressed comments of reviewer. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt

[PATCH] D42730: Add clang-tidy check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 4 inline comments as done. massberg added inline comments. Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19 + +/// Check for several deprecated types and classes from header +/// massberg wrote: > aaron.ballman wrote: > > Missing full

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132592. massberg marked an inline comment as done. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132538. massberg added a comment. Addressed comments of reviewers. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: test/clang-tidy/modernize-avoid-functional.cpp:30 + +// CHECK-MESSAGES: [[@LINE+1]]:25: warning: 'binary_function' is deprecated in C++11 and removed in C++17

[PATCH] D42730: Add clang-tidy check for use of types/classes/functions from functional.h which are deprecated and removed in C++17

massberg created this revision. massberg added a reviewer: alexfh. Herald added subscribers: cfe-commits, hintonda, mgorny. In C++17 several classes, types and functions from functional.h are no longer available. In this change we add first clang-tidy checks for occurrences of -

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 4 inline comments as done. massberg added a comment. Thanks for the comments! I double-checked that the renaming went well and hope that I haven't missed anything this time ... https://reviews.llvm.org/D42730 ___ cfe-commits

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 133027. massberg edited the summary of this revision. massberg added a comment. Addressed comments and renamed test to modernize-deprecated-functional https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/CMakeLists.txt

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 134578. massberg edited the summary of this revision. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedFunctionalCheck.cpp clang-tidy/modernize/DeprecatedFunctionalCheck.h

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 8 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:26 +.bind("base")), + anyOf(isClass(),

[PATCH] D96281: Add options to flag individual core increments and to ignore macros to cognitive complexity check.

massberg created this revision. massberg added reviewers: lebedev.ri, alexfh. Herald added a subscriber: nullptr.cpp. massberg requested review of this revision. Herald added a project: clang. Often you are only interested in the overall cognitive complexity of a function and not every individual

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 322921. massberg added a comment. Clarified option FlagBasicIncrements and removed base default constructor from class initializer list of FunctionASTVisitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : RecursiveASTVisitor(),

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323052. massberg marked 2 inline comments as done. massberg added a comment. Add test cases showing that when IgnoreMacros is set to 'true', also macro arguments are ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2556586 , @njames93 wrote: > How does this handle a macro where the argument has complex code. > > MACRO(if (...) {}); I agree that macro arguments should account to the complexity. However, with this change macro

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 329559. massberg added a comment. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://reviews.llvm.org/D98070 Files:

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327721. massberg added a comment. Remove IgnoreMacros option (to be added in a follow up patch) and sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2596657 , @lebedev.ri wrote: > Once again, can we please split this into two patches? > I'm quite happy with the `DescribeBasicIncrements` stuff, that can be merged > right now. I have removed the IgnoreMacros and

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327746. massberg added a comment. Add checks to ensure that notes aren't added for specific options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281 Files:

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327805. massberg added a comment. Remove unnecessary checks. After testing locally it turned out that we do not need these checks. If there is an unexpected note, the test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-function-cognitive-complexity-flags.cpp:16 + // CHECK-NOTES: :[[@LINE-1]]:6: warning: function 'func_of_complexity_4' has cognitive

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg created this revision. Herald added subscribers: lebedev.ri, xazax.hun. Herald added a reviewer: lebedev.ri. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a macro is used within a function, the code inside the macro

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 336831. massberg added a comment. Add test with global IgnoreMacros=true and readability-function-cognitive-complexity.IgnoreMacros unset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 336848. massberg added a comment. Add note that the new IgnoreMarcos options isn't guaranteed to be forward compatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31 + any macro arguments are ignored, even if they should count to the complexity. + Default is

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323962. massberg added a comment. Change option name, improve description and minor fixes. - Change name FlagBasicIncrements to DescribeBasicIncrements. - Improve description of this option and added an example. - Minor code fixes. Repository: rG LLVM

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg marked 4 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.h:24-26 +/// * `FlagBasicIncrements`- if set to `true`, additional to flagging +//

[PATCH] D155858: Add a concept AST node.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; +

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554660. massberg marked 3 inline comments as done. massberg added a comment. Resolve remaining comments. - Added tests for new location functions of `ConceptReference`. There is an existing bug with the end location if there are no template arguments. As

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159450

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d2e756dacfd: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554743. massberg marked 7 inline comments as done. massberg added a comment. Fixed remaining nits. Thanks for the reviews and comments everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/

[PATCH] D155858: Add a concept AST node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2bf9baf5987: Add a concept AST node. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc39dcd2c2bc7: [c++20][clangd] Simplify code using the new `ConceptReference` nodes. (authored by massberg). Repository: rG LLVM Github Monorepo

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg updated this revision to Diff 554985. massberg marked an inline comment as done. massberg added a comment. Use VisitConceptReference instead of TraverseConceptReference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159268/new/

[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

massberg accepted this revision. massberg added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159300/new/ https://reviews.llvm.org/D159300

[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

massberg added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:2545 }; -dependentSizedArrayType() +dependentSizedArrayType matches "T data[Size]" Was this change to drop the () by purpose? Comment at:

[PATCH] D159465: Add index test with unconstrained auto.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without the fix in

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552742. massberg marked 4 inline comments as done. massberg added a comment. Resolved the next round of comments. There are still some left to be addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554257. massberg marked 7 inline comments as done. massberg added a comment. Resolve more of the open comments. - add `getBeginLoc()`, `getEndLoc()` and `getSourceRange()` to `ConceptReference` and updated corresponding functions in

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552307. massberg added a comment. Resolve some of the reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.org/D155858 Files:

[PATCH] D155858: Add a concept AST node.

massberg marked 13 inline comments as done. massberg added a comment. I have resolved some of the comments, but I need another round to finish all of the, Thanks to all reviewers so far! Comment at: clang/include/clang/AST/ExprConcepts.h:90 + // NOTE(massberg): For the first

[PATCH] D155858: Add a concept AST node.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size];

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++20 is more strict when erroring out due to incomplete types.

[PATCH] D141671: Move definitions to prevent incomplete types.

massberg added a comment. I have updated the code. It turned out that much less code has to be moved than I initially thought. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg added a comment. > Having as few code in headers as possible is the general style guide in LLVM, > so I'd rather err towards that and put definitions out-of-line as much as > possible. Therefore if we can getaway by just moving definitions out-of-line, > while keeping rest of the

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg updated this revision to Diff 488976. massberg added a comment. Clean up code and only mode definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 Files:

[PATCH] D141671: Move definitions to prevent incomplete types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480475. massberg added a comment. Moved check if we have a pack expansion with reference type to Sema::BuildLambdaExpr. I'm still not sure if this is the right place, or if `From.isCopyCapture()` should be `false` for pack expansions with refernece types.

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 481264. massberg added a comment. Use isLocalVarDecl to check if we have a local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files:

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 481295. massberg added a comment. Reuse existing error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. In D139400#3974624 , @shafik wrote: > It looks like we have an existing message for the regular function case Thanks! We can indeed reuse this error message. In D139400#3974654 ,

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 482140. massberg added a comment. Additionally check for ODR use and remove inlcude added by accident. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files:

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:11 +#include // massberg #include "TreeTransform.h" shafik wrote: > Please remove. Ups, thanks! Comment at:

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I haven't found an existing error message for this in

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType,

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 480369. massberg added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType,

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480518. massberg added a comment. Instead of lokking if there is a pack expansion pass the already computed information whether we have a by ref or a by copy type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480800. massberg added a comment. Simplify code and update description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://reviews.llvm.org/D139125 Files: clang/include/clang/Sema/Sema.h

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType,

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. In D139400#3974654 , @shafik wrote: > It looks like the existing diagnostic is issued by > `CheckDefaultArgumentVisitor`. I think you can reuse it here but not 100% on > that. Thanks for the pointer! I will have a look.

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedbea62f72f7: [clang] Correctly handle by-reference capture with an initializer that is a… (authored by massberg). Repository: rG LLVM Github

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename parameter in Sema::addInitCapture as proposed in review of

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138701/new/ https://reviews.llvm.org/D138701 ___ cfe-commits

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg updated this revision to Diff 477941. massberg added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138701/new/ https://reviews.llvm.org/D138701 Files: clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478477. massberg added a comment. Fixed comments and removed unnecessary includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___ cfe-commits

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG849b650cf3b6: [clang] Skip defaulted functions in zero-as-null-pointer-constant. (authored by massberg). Repository: rG LLVM Github Monorepo

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg added a comment. Note: The build failures are in parts of the code that isn't effected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The zero-as-null-pointer-constant check should not fire if it is inside a

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478227. massberg added a comment. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 479579. massberg added a comment. Add a diagnostics test for pack expansions to check if args are passed by reference and not by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 479581. massberg added a comment. Remove unnecessary code from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://reviews.llvm.org/D139125 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478261. massberg added a comment. Run clang-format on changed files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a new init capture type for a lamdba expression is created, one has to

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implemed the change proposed in [P2002R1] to 11.11.1

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 517489. massberg added a comment. Updated errort messages, code and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files:

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8593 +const FunctionProtoType *FnType = FD->getType()->castAs(); +if (FnType->isVolatile()) { aaron.ballman wrote: > aaron.ballman

[PATCH] D149649: Update comment.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [class.rel] has been renamed to [class.compare.secondary]. Repository: rG

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg added a comment. I have checked the paper P2002R1 and as far as I can tell it is fully implemented when this patch has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 519432. massberg added a comment. Fix test that broke after last change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

This revision was automatically updated to reflect the committed changes. massberg marked an inline comment as done. Closed by commit rG8af9a373ad95: Add missing semantic highlighing for concepts. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg marked 7 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:327 +return ""; + return "<" + Signature.substr(FirstComma + 2); +} sammccall wrote: > I don't love the arithmetic, the

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537163. massberg marked 2 inline comments as done. massberg added a comment. Add test case that isn't correctly handled yet and add FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537161. massberg added a comment. Update code by resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ https://reviews.llvm.org/D154450 Files:

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg updated this revision to Diff 538952. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154853/new/ https://reviews.llvm.org/D154853 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec9e2048024: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, kristof.beyls. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg added inline comments. Comment at: clang/unittests/AST/SourceLocationTest.cpp:274 + + Verifier.expectRange(2, 11, 2, 31); + EXPECT_TRUE(Verifier.match("template concept Fooable = true;\n" massberg wrote: > This range looks a bit to long. What I'm

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:562 )cpp"; - EXPECT_DECLS("ConceptSpecializationExpr", + EXPECT_DECLS("TemplateTypeParmTypeLoc", {"template concept Fooable = true"}); This

  1   2   >