[PATCH] D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg

jdemeule created this revision. jdemeule added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Updating the run-clang-tidy.py script to allow specification of the vfsoverlay argument to the clang-tidy invocation. Repository: rCTE Clang Tools Extra

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > Is there a way to make clang-apply-replacements smarter rather than forcing > > every check to jump through hoops? I'm worried

[PATCH] D43500: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule created this revision. jdemeule added a reviewer: alexfh. Herald added subscribers: cfe-commits, mgorny. 'modernize-user-default-member-init' does not automatically ask to remove comma and colon when replacements are produced. It seems, when they are apply directly from clang-tidy, the

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160 + CleannedReplacements = std::move(FormattedReplacements); + if (!CleannedReplacements) +llvm_unreachable("!CleannedReplacements"); +} else {

[PATCH] D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg

jdemeule added a comment. kindly ping reviewers. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( alexfh wrote: > I wonder whether it's better to use lit for the tests that require formatting >

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:213-221 // Use the file manager to deduplicate paths. FileEntries are // automatically canonicalized. - if (const FileEntry *Entry =

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Thanks for your feedback, they are very precious to me! Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:45 +/// \brief Map mapping file name to AtomicChange targeting that file. +typedef

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule updated this revision to Diff 136389. jdemeule added a comment. Update after review. https://reviews.llvm.org/D43500 Files: unittests/clang-tidy/CMakeLists.txt unittests/clang-tidy/ClangTidyTest.h unittests/clang-tidy/ModernizerModuleTest.cpp Index:

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353 +const FileEntry *Entry = FileAndReplacements.first; +ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry); +for (const auto :

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 138504. jdemeule added a comment. Update after review. Add tests to check identical insertions and order dependent insertions. https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Thank you for applying the patch. I suspect some undefined order when applying replacements as directly dependant in which order OS reads `file1.yaml`, `file2.yaml`and `file3.yaml`. As I am not able to reproduce it on my machine, can you share with me the content of

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Ok, I understand the problem. Previously, during the deduplication step, replacements per file where sorted and it is not the case anymore. That means now, clang-apply-replacement is highly dependant of reading file order during error reporting. I mainly see 2 options

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Can I help in some way to close this PR? https://reviews.llvm.org/D43764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 141969. jdemeule marked 3 inline comments as done. jdemeule added a comment. Sort replacements before converting them to AtomicChange. https://reviews.llvm.org/D43764 Files:

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 139889. jdemeule added a comment. Update after review (cleanup and improve comments). https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Thanks a lot! Can I ask you if I need to do something as I do not have commit access? https://reviews.llvm.org/D43764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 139082. jdemeule added a comment. Update after review. Change error reporting to use `ReplacementError` message. https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:75 +/// \brief Deduplicate, check for conflicts, and convert all Replacements stored +/// in \c TUs to AtomicChange. If conflicts occur, no

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353 +const FileEntry *Entry = FileAndReplacements.first; +ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry); +for (const auto :

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:207 + llvm::DenseMap> + GroupedReplacements; + ioeric wrote: > jdemeule wrote: > > ioeric wrote: > > > I don't think we need to do the deduplication here

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 136944. jdemeule added a comment. Update patch after reviewer comments. https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule updated this revision to Diff 135895. jdemeule added a comment. As discuss, I have removed the modifications but keep the tests. To have tests with meaning, I have also add a way to format code on 'runCheckOnCode'. https://reviews.llvm.org/D43500 Files:

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule created this revision. jdemeule added reviewers: klimek, ioeric. Herald added subscribers: cfe-commits, mgorny. By converting Replacements by AtomicChange, clang-apply-replacements is able like clang-tidy to automatically cleanup and format changes. This should permits to close this

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In D43500#1244518 , @JonasToth wrote: > What is the status here? Will you continue to work on this patch @jdemeule > (which would be great!) ? Hi, now, this patch contains only tests which are already covered with lit tests.

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In D43500#1546089 , @lebedev.ri wrote: > In D43500#1546077 , @jdemeule wrote: > > > In D43500#1244518 , @JonasToth > > wrote: > > > > > What is

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a reviewer: ioeric. jdemeule added a comment. Kindly ping reviewers and adding Eric as you were interested last year about that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a comment. Kindly ping reviewers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule created this revision. jdemeule added a reviewer: rsmith. jdemeule added a project: clang. Clang will report an error when the exception specification is not respected with a fix-it. However, this fix-it does not fully qualify the type in case of function template specialization which

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule created this revision. jdemeule added a reviewer: klimek. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Last year, I made some suggestion to improve conflict reporting in clang-apply-replacements (https://reviews.llvm.org/D43764). I have a very simple

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a comment. Kindly ping reviewers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org