[PATCH] D46602: [clang-tidy] Store checks profiling info as CSV files

2018-05-08 Thread Joe via Phabricator via cfe-commits
rja added a comment. +1 for JSON Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-05-09 Thread Joe via Phabricator via cfe-commits
rja accepted this revision. rja added a comment. LG https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

2018-05-17 Thread Joe via Phabricator via cfe-commits
rja added inline comments. Comment at: clang-doc/generators/MDGenerator.cpp:57 + sys::path::native(NamespacesPath, Path); + // for (const auto &Namespace : I->Namespace) + // sys::path::append(Path, IS->find(Namespace)->Name); remove commented code? Reposi

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-11 Thread Joe via Phabricator via cfe-commits
joedaniels29 updated this revision to Diff 181371. joedaniels29 added a comment. Tried to fix Aaron Ballman's feedback. Thanks Aaron! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.org/D56555 Files: clang/include/clang/Basic/Attr

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-14 Thread Joe via Phabricator via cfe-commits
joedaniels29 updated this revision to Diff 181692. joedaniels29 marked 2 inline comments as done. joedaniels29 added a comment. Hopefully addressed Aaron's comments. Thanks again Aaron. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-14 Thread Joe via Phabricator via cfe-commits
joedaniels29 added a comment. never mind, I didnt address > It's still missing the tests in SemaObjC -- you can use > clang\test\SemaObjC\attr-root-class.m as an example of what I'm talking about. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https:/

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-14 Thread Joe via Phabricator via cfe-commits
joedaniels29 added a comment. On second thought, I have addressed everything, I think. > clang/test/SemaObjC/attr-objc-non-lazy.m Aaron, would you mind taking another look? Thanks a bunch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-31 Thread Joe via Phabricator via cfe-commits
joedaniels29 updated this revision to Diff 184671. joedaniels29 marked 4 inline comments as done. joedaniels29 added a comment. Herald added a project: clang. Docs changes, formatting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-10 Thread Joe via Phabricator via cfe-commits
joedaniels29 created this revision. joedaniels29 added reviewers: erik.pilkington, rjmccall. Currently to get a nonlazy class in objective c, you need to define a +load method. Because we do other work when we realize a class, other than just call that load method, it would be ideal to have an