joshz added a comment.
Hey there, reviewers.
Any chance you can take a look at this change?
Thanks! :-)
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joshz added a comment.
Thanks, Aaron!
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joshz added a comment.
I don't believe I have access to commit this revision myself; can someone
please do it for me?
Thanks! :-)
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joshz updated this revision to Diff 95833.
joshz marked 3 inline comments as done.
joshz added a comment.
Clean up IsBinaryOrTernary
Repository:
rL LLVM
https://reviews.llvm.org/D31542
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
clang-tidy/utils/ASTUtils.cpp
joshz updated this revision to Diff 95488.
joshz marked an inline comment as done.
joshz edited the summary of this revision.
joshz added a comment.
Resolved the bug, with a slightly modified version of Aaron's suggestion. (It
will suggest parens for anything that wasn't just a DeclRefExpr,
joshz updated this revision to Diff 95655.
joshz added a comment.
Updated per some suggestions by sbenza@ on dealing with the parentheses;
IsBinaryOrTernary is based on a function he wrote at Google.
PTAL.
Repository:
rL LLVM
https://reviews.llvm.org/D31542
Files:
joshz added a comment.
Are there any further changes I should make, or is this good to submit now?
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joshz added a comment.
In https://reviews.llvm.org/D31542#734809, @aaron.ballman wrote:
> In https://reviews.llvm.org/D31542#734455, @joshz wrote:
>
> > Are there any further changes I should make, or is this good to submit now?
> >
> > Thanks!
>
>
> This still LGTM, so it's good to submit. Do
