Re: [PATCH] D11459: [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel

(resending with the list address fixed) John Brawn john.br...@arm.com writes: john.brawn created this revision. john.brawn added reviewers: ddunbar, mcrosier. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. -mkernel enables

Re: r244412 - [modules] Don't leak -M flags for dependency file generation into the module

Richard Smith via cfe-commits cfe-commits@lists.llvm.org writes: Author: rsmith Date: Sat Aug 8 21:44:20 2015 New Revision: 244412 URL: http://llvm.org/viewvc/llvm-project?rev=244412view=rev Log: [modules] Don't leak -M flags for dependency file generation into the module build process

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

Eric Christopher echri...@gmail.com writes: There is nothing broken about not having the include guards there, it's just not helpful. I'm working on the infrastructure for an error if you call a function from within an incompatible routine at the moment (without duplicating a lot of code it's

Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Chris Bieneman be...@apple.com writes: beanz updated this revision to Diff 32349. beanz added a comment. - Adapting to r245255 which exposes a variable in autoconf for which compiler you are building with. - Updated the CMake to be more CMake-y Note: This has been tested by running a check

Re: r245264 - Generating assumption loads of vptr after ctor call (fixed)

Piotr Padlewski via cfe-commits cfe-commits@lists.llvm.org writes: Author: prazek Date: Mon Aug 17 22:52:00 2015 New Revision: 245264 URL: http://llvm.org/viewvc/llvm-project?rev=245264view=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp

r245267 - Revert Generating assumption loads of vptr after ctor call (fixed)

Author: bogner Date: Tue Aug 18 00:40:20 2015 New Revision: 245267 URL: http://llvm.org/viewvc/llvm-project?rev=245267view=rev Log: Revert Generating assumption loads of vptr after ctor call (fixed) Bootstrap bots were failing:

Re: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

Li, Charles charles...@playstation.sony.com writes: Hi Richard, I have modified the “expected-“ lines as you requested. Cheers, Charles From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Monday, August 17, 2015 5:41 PM To: Li, Charles Cc: Justin Bogner;

Re: r245267 - Revert Generating assumption loads of vptr after ctor call (fixed)

Yep, looks like two distinct problems. I'm going to revert r245265 as well and send Piotr the crash repro for the second assertion. Piotr Padlewski pra...@google.com writes: Confirm, the assertions are different from the last one. On Mon, Aug 17, 2015 at 11:45 PM, Justin Bogner via cfe-commits

Re: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

Li, Charles via cfe-commits cfe-commits@lists.llvm.org writes: Hi Clang developers, We here at Sony are continuing to update the Lit tests for C++ dialects compatibility. Attached is the second patch. (As a reference, here is the link to the discussion on the previous Lit patch.

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Justin Bogner m...@justinbogner.com writes: Locally, it seems to fail two tests now: Failing Tests (2): Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp Clang Tools :: clang-tidy/modernize-use-nullptr.cpp I'll poke at it for a minute and see if there's something obvious I

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

That didn't work either - both tests are still failing. Alexander Kornienko ale...@google.com writes: Something weird happens with options reading. Submitted a possible workaround in r245517. On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner m...@justinbogner.com wrote: Locally, it seems

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Locally, it seems to fail two tests now: Failing Tests (2): Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp Clang Tools :: clang-tidy/modernize-use-nullptr.cpp I'll poke at it for a minute and see if there's something obvious I can do, but running the run line manually just

Re: [PATCH] [Rewriter] Fix RemoveText when IncludeInsertsAtBeginOfRange=true

Alex Corrado alexander.corr...@gmail.com writes: Hello, I’m new to Clang, and I’d like to start off by saying that it's been a real treat to work with so far. I’ve been putting the Rewriter through its paces and found a bug: RemoveText does not use the correct starting offset when

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

David Majnemer david.majne...@gmail.com writes: majnemer created this revision. majnemer added a reviewer: rsmith. majnemer added a subscriber: cfe-commits. We risk iterator invalidation issues if we use DenseMap structures for MaterializedTemporaryExprs. Use a std::map to ensure that they

Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Chris Bieneman be...@apple.com writes: beanz added a comment. dblaikie, I've run this through check-all with no issues. Might want to bootstrap with sanitizers or something. Strict aliasing related bugs can be subtle. ___ cfe-commits mailing list

Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Chris Bieneman be...@apple.com writes: Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build (I’ll clean up the patches and send those out separately). check-clang worked with asan and ubsan enabled. Is that sufficient pre-commit testing? Yes, I'd expect that to shake out any

Re: r251385 - Create undef reference to profile hook symbol

Xinliang David Li via cfe-commits writes: > Author: davidxl > Date: Tue Oct 27 00:15:35 2015 > New Revision: 251385 > > URL: http://llvm.org/viewvc/llvm-project?rev=251385=rev > Log: > Create undef reference to profile hook symbol > > Create undef reference to profile

r253104 - Revert "[AArch64] Unconditionally pass subtarget feature reserve-x18 on Darwin."

Author: bogner Date: Fri Nov 13 17:07:31 2015 New Revision: 253104 URL: http://llvm.org/viewvc/llvm-project?rev=253104=rev Log: Revert "[AArch64] Unconditionally pass subtarget feature reserve-x18 on Darwin." This reverts r243310, which is redundant as of r253102. Conflicts:

Re: Porting Clang to a new architecture

Ariel Arelovich via cfe-commits writes: > Great. > > So this is what I wanted to know. I think understand what you are saying. > You are saying that most of the work that I would need to do from the AST > (I'm assuming that this stands from Abstract Syntax Tree) is

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Hm. Well, supporting both "and" and "or" combinations here sounds like an unpleasant path to go down. I guess the question is, which is weirder? - With fma, we have fma4 which is basically a synonym as far as intrinsics go - some chips have 3-argument versions and some have 4, but I don't

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher writes: > I'm reasonably certain you forgot to rebuild or ran make test in the wrong > directory. You're right, I did something funny there. Sorry for the noise. > Two reasons: > > a) This is pretty much my first patch. I mean, identical and I tried that. >

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Looks like we'll need "and" for ARM's builtins as well - several require things like neon+fp16 or neon+vfp4. Eric Christopher writes: > Right. My current direction is going to be: > > "foo+bar" we can represent as "and" > "foo,bar" we'll continue to represent as "or" > > this

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher via cfe-commits writes: > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473=rev > Log: > Add an error when calling a builtin that requires features that don't > match the

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

David Li writes: > davidxl updated this revision to Diff 36316. > davidxl added a comment. > > I have modified the implementation to not use linker script, so this > clang patch becomes strictly refactoring with NFC. I think it is still > a good thing to have this in so that

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

Richard Smith via cfe-commits cfe-commits@lists.llvm.org writes: Author: rsmith Date: Fri Aug 21 20:47:18 2015 New Revision: 245779 URL: http://llvm.org/viewvc/llvm-project?rev=245779view=rev Log: [modules] Rearrange how redeclaration chains are loaded, to remove a walk over all modules

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

Eric Christopher via cfe-commits cfe-commits@lists.llvm.org writes: Author: echristo Date: Wed Aug 26 03:21:55 2015 New Revision: 246027 URL: http://llvm.org/viewvc/llvm-project?rev=246027view=rev Log: Convert a bunch of loops to ranged-for and clean up accordingly. Modified:

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

David Li writes: > davidxl created this revision. > davidxl added reviewers: bogner, rsmith. > davidxl added subscribers: cfe-commits, llvm-commits. > Herald added subscribers: srhines, danalbert, tberghammer. > > With PGO, the instrumented binary needs to dump

Re: [PATCH] D15158: [PGO] Instrument only base constructors and destructors.

Serge Pavlov writes: > sepavloff created this revision. > sepavloff added a reviewer: bogner. > sepavloff added subscribers: cfe-commits, silvas. > > Constructors and destructors may be represented by several functions > in IR. Only the base structors correspond to source

r254935 - AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy

Author: bogner Date: Mon Dec 7 14:04:57 2015 New Revision: 254935 URL: http://llvm.org/viewvc/llvm-project?rev=254935=rev Log: AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy If we're initializing a TypeLoc from one that's been allocated with different alignment, memcpy will get the

Re: [PATCH] D15158: [PGO] Instrument only base constructors and destructors.

Serge Pavlov writes: > sepavloff updated this revision to Diff 41744. > sepavloff added a comment. > > Changes according to reviewer's notes. LGTM. > > http://reviews.llvm.org/D15158 > > Files: > lib/CodeGen/CGBlocks.cpp > lib/CodeGen/CGObjC.cpp >

r255297 - www: Mention -DGCC_INSTALL_PREFIX instead of --with-gcc-toolchain

Author: bogner Date: Thu Dec 10 14:52:59 2015 New Revision: 255297 URL: http://llvm.org/viewvc/llvm-project?rev=255297=rev Log: www: Mention -DGCC_INSTALL_PREFIX instead of --with-gcc-toolchain Since the instructions use cmake, we should probably refer to the cmake flags and not the configure

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman added a comment. > > Justin, does this patch look ok? Sure. > > Repository: > rL LLVM > > http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman updated this revision to Diff 42549. > eraman added a comment. > > Added a test case. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D15163 > > Files: > lib/CodeGen/CodeGenModule.cpp > test/CodeGen/pgo-max-function-count.c > >

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, silvas, chandlerc. > beanz added a subscriber: cfe-commits. > > This patch adds support for the clang multi-stage bootstrapping to > support PGO profdata generation, and can build a 2 or 3

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka writes: > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner > wrote: > >> Akira Hatanaka via cfe-commits writes: >> > ahatanak created this revision. >> > ahatanak added a subscriber: cfe-commits. >> > >> > This

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka writes: > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner > wrote: > >> Akira Hatanaka writes: >> > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner >> > wrote: >> > >> >> Akira Hatanaka via

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

Sean Silva writes: > silvas added a comment. > > Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; > they're likely to have more higher-level thoughts. I'm fine with the concept and Sean's LGTM should cover the details :) > > >

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka via cfe-commits writes: > ahatanak created this revision. > ahatanak added a subscriber: cfe-commits. > > This patch fixes a crash that occurs when __kindof is incorrectly used > in the type parameter list of an interface. The crash occurs because >

Re: [PATCH] D14938: Fix implicit conversion from _Nullable to _Nonnull warnings in C++

George Burgess IV via cfe-commits writes: > george.burgess.iv created this revision. > george.burgess.iv added a reviewer: doug.gregor. > george.burgess.iv added subscribers: cfe-commits, doug.gregor. > > Currently, code like this compiles cleanly in C++, but with

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman writes: > eraman added a comment. > > I have reverted the commit in r255416 because the test failed in many > architectures. You also committed without waiting for further review, despite that David said "LGTM but please wait for other reviewers". Please don't

Re: [PATCH] D15584: [CMake] Support a simple case for bootstrap builds to generate PGO data

Chris Bieneman writes: > beanz updated this revision to Diff 43192. > beanz added a comment. > > One more dependency hookup fix, this one makes it so that stage2 > doesn't depend on the stage2-instrumented compiler-rt, and avoids > building it when you invoke the 'stage2' target.

r254173 - docs: Remove references to the long-defunct LLVM_USED_LIBS

Author: bogner Date: Thu Nov 26 13:52:24 2015 New Revision: 254173 URL: http://llvm.org/viewvc/llvm-project?rev=254173=rev Log: docs: Remove references to the long-defunct LLVM_USED_LIBS LLVM_USED_LIBS hasn't done anything since 2012, stop telling people to set it in the docs. Modified:

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Taewook Oh via cfe-commits writes: > Author: twoh > Date: Fri Jun 3 13:52:51 2016 > New Revision: 271708 > > URL: http://llvm.org/viewvc/llvm-project?rev=271708=rev > Log: > Use the name of the file on disk to issue a new diagnostic about > non-portable #include and

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added subscribers: kcc, cfe-commits, silvas. > > It would be helpful to have a user-friendly guide for code > coverage. There is some overlap with [1], but this document visits > issues which

Re: [PATCH] D16896: [CMake] Improve the clang order-file generation workflow

Chris Bieneman writes: > beanz created this revision. > beanz added a reviewer: bogner. > beanz added a subscriber: cfe-commits. > > With this change generating clang order files using dtrace uses the > following workflow: > > # Configure LLVM & Clang using any options on a

Re: [PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added a subscriber: cfe-commits. > > When handling 'if' statements, we crash if the condition and the consequent > branch are spanned by a single macro expansion. > > The crash occurs because

Re: [PATCH] D16999: [CMake] Improve the clang order-file generation workflow

Chris Bieneman writes: > beanz created this revision. > beanz added a reviewer: bogner. > beanz added a subscriber: cfe-commits. > > This commit re-lands r259862. The underlying cause of the build > breakage was an incorrectly written capabilities test. In >

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

Manman Ren via cfe-commits writes: > manmanren created this revision. > manmanren added reviewers: echristo, rafael, ahatanak. > manmanren added a subscriber: cfe-commits. > > It can happen that frontend emits error message when releasing the > builder. When that

Re: [PATCH] D18636: [PGO] Avoid instrumenting constants at value sites

Betul Buyukkurt writes: > betulb created this revision. > betulb added reviewers: davidxl, bogner. > betulb added subscribers: llvm-commits, cfe-commits. > betulb set the repository for this revision to rL LLVM. > betulb changed the visibility of this Differential Revision

r264071 - StaticAnalyzer: Avoid an unintentional copy

Author: bogner Date: Tue Mar 22 12:50:05 2016 New Revision: 264071 URL: http://llvm.org/viewvc/llvm-project?rev=264071=rev Log: StaticAnalyzer: Avoid an unintentional copy The range here isn't over references, so using `auto &` here incites a copy. Switching to `auto *` would do, but we might as

r263909 - AST: Fix some bogus indentation. NFC

Author: bogner Date: Sun Mar 20 11:58:03 2016 New Revision: 263909 URL: http://llvm.org/viewvc/llvm-project?rev=263909=rev Log: AST: Fix some bogus indentation. NFC Noticed by Liu Xin. Thanks! Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL:

Re: r264071 - StaticAnalyzer: Avoid an unintentional copy

David Blaikie <dblai...@gmail.com> writes: > On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: bogner >> Date: Tue Mar 22 12:50:05 2016 >> New Revision: 264071 >> >> URL: http:/

Re: [PATCH] D18533: Fixing PR26558: the adc builtins do not require the adx target attribute

Yunzhong Gao writes: > ygao created this revision. > ygao added subscribers: craig.topper, bogner, cfe-commits. > > Hi, > The addcarry and subborrow variants of the builtins do not require the > adx target attribute. Only the addcarryx variants require them. >

Re: [PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

Igor Kudrin writes: > ikudrin created this revision. > ikudrin added reviewers: bogner, davidxl, vsk. > ikudrin added a subscriber: cfe-commits. > > The situation happened when a macro contained a full loop statement, > which body ended at the end of the macro. A comment

Re: [PATCH] D19243: [CodeGen] Move some CodeGenPGO stuff out of CodeGenFunction.h

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added a subscriber: cfe-commits. > > Cons: 1 extra malloc per CodeGenFunction instantiation. > > Pros: This makes incremental builds noticeably faster, especially on > my laptop. E.g with this

Re: [PATCH] D19959: [scan-build] fix warning emitted on Clang Driver code baseFix a "logic error" warning of the type Called c++ object pointer isnull" reported by Clang Static Analyzer on the file:-

Apelete Seketeli via cfe-commits writes: > apelete created this revision. > apelete added reviewers: kevin.qin, rsmith. > apelete added a subscriber: cfe-commits. > > Signed-off-by: Apelete Seketeli > > http://reviews.llvm.org/D19959 > > Files: >

Re: r276716 - [Coverage] Do not write out coverage mappings with zero entries

Vedant Kumar via cfe-commits writes: > Hi Justin, > > Could you take a look at this code coverage fix? > > It skips visiting decls if they would require context from system headers to > present properly. This prevents us from writing out an empty coverage mapping > for

r274770 - NVPTX: Use the nvvm builtins to read SRegs rather than the legacy ptx ones

Author: bogner Date: Thu Jul 7 11:41:08 2016 New Revision: 274770 URL: http://llvm.org/viewvc/llvm-project?rev=274770=rev Log: NVPTX: Use the nvvm builtins to read SRegs rather than the legacy ptx ones The ptx spellings were removed from LLVM in r274769. Modified:

Re: r274663 - NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl

Justin Bogner via cfe-commits <cfe-commits@lists.llvm.org> writes: > Author: bogner > Date: Wed Jul 6 14:52:32 2016 > New Revision: 274663 > > URL: http://llvm.org/viewvc/llvm-project?rev=274663=rev > Log: > NVPTX: Rename __builtin_ptx_shfl -> __nvvm_

r274663 - NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl

Author: bogner Date: Wed Jul 6 14:52:32 2016 New Revision: 274663 URL: http://llvm.org/viewvc/llvm-project?rev=274663=rev Log: NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl To match "NVPTX: Make the llvm.nvvm.shfl intrinsics and builtin names consistent" in LLVM. Modified:

r274562 - Revert "test: Use add_lit_testsuites so that subsets of tests can be specified"

Author: bogner Date: Tue Jul 5 11:14:58 2016 New Revision: 274562 URL: http://llvm.org/viewvc/llvm-project?rev=274562=rev Log: Revert "test: Use add_lit_testsuites so that subsets of tests can be specified" This reverts r274560. It's breaking a bunch of bots due to a directory with a space in

r274560 - test: Use add_lit_testsuites so that subsets of tests can be specified

Author: bogner Date: Tue Jul 5 11:06:12 2016 New Revision: 274560 URL: http://llvm.org/viewvc/llvm-project?rev=274560=rev Log: test: Use add_lit_testsuites so that subsets of tests can be specified This creates make/ninja targets like check-clang-codegen and check-clang-unit, much like LLVM

r274565 - Re-apply "test: Use add_lit_testsuites so that subsets of tests can be specified"

Author: bogner Date: Tue Jul 5 12:54:40 2016 New Revision: 274565 URL: http://llvm.org/viewvc/llvm-project?rev=274565=rev Log: Re-apply "test: Use add_lit_testsuites so that subsets of tests can be specified" This version should actually remove the empty directories I removed all of the files

[libcxx] r293581 - Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`"

Author: bogner Date: Mon Jan 30 19:26:09 2017 New Revision: 293581 URL: http://llvm.org/viewvc/llvm-project?rev=293581=rev Log: Revert "Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`" While this change didn't really hurt, it does lead to spurious warnings about not being

r295466 - Rename DiagnosticInfoWithDebugLoc to WithLocation to match LLVM

Author: bogner Date: Fri Feb 17 11:34:49 2017 New Revision: 295466 URL: http://llvm.org/viewvc/llvm-project?rev=295466=rev Log: Rename DiagnosticInfoWithDebugLoc to WithLocation to match LLVM Updates for llvm r295465. Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified:

Re: [libcxx] r294116 - Remove CMake hack

Eric Fiselier via cfe-commits writes: > Author: ericwf > Date: Sat Feb 4 19:19:02 2017 > New Revision: 294116 > > URL: http://llvm.org/viewvc/llvm-project?rev=294116=rev > Log: > Remove CMake hack FWIW, I just spent half an hour trying to figure out why a tree I

r279159 - CodeGen: Rename a variable to better fit LLVM style. NFC

Author: bogner Date: Thu Aug 18 16:46:54 2016 New Revision: 279159 URL: http://llvm.org/viewvc/llvm-project?rev=279159=rev Log: CodeGen: Rename a variable to better fit LLVM style. NFC Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: zaks.anna, kubabrecka, bogner. > beanz added a subscriber: cfe-commits. > > The -nodefaultlibs and -nostdlib flags suppress all the runtime > libraries that the driver puts on the link line. This feels

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, zaks.anna, bruno, filcab. > beanz added a subscriber: cfe-commits. > Herald added a subscriber: emaste. > > The FreeBSD and GNUTools drivers support -fsanitize arguments > bypassing

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Richard Smith writes: > My 2c: `-nodefaultlibs` means "don't link against any libraries I > didn't explicitly tell you to". `-fsanitize=*` as a driver argument > *when linking* is an explicit request to link against the sanitizer > runtimes. So that should win. If you don't

Re: [PATCH] D24015: [CMake] Copy headers relative to LLVM_BINARY_DIR

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, EricWF. > beanz added a subscriber: cfe-commits. > > This copy phase is only needed for in-tree builds, so we should be > copying to the LLVM build directory's include dir instead of the >

Re: r281261 - CodeGen: use some range-based for loops

Saleem Abdulrasool via cfe-commits writes: > Author: compnerd > Date: Mon Sep 12 16:15:23 2016 > New Revision: 281261 > > URL: http://llvm.org/viewvc/llvm-project?rev=281261=rev > Log: > CodeGen: use some range-based for loops > > Use range-based for loops to simplify

r286210 - cmake: Don't try to install exports if there aren't any

Author: bogner Date: Mon Nov 7 23:02:33 2016 New Revision: 286210 URL: http://llvm.org/viewvc/llvm-project?rev=286210=rev Log: cmake: Don't try to install exports if there aren't any When using LLVM_DISTRIBUTION_COMPONENTS, it's possible for clang's export list to be empty. If this happens the

r286181 - cmake: Support exports correctly with LLVM_DISTRIBUTION_COMPONENTS

Author: bogner Date: Mon Nov 7 17:46:05 2016 New Revision: 286181 URL: http://llvm.org/viewvc/llvm-project?rev=286181=rev Log: cmake: Support exports correctly with LLVM_DISTRIBUTION_COMPONENTS We need to apply the same export logic in clang as in llvm for LLVM_DISTRIBUTION_COMPONENTS, or the

r284366 - AST: Prefer LLVM_NODISCARD to LLVM_ATTRIBUTE_UNUSED_RESULT

Author: bogner Date: Mon Oct 17 01:46:35 2016 New Revision: 284366 URL: http://llvm.org/viewvc/llvm-project?rev=284366=rev Log: AST: Prefer LLVM_NODISCARD to LLVM_ATTRIBUTE_UNUSED_RESULT Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL:

r284341 - AST: Improve a couple of comments and cast unused values to void

Author: bogner Date: Sun Oct 16 15:12:42 2016 New Revision: 284341 URL: http://llvm.org/viewvc/llvm-project?rev=284341=rev Log: AST: Improve a couple of comments and cast unused values to void Make these comments a bit more explicit that they're initializing the RawText member, and explicitly

Re: [libcxx] r286789 - Add check-cxx-abilist target when supported.

Yep, the copy-libcxx-headers-into-build-tree logic is so that they end up somewhere where a just built clang will find them relative to itself (it looks for something like ../include/c++/v1). It's purely a convenience so you don't need to call `ninja install` to use a clang that refers to headers

[libcxx] r291497 - Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`

Author: bogner Date: Mon Jan 9 17:07:12 2017 New Revision: 291497 URL: http://llvm.org/viewvc/llvm-project?rev=291497=rev Log: Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY` As per discussion with mclow and EricWF on irc, this is small and simple enough to deserve being

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Chandler Carruth via cfe-commits writes: > Author: chandlerc > Date: Thu Dec 22 18:23:01 2016 > New Revision: 290392 > > URL: http://llvm.org/viewvc/llvm-project?rev=290392=rev > Log: > Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'. > > Much to my

Re: [PATCH] D34563: [ubsan] Disable the object-size check at -O0

Vedant Kumar via Phabricator writes: > vsk created this revision. > > This is motivated by the thread: > [cfe-dev] Disabling ubsan's object size check at -O0 > > I think the driver is the best place to disable a sanitizer check at > particular optimization levels. Doing

Re: [PATCH] D34563: [ubsan] Disable the object-size check at -O0

v...@apple.com writes: > Good point, it makes sense to hand users a warning when they explicitly enable > -fsanitize=object-size at -O0. I've added in the diagnostic. PTAL. LGTM. > diff --git a/include/clang/Basic/DiagnosticDriverKinds.td > b/include/clang/Basic/DiagnosticDriverKinds.td > index

[clang] Update GoogleTest to v1.14.0 (PR #65823)

bogner wrote: I'm seeing some unused functions in files that haven't been changed in years, which I'm guessing come from this update - did the new googletest change how custom output works? ``` llvm/unittests/Support/JSONTest.cpp:490:27: error: unused function 'operator<<'

[clang] e504194 - [Driver][HLSL] Improve diagnostics for invalid shader model and stage

Author: Justin Bogner Date: 2023-09-13T10:45:39-07:00 New Revision: e504194d51e1f0f7ca5b684b4aa99db4940856c2 URL: https://github.com/llvm/llvm-project/commit/e504194d51e1f0f7ca5b684b4aa99db4940856c2 DIFF: https://github.com/llvm/llvm-project/commit/e504194d51e1f0f7ca5b684b4aa99db4940856c2.diff

[clang] ef2b170 - [Sema][HLSL] Consolidate handling of HLSL attributes

Author: Justin Bogner Date: 2023-08-29T08:55:38-07:00 New Revision: ef2b1700f4648816e6a6ce27cfee1c501421ee50 URL: https://github.com/llvm/llvm-project/commit/ef2b1700f4648816e6a6ce27cfee1c501421ee50 DIFF: https://github.com/llvm/llvm-project/commit/ef2b1700f4648816e6a6ce27cfee1c501421ee50.diff

[clang-tools-extra] [clang] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -898,23 +898,29 @@ namespace { } class EnumArgument : public Argument { -std::string type; +std::string fullType; +StringRef shortType; std::vector values, enums, uniques; +bool isExternal; public: EnumArgument(const Record , StringRef

[clang-tools-extra] [clang] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -898,23 +898,29 @@ namespace { } class EnumArgument : public Argument { -std::string type; +std::string fullType; +StringRef shortType; std::vector values, enums, uniques; +bool isExternal; public: EnumArgument(const Record , StringRef

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

bogner wrote: > Its a bit of a shame that the `VariadicEnumArgument` isn't being included > here/updated here, I typically appreciate the variadic versions being kept in > sync. But since we don't have a use for it at the moment, I think a 'fixme' > (or a future patch!) would be acceptable.

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -898,23 +898,29 @@ namespace { } class EnumArgument : public Argument { -std::string type; +std::string fullType; +StringRef shortType; std::vector values, enums, uniques; +bool isExternal; public: EnumArgument(const Record , StringRef

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/70835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -1010,14 +1022,17 @@ namespace { // trivial because some enumeration values have multiple named // enumerators, such as type_visibility(internal) and // type_visibility(hidden) both mapping to TypeVisibilityAttr::Hidden. - OS << "const char *" <<

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -930,77 +936,83 @@ namespace { OS << getLowerName() << "(" << getUpperName() << ")"; } void writeCtorDefaultInitializers(raw_ostream ) const override { - OS << getLowerName() << "(" << type << "(0))"; + OS << getLowerName() << "(" << fullType <<

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -279,12 +279,13 @@ class DefaultIntArgument : IntArgument { // This argument is more complex, it includes the enumerator type name, // a list of strings to accept, and a list of enumerators to map them to. -class EnumArgument values, +class EnumArgument values,

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -930,77 +936,83 @@ namespace { OS << getLowerName() << "(" << getUpperName() << ")"; } void writeCtorDefaultInitializers(raw_ostream ) const override { - OS << getLowerName() << "(" << type << "(0))"; + OS << getLowerName() << "(" << fullType <<

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -19,11 +19,12 @@ #include "clang/AST/Type.h" #include "clang/Basic/AttrKinds.h" #include "clang/Basic/AttributeCommonInfo.h" -#include "clang/Basic/LangOptions.h" #include "clang/Basic/LLVM.h" +#include "clang/Basic/LangOptions.h" #include "clang/Basic/OpenMPKinds.h"

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -1010,14 +1022,17 @@ namespace { // trivial because some enumeration values have multiple named // enumerators, such as type_visibility(internal) and // type_visibility(hidden) both mapping to TypeVisibilityAttr::Hidden. - OS << "const char *" <<

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -279,12 +279,13 @@ class DefaultIntArgument : IntArgument { // This argument is more complex, it includes the enumerator type name, // a list of strings to accept, and a list of enumerators to map them to. -class EnumArgument values, +class EnumArgument values,

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

@@ -898,23 +898,29 @@ namespace { } class EnumArgument : public Argument { -std::string type; +std::string fullType; +StringRef shortType; std::vector values, enums, uniques; +bool isExternal; public: EnumArgument(const Record , StringRef

[clang] [clang-tools-extra] [Attributes][HLSL] Teach EnumArgument to refer to an external enum (PR #70835)

bogner wrote: This is NFC in practice so it might be okay that I don't have any tests, but if folks have ideas on how to test this I'd like that better. https://github.com/llvm/llvm-project/pull/70835 ___ cfe-commits mailing list

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

@@ -930,7 +930,11 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, // and FP constants (specifically, the 'pp-number' regex), and assumes that // the byte at "*end" is both valid and not part of the regex. Because of // this, it doesn't have to

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

@@ -1950,6 +1950,10 @@ bool Lexer::LexNumericConstant(Token , const char *CurPtr) { while (isPreprocessingNumberBody(C)) { CurPtr = ConsumeChar(CurPtr, Size, Result); PrevCh = C; +if (LangOpts.HLSL && C == '.' && (*CurPtr == 'x' || *CurPtr == 'r')) { +

  1   2   3   >