kmarshall created this revision.
The extent calculation function had a bug which caused it to ignore if the size
value was defined prior to casting it. As a result, size expressions with free
variables would trigger assertion failures during the cast operation.
This patch adds that missing
kmarshall added a comment.
OK. I'll make bugs for the false positives I'm confident about.
Repository:
rL LLVM
https://reviews.llvm.org/D30593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kmarshall added a comment.
Note to reviewers: this diff is relative to "llvm/cfe" - I couldn't find a way
to specify a repository subpath to use for this diff.
Repository:
rL LLVM
https://reviews.llvm.org/D30593
___
cfe-commits mailing list
kmarshall created this revision.
The Clang static analyzer doesn't follow the warning suppression semantics of
the "-isystem" command line flag. This patch adds a check to BugReporter which
causes it to drop any BugReports which originated from a system header
(descendant of an -isystem path).
kmarshall added a comment.
NP, Anna. I filed a number of bugs for the false positives:
- https://bugs.llvm.org/show_bug.cgi?id=32229
- https://bugs.llvm.org/show_bug.cgi?id=32232
- https://bugs.llvm.org/show_bug.cgi?id=32233
- https://bugs.llvm.org/show_bug.cgi?id=32234
-
kmarshall added a comment.
Also, it looks like some instances of safe unique_ptr assignment using
std::move() are tripping up the analyzer.
Error:
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:190:4:
warning:
kmarshall added a comment.
That makes sense. In the cases that I'm finding, the original call site is in
application source code, but the warning is generated from inside a system
header. So, I suppose the suppressions are working as intended, and we just
need to add one-off suppressions for
