r334718 - [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

2018-06-14 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 14 07:53:51 2018 New Revision: 334718 URL: http://llvm.org/viewvc/llvm-project?rev=334718=rev Log: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents This diff includes changes for the remaining _Fract and _Sat

r333814 - This diff includes changes for supporting the following types.

2018-06-01 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jun 1 19:58:51 2018 New Revision: 333814 URL: http://llvm.org/viewvc/llvm-project?rev=333814=rev Log: This diff includes changes for supporting the following types. ``` // Primary fixed point types signed short _Accum s_short_accum; signed _Accum s_accum; signed

r333815 - Revert "This diff includes changes for supporting the following types."

2018-06-01 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jun 1 20:27:13 2018 New Revision: 333815 URL: http://llvm.org/viewvc/llvm-project?rev=333815=rev Log: Revert "This diff includes changes for supporting the following types." This reverts commit r333814, which fails for a test checking the bit width on ubuntu.

Re: r333923 - This diff includes changes for supporting the following types.

2018-06-04 Thread Leonard Chan via cfe-commits
easonable. > In this case it is not reasonable. > > On Mon, Jun 4, 2018 at 7:07 PM, Leonard Chan via cfe-commits > wrote: > > Author: leonardchan > > Date: Mon Jun 4 09:07:52 2018 > > New Revision: 333923 > > > > URL: http://llvm.org/viewvc/llvm-project?rev

r333923 - This diff includes changes for supporting the following types.

2018-06-04 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Jun 4 09:07:52 2018 New Revision: 333923 URL: http://llvm.org/viewvc/llvm-project?rev=333923=rev Log: This diff includes changes for supporting the following types. // Primary fixed point types signed short _Accum s_short_accum; signed _Accum s_accum; signed long

r335993 - [Fixed Point Arithmetic] Rename `-fsame-fbits` flag

2018-06-29 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jun 29 10:08:19 2018 New Revision: 335993 URL: http://llvm.org/viewvc/llvm-project?rev=335993=rev Log: [Fixed Point Arithmetic] Rename `-fsame-fbits` flag - Rename the `-fsame-fbits` flag to `-fpadding-on-unsigned-fixed-point` - Move the flag from a driver option to

r335148 - [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals

2018-06-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jun 20 10:19:40 2018 New Revision: 335148 URL: http://llvm.org/viewvc/llvm-project?rev=335148=rev Log: [Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals This diff includes the logic for setting the precision bits for each primary fixed

Re: r335159 - Fixed test in prior build where FileCheck tried to match against

2018-06-20 Thread Leonard Chan via cfe-commits
gt; > See inline (same as previous). > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > > Leonard Chan via cfe-commits > > Sent: Wednesday, June 20, 2018 3:34 PM > > To: cfe-commits@lists.llvm.org >

r335159 - Fixed test in prior build where FileCheck tried to match against

2018-06-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jun 20 12:34:05 2018 New Revision: 335159 URL: http://llvm.org/viewvc/llvm-project?rev=335159=rev Log: Fixed test in prior build where FileCheck tried to match against `common` when declaring a global variable when we primarily care about the value assigned in the

r335155 - Fixed test that failed when checking what variable a value was stored

2018-06-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jun 20 11:48:05 2018 New Revision: 335155 URL: http://llvm.org/viewvc/llvm-project?rev=335155=rev Log: Fixed test that failed when checking what variable a value was stored in for fixed point types. Modified: cfe/trunk/test/Frontend/fixed_point_same_fbits.c

r339044 - Fix for broken build on clang-hexagon-elf for ambiguous call to

2018-08-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 6 12:31:00 2018 New Revision: 339044 URL: http://llvm.org/viewvc/llvm-project?rev=339044=rev Log: Fix for broken build on clang-hexagon-elf for ambiguous call to std::abs. Modified: cfe/trunk/lib/Basic/FixedPoint.cpp Modified:

r339167 - [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-07 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Aug 7 12:43:53 2018 New Revision: 339167 URL: http://llvm.org/viewvc/llvm-project?rev=339167=rev Log: [Sema] Fix for crash on conditional operation with address_space pointer Compiling the following causes clang to crash ``` char

r339037 - Fix for failing test from sanitizer-x86_64-linux-fast where there was a

2018-08-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 6 10:55:38 2018 New Revision: 339037 URL: http://llvm.org/viewvc/llvm-project?rev=339037=rev Log: Fix for failing test from sanitizer-x86_64-linux-fast where there was a left shift on a negative value. Modified: cfe/trunk/unittests/Basic/FixedPointTest.cpp

r339038 - Removed the OverflowConversionsToFract tests for now. Will add them back

2018-08-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 6 11:02:16 2018 New Revision: 339038 URL: http://llvm.org/viewvc/llvm-project?rev=339038=rev Log: Removed the OverflowConversionsToFract tests for now. Will add them back in once I figure out why this doesn't work on windows. Modified:

r339026 - [Fixed Point Arithmetic] Fix for FixedPointValueToString

2018-08-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 6 09:05:08 2018 New Revision: 339026 URL: http://llvm.org/viewvc/llvm-project?rev=339026=rev Log: [Fixed Point Arithmetic] Fix for FixedPointValueToString - Print negative numbers correctly - Handle APInts of different sizes - Add formal unit tests for

r339028 - [Fixed Point Arithmetic] Fixed Point Constant

2018-08-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 6 09:42:37 2018 New Revision: 339028 URL: http://llvm.org/viewvc/llvm-project?rev=339028=rev Log: [Fixed Point Arithmetic] Fixed Point Constant This patch proposes an abstract type that represents fixed point numbers, similar to APInt or APSInt that was

r340765 - [Sema/Attribute] Make types declared with address_space an AttributedType

2018-08-27 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 27 10:57:29 2018 New Revision: 340765 URL: http://llvm.org/viewvc/llvm-project?rev=340765=rev Log: [Sema/Attribute] Make types declared with address_space an AttributedType Currently an address_space is stored in a qualifier. This makes any type declared with an

r337289 - [Fixed Point Arithmetic] Fix for bug where integer literals could be treated as fixed point literals

2018-07-17 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Jul 17 07:58:49 2018 New Revision: 337289 URL: http://llvm.org/viewvc/llvm-project?rev=337289=rev Log: [Fixed Point Arithmetic] Fix for bug where integer literals could be treated as fixed point literals This addresses a bug brought up in

[clang-tools-extra] r344548 - added fix

2018-10-15 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Oct 15 12:59:52 2018 New Revision: 344548 URL: http://llvm.org/viewvc/llvm-project?rev=344548=rev Log: added fix Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp Modified:

[clang-tools-extra] r344549 - [Fixed Point Arithmetic] Fix for clang-tools-extra warning

2018-10-15 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Oct 15 13:00:03 2018 New Revision: 344549 URL: http://llvm.org/viewvc/llvm-project?rev=344549=rev Log: [Fixed Point Arithmetic] Fix for clang-tools-extra warning Fix for warnings generated on unhandled enum value `STK_FixedPoint`. Differential Revision:

r344702 - Fix for arm bots afternew PM pass port. Prevent cross compiling on arm.

2018-10-17 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Oct 17 11:12:18 2018 New Revision: 344702 URL: http://llvm.org/viewvc/llvm-project?rev=344702=rev Log: Fix for arm bots afternew PM pass port. Prevent cross compiling on arm. Modified: cfe/trunk/test/CodeGen/asan-new-pm.ll Modified:

r344701 - Fix for failing unit tests on some bots after r344696.

2018-10-17 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Oct 17 09:21:19 2018 New Revision: 344701 URL: http://llvm.org/viewvc/llvm-project?rev=344701=rev Log: Fix for failing unit tests on some bots after r344696. Modified: cfe/trunk/test/CodeGen/asan-new-pm.ll Modified: cfe/trunk/test/CodeGen/asan-new-pm.ll URL:

r344699 - [PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address

2018-10-17 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Oct 17 08:38:22 2018 New Revision: 344699 URL: http://llvm.org/viewvc/llvm-project?rev=344699=rev Log: [PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address Enable usage of `AddressSanitizer` and `AddressModuleSanitizer`

r344530 - [Fixed Point Arithmetic] FixedPointCast

2018-10-15 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Oct 15 09:07:02 2018 New Revision: 344530 URL: http://llvm.org/viewvc/llvm-project?rev=344530=rev Log: [Fixed Point Arithmetic] FixedPointCast This patch is a part of https://reviews.llvm.org/D48456 in an attempt to split them up. This contains the code for casting

r345063 - [Fixed Point Arithmetic] Fixed Point to Boolean Cast

2018-10-23 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Oct 23 10:55:35 2018 New Revision: 345063 URL: http://llvm.org/viewvc/llvm-project?rev=345063=rev Log: [Fixed Point Arithmetic] Fixed Point to Boolean Cast This patch is a part of https://reviews.llvm.org/D48456 in an attempt to split the casting logic up into

r345433 - Revert "[PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address"

2018-10-26 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Oct 26 15:51:51 2018 New Revision: 345433 URL: http://llvm.org/viewvc/llvm-project?rev=345433=rev Log: Revert "[PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address" This reverts commit

Re: r342793 - [Lexer] Add udefined_behavior_sanitizer feature

2018-09-21 Thread Leonard Chan via cfe-commits
cal concerns with the patch, but the sanitizer owners should > have had a chance to weigh in. That said, I don't see value in > reverting and recommitting later, so if there are concerns, they can > be dealt with post commit. > > ~Aaron > > On Fri, Sep 21, 2018 at 9:03 PM, Leon

r342793 - [Lexer] Add udefined_behavior_sanitizer feature

2018-09-21 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Sep 21 18:03:16 2018 New Revision: 342793 URL: http://llvm.org/viewvc/llvm-project?rev=342793=rev Log: [Lexer] Add udefined_behavior_sanitizer feature This can be used to detect whether the code is being built with UBSan using the

r351364 - [Fixed Point Arithmetic] Fixed Point Addition

2019-01-16 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jan 16 10:13:59 2019 New Revision: 351364 URL: http://llvm.org/viewvc/llvm-project?rev=351364=rev Log: [Fixed Point Arithmetic] Fixed Point Addition This patch covers addition between fixed point types and other fixed point types or integers, using the conversion

r351371 - [Fixed Point Arithmetic] Fixed Point Subtraction

2019-01-16 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jan 16 11:53:50 2019 New Revision: 351371 URL: http://llvm.org/viewvc/llvm-project?rev=351371=rev Log: [Fixed Point Arithmetic] Fixed Point Subtraction This patch covers subtraction between fixed point types and other fixed point types or integers, using the

r351368 - [Fixed Point Arithmetic] Add APFixedPoint to APValue

2019-01-16 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jan 16 10:53:05 2019 New Revision: 351368 URL: http://llvm.org/viewvc/llvm-project?rev=351368=rev Log: [Fixed Point Arithmetic] Add APFixedPoint to APValue This adds APFixedPoint to the union of values that can be represented with an APValue. Differential

r351593 - [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

2019-01-18 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jan 18 13:04:25 2019 New Revision: 351593 URL: http://llvm.org/viewvc/llvm-project?rev=351593=rev Log: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation This patch includes logic for constant expression evaluation of fixed point

r348434 - [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

2018-12-05 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Dec 5 16:10:36 2018 New Revision: 348434 URL: http://llvm.org/viewvc/llvm-project?rev=348434=rev Log: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions This patch creates a new context for every function

r348442 - [Sema/Attribute] Check for noderef attribute

2018-12-05 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Dec 5 17:05:54 2018 New Revision: 348442 URL: http://llvm.org/viewvc/llvm-project?rev=348442=rev Log: [Sema/Attribute] Check for noderef attribute This patch adds the noderef attribute in clang and checks for dereferences of types that have this attribute. This

r354621 - [Fixed Point Arithmetic] Fixed Point Comparisons

2019-02-21 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Feb 21 12:50:09 2019 New Revision: 354621 URL: http://llvm.org/viewvc/llvm-project?rev=354621=rev Log: [Fixed Point Arithmetic] Fixed Point Comparisons This patch implements fixed point comparisons with other fixed point types and integers. This also provides

r355462 - [Fixed Point Arithmetic] Fixed Point and Integer Conversions

2019-03-05 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Mar 5 16:28:43 2019 New Revision: 355462 URL: http://llvm.org/viewvc/llvm-project?rev=355462=rev Log: [Fixed Point Arithmetic] Fixed Point and Integer Conversions This patch includes the necessary code for converting between a fixed point type and integer. This

r353999 - Fix for asan bots

2019-02-13 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Feb 13 17:07:47 2019 New Revision: 353999 URL: http://llvm.org/viewvc/llvm-project?rev=353999=rev Log: Fix for asan bots Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

r353985 - [NewPM] Second attempt at porting ASan

2019-02-13 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Feb 13 14:22:48 2019 New Revision: 353985 URL: http://llvm.org/viewvc/llvm-project?rev=353985=rev Log: [NewPM] Second attempt at porting ASan This is the second attempt to port ASan to new PM after D52739. This takes the initialization requried by ASan from the

r354431 - [NewPM] Add other sanitizers at O0

2019-02-19 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Feb 19 19:50:11 2019 New Revision: 354431 URL: http://llvm.org/viewvc/llvm-project?rev=354431=rev Log: [NewPM] Add other sanitizers at O0 This allows for MSan and TSan to be used without optimizations required. Differential Revision: https://reviews.llvm.org/D58424

r354432 - Remove test on incompatible mpis target.

2019-02-19 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Feb 19 20:35:28 2019 New Revision: 354432 URL: http://llvm.org/viewvc/llvm-project?rev=354432=rev Log: Remove test on incompatible mpis target. Modified: cfe/trunk/test/Driver/msan.c Modified: cfe/trunk/test/Driver/msan.c URL:

r354435 - Limit new PM tests to X86 registered targets.

2019-02-19 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Feb 19 21:07:14 2019 New Revision: 354435 URL: http://llvm.org/viewvc/llvm-project?rev=354435=rev Log: Limit new PM tests to X86 registered targets. Modified: cfe/trunk/test/Driver/msan.c cfe/trunk/test/Driver/tsan.c Modified: cfe/trunk/test/Driver/msan.c

r351997 - [Sema] Fix Modified Type in address_space AttributedType

2019-01-23 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jan 23 16:11:35 2019 New Revision: 351997 URL: http://llvm.org/viewvc/llvm-project?rev=351997=rev Log: [Sema] Fix Modified Type in address_space AttributedType This is a fix for https://reviews.llvm.org/D51229 where we pass the address_space qualified type as the

r358538 - [NFC] Remove unused function (Sema::pushExternalDeclIntoScope)

2019-04-16 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Apr 16 15:59:39 2019 New Revision: 358538 URL: http://llvm.org/viewvc/llvm-project?rev=358538=rev Log: [NFC] Remove unused function (Sema::pushExternalDeclIntoScope) Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaDecl.cpp Modified:

r360544 - Fix for P41852 where builtin attributes were being caught by FindLocsWithCommonFileID().

2019-05-12 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Sun May 12 14:50:01 2019 New Revision: 360544 URL: http://llvm.org/viewvc/llvm-project?rev=360544=rev Log: Fix for P41852 where builtin attributes were being caught by FindLocsWithCommonFileID(). Added: cfe/trunk/test/Driver/mingw-macro-qualified-type.c Modified:

r360548 - Fix test to use -cc1.

2019-05-12 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Sun May 12 15:44:46 2019 New Revision: 360548 URL: http://llvm.org/viewvc/llvm-project?rev=360548=rev Log: Fix test to use -cc1. Added: cfe/trunk/test/Sema/mingw-macro-qualified-type.c Removed: cfe/trunk/test/Driver/mingw-macro-qualified-type.c Removed:

r363278 - [clang][NewPM] Fix broken profile test

2019-06-13 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 13 10:25:36 2019 New Revision: 363278 URL: http://llvm.org/viewvc/llvm-project?rev=363278=rev Log: [clang][NewPM] Fix broken profile test This contains the part of D62225 which fixes Profile/gcc-flag-compatibility.c by adding the pass that allows default profile

r363287 - [clang][NewPM] Fix broken -O0 test from missing assumptions

2019-06-13 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 13 11:18:40 2019 New Revision: 363287 URL: http://llvm.org/viewvc/llvm-project?rev=363287=rev Log: [clang][NewPM] Fix broken -O0 test from missing assumptions Add an AssumptionCache callback to the InlineFuntionInfo used for the AlwaysInlinerPass to match

r363281 - [clang][NewPM] Fix split debug test

2019-06-13 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 13 10:40:03 2019 New Revision: 363281 URL: http://llvm.org/viewvc/llvm-project?rev=363281=rev Log: [clang][NewPM] Fix split debug test This contains the part of D62225 which fixes CodeGen/split-debug-single-file.c by not placing .dwo sections when using

r363277 - [clang][NewPM] Fix broken -O0 test from the AlwaysInliner

2019-06-13 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 13 09:45:29 2019 New Revision: 363277 URL: http://llvm.org/viewvc/llvm-project?rev=363277=rev Log: [clang][NewPM] Fix broken -O0 test from the AlwaysInliner This contains the part of D62225 which prevents insertion of lifetime intrinsics when creating the

r363846 - [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM

2019-06-19 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Jun 19 10:41:30 2019 New Revision: 363846 URL: http://llvm.org/viewvc/llvm-project?rev=363846=rev Log: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM - CodeGen/flatten.c will fail under new PM becausec the new PM AlwaysInliner seems to

r363969 - [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline

2019-06-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 20 12:35:25 2019 New Revision: 363969 URL: http://llvm.org/viewvc/llvm-project?rev=363969=rev Log: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline This fixes CodeGen/x86_64-instrument-functions.c when running under the new pass

r363971 - [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs

2019-06-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jun 20 12:44:51 2019 New Revision: 363971 URL: http://llvm.org/viewvc/llvm-project?rev=363971=rev Log: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs This fixes CodeGen/available-externally-suppress.c when the new pass manager is turned

r364066 - [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

2019-06-21 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jun 21 09:03:06 2019 New Revision: 364066 URL: http://llvm.org/viewvc/llvm-project?rev=364066=rev Log: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests As per the discussion on D58375, we disable test that have optimizations under the new PM. This

r364201 - [clang][NewPM] Remove exception handling before loading pgo sample profile data

2019-06-24 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Jun 24 09:44:27 2019 New Revision: 364201 URL: http://llvm.org/viewvc/llvm-project?rev=364201=rev Log: [clang][NewPM] Remove exception handling before loading pgo sample profile data This patch ensures that SimplifyCFGPass comes before SampleProfileLoaderPass on PGO

r364202 - [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

2019-06-24 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Jun 24 09:49:18 2019 New Revision: 364202 URL: http://llvm.org/viewvc/llvm-project?rev=364202=rev Log: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM For CodeGenOpenCL/convergent.cl, the new PM produced a slightly different for

r360448 - Fix and test for assertion error in P41835.

2019-05-10 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri May 10 11:05:15 2019 New Revision: 360448 URL: http://llvm.org/viewvc/llvm-project?rev=360448=rev Log: Fix and test for assertion error in P41835. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/test/Frontend/macro_defined_type.cpp Modified:

r360465 - Add target triple to test.

2019-05-10 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri May 10 13:07:47 2019 New Revision: 360465 URL: http://llvm.org/viewvc/llvm-project?rev=360465=rev Log: Add target triple to test. Modified: cfe/trunk/test/Frontend/macro_defined_type.cpp Modified: cfe/trunk/test/Frontend/macro_defined_type.cpp URL:

r360707 - [NewPM] Port HWASan and Kernel HWASan

2019-05-14 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue May 14 14:17:21 2019 New Revision: 360707 URL: http://llvm.org/viewvc/llvm-project?rev=360707=rev Log: [NewPM] Port HWASan and Kernel HWASan Port hardware assisted address sanitizer to new PM following the same guidelines as msan and tsan. Changes: - Separate

r360720 - Fix bots by adding target triple to test.

2019-05-14 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue May 14 15:37:34 2019 New Revision: 360720 URL: http://llvm.org/viewvc/llvm-project?rev=360720=rev Log: Fix bots by adding target triple to test. Modified: cfe/trunk/test/CodeGen/hwasan-new-pm.c Modified: cfe/trunk/test/CodeGen/hwasan-new-pm.c URL:

r361302 - Remove unicode character from test

2019-05-21 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue May 21 13:12:00 2019 New Revision: 361302 URL: http://llvm.org/viewvc/llvm-project?rev=361302=rev Log: Remove unicode character from test Modified: cfe/trunk/test/SemaObjC/nullability_macro.m Modified: cfe/trunk/test/SemaObjC/nullability_macro.m URL:

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-20 Thread Leonard Chan via cfe-commits
is replaced by > `__attribute__((annotate("ui_appearance_selector")))` in the source code, > even though both lead to the same -E output. > > *From: *Leonard Chan via cfe-commits > *Date: *Mon, May 6, 2019 at 11:17 PM > *To: * > > Author: leonardchan >>

r361205 - [Sema] Fix for build on some iOS programs.

2019-05-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon May 20 15:42:19 2019 New Revision: 361205 URL: http://llvm.org/viewvc/llvm-project?rev=361205=rev Log: [Sema] Fix for build on some iOS programs. Nullability attributes weren't being stripped for AttributedTypes that were wrapped in a MacroQualifiedType. This fix

r360120 - [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller

2019-05-07 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue May 7 01:12:28 2019 New Revision: 360120 URL: http://llvm.org/viewvc/llvm-project?rev=360120=rev Log: [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller To hopefully fix greenbot failures Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified:

r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon May 6 20:20:17 2019 New Revision: 360109 URL: http://llvm.org/viewvc/llvm-project?rev=360109=rev Log: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration" Updated with fix for read of uninitialized memory. Added:

r360089 - [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice

2019-05-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon May 6 15:09:12 2019 New Revision: 360089 URL: http://llvm.org/viewvc/llvm-project?rev=360089=rev Log: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-07 Thread Leonard Chan via cfe-commits
at your patch is still triggering an assertion on >>> GreenDragon: >>> http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/56255/consoleFull#312501878d489585b-5106-414a-ac11-3ff90657619c >>> >>> Can you please have a look? >>> >>> Th

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-07 Thread Leonard Chan via cfe-commits
-configure-RA/56255/consoleFull#312501878d489585b-5106-414a-ac11-3ff90657619c > > Can you please have a look? > > Thanks, > Jonas > > > On Mon, May 6, 2019 at 8:17 PM Leonard Chan via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: leonardchan

r360225 - Fix for the greendragon bots.

2019-05-07 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue May 7 22:59:25 2019 New Revision: 360225 URL: http://llvm.org/viewvc/llvm-project?rev=360225=rev Log: Fix for the greendragon bots. Adds extra checks for ObjC GC and Ownership. Modified: cfe/trunk/lib/Sema/SemaType.cpp cfe/trunk/test/SemaObjC/mrc-weak.m

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-08 Thread Leonard Chan via cfe-commits
gt;>>> >>>> Thanks, >>>> Leonard >>>> >>>> On Tue, May 7, 2019, 09:26 Jonas Devlieghere >>>> wrote: >>>> >>>>> Hi Leonard, >>>>> >>>>> It appears that your patch is still tri

r359826 - [Attribute/Diagnostics] Print macro if definition is an attribute declaration

2019-05-02 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu May 2 13:38:14 2019 New Revision: 359826 URL: http://llvm.org/viewvc/llvm-project?rev=359826=rev Log: [Attribute/Diagnostics] Print macro if definition is an attribute declaration If an address_space attribute is defined in a macro, print the macro instead when

r359859 - Revert "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-02 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu May 2 20:28:06 2019 New Revision: 359859 URL: http://llvm.org/viewvc/llvm-project?rev=359859=rev Log: Revert "[Attribute/Diagnostics] Print macro if definition is an attribute declaration" This reverts commit fc40cbd9d8c63e65eed3590ba925321afe782e1d. Removed:

r365838 - [NewPM] Port Sancov

2019-07-11 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jul 11 15:35:40 2019 New Revision: 365838 URL: http://llvm.org/viewvc/llvm-project?rev=365838=rev Log: [NewPM] Port Sancov This patch contains a port of SanitizerCoverage to the new pass manager. This one's a bit hefty. Changes: - Split SanitizerCoverageModule

r364692 - Revert "[clang][NewPM] Fix broken profile test"

2019-06-28 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jun 28 17:10:22 2019 New Revision: 364692 URL: http://llvm.org/viewvc/llvm-project?rev=364692=rev Log: Revert "[clang][NewPM] Fix broken profile test" This reverts commit ab2c0ed01edfec9a9402d03bdf8633b34b73f3a7. See https://reviews.llvm.org/D63155 Modified:

Re: r369281 - Implement P1668R1

2019-08-19 Thread Leonard Chan via cfe-commits
 Thanks On Mon, Aug 19, 2019 at 11:34 AM Keane, Erich wrote: > Yeah, sorry about that. I fixed it in 369284. > > > > *From:* Leonard Chan [mailto:leonardc...@google.com] > *Sent:* Monday, August 19, 2019 11:33 AM > *To:* Keane, Erich > *Cc:* cfe-commits cfe > *Subject:* Re: r369281 -

Re: r369281 - Implement P1668R1

2019-08-19 Thread Leonard Chan via cfe-commits
Not sure if this was caught by upstream bots already, but we're seeing a failing test ob our x64 bots: ``` FAIL: Clang :: SemaCXX/cxx1z-constexpr-lambdas.cpp (9574 of 15387) TEST 'Clang :: SemaCXX/cxx1z-constexpr-lambdas.cpp' FAILED Script: -- : 'RUN: at

r369550 - [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager

2019-08-21 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Aug 21 10:24:14 2019 New Revision: 369550 URL: http://llvm.org/viewvc/llvm-project?rev=369550=rev Log: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 under the new pass manager Match the behavior of D65009 under the new pass manager. This addresses

r369442 - [NewPM] Run ubsan-coroutines test under the legacy pass manager only

2019-08-20 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Tue Aug 20 13:55:36 2019 New Revision: 369442 URL: http://llvm.org/viewvc/llvm-project?rev=369442=rev Log: [NewPM] Run ubsan-coroutines test under the legacy pass manager only The passes that lower the llvm.coro.* instrinsics have not yet been ported, so only run under

r370971 - [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

2019-09-04 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Wed Sep 4 13:30:29 2019 New Revision: 370971 URL: http://llvm.org/viewvc/llvm-project?rev=370971=rev Log: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes This patch merges the sancov module and funciton passes into one module pass. The reason for this is

r371326 - [NewPM][Sancov] Create the Sancov Pass after building the pipelines

2019-09-08 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Sun Sep 8 00:30:17 2019 New Revision: 371326 URL: http://llvm.org/viewvc/llvm-project?rev=371326=rev Log: [NewPM][Sancov] Create the Sancov Pass after building the pipelines We're running into linker errors from missing sancov sections: ``` ld.lld: error: relocation

r366153 - Revert "[NewPM] Port Sancov"

2019-07-15 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Jul 15 16:18:31 2019 New Revision: 366153 URL: http://llvm.org/viewvc/llvm-project?rev=366153=rev Log: Revert "[NewPM] Port Sancov" This reverts commit 5652f35817f07b16f8b3856d594cc42f4d7ee29c. Removed: cfe/trunk/test/CodeGen/sancov-new-pm.c Modified:

r367053 - Reland the "[NewPM] Port Sancov" patch from rL365838. No functional

2019-07-25 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jul 25 13:53:15 2019 New Revision: 367053 URL: http://llvm.org/viewvc/llvm-project?rev=367053=rev Log: Reland the "[NewPM] Port Sancov" patch from rL365838. No functional changes were made to the patch since then. [NewPM] Port Sancov This patch contains a

r367157 - [NewPM] Run avx*-builtins.c tests under the new pass manager only

2019-07-26 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jul 26 14:19:37 2019 New Revision: 367157 URL: http://llvm.org/viewvc/llvm-project?rev=367157=rev Log: [NewPM] Run avx*-builtins.c tests under the new pass manager only This patch changes the following tests to run under the new pass manager only: ``` Clang ::

[clang] e278c13 - [Sema] Add MacroQualified case for FunctionTypeUnwrapper

2019-11-12 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2019-11-12T16:22:13-08:00 New Revision: e278c138a937a68f3e6c89df8eaeffa913f9b0f7 URL: https://github.com/llvm/llvm-project/commit/e278c138a937a68f3e6c89df8eaeffa913f9b0f7 DIFF: https://github.com/llvm/llvm-project/commit/e278c138a937a68f3e6c89df8eaeffa913f9b0f7.diff

[clang] 85b718f - [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

2019-10-28 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2019-10-28T14:19:38-07:00 New Revision: 85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3 URL: https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3 DIFF: https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3.diff

[clang] d2cbaf1 - Fix for the test failues introduced in https://reviews.llvm.org/D74704.

2020-02-26 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-02-26T12:23:15-08:00 New Revision: d2cbaf1755ffa90300365c0d71400a5ee4ada3bd URL: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd DIFF: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd.diff

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via cfe-commits
Will you be sending out the patch for this? On Wed, Feb 26, 2020 at 12:05 PM Leonard Chan wrote: > Yup, I added it to both *-extra.c files and it seemed to fix the tests. > > On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton > wrote: > >> Does adding >> >> // REQUIRES: platform-linker >> >> to

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-26 Thread Leonard Chan via cfe-commits
Yup, I added it to both *-extra.c files and it seemed to fix the tests. On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton wrote: > Does adding > > // REQUIRES: platform-linker > > to Driver/riscv32-toolchain-extra.c fixes your issue? > > > On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via

[libunwind] 1c70dec - [libunwind] Remove __FILE__ and __LINE__ from error reporting

2020-03-10 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-03-10T18:58:41-07:00 New Revision: 1c70dec18c7e530264cc70841cc60f385259b9e0 URL: https://github.com/llvm/llvm-project/commit/1c70dec18c7e530264cc70841cc60f385259b9e0 DIFF: https://github.com/llvm/llvm-project/commit/1c70dec18c7e530264cc70841cc60f385259b9e0.diff

[clang] 592303a - [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

2020-05-14 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-05-14T17:03:58-07:00 New Revision: 592303a53e6bc0737c3999e91aab9ea2147f73ab URL: https://github.com/llvm/llvm-project/commit/592303a53e6bc0737c3999e91aab9ea2147f73ab DIFF: https://github.com/llvm/llvm-project/commit/592303a53e6bc0737c3999e91aab9ea2147f73ab.diff

[clang] e9802aa - Revert "Run Coverage pass before other *San passes under new pass manager"

2020-05-14 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-05-14T15:19:27-07:00 New Revision: e9802aa4221ba3857041c2328639ce2aac0ace67 URL: https://github.com/llvm/llvm-project/commit/e9802aa4221ba3857041c2328639ce2aac0ace67 DIFF: https://github.com/llvm/llvm-project/commit/e9802aa4221ba3857041c2328639ce2aac0ace67.diff

[clang] 64c0792 - [clang][feature] Add cxx_abi_relative_vtable feature

2020-10-08 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-10-08T10:30:54-07:00 New Revision: 64c0792946b792839b2f39e4e208fdd7398aaea0 URL: https://github.com/llvm/llvm-project/commit/64c0792946b792839b2f39e4e208fdd7398aaea0 DIFF: https://github.com/llvm/llvm-project/commit/64c0792946b792839b2f39e4e208fdd7398aaea0.diff

Re: [clang] 683b308 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2020-10-14 Thread Leonard Chan via cfe-commits
Updated with 8487bfd4e9ae186f9f588ef989d27a96cc2438c9 On Wed, Oct 14, 2020 at 1:53 PM Richard Smith wrote: > On Wed, 14 Oct 2020 at 12:31, Leonard Chan via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: Leonard Chan >> Date: 2020-10-

[clang] 8487bfd - [clang][NFC] Change diagnostic to start with lowercase letter

2020-10-14 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-10-14T15:48:29-07:00 New Revision: 8487bfd4e9ae186f9f588ef989d27a96cc2438c9 URL: https://github.com/llvm/llvm-project/commit/8487bfd4e9ae186f9f588ef989d27a96cc2438c9 DIFF: https://github.com/llvm/llvm-project/commit/8487bfd4e9ae186f9f588ef989d27a96cc2438c9.diff

[clang] 79829a4 - Revert "[clang] Add -fc++-abi= flag for specifying which C++ ABI to use"

2020-10-15 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-10-15T14:24:38-07:00 New Revision: 79829a47040512fe54001db839ac59146ca55aec URL: https://github.com/llvm/llvm-project/commit/79829a47040512fe54001db839ac59146ca55aec DIFF: https://github.com/llvm/llvm-project/commit/79829a47040512fe54001db839ac59146ca55aec.diff

[clang] 683b308 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2020-10-14 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-10-14T12:31:21-07:00 New Revision: 683b308c07bf827255fe1403056413f790e03729 URL: https://github.com/llvm/llvm-project/commit/683b308c07bf827255fe1403056413f790e03729 DIFF: https://github.com/llvm/llvm-project/commit/683b308c07bf827255fe1403056413f790e03729.diff

Re: [PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

2020-09-29 Thread Leonard Chan via cfe-commits
Thanks for looking into it. We have that commit but it still seems to be failing for us with the same error. On Tue, Sep 29, 2020 at 12:58 AM Serge Pavlov wrote: > Hi! > > This issue must be fixed by: https://reviews.llvm.org/rGf91b9c0f9858 > Do you have recent changes from the trunk? > >

[clang] 15d94a7 - Revert "Canonicalize declaration pointers when forming APValues."

2020-09-22 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-09-22T17:40:53-07:00 New Revision: 15d94a7d0f8f0d6b3b5308fff51b286957e45650 URL: https://github.com/llvm/llvm-project/commit/15d94a7d0f8f0d6b3b5308fff51b286957e45650 DIFF: https://github.com/llvm/llvm-project/commit/15d94a7d0f8f0d6b3b5308fff51b286957e45650.diff

[clang] ef37444 - [Lexer] Fix invalid suffix diagnostic for fixed-point literals

2020-05-27 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-05-27T16:16:56-07:00 New Revision: ef37444058550b0f49441b994c9e9368d8e42da8 URL: https://github.com/llvm/llvm-project/commit/ef37444058550b0f49441b994c9e9368d8e42da8 DIFF: https://github.com/llvm/llvm-project/commit/ef37444058550b0f49441b994c9e9368d8e42da8.diff

[clang] de172dd - [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp

2020-06-29 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-06-29T13:06:42-07:00 New Revision: de172dd17f0334e1fcbbf28a33d0ea24f7cbff1a URL: https://github.com/llvm/llvm-project/commit/de172dd17f0334e1fcbbf28a33d0ea24f7cbff1a DIFF: https://github.com/llvm/llvm-project/commit/de172dd17f0334e1fcbbf28a33d0ea24f7cbff1a.diff

[clang] 2f6bb2a - [clang][Attribute] Fix noderef attribute false-negatives

2020-06-10 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2020-06-10T12:20:54-07:00 New Revision: 2f6bb2a69215f9cae883da12f8f596d3f80f8d71 URL: https://github.com/llvm/llvm-project/commit/2f6bb2a69215f9cae883da12f8f596d3f80f8d71 DIFF: https://github.com/llvm/llvm-project/commit/2f6bb2a69215f9cae883da12f8f596d3f80f8d71.diff

  1   2   >