[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + rjmccall wrote: > Comment indentation. > > Should we do this when starting to parse a function prototype instead

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209348. Mordante added a comment. tab -> space adds an extra unit test for lambdas fixes an off by one error found while testing the lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 Files: clang/in

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + rjmccall wrote: > Mordante wrote: > > rjmccall wrote: > > > Comment indentation. > > > > > > Should we do this w

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209513. Mordante added a comment. Moved the test out of the loop as suggested by rjmccall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic

[PATCH] D64644: Fixes a clang frontend assertion failure (bug 35682)

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. This fixes bug 35682. I was not able to easily generate a test-case so I haven't been able to add unit tests. I'll update the bug in bugzilla with some additional information. Repository: rG

[PATCH] D64644: Fixes a clang frontend assertion failure (bug 35682)

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for feedback. I'll whether I can find a way to generate a nice test case. Comment at: clang/lib/Sema/SemaTemplate.cpp:726 +return ExprError(); + else +return DependentScopeDeclRefExpr::Create(C

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante created this revision. Mordante added reviewers: gribozavr, rsmith. Mordante added a project: clang. It warns for for comments like /** \pre \em */ where \em has no argument This warning is enabled with the -Wdocumentation option. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209703. Mordante added a comment. Addresses @rjmccall's remarks. Fixes the tests for the nested lambda's. As suspected the blocks also have the same nesting limit, thus added a test for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante added a comment. Thanks for the review. I don't have SVN access, can you commit these changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante updated this revision to Diff 210128. Mordante marked an inline comment as done. Mordante retitled this revision from "Fixes a clang frontend assertion failure (bug 35682)" to "Fixes an assertion failure while instantiation a template with an incomplete typo corrected type". Mordante edi

[PATCH] D64811: Warn when NumParams overflows

Mordante created this revision. Mordante added reviewers: rsmith, rjmccall. Mordante added a project: clang. Before when the overflow occurred an assertion was triggered. Now check whether the maximum has been reached and warn properly. This patch fixes bug 33162 which is marked as 'duplicate' o

[PATCH] D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante updated this revision to Diff 210146. Mordante added a comment. Remove the includes from the test. Changed the `std::is_constructible` to `is_same` since the latter is easier to mock. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64644/new/ https://reviews.llvm.org/D64644 Fil

[PATCH] D64820: Avoids an assertion failure when an invalid conversion declaration is used

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. When using a user-defined conversion function template with a deduced return type the compiler gives a set of warnings: bug.cc:252:44: error: cannot specify any part of a return type in the dec

[PATCH] D64874: Improve handling of function pointer conversions

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. Starting with C++17 the `noexcept` is part of the function signature but a `noexcept` function can be converted to a `noexcept(false)` function. The overload resolution code handles it properly bu

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante marked 2 inline comments as done. Mordante added a comment. All inline commands defined in include/clang/AST/CommentCommands.td require an argument. The escape commands, like \&, are handled in the switch starting at lib/AST/CommentLexer.cpp:366. They are stored as Text and not as an I

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante updated this revision to Diff 211340. Mordante added a comment. Addresses @gribozavr comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696 Files: clang/include/clang/Basic/DiagnosticCommentKinds.td clang/lib/AST/CommentParser.cp

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Thanks for the review. I don't have commit access. So yes please commit the patch for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696 ___ cfe-commits mailing list cfe-c

[PATCH] D64811: Warn when NumParams overflows

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6673 + // Avoid exceeding the maximum function parameters + // See https://bugs.llvm.org/show_bug.cgi?id=19607 + if (ParamInfo.size() > Type::getMaxNumParams())

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

Mordante created this revision. Mordante added reviewers: sepavloff, rsmith. Mordante added a project: clang. This fixes https://bugs.llvm.org/show_bug.cgi?id=28500 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65694 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. The overload resolution for enums with a fixed underlaying type has changed in the C++14 standard. This patch implements the new rule. Note: I don't have access to the CWG 1601 paper, but

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. This implements the current standard wording for [dcl.fct.default]p9 and [dcl.fct.default]p7. This has been changed by CWG 2082. Note: I don't have access to the paper therefore I assume i

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:103-105 + // A local variable cannot be odr-used (6.2) in a default argument. + if (DRE->isNonOdrUse() != NOUR_None) +return false; --

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> I'll properly update this file as explained in D65696. Repository: rG LLVM Github Mo

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. I think it should warn; according to the documentation [1] `\c` expects a word. Testing with Doxygen indeed gives a warning. Can you post the real comment where this occurs? [1] http://www.doxygen.nl/manual/commands.html#cmdc Repository: rL LLVM CHANGES SINCE LAS

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Unfortunately I'm not able to quickly find the Doxygen output of Swift online. When I process: `A limited variant of \c @objc that's used for classes with generic ancestry.` with Doxygen I get: `A limited variant of that's used for classes with generic ancestry.` Since t

[PATCH] D64811: Warn when NumParams overflows

Mordante updated this revision to Diff 215425. Mordante added a comment. Moved the testing from Parse to Sema. Added additional safeguards for template instantiation. Added more unit tests. The comments may be a bit noisy, but they explain why the templates need to be tested at two locations. C

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante updated this revision to Diff 215448. Mordante added a comment. Updated the unit tests as requested. This required the `Sema::ActOnParamDefaultArgument` to delay a part of the ODR validation until the default argument has been 'instantiated'. As discussed on IRC; the up to date `cwg_ind

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante updated this revision to Diff 215457. Mordante added a comment. Add the proper markers in the unit test to update `cxx_dr_status.html`. As discussed on IRC; the up to date `cwg_index.html` is not public, so I only updated the unit test and removed the changes to `cxx_dr_status.html`.

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante marked 4 inline comments as done. Mordante added inline comments. Comment at: clang/test/CXX/drs/dr16xx.cpp:26 +namespace dr1601 { // dr1601: 10 c++11 +#if __cplusplus >= 201103L rsmith wrote: > No need for the "c++11" marker here. (We accept fixed und

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante updated this revision to Diff 215736. Mordante marked an inline comment as done. Mordante edited the summary of this revision. Mordante added a comment. Implemented the changes requested by @rsmith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65695/new/ https://reviews.llvm.o

[PATCH] D64874: Improve handling of function pointer conversions

Mordante added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64874/new/ https://reviews.llvm.org/D64874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D64820: Avoids an assertion failure when an invalid conversion declaration is used

Mordante added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

Mordante added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics Wouldn't it be better to

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. Herald added a subscriber: cfe-commits. Before when the overflow occurred an assertion as triggered. Now check whether the maximum has been reached and warn properly. This patch fixes the original

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante added a comment. Thanks for the review. Can you commit the patch since I don't have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65695/new/ https://reviews.llvm.org/D65695 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

Mordante added a comment. Thanks for the review. Can you commit the patch since I don't have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, xbolva00. Mordante added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68913 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema/SemaStmt.cpp clang/test/S

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, xbolva00. Mordante added a project: clang. This makes the range loop warnings part of -Wall. This 'fixes' https://bugs.llvm.org/show_bug.cgi?id=32823 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68912

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

Mordante updated this revision to Diff 224753. Mordante added a comment. Removed the language version test. I also added `clang/test/CXX/conv/conv.fctptr/template-noreturn.cpp` to show this is not enough to allow `noreturn` to all language versions, so this file should not be committed. Do you

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante updated this revision to Diff 225782. Mordante added a comment. Undo the changes to the caret position as requested by @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 Files: clang/include/clang/AST/Decl.h clang/lib/

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante created this revision. Mordante added a reviewer: gribozavr. Mordante added a project: clang. Herald added a subscriber: arphaman. I'm not sure it should be added to the `InlineComment` group. It's not entirely a markup. Do you think it should be a in a separate group? (I also have not

[PATCH] D69225: Sema: Fixes a crash with a templated destructor

Mordante created this revision. Mordante added reviewers: rcraik, hubert.reinterpretcast, aaron.ballman, rsmith. Mordante added a project: clang. This fixes PR38671. The issue was introduced by D33833 which fixed PR33189. Repository: rG LLVM Github Monorepo

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante updated this revision to Diff 226539. Mordante added a comment. Adds a test as requested by @xbolva00 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/SemaCXX/warn-ran

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

Mordante created this revision. Mordante added reviewers: rnk, rsmith, aaron.ballman. Mordante added a project: clang. This allows the caller of the function to add a note about how to fix the stack exhaustion. This can be useful to aid the user. For example it can be used to show a help message

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante created this revision. Mordante added reviewers: rnk, rsmith, aaron.ballman. Mordante added a project: clang. When a long set of expressions is chained it may overflow the stack. This warns about the issue. Note I'm not sure whether `AnalyzeImplicitConversions` is the best place to add

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

Mordante added a comment. The use case and its test are in D69479 . Is that sufficient? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 __

[PATCH] D69481: [Sema] Fixes templated friend member assertion

Mordante created this revision. Mordante added reviewers: rjmccall, rsmith, aaron.ballman. Mordante added a project: clang. Mordante added a subscriber: rtrieu. Fixes https://bugs.llvm.org/show_bug.cgi?id=41792 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69481 Files: clan

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12349 // This is not the right CC for (e.g.) a variable initialization. - AnalyzeImplicitConversions(*this, E, CC); + analyzeImplicitConversionsWithSufficie

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante updated this revision to Diff 226590. Mordante marked an inline comment as done. Mordante added a comment. Add an extra argument to `AnalyzeImplicitConversions` as suggested by @xbolva00 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69479/new/ https://reviews.llvm.org/D69479

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

Mordante added a comment. @rsmith also doesn't like the approach `runWithSufficientStackSpace` in D69479 . So I'll try to use a different approach. If that succeeds I have no use case for this patch and will probably abandon it. Repository: rG LLVM Github Mon

[PATCH] D69479: [Sema] Warn about possible stack exhaution

Mordante added a comment. I'll look at a worklist first, before fixing the other issues. However it seems it's not as trivial as I hoped. The recursion occurs in the `SequenceChecker` which has a `WorkList` but that's not used for this part. I'll try to find a solution. CHANGES SINCE LAST ACT

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1723722 , @aaron.ballman wrote: > In D68912#1723691 , @xbolva00 wrote: > > > >> Does this analysis require CFG support > > > > https://reviews.llvm.org/D69292 also requires CFG s

[PATCH] D71142: [Sema] Validate large bitfields

Mordante planned changes to this revision. Mordante added a comment. In D71142#1967409 , @aaron.ballman wrote: > In D71142#1967315 , @xbolva00 wrote: > > > Any comments? > > > > @rsmith @aaron.ballman > > > There a

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante created this revision. Mordante added reviewers: rsmith, rjmccall. Mordante added a project: clang. Herald added subscribers: llvm-commits, hiraditya. Herald added a reviewer: aaron.ballman. Herald added a project: LLVM. Mordante requested review of this revision. This contains the initia

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante updated this revision to Diff 282460. Mordante added a comment. Rebased the patch and updated the unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaTemplate/instantiate

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante created this revision. Mordante added reviewers: rsmith, rjmccall. Mordante added a project: clang. Mordante requested review of this revision. Fixes PR46484: Clang crash in clang/lib/Sema/SemaChecking.cpp:10028 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85601 Fil

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante created this revision. Mordante added reviewers: aaron.ballman, dblaikie, rsmith. Mordante added a project: clang. Herald added a subscriber: dexonsmith. Mordante requested review of this revision. When casting an enumerate with a fixed bool type the casting should use an IntegralToBoole

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + rsmith wrote: > aaron.ballman wrote

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 284478. Mordante added a comment. Addresses the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/AST/ast-dump-enum-bool.cpp clang/test/Cod

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante marked an inline comment as done. Mordante added a comment. I added `void g()` since that's valid code which also caused an assertion failure. So the issue isn't in the error recovery but in determining the required IntRange. It seems the code doesn't take http://eel.is/c++draft/expr.c

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump %s | FileCheck %s + rsmith wrote: > I don't think

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 285685. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/CXX/drs/dr23xx.cpp clang/test/CodeGen/enum-bo

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10317-10320 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth, InConstantContext); IntRange R = GetExprRange(C, CO->getFalseEx

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante updated this revision to Diff 285704. Mordante marked an inline comment as done. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85601/new/ https://reviews.llvm.org/D85601 Files: clang/lib/Sema/SemaChecking.cpp clang/test/

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante planned changes to this revision. Mordante marked 14 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodD

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG827ba67e3833: [Sema] Validate calls to GetExprRange. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85601/new/ https://reviews.llvm.o

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

This revision was automatically updated to reflect the committed changes. Closed by commit rGfef260712407: [Sema] Use the proper cast for a fixed bool enum. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://rev

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 14 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs]; aaron.ballman wrote:

[PATCH] D131479: Handle explicitly defaulted consteval special members.

Mordante added a comment. This change breaks the libc++ test `libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.fail.cpp`. (https://buildkite.com/llvm-project/libcxx-ci/builds/13149#0182d0d4-341a-4b41-b67f-12937f41e6d5) Looking at the description of this patch it sho

[PATCH] D131479: Handle explicitly defaulted consteval special members.

Mordante added a comment. In D131479#3753533 , @aaron.ballman wrote: > In D131479#3753462 , @Mordante > wrote: > >> This change breaks the libc++ test >> `libcxx/test/std/utilities/optional/optional.object/opti

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

Mordante added subscribers: ldionne, Mordante. Mordante added inline comments. Comment at: libcxx/utils/ci/buildkite-pipeline.yml:377 +CFLAGS: "-fcrash-diagnostics-dir=crash_diagnostics_dir" +CXXFLAGS: "-fcrash-diagnostics-dir=crash_diagnostics_dir" LLVM_

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

Mordante added a comment. Thanks for working on this! It's really great to get the crash report as an artifact. Comment at: libcxx/test/libcxx/crash.sh.cpp:15 + +#pragma clang __debug parser_crash The libc++ build seems to be green. I assume it was intended to

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

Mordante accepted this revision. Mordante added a comment. Ideally it would be documented these artifacts are now available. However there's no good place in libc++ to document that. I'm working on such a document so I will take care of documenting these artifacts. LGTM from libc++'s PoV. ==

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante created this revision. Mordante added reviewers: aaron.ballman, ldionne. Herald added subscribers: mstorsjo, arphaman. Herald added a project: All. Mordante requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Heral

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante added a comment. Thanks for the review comments. I'll address them in a little while. I want to wait for more review comments. Comment at: clang/www/hacking.html:302 + + For most builds, the pre-commit CI uses a recent + https://apt.llvm.org/";>nightly build of Clan

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 8 inline comments as done. Mordante added a comment. Thanks for all review comments! I'm a bit out of time so I will look at the other comments later. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. T

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 459347. Mordante marked 15 inline comments as done. Mordante added a comment. Addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: cla

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante added inline comments. Comment at: libcxx/docs/Contributing.rst:88 +* C++XX for the Linux platform (where XX is the latest C++ version). +* MacOS X86_64 and MacOS arm64 for the Apple platform. + philnik wrote: > They are synonyms, since use the undersco

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 459351. Mordante added a comment. Rebased to fix CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: clang/www/hacking.html libcxx/docs/Contributi

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM with some suggestions. Comment at: libcxx/docs/ReleaseNotes.rst:226 + experimental features provided by it. Note that vendors are encour

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante added a comment. Thanks @egorzhdan for working on this, I seem to have overlooked this item in the review queue. SGMT, but it seems the libc++ CI hasn't been triggered with this change. Maybe change one file in libc++ to give the CI a spin? Comment at: clang/docs/Cla

[PATCH] D128844: Improve the formatting of static_assert messages

Mordante accepted this revision. Mordante added a comment. In D128844#360 , @aaron.ballman wrote: > So I *think* this LG, but am not certain what will happen when you land it. I > think the precommit CI failures are not failures that will happen whe

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. I had a look at the changes and still LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 ___ cfe-c

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

Mordante created this revision. Mordante added reviewers: serge-sans-paille, aaron.ballman. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D117296 removed wording for

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

Mordante added a comment. In D122423#3406381 , @aaron.ballman wrote: > LGTM, a second time. :-D Sorry for missing that the first time. No problem, thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D122423: [Clang][doc] Fix __builtin_assume wording.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3b672a34cde: [Clang][doc] Fix __builtin_assume wording. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131062: [docs] Add "C++20 Modules"

Mordante added a comment. Thanks a lot for working on this! I wonder whether it would be better to have some of the more technical information in a separate file and let this file mainly have an introduction to modules in general and how to get started using them in Clang. I haven't tested the

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. In D123182#3458712 , @royjacobson wrote: > So, it seems like this broke one of `basic_arg_format`'s private > constructors.. Sorry for that. > > This is now ambiguous when calling `basic_format_arg(char)` because the > argumen

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. I've a fix in D124103 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___ cfe-commits mailing list

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. I didn't look at the code, but I have some hints how we can test libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commi

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#3463887 , @pcwang-thead wrote: > In D112921#3462592 , @Mordante > wrote: > >> I didn't look at the code, but I have some hints how we can test libc++. > > Thanks! I ran tests

[PATCH] D113319: [clang-format] Improve require and concept handling

Mordante added a comment. Thanks for working on this! I love to see better `requires` support in clang-format. I didn't do a real review, just some drive-by comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3399 +**RequiresClausePositionForClasses** (``RequiresCla

[PATCH] D113319: [clang-format] Improve require and concept handling

Mordante added inline comments. Comment at: clang/lib/Format/Format.cpp:1212 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + // This is open for discussions! When will LLVM adapt C++20? + LLVMStyle.RequiresClausePositionForClasses = FormatStyle::RCPS_OwnLine;

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante added a comment. Sorry I missed your message. At the moment I don't intend to continue with this review. Do you want to commandeer this one or do you prefer me to abandon it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71966/new/ https://reviews.llvm.org/D71966

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

Mordante added a comment. Thanks for these fixes. SGTM, but I want to see the CI pass. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:135 FD->getNameForDiagnostic(Out, FD->getASTContext().getLangOpts(), true); - Out << "' call may invalidat

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. I see some test time-outs, but they seem to happen quite often. LGTM, but please wait a few days before landing this patch to give other reviewers time to have a look. Repository: rG LL

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87a55137e2a2: Fix "the the" typo in documentation and user facing strings (authored by briantracy, committed by Mordante). Repository: rG LLVM Git

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

Mordante added a comment. The libc++ build failures are due a broken libc++ HEAD. The current HEAD should work again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 _

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante accepted this revision. Mordante added a comment. LGTM, but please update the name of the flag in the title before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141 ___

[PATCH] D129048: Rewording the "static_assert" to static assertion

Mordante added a comment. In D129048#3668905 , @aaron.ballman wrote: > In D129048#3668846 , @ldionne wrote: > >> In D129048#3668594 , @philnik >> wrote: >> >>> Also, ple

  1   2   3   4   5   >