Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

mclow.lists added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include __config_site + #ifdef __GNUC__ espositofulvio wrote: mclow.lists wrote: I'm reluctant to do this; because every include file slows down compilation - for every

[libcxx] r245330 - implement more of N4258 - Cleaning up noexcept in the standard library. Specifically add new noexcept stuff to vector and string's move-assignment operations

Author: marshall Date: Tue Aug 18 13:57:00 2015 New Revision: 245330 URL: http://llvm.org/viewvc/llvm-project?rev=245330view=rev Log: implement more of N4258 - Cleaning up noexcept in the standard library. Specifically add new noexcept stuff to vector and string's move-assignment operations

Re: [PATCH] D11555: [libcxx] Allow use of atomic in C++03. Try 3.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I think this is ready to land now. Thanks, Eric. http://reviews.llvm.org/D11555 ___ cfe-commits mailing list

[libcxx] r245849 - Fix a crasher found by libFuzzer

Author: marshall Date: Mon Aug 24 10:57:09 2015 New Revision: 245849 URL: http://llvm.org/viewvc/llvm-project?rev=245849view=rev Log: Fix a crasher found by libFuzzer Modified: libcxx/trunk/include/regex libcxx/trunk/test/std/re/re.alg/re.alg.search/grep.pass.cpp Modified:

[libcxx] r245239 - Make regex and any assert when they should throw an exception _but_ the user has decreed 'no exceptions'. This matches the behavior of string and vector

Author: marshall Date: Mon Aug 17 16:14:16 2015 New Revision: 245239 URL: http://llvm.org/viewvc/llvm-project?rev=245239view=rev Log: Make regex and any assert when they should throw an exception _but_ the user has decreed 'no exceptions'. This matches the behavior of string and vector

[PATCH] D11948: Add some macros to abstract marking of parameters as not null, and use them in cstring

mclow.lists created this revision. mclow.lists added reviewers: chandlerc, rsmith, EricWF. mclow.lists added a subscriber: cfe-commits. Herald added subscribers: danalbert, tberghammer. The C standard says that calling `memcpy`, etc with null parameters is undefined behavior. GCC (and clang)

Re: [PATCH] D11781: Refactored pthread usage in libcxx

mclow.lists added a subscriber: mclow.lists. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. I agree with @jroelofs that we don't want to `#include unistd.h` in `__config` Repository: rL LLVM http://reviews.llvm.org/D11781

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as not null, and use them in cstring

mclow.lists added inline comments. Comment at: include/cstring:96 @@ +95,3 @@ +int strncmp(const char* __s1, const char* __s2, size_t __n) +{ return ::memcmp(__s1, __s2, __n); } + nlopes wrote: typo here. Oops. Thanks! http://reviews.llvm.org/D11948

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 11:12 AM, Hans Wennborg h...@chromium.org wrote: On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits cfe-commits@lists.llvm.org wrote: On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via cfe-commits wrote: Author: joerg Date: Mon Aug

[libcxx] r251220 - Update C++ status from Kona

Author: marshall Date: Sun Oct 25 01:02:23 2015 New Revision: 251220 URL: http://llvm.org/viewvc/llvm-project?rev=251220=rev Log: Update C++ status from Kona Modified: libcxx/trunk/www/cxx1z_status.html libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r251545 - Mark two Kona papers as 'in progress'

Author: marshall Date: Wed Oct 28 14:21:40 2015 New Revision: 251545 URL: http://llvm.org/viewvc/llvm-project?rev=251545=rev Log: Mark two Kona papers as 'in progress' Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r251618 - Implement P0004R1 'Remove Deprecated iostreams aliases'

Author: marshall Date: Thu Oct 29 00:43:30 2015 New Revision: 251618 URL: http://llvm.org/viewvc/llvm-project?rev=251618=rev Log: Implement P0004R1 'Remove Deprecated iostreams aliases' Modified: libcxx/trunk/include/ios libcxx/trunk/test/std/depr/depr.ios.members/io_state.pass.cpp

[libcxx] r251257 - Fix LWG#2489: mem_fn() should be noexcept

Author: marshall Date: Sun Oct 25 15:12:16 2015 New Revision: 251257 URL: http://llvm.org/viewvc/llvm-project?rev=251257=rev Log: Fix LWG#2489: mem_fn() should be noexcept Modified: libcxx/trunk/include/functional

[libcxx] r251247 - Fix LWG#2127: Move-construction with raw_storage_iterator.

Author: marshall Date: Sun Oct 25 13:58:07 2015 New Revision: 251247 URL: http://llvm.org/viewvc/llvm-project?rev=251247=rev Log: Fix LWG#2127: Move-construction with raw_storage_iterator. Modified: libcxx/trunk/include/memory

[libcxx] r251252 - Add a test for LWG#2466: allocator_traits::max_size() default behavior is incorrect

Author: marshall Date: Sun Oct 25 14:34:04 2015 New Revision: 251252 URL: http://llvm.org/viewvc/llvm-project?rev=251252=rev Log: Add a test for LWG#2466: allocator_traits::max_size() default behavior is incorrect Modified: libcxx/trunk/include/memory

[libcxx] r251254 - Add the tests for the last commit

Author: marshall Date: Sun Oct 25 14:53:29 2015 New Revision: 251254 URL: http://llvm.org/viewvc/llvm-project?rev=251254=rev Log: Add the tests for the last commit Added: libcxx/trunk/test/std/utilities/allocator.adaptor/scoped.adaptor.operators/copy_assign.pass.cpp

[libcxx] r251246 - Fix LWG#2244: basic_istream::seekg

Author: marshall Date: Sun Oct 25 13:31:51 2015 New Revision: 251246 URL: http://llvm.org/viewvc/llvm-project?rev=251246=rev Log: Fix LWG#2244: basic_istream::seekg Modified: libcxx/trunk/include/istream

[libcxx] r251250 - Add a test for LWG#2462: std::ios_base::failure is overspecified

Author: marshall Date: Sun Oct 25 14:20:14 2015 New Revision: 251250 URL: http://llvm.org/viewvc/llvm-project?rev=251250=rev Log: Add a test for LWG#2462: std::ios_base::failure is overspecified Modified:

[libcxx] r251253 - Fix LWG#2476: scoped_allocator_adaptor is not assignable

Author: marshall Date: Sun Oct 25 14:52:47 2015 New Revision: 251253 URL: http://llvm.org/viewvc/llvm-project?rev=251253=rev Log: Fix LWG#2476: scoped_allocator_adaptor is not assignable Modified: libcxx/trunk/include/scoped_allocator Modified: libcxx/trunk/include/scoped_allocator URL:

[libcxx] r252610 - Explicitly #include so that we get std::move. Thanks to Walter for the bug report.

Author: marshall Date: Tue Nov 10 09:22:08 2015 New Revision: 252610 URL: http://llvm.org/viewvc/llvm-project?rev=252610=rev Log: Explicitly #include so that we get std::move. Thanks to Walter for the bug report. Modified:

[libcxx] r252614 - Fix typo I just introduced.

Author: marshall Date: Tue Nov 10 10:10:17 2015 New Revision: 252614 URL: http://llvm.org/viewvc/llvm-project?rev=252614=rev Log: Fix typo I just introduced. Modified: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke.pass.cpp Modified:

[libcxx] r252613 - std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch

Author: marshall Date: Tue Nov 10 10:04:13 2015 New Revision: 252613 URL: http://llvm.org/viewvc/llvm-project?rev=252613=rev Log: std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch Modified: libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp Modified:

[libcxx] r252509 - Mark LWG#2486 as complete. Eric did this as part of r242959

Author: marshall Date: Mon Nov 9 14:49:15 2015 New Revision: 252509 URL: http://llvm.org/viewvc/llvm-project?rev=252509=rev Log: Mark LWG#2486 as complete. Eric did this as part of r242959 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r252905 - Implement P0074: Making owner_less more flexible

Author: marshall Date: Thu Nov 12 09:56:44 2015 New Revision: 252905 URL: http://llvm.org/viewvc/llvm-project?rev=252905=rev Log: Implement P0074: Making owner_less more flexible Modified: libcxx/trunk/include/memory

[libcxx] r251802 - Remove undefined behavior from some tests. Thanks to Walter Brown for the heads-up.

Author: marshall Date: Mon Nov 2 09:25:53 2015 New Revision: 251802 URL: http://llvm.org/viewvc/llvm-project?rev=251802=rev Log: Remove undefined behavior from some tests. Thanks to Walter Brown for the heads-up. Modified:

[libcxx] r251804 - Remove undefined behavior from some tests. Same pattern as the unitialized_copy tests

Author: marshall Date: Mon Nov 2 09:29:13 2015 New Revision: 251804 URL: http://llvm.org/viewvc/llvm-project?rev=251804=rev Log: Remove undefined behavior from some tests. Same pattern as the unitialized_copy tests Modified:

[libcxx] r251767 - Improve the tests for 'is_literal_type'

Author: marshall Date: Sun Nov 1 15:13:10 2015 New Revision: 251767 URL: http://llvm.org/viewvc/llvm-project?rev=251767=rev Log: Improve the tests for 'is_literal_type' Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_literal_type.pass.cpp Modified:

[libcxx] r251768 - Add 'nostdinc++' to the flags used by testit. Makes the tests run better on Mac OS X with the new depr.c headers change

Author: marshall Date: Sun Nov 1 15:14:22 2015 New Revision: 251768 URL: http://llvm.org/viewvc/llvm-project?rev=251768=rev Log: Add 'nostdinc++' to the flags used by testit. Makes the tests run better on Mac OS X with the new depr.c headers change Modified: libcxx/trunk/test/testit

[libcxx] r252195 - Implement P0092R1 for C++1z

Author: marshall Date: Thu Nov 5 13:33:59 2015 New Revision: 252195 URL: http://llvm.org/viewvc/llvm-project?rev=252195=rev Log: Implement P0092R1 for C++1z Added: libcxx/trunk/test/std/utilities/time/time.duration/time.duration.alg/

[libcxx] r252199 - Mark LWG issue #2234. We already do this; no code change needed

Author: marshall Date: Thu Nov 5 13:57:50 2015 New Revision: 252199 URL: http://llvm.org/viewvc/llvm-project?rev=252199=rev Log: Mark LWG issue #2234. We already do this; no code change needed Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r252406 - More of P0006R0: type traits variable aliases for C++17.

Author: marshall Date: Sat Nov 7 11:44:36 2015 New Revision: 252406 URL: http://llvm.org/viewvc/llvm-project?rev=252406=rev Log: More of P0006R0: type traits variable aliases for C++17. Modified: libcxx/trunk/include/type_traits

[libcxx] r252407 - Implement LWG#2353: std::next is over-constrained

Author: marshall Date: Sat Nov 7 11:48:49 2015 New Revision: 252407 URL: http://llvm.org/viewvc/llvm-project?rev=252407=rev Log: Implement LWG#2353: std::next is over-constrained Modified: libcxx/trunk/include/iterator

[libcxx] r252408 - Mark LWG#2224 as complete. Wording change only, no code changes required

Author: marshall Date: Sat Nov 7 11:56:51 2015 New Revision: 252408 URL: http://llvm.org/viewvc/llvm-project?rev=252408=rev Log: Mark LWG#2224 as complete. Wording change only, no code changes required Modified: libcxx/trunk/www/cxx1z_status.html Modified:

[libcxx] r251836 - Make reverse() call iter_swap like the standard says, instead of calling swap directly. No real change.

Author: marshall Date: Mon Nov 2 15:34:25 2015 New Revision: 251836 URL: http://llvm.org/viewvc/llvm-project?rev=251836=rev Log: Make reverse() call iter_swap like the standard says, instead of calling swap directly. No real change. Modified: libcxx/trunk/include/algorithm Modified:

Re: [PATCH] D12747: Implement [depr.c.headers]

On Wed, Oct 7, 2015 at 2:38 PM, Richard Smith wrote: > Marshall: ping, does the below satisfy your concerns about the direction > here? > No, not really, because I'm worried about behavior changes with this approach. #include isdigit(c); will call different code

[libcxx] r249593 - While researching LWG#2244, I noticed we weren't testing that eofbit was being cleared. Now we are

Author: marshall Date: Wed Oct 7 14:41:24 2015 New Revision: 249593 URL: http://llvm.org/viewvc/llvm-project?rev=249593=rev Log: While researching LWG#2244, I noticed we weren't testing that eofbit was being cleared. Now we are Modified:

[libcxx] r249595 - Mark 2244 as 'Patch Ready', 2477 and 2487 as 'Complete'

Author: marshall Date: Wed Oct 7 14:45:14 2015 New Revision: 249595 URL: http://llvm.org/viewvc/llvm-project?rev=249595=rev Log: Mark 2244 as 'Patch Ready', 2477 and 2487 as 'Complete' Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r250802 - Detect relaxed constexpr rules for gcc versions

Author: marshall Date: Tue Oct 20 02:37:11 2015 New Revision: 250802 URL: http://llvm.org/viewvc/llvm-project?rev=250802=rev Log: Detect relaxed constexpr rules for gcc versions Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

[libcxxabi] r250097 - Fix Bug 25103 - _cxa_demangle improperly demangles virtual thunks. Thanks to Jason King for the report and suggested fix

Author: marshall Date: Mon Oct 12 15:45:05 2015 New Revision: 250097 URL: http://llvm.org/viewvc/llvm-project?rev=250097=rev Log: Fix Bug 25103 - _cxa_demangle improperly demangles virtual thunks. Thanks to Jason King for the report and suggested fix Modified:

Re: [PATCH] D13192: Fix incorrect parsing of arguments for nested functions

mclow.lists closed this revision. mclow.lists added a comment. landed as revision 249649 http://reviews.llvm.org/D13192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r249333 - Private page for status of Kona issues and papers. Will be deleted after the Kona meeting. Not to be linked to from other pages.

Author: marshall Date: Mon Oct 5 13:40:13 2015 New Revision: 249333 URL: http://llvm.org/viewvc/llvm-project?rev=249333=rev Log: Private page for status of Kona issues and papers. Will be deleted after the Kona meeting. Not to be linked to from other pages. Added:

[libcxx] r249334 - Add comments about the issues

Author: marshall Date: Mon Oct 5 13:48:10 2015 New Revision: 249334 URL: http://llvm.org/viewvc/llvm-project?rev=249334=rev Log: Add comments about the issues Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r249461 - Updated issue 2476

Author: marshall Date: Tue Oct 6 15:35:15 2015 New Revision: 249461 URL: http://llvm.org/viewvc/llvm-project?rev=249461=rev Log: Updated issue 2476 Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r249458 - Our test allocators support move/copy construction; they should support move/copy assignment as well

Author: marshall Date: Tue Oct 6 15:30:56 2015 New Revision: 249458 URL: http://llvm.org/viewvc/llvm-project?rev=249458=rev Log: Our test allocators support move/copy construction; they should support move/copy assignment as well Modified: libcxx/trunk/test/support/allocators.h Modified:

[libcxx] r249345 - Patch ready for 2127

Author: marshall Date: Mon Oct 5 15:16:30 2015 New Revision: 249345 URL: http://llvm.org/viewvc/llvm-project?rev=249345=rev Log: Patch ready for 2127 Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r249347 - Mark 2072 as complete; we already do this

Author: marshall Date: Mon Oct 5 15:21:54 2015 New Revision: 249347 URL: http://llvm.org/viewvc/llvm-project?rev=249347=rev Log: Mark 2072 as complete; we already do this Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r249349 - Fixed a possible overflow in a test of allocator::max_size().

Author: marshall Date: Mon Oct 5 15:50:25 2015 New Revision: 249349 URL: http://llvm.org/viewvc/llvm-project?rev=249349=rev Log: Fixed a possible overflow in a test of allocator::max_size(). Modified:

Re: [PATCH] D12297: [libcxx] Fix most undefined behavior in list

mclow.lists added a comment. I like this because it localizes the weirdness into one routine `self`. If we can't get D12999 applied due to ABI concerns, this will help a bunch. http://reviews.llvm.org/D12297 ___ cfe-commits mailing list

Re: [PATCH] D12299: [libcxx] ABI-Breaking Fix for ALL undefined behavior in list.

mclow.lists added a comment. So... what do we need to do to enumerate the ABI breakage of this patch? I get that there's a couple of member variables that are changing type. Can they change (as a result of this patch) from a plain pointer to a fancy pointer (or vice versa)? Can they change

Re: [PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

mclow.lists added a comment. I think I'd rather see the call to `strcmp` and `wcscmp` in the char_traits class. http://reviews.llvm.org/D12355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

mclow.lists added inline comments. Comment at: include/__functional_base:521 @@ +520,3 @@ +operator() (_ArgTypes... __args) const { +return __invoke(get(), _VSTD::forward_ArgTypes(__args)...); +} I know you didn't change this, but how did we get

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Ok, I think this is good to go. Thanks, Eric. http://reviews.llvm.org/D11553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11553: [libcxx] Rewrite C++03 __invoke.

mclow.lists added a comment. So far, this looks good. I'm going to apply it locally and futz with it. Comment at: include/__functional_base_03:30 @@ +29,3 @@ +typedef _Ret _Bullet2; +typedef _Ret type; +}; Let's be consistent. :-) typedef _Bullet2

Re: [PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

mclow.lists added a comment. In http://reviews.llvm.org/D12355#233477, @bkramer wrote: Won't this do the wrong thing for embedded '\0' in a std::string? std::string(hello\0world, 11).compare(hello) should not return 0. Good point; I think that pretty much kills this proposed change.

Re: [PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

mclow.lists added a comment. The first change LGTM. The second one needs to match it. Comment at: include/string:3816 @@ -3808,2 +3815,3 @@ +return __lhs.compare(0, _String::npos, __rhs, __rhs_len) == 0; } You'll want to do the same as above here.

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

mclow.lists added a comment. Two comments answered. One still remaining. Comment at: include/experimental/functional:256 @@ +255,3 @@ + +public: // TODO private: +_RandomAccessIterator1 __first_; EricWF wrote: Is this for testing? Well, for

Re: [PATCH] D12135: [libcxx] Mark most test/std/future tests as UNSUPPORTED in C++03

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks very mechanical, except for the changes to test_allocator.h, and that's a bug fix. http://reviews.llvm.org/D12135 ___

Re: [PATCH] D12173: [libcxx] Constrain unique_ptr::operator=(unique_ptrTp, Dp) in C++03 mode

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This is just making the two halves of the #ifdef consistent. LGTM. http://reviews.llvm.org/D12173 ___ cfe-commits mailing list

[libcxx] r246445 - Remove unused code. NFC

Author: marshall Date: Mon Aug 31 09:43:41 2015 New Revision: 246445 URL: http://llvm.org/viewvc/llvm-project?rev=246445=rev Log: Remove unused code. NFC Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

mclow.lists updated this revision to Diff 33624. mclow.lists added a comment. Fixed a typo in the patch for `strncmp`, and added a macro `_LIBCPP_HAS_NO_NONNULL` to allow people to disable these checks. Marked them as disabled for non-clang and non-gcc compilers.

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

mclow.lists updated this revision to Diff 33770. mclow.lists added a comment. Updated based on Eric's comments. http://reviews.llvm.org/D11380 Files: include/experimental/functional test/std/experimental/algorithms/alg.search/search.pass.cpp

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

mclow.lists marked 3 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D11380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r246772 - Make a helper routine __throw_future_error, and encapsulate the #ifdef _LIBCPP_NO_EXCEPTIONS there, instead of duplicating it throughout the code. No functionality change

Author: marshall Date: Thu Sep 3 10:11:32 2015 New Revision: 246772 URL: http://llvm.org/viewvc/llvm-project?rev=246772=rev Log: Make a helper routine __throw_future_error, and encapsulate the #ifdef _LIBCPP_NO_EXCEPTIONS there, instead of duplicating it throughout the code. No functionality

Re: [PATCH] D3197: Remove undefined behavior from list::push_back/front, emplace_back/front.

mclow.lists abandoned this revision. mclow.lists added a comment. There are other suggested fixes for this problem, and this has gotten stale. http://reviews.llvm.org/D3197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r247036 - Implementation of Boyer-Moore and Boyer-Moore-Horspool searchers for the LFTS.

Author: marshall Date: Tue Sep 8 12:59:09 2015 New Revision: 247036 URL: http://llvm.org/viewvc/llvm-project?rev=247036=rev Log: Implementation of Boyer-Moore and Boyer-Moore-Horspool searchers for the LFTS. Added:

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

mclow.lists closed this revision. mclow.lists added a comment. Landed as revision 247036 http://reviews.llvm.org/D11380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r247704 - Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated doesn't change the fact that we have to test it.

Author: marshall Date: Tue Sep 15 12:12:49 2015 New Revision: 247704 URL: http://llvm.org/viewvc/llvm-project?rev=247704=rev Log: Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated doesn't change the fact that we have to test it. Modified:

[libcxx] r247695 - Change initialization of mbstate_t objects in tests from '= {0}' to '= {}', which does the same thing, w/o having clang and gcc warn with -Wall.

Author: marshall Date: Tue Sep 15 09:46:03 2015 New Revision: 247695 URL: http://llvm.org/viewvc/llvm-project?rev=247695=rev Log: Change initialization of mbstate_t objects in tests from '= {0}' to '= {}', which does the same thing, w/o having clang and gcc warn with -Wall. Modified:

Re: [PATCH] D13337: [libcxx] Attempt to fix __throw_future_error in C++03

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. I can't reproduce the error that I was getting. http://reviews.llvm.org/D13337 ___ cfe-commits mailing list

Re: [libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

On Fri, Oct 2, 2015 at 1:58 PM, Eric Fiselier wrote: > Hi Tom, > > I would like this patch merged into 3.7.1. > Marshall can you please approve this? > Looks fine to me. -- Marshall > > /Eric > > On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits >

Re: [PATCH] D13331: [libcxx] Use newest supported language dialect when running the test suite.

mclow.lists added a comment. Works for me. Now we need to do the same for clang. http://reviews.llvm.org/D13331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r249352 - Patch for 2466 is ready

Author: marshall Date: Mon Oct 5 16:08:49 2015 New Revision: 249352 URL: http://llvm.org/viewvc/llvm-project?rev=249352=rev Log: Patch for 2466 is ready Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r249354 - Mark 2380 and 2384 as complete; no changes needed

Author: marshall Date: Mon Oct 5 16:11:20 2015 New Revision: 249354 URL: http://llvm.org/viewvc/llvm-project?rev=249354=rev Log: Mark 2380 and 2384 as complete; no changes needed Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

[libcxx] r249363 - Mark 2259 and 2473 as complete. Add some more notes

Author: marshall Date: Mon Oct 5 18:27:10 2015 New Revision: 249363 URL: http://llvm.org/viewvc/llvm-project?rev=249363=rev Log: Mark 2259 and 2473 as complete. Add some more notes Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

mclow.lists added a comment. Please DO NOT commit this patch. See http://cplusplus.github.io/LWG/lwg-active.html#2224 for a discussion of this code, and the (proposed) resolution is that this is undefined behavior. http://reviews.llvm.org/D13080

[libcxx] r248305 - Check in the test for PR#24890 that I forgot in previous commit

Author: marshall Date: Tue Sep 22 12:57:41 2015 New Revision: 248305 URL: http://llvm.org/viewvc/llvm-project?rev=248305=rev Log: Check in the test for PR#24890 that I forgot in previous commit Modified: libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp Modified:

[libcxx] r248307 - The test I cnecked in to check the fix for PR#24890 failed (as expected) w/o the fix, but for the wrong reason. Now it fails for the right reason.

Author: marshall Date: Tue Sep 22 13:09:13 2015 New Revision: 248307 URL: http://llvm.org/viewvc/llvm-project?rev=248307=rev Log: The test I cnecked in to check the fix for PR#24890 failed (as expected) w/o the fix, but for the wrong reason. Now it fails for the right reason. Modified:

[libcxx] r249325 - Implement LWG#2063, and update the issues links to point to the github generated pages

Author: marshall Date: Mon Oct 5 11:17:34 2015 New Revision: 249325 URL: http://llvm.org/viewvc/llvm-project?rev=249325=rev Log: Implement LWG#2063, and update the issues links to point to the github generated pages Modified: libcxx/trunk/include/string

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists added inline comments. Comment at: clang-tidy/misc/StdSwapCheck.cpp:24 @@ +23,3 @@ +/// source location will be invalid. +static SourceLocation findSemiAfterLocation(SourceLocation loc, +ASTContext ,

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists added inline comments. Comment at: clang-tidy/misc/StdSwapCheck.cpp:68 @@ +67,3 @@ + callee(expr(ignoringParenImpCasts(declRefExpr(has(nestedNameSpecifierLoc().bind("namespace"))).bind("swap"), +this); +} I believe that if you do that, you

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

mclow.lists added a comment. In general, this looks fine. There are a few nits. 1. There needs to be a way to disable these annotations. The usual way in libc++ is to check to see if `_LIBCPP_THREAD_ANNOTATION` is already defined, and if so, do not define it. We usually state things in the

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

mclow.lists added a comment. > We usually state things in the negative, so the controlling macro should be > _LIBCPP_HAS_NO_THREAD_ANNOTATION Or actually, `_LIBCPP_HAS_NO_THREAD_ANNOTATIONS` http://reviews.llvm.org/D14731 ___ cfe-commits

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists updated the summary for this revision. mclow.lists updated this revision to Diff 41559. mclow.lists added a comment. Suggestions from @AaronBallman; now does the substitution correctly, and passes the tests. Note: The diagnostics that clang emits are still whacko.

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists updated this revision to Diff 41667. mclow.lists added a comment. Richard clued me in to the cool method `isStdNamespace()`, which made the code simpler. http://reviews.llvm.org/D15121 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists added a comment. I ran this on LLVM + clang, and it changed calls in 61 files. The changed LLVM codebase compiled successfully, and passed all the tests. Re: @dblaikie's comment, I'd rather call such a beast `llvm::swap`, and it would have to go into a header file that everyone

[PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists created this revision. mclow.lists added reviewers: klimek, aaron.ballman, chandlerc. mclow.lists added a subscriber: cfe-commits. Motivation: LLVM has many overloads of `std::swap` for its own types. This is technically forbidden by the standard, but is pervasive in the LLVM code

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists added a comment. Also, even though the `--fix` done by the tool is (almost) correct, the display of the fixit hint by clang is really confusing, even wrong http://reviews.llvm.org/D15121 ___ cfe-commits mailing list

[libcxx] r254971 - Cleaned up the intro for the TS status page; really need much more info here

Author: marshall Date: Mon Dec 7 18:08:23 2015 New Revision: 254971 URL: http://llvm.org/viewvc/llvm-project?rev=254971=rev Log: Cleaned up the intro for the TS status page; really need much more info here Modified: libcxx/trunk/www/ts1z_status.html Modified:

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists updated this revision to Diff 41662. mclow.lists added a comment. More tests; incorporated some of the suggestions for making sure we don't step on other people's namespaces named `std`. http://reviews.llvm.org/D15121 Files: clang-tidy/misc/CMakeLists.txt

[libcxx] r255513 - Add add_lvalue_ref tests for a few function types, with a note why not more

Author: marshall Date: Mon Dec 14 11:34:03 2015 New Revision: 255513 URL: http://llvm.org/viewvc/llvm-project?rev=255513=rev Log: Add add_lvalue_ref tests for a few function types, with a note why not more Modified:

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

mclow.lists added inline comments. Comment at: test/support/noexcept.h:43 @@ +42,3 @@ +#define try if(!setjmp(try_buf)) +#define catch(ex) else + This is explicitly forbidden by the standard. [macro.names]/2: A translation unit shall not #define or #undef names

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

mclow.lists added a comment. do we even use `_NOEXCEPT_OR_FALSE` any more? http://reviews.llvm.org/D15516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r255517 - Fix a corner case that involved calling rethrow_if_nested with a type that had a deleted operator&. Added a test to catch this as well. Thanks to Ville for the heads-up.

Author: marshall Date: Mon Dec 14 12:01:56 2015 New Revision: 255517 URL: http://llvm.org/viewvc/llvm-project?rev=255517=rev Log: Fix a corner case that involved calling rethrow_if_nested with a type that had a deleted operator&. Added a test to catch this as well. Thanks to Ville for the

[libcxx] r255519 - K-Ballo pointed out a mistake in the add_lvalue_ref tests I checked in; now more of them are passing. Thanks

Author: marshall Date: Mon Dec 14 12:11:51 2015 New Revision: 255519 URL: http://llvm.org/viewvc/llvm-project?rev=255519=rev Log: K-Ballo pointed out a mistake in the add_lvalue_ref tests I checked in; now more of them are passing. Thanks Modified:

[libcxx] r255518 - Missed this on the previous (255517) commit

Author: marshall Date: Mon Dec 14 12:02:23 2015 New Revision: 255518 URL: http://llvm.org/viewvc/llvm-project?rev=255518=rev Log: Missed this on the previous (255517) commit Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Other than the `_NOEXCEPT_OR_FALSE` thing, this LGTM. http://reviews.llvm.org/D15516 ___ cfe-commits mailing list

[PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

mclow.lists created this revision. mclow.lists added reviewers: howard.hinnant, EricWF, rsmith. mclow.lists added a subscriber: cfe-commits. libc++'s basic_string class assumes that iterator operations on the iterators that are passed to it don't throw. This is wrong, and means that we don't

Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

mclow.lists updated this revision to Diff 43906. mclow.lists added a comment. Howard suggested a fix for the "is incremental" problem in the type trait. I also added assignable. http://reviews.llvm.org/D15862 Files: include/algorithm include/iterator include/string Index:

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

mclow.lists added a comment. ping? http://reviews.llvm.org/D15121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973.

mclow.lists added inline comments. Comment at: include/string:1211 @@ +1210,3 @@ +// noexcept(declval<_Iter>().operator++()) && +// noexcept(++(declval<_Iter>())) && + noexcept(declval<_Iter>() == declval<_Iter>()) && This is not quite right yet.

  1   2   3   4   5   6   7   8   9   >