pelikan accepted this revision.
pelikan added a comment.
This revision is now accepted and ready to land.
Most of my comments are minor enough I'd be OK if this went in. But please
consider them before committing.
Comment at: clang/include/clang/Driver/XRayArgs.h:29
std::v
pelikan created this revision.
pelikan added a reviewer: dberris.
Depends on https://reviews.llvm.org/D38993.
Repository:
rC Clang
https://reviews.llvm.org/D45570
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
=
pelikan updated this revision to Diff 142174.
pelikan added a comment.
while there, clang-format the code I touched
Repository:
rC Clang
https://reviews.llvm.org/D45570
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
===
pelikan added a comment.
I would probably add more tests for the different configurations, but I suspect
more diffs are coming after this.
Comment at: clang/include/clang/Driver/Options.td:1112
+ Group, Flags<[CC1Option]>,
+ HelpText<"Select which bundle of XRay instrumentat
pelikan created this revision.
Functions with the "xray_log_args" attribute will tell LLVM to emit a special
XRay sled for compiler-rt to copy any call arguments to your logging handler.
https://reviews.llvm.org/D29704
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib
pelikan updated this revision to Diff 90431.
pelikan marked an inline comment as done.
pelikan added a comment.
- clarify comment and rename variable so it'll all fit.
https://reviews.llvm.org/D29704
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CodeGenFun
