Author: mprobst
Date: Tue May 22 03:39:07 2018
New Revision: 332968
URL: http://llvm.org/viewvc/llvm-project?rev=332968&view=rev
Log:
clang-format: [JS] do not wrap before any `is`.
Summary:
`is` type annotations can occur at any nesting level. For example:
function x() {
return functi
Author: mprobst
Date: Thu Aug 2 04:52:08 2018
New Revision: 338706
URL: http://llvm.org/viewvc/llvm-project?rev=338706&view=rev
Log:
clang-format: fix a crash in comment wraps.
Summary:
Previously, clang-format would crash if it tried to wrap an overlong
single line comment, because two parts of
Author: mprobst
Date: Fri Aug 3 02:34:41 2018
New Revision: 338837
URL: http://llvm.org/viewvc/llvm-project?rev=338837&view=rev
Log:
clang-format: [JS] don't break comments before any '{'
Summary:
Previously, clang-format would avoid breaking before the first `{`
found, but then happily break be
Sorry about that, yes, that was me. Thanks for reverting!
Tim Northover schrieb am Fr., 3. Aug. 2018 um
14:19 Uhr:
> On Fri, 3 Aug 2018 at 11:47, Tim Northover
> wrote:
> > On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits
> > wrote:
> > > clang-format
Author: mprobst
Date: Fri Aug 3 06:58:33 2018
New Revision: 338890
URL: http://llvm.org/viewvc/llvm-project?rev=338890&view=rev
Log:
clang-format: [JS] don't break comments before any '{'
Summary:
Previously, clang-format would avoid breaking before the first `{`
found, but then happily break be
Author: mprobst
Date: Mon Feb 19 04:32:13 2018
New Revision: 325489
URL: http://llvm.org/viewvc/llvm-project?rev=325489&view=rev
Log:
clang-format: [JS] fix `of` detection.
Summary:
`of` is only a keyword when after an identifier, but not when after
an actual keyword.
Before:
return of (a, b
Author: mprobst
Date: Mon May 29 02:50:52 2017
New Revision: 304135
URL: http://llvm.org/viewvc/llvm-project?rev=304135&view=rev
Log:
clang-format: [JS] fix indenting bound functions.
Summary:
The previous fix to force build style wrapping if the previous token is a
closing parenthesis broke a p
Author: mprobst
Date: Mon May 29 03:41:11 2017
New Revision: 304141
URL: http://llvm.org/viewvc/llvm-project?rev=304141&view=rev
Log:
clang-format: [JS] do not clean up duplicated commas.
Summary:
In JavaScript, duplicated commas have semantic meaning.
x = [a,,b];
The statement above creates
Author: mprobst
Date: Wed May 31 04:29:40 2017
New Revision: 304290
URL: http://llvm.org/viewvc/llvm-project?rev=304290&view=rev
Log:
clang-format: [JS] improve calculateBraceType heuristic
Summary:
calculateBraceTypes decides for braced init for empty brace pairs ({}).
In context of a function
Author: mprobst
Date: Tue Jun 6 07:38:29 2017
New Revision: 304791
URL: http://llvm.org/viewvc/llvm-project?rev=304791&view=rev
Log:
clang-format: [JS] Correctly Indent Nested JavaScript Literals.
Nested literals are sometimes only indented by 2 spaces, instead of
respecting the IndentWidth opti
Author: mprobst
Date: Wed Jun 7 07:53:22 2017
New Revision: 304904
URL: http://llvm.org/viewvc/llvm-project?rev=304904&view=rev
Log:
clang-format: [JS] recognize exported type definitions.
Summary: Support "export type T = {...};", in addition to just "type T =
{...};".
Reviewers: klimek
Diff
Author: mprobst
Date: Mon Jun 11 09:20:13 2018
New Revision: 334415
URL: http://llvm.org/viewvc/llvm-project?rev=334415&view=rev
Log:
clang-format: [JS] strict prop init annotation.
Summary:
TypeScript uses the `!` token for strict property initialization
assertions, as in:
class X {
s
Author: mprobst
Date: Tue Mar 19 04:15:52 2019
New Revision: 356447
URL: http://llvm.org/viewvc/llvm-project?rev=356447&view=rev
Log:
[clang-format] [JS] Don't break between template string and tag
Before:
const x = veryLongIdentifier
`hello`;
After:
const x =
veryLongIden
Author: mprobst
Date: Tue Mar 19 05:28:41 2019
New Revision: 356449
URL: http://llvm.org/viewvc/llvm-project?rev=356449&view=rev
Log:
[clang-format] [JS] handle private members.
Addresses PR40999 https://bugs.llvm.org/show_bug.cgi?id=40999
Private fields and methods in JavaScript would get incor
Author: mprobst
Date: Wed Sep 26 01:28:33 2018
New Revision: 343080
URL: http://llvm.org/viewvc/llvm-project?rev=343080&view=rev
Log:
clang-format: [JS] space after parameter naming.
Summary:
Previously:
foo(/*bar=*/baz);
Now:
foo(/*bar=*/ baz);
The run-in parameter naming comment is no
Author: mprobst
Date: Wed Sep 26 23:48:13 2018
New Revision: 343179
URL: http://llvm.org/viewvc/llvm-project?rev=343179&view=rev
Log:
clang-format: [JS] conditional types.
Summary:
This change adds some rudimentary support for conditional types.
Specifically it avoids breaking before `extends` an
Author: mprobst
Date: Tue Aug 29 01:30:07 2017
New Revision: 311988
URL: http://llvm.org/viewvc/llvm-project?rev=311988&view=rev
Log:
clang-format: [JS] simplify template string wrapping.
Summary:
Previously, clang-format would try to wrap template string substitutions
by indenting relative to th
Author: mprobst
Date: Mon Sep 11 08:22:52 2017
New Revision: 312918
URL: http://llvm.org/viewvc/llvm-project?rev=312918&view=rev
Log:
clang-format: [JS] wrap and indent `goog.setTestOnly` calls.
Summary:
While `goog.setTestOnly` usually appears in the imports section of a file, it is
not actually
Author: mprobst
Date: Mon Jan 7 05:12:50 2019
New Revision: 350516
URL: http://llvm.org/viewvc/llvm-project?rev=350516&view=rev
Log:
clang-format: [JS] support goog.requireType.
Summary:
It's a new primitive for importing symbols, and should be treated like
the (previously handled) `goog.require
Author: Martin Probst
Date: 2020-04-03T14:23:56+02:00
New Revision: 146d685cd657399a4698015f16cc5910cc828728
URL:
https://github.com/llvm/llvm-project/commit/146d685cd657399a4698015f16cc5910cc828728
DIFF:
https://github.com/llvm/llvm-project/commit/146d685cd657399a4698015f16cc5910cc828728.diff
Author: Martin Probst
Date: 2020-04-06T17:13:04+02:00
New Revision: 92201505cdecd8ba5795f5e33821c49dc57f0816
URL:
https://github.com/llvm/llvm-project/commit/92201505cdecd8ba5795f5e33821c49dc57f0816
DIFF:
https://github.com/llvm/llvm-project/commit/92201505cdecd8ba5795f5e33821c49dc57f0816.diff
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Previously, clang-format would always insert an additional line break after the
import block if the main body started with a comment, due to loosing track o
Author: mprobst
Date: Sun Sep 18 12:21:52 2016
New Revision: 281856
URL: http://llvm.org/viewvc/llvm-project?rev=281856&view=rev
Log:
clang-format: [JS] ASI insertion after boolean literals.
Summary:
Before when a semicolon was missing after a boolean literal:
a = true
return 1;
clang-fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281856: clang-format: [JS] ASI insertion after boolean
literals. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24574?vs=71385&id=71755#toc
Repository:
rL LLVM
https://rev
Author: mprobst
Date: Sun Sep 18 12:33:51 2016
New Revision: 281857
URL: http://llvm.org/viewvc/llvm-project?rev=281857&view=rev
Log:
clang-format: [JS] Do not wrap taze annotation comments.
Summary:
`// taze: ... from ...` comments are used help tools where a
specific global symbol comes from.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281857: clang-format: [JS] Do not wrap taze annotation
comments. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24477?vs=71189&id=71756#toc
Repository:
rL LLVM
https://rev
Author: mprobst
Date: Mon Sep 19 02:02:34 2016
New Revision: 281888
URL: http://llvm.org/viewvc/llvm-project?rev=281888&view=rev
Log:
clang-format: [JS] Fix line breaks before comments when sorting imports.
Summary:
Previously, clang-format would always insert an additional line break after the
i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281888: clang-format: [JS] Fix line breaks before comments
when sorting imports. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24708?vs=71754&id=71772#toc
Repository:
rL L
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
@returns is incorrect code, the standard is @return. However wrapping it can
still confuse users.
https://reviews.llvm.org/D24767
Files:
lib/Format/For
Author: mprobst
Date: Wed Sep 21 01:56:38 2016
New Revision: 282056
URL: http://llvm.org/viewvc/llvm-project?rev=282056&view=rev
Log:
clang-format: [JS] do not wrapp @returns tags.
Summary: @returns is incorrect code, the standard is @return. However wrapping
it can still confuse users.
Reviewe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282056: clang-format: [JS] do not wrapp @returns tags.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24767?vs=71938&id=72010#toc
Repository:
rL LLVM
https://reviews.llvm.
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Before:
class X {
delete () {
...
}
}
After:
class X {
delete() {
...
}
}
https://reviews.llvm.org
mprobst updated this revision to Diff 72061.
mprobst added a comment.
- move up to support let in methods.
https://reviews.llvm.org/D24804
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282138: clang-format: [JS] reserved words in method names.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24804?vs=72061&id=72140#toc
Repository:
rL LLVM
https://reviews.l
Author: mprobst
Date: Thu Sep 22 02:18:00 2016
New Revision: 282138
URL: http://llvm.org/viewvc/llvm-project?rev=282138&view=rev
Log:
clang-format: [JS] reserved words in method names.
Summary:
Before:
class X {
delete () {
...
}
}
After:
class X {
delete()
mprobst added a comment.
Looks good to me, but Daniel is a better owner for this code.
https://reviews.llvm.org/D25439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Previously, automatic semicolon insertion would add an unwrapped line
when a template string contained a line break.
var x = `foo${
bar}`;
Would b
Author: mprobst
Date: Fri Nov 24 02:48:25 2017
New Revision: 318942
URL: http://llvm.org/viewvc/llvm-project?rev=318942&view=rev
Log:
clang-format: [JS] handle destructuring `of`.
Summary:
Previously, clang-format would drop a space character between `of` and
then following (non-identifier) token
Author: mprobst
Date: Fri Nov 24 09:04:40 2017
New Revision: 318957
URL: http://llvm.org/viewvc/llvm-project?rev=318957&view=rev
Log:
clang-format: [JS] space between ! assert and in.
Summary:
Before:
x = y!in z;
After:
x = y! in z;
Reviewers: djasper
Subscribers: klimek
Differential R
Author: mprobst
Date: Fri Nov 24 09:05:35 2017
New Revision: 318958
URL: http://llvm.org/viewvc/llvm-project?rev=318958&view=rev
Log:
clang-format: [JS] do not wrap before yield.
Summary: The same rules apply as for `return`.
Reviewers: djasper
Subscribers: klimek
Differential Revision: https:
Author: mprobst
Date: Fri Nov 24 09:05:56 2017
New Revision: 318959
URL: http://llvm.org/viewvc/llvm-project?rev=318959&view=rev
Log:
clang-format: [JS] do not break in ArrayType[].
Summary:
Wrapping between the type name and the array type indicator creates
invalid syntax in TypeScript.
Before:
Author: mprobst
Date: Sat Nov 25 01:19:42 2017
New Revision: 318973
URL: http://llvm.org/viewvc/llvm-project?rev=318973&view=rev
Log:
clang-format: [JS] disable ASI on decorators.
Summary:
Automatic Semicolon Insertion in clang-format tries to guess if a line
wrap should insert an implicit semico
Author: mprobst
Date: Sat Nov 25 01:24:33 2017
New Revision: 318974
URL: http://llvm.org/viewvc/llvm-project?rev=318974&view=rev
Log:
clang-format: [JS] handle `for` as object label.
Summary: Previously, clang-format would fail formatting `{for: 1}`.
Reviewers: djasper
Subscribers: klimek
Diff
Author: mprobst
Date: Sat Nov 25 01:33:47 2017
New Revision: 318975
URL: http://llvm.org/viewvc/llvm-project?rev=318975&view=rev
Log:
clang-format: [JS] handle semis in generic types.
Summary:
TypeScript generic type arguments can contain object (literal) types,
which in turn can contain semicolo
Author: mprobst
Date: Sat Nov 25 01:35:33 2017
New Revision: 318976
URL: http://llvm.org/viewvc/llvm-project?rev=318976&view=rev
Log:
clang-format: [JS] do not collapse short classes.
Summary:
clang-format does not collapse short records, interfaces, unions, etc.,
but fails to do so if the record
Author: mprobst
Date: Thu Nov 30 02:25:17 2017
New Revision: 319415
URL: http://llvm.org/viewvc/llvm-project?rev=319415&view=rev
Log:
clang-format: [JS] do not wrap after async/await.
Summary:
Otherwise automatic semicolon insertion can trigger, i.e. wrapping
produces invalid syntax.
Reviewers:
Author: mprobst
Date: Mon Aug 26 08:37:05 2019
New Revision: 369916
URL: http://llvm.org/viewvc/llvm-project?rev=369916&view=rev
Log:
clang-format: [JS] handle `as const`.
Summary:
TypeScript 3.4 supports casting into a const type using `as const`:
const x = {x: 1} as const;
Previously, cla
Author: mprobst
Date: Tue Aug 1 08:46:10 2017
New Revision: 309695
URL: http://llvm.org/viewvc/llvm-project?rev=309695&view=rev
Log:
clang-format: [JS] handle object types in extends positions.
Summary:
clang-format would previously drop the whitespace after `extends` in code such
as:
clas
Author: mprobst
Date: Tue Aug 1 08:54:43 2017
New Revision: 309697
URL: http://llvm.org/viewvc/llvm-project?rev=309697&view=rev
Log:
clang-format: [JS] support default imports.
Summary: Formerly, `import {default as X} from y;` would not be recognized as
an import.
Reviewers: djasper
Subscrib
Author: mprobst
Date: Tue Aug 1 10:12:15 2017
New Revision: 309703
URL: http://llvm.org/viewvc/llvm-project?rev=309703&view=rev
Log:
clang-format: [JS] consistenly format enums.
Summary: Previously, const enums would get formatted differently because the
modifier was not recognized.
Reviewers:
Author: mprobst
Date: Tue Aug 1 10:19:32 2017
New Revision: 309707
URL: http://llvm.org/viewvc/llvm-project?rev=309707&view=rev
Log:
clang-format: [JS] handle union types in arrow functions.
Summary: clang-format would previously fail to detect that an arrow functions
parameter block is not an
Author: mprobst
Date: Tue Aug 1 10:22:15 2017
New Revision: 309710
URL: http://llvm.org/viewvc/llvm-project?rev=309710&view=rev
Log:
clang-format: [JS] whitespace between keywords and parenthesized expressions.
Summary: `throw (...)` should have a whitespace following it, as do await and
void.
Author: mprobst
Date: Tue Aug 1 10:35:57 2017
New Revision: 309712
URL: http://llvm.org/viewvc/llvm-project?rev=309712&view=rev
Log:
clang-format: [JS] prefer wrapping chains over empty literals.
Summary:
E.g. don't wrap like this:
(foo.bar.baz).and.bam(Blah.of({
}))
But rather:
(
Author: mprobst
Date: Tue Aug 1 10:42:16 2017
New Revision: 309713
URL: http://llvm.org/viewvc/llvm-project?rev=309713&view=rev
Log:
clang-format: [JS] no whitespace between typeof operator and l_paren.
Modified:
cfe/trunk/lib/Format/FormatToken.h
cfe/trunk/lib/Format/TokenAnnotator.cpp
Author: mprobst
Date: Fri Aug 4 10:07:15 2017
New Revision: 310070
URL: http://llvm.org/viewvc/llvm-project?rev=310070&view=rev
Log:
clang-format: [JS] support fields with case/switch/default labels.
Summary:
`case:` and `default:` would normally parse as labels for a `switch` block.
However in
Author: mprobst
Date: Tue Aug 8 07:52:42 2017
New Revision: 310365
URL: http://llvm.org/viewvc/llvm-project?rev=310365&view=rev
Log:
clang-format: [JS] handle single lines comments ending in `\\`.
Summary:
Previously, clang-format would consider the following code line to be part of
the comment
Author: mprobst
Date: Tue Aug 8 08:00:58 2017
New Revision: 310367
URL: http://llvm.org/viewvc/llvm-project?rev=310367&view=rev
Log:
clang-format: [JS] fix union type spacing in object & array types.
Summary:
Previously, clang-format would insert whitespace in union types nested in object
and ar
Author: mprobst
Date: Wed Aug 9 08:19:16 2017
New Revision: 310482
URL: http://llvm.org/viewvc/llvm-project?rev=310482&view=rev
Log:
clang-format: [JS] detect ASI after closing parens.
Summary: A closing parenthesis followed by a declaration or statement should
always terminate the current stat
Author: mprobst
Date: Mon Aug 14 09:08:16 2017
New Revision: 310851
URL: http://llvm.org/viewvc/llvm-project?rev=310851&view=rev
Log:
clang-format: [JS] do not insert whitespace in call positions.
Summary:
In JavaScript, may keywords can be used in method names and thus call sites:
foo.delet
Author: mprobst
Date: Mon Aug 14 09:09:08 2017
New Revision: 310852
URL: http://llvm.org/viewvc/llvm-project?rev=310852&view=rev
Log:
clang-format: [JS] wrap optional properties in type aliases.
Summary:
clang-format wraps object literal keys in an object literal if they are
marked as `TT_Selecto
Author: Martin Probst
Date: 2020-01-16T11:23:11+01:00
New Revision: 736a3802124b57490fa1e67538415a2a77fa731c
URL:
https://github.com/llvm/llvm-project/commit/736a3802124b57490fa1e67538415a2a77fa731c
DIFF:
https://github.com/llvm/llvm-project/commit/736a3802124b57490fa1e67538415a2a77fa731c.diff
Author: Martin Probst
Date: 2020-11-10T09:26:46+01:00
New Revision: 16212b8b3e4fd5fbb73aecabf6f0b6fec91913d2
URL:
https://github.com/llvm/llvm-project/commit/16212b8b3e4fd5fbb73aecabf6f0b6fec91913d2
DIFF:
https://github.com/llvm/llvm-project/commit/16212b8b3e4fd5fbb73aecabf6f0b6fec91913d2.diff
Author: Martin Probst
Date: 2021-06-11T12:02:33+02:00
New Revision: 63042d46bb0c2481a8b7aa1c324405c2720b3603
URL:
https://github.com/llvm/llvm-project/commit/63042d46bb0c2481a8b7aa1c324405c2720b3603
DIFF:
https://github.com/llvm/llvm-project/commit/63042d46bb0c2481a8b7aa1c324405c2720b3603.diff
Author: Martin Probst
Date: 2019-11-11T16:35:35+01:00
New Revision: a7638d384983e8e3eb44a2d8c757238efc7096dc
URL:
https://github.com/llvm/llvm-project/commit/a7638d384983e8e3eb44a2d8c757238efc7096dc
DIFF:
https://github.com/llvm/llvm-project/commit/a7638d384983e8e3eb44a2d8c757238efc7096dc.diff
Author: Martin Probst
Date: 2019-11-11T16:36:00+01:00
New Revision: 6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b
URL:
https://github.com/llvm/llvm-project/commit/6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b
DIFF:
https://github.com/llvm/llvm-project/commit/6bcd8d4a18fc0604a2297a626c1fc808cbfb7b9b.diff
Author: Martin Probst
Date: 2020-02-03T08:51:52+01:00
New Revision: dc04c54fc1f6660770040f9a17ea600ce95e4b60
URL:
https://github.com/llvm/llvm-project/commit/dc04c54fc1f6660770040f9a17ea600ce95e4b60
DIFF:
https://github.com/llvm/llvm-project/commit/dc04c54fc1f6660770040f9a17ea600ce95e4b60.diff
Author: Martin Probst
Date: 2020-01-17T10:10:16+01:00
New Revision: 0734fb21ed5e267dda1a91e5f8b82f653ac3562d
URL:
https://github.com/llvm/llvm-project/commit/0734fb21ed5e267dda1a91e5f8b82f653ac3562d
DIFF:
https://github.com/llvm/llvm-project/commit/0734fb21ed5e267dda1a91e5f8b82f653ac3562d.diff
Author: Martin Probst
Date: 2020-01-17T13:39:05+01:00
New Revision: 9835cf159014f40e8ea655d0bb3a341ef7ec34f7
URL:
https://github.com/llvm/llvm-project/commit/9835cf159014f40e8ea655d0bb3a341ef7ec34f7
DIFF:
https://github.com/llvm/llvm-project/commit/9835cf159014f40e8ea655d0bb3a341ef7ec34f7.diff
Author: Martin Probst
Date: 2020-01-20T17:07:14+01:00
New Revision: 4c9d6914453d970b7b8202b7efd7524b2f0a72ac
URL:
https://github.com/llvm/llvm-project/commit/4c9d6914453d970b7b8202b7efd7524b2f0a72ac
DIFF:
https://github.com/llvm/llvm-project/commit/4c9d6914453d970b7b8202b7efd7524b2f0a72ac.diff
Author: Martin Probst
Date: 2020-01-27T16:27:25+01:00
New Revision: 02656f29abda4eedd22e3b2b30bf2f422983514e
URL:
https://github.com/llvm/llvm-project/commit/02656f29abda4eedd22e3b2b30bf2f422983514e
DIFF:
https://github.com/llvm/llvm-project/commit/02656f29abda4eedd22e3b2b30bf2f422983514e.diff
Author: Martin Probst
Date: 2020-01-29T13:23:54+01:00
New Revision: a324fcf1ae62d065b957e66a9d2f5c18b6259d27
URL:
https://github.com/llvm/llvm-project/commit/a324fcf1ae62d065b957e66a9d2f5c18b6259d27
DIFF:
https://github.com/llvm/llvm-project/commit/a324fcf1ae62d065b957e66a9d2f5c18b6259d27.diff
Author: mprobst
Date: Fri Nov 17 10:06:33 2017
New Revision: 318537
URL: http://llvm.org/viewvc/llvm-project?rev=318537&view=rev
Log:
clang-format: remove trailing lines in lamdas and arrow functions.
Summary:
clang-format already removes empty lines at the beginning & end of
blocks:
int x()
Author: mprobst
Date: Wed Jan 4 07:36:43 2017
New Revision: 290959
URL: http://llvm.org/viewvc/llvm-project?rev=290959&view=rev
Log:
clang-format: [JS] avoid indent after ambient function declarations.
Summary:
Before:
declare function foo();
let x = 1;
After:
declare function foo();
Author: mprobst
Date: Mon Jan 9 02:56:36 2017
New Revision: 291428
URL: http://llvm.org/viewvc/llvm-project?rev=291428&view=rev
Log:
clang-format: [JS] ASI after imports
Summary:
Automatic semicolon insertion should break import and export statements:
Before, this would format on one line:
/
Author: mprobst
Date: Mon Jan 9 03:00:58 2017
New Revision: 291429
URL: http://llvm.org/viewvc/llvm-project?rev=291429&view=rev
Log:
clang-format: [JS] fix broken test.
Modified:
cfe/trunk/unittests/Format/FormatTestJS.cpp
Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp
URL:
http://l
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
E.g. `{a: 1} as b`.
https://reviews.llvm.org/D23714
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Form
mprobst updated this revision to Diff 68687.
mprobst added a comment.
- Use a stack to parse nested template strings.
- move docs
- Fold GreaterStashed, LessStashed into TOKEN_STASHED lexer state.
https://reviews.llvm.org/D22431
Files:
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenL
mprobst marked 9 inline comments as done.
mprobst added a comment.
https://reviews.llvm.org/D22431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mprobst
Date: Fri Aug 19 09:35:01 2016
New Revision: 279250
URL: http://llvm.org/viewvc/llvm-project?rev=279250&view=rev
Log:
clang-format: [JS] handle object literals with casts.
Summary: E.g. `{a: 1} as b`.
Reviewers: djasper
Subscribers: cfe-commits, klimek
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279250: clang-format: [JS] handle object literals with
casts. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D23714?vs=68686&id=68688#toc
Repository:
rL LLVM
https://review
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added subscribers: cfe-commits, klimek.
https://reviews.llvm.org/D23761
Files:
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: un
mprobst updated this revision to Diff 68844.
mprobst added a comment.
- drop accidentally included template string patch from this diff.
https://reviews.llvm.org/D23761
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
=
mprobst marked an inline comment as done.
Comment at: lib/Format/FormatTokenLexer.cpp:245
@@ -241,1 +244,3 @@
++Offset; // Skip the escaped character.
+if (Offset + 1 < Lex->getBuffer().end() && *Offset == '$' &&
+*(Offset + 1) == '{') {
ygao wr
mprobst updated this revision to Diff 68851.
mprobst added a comment.
- Test escaped dollar sign.
https://reviews.llvm.org/D22431
Files:
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format
mprobst added inline comments.
Comment at: lib/Format/FormatTokenLexer.cpp:259
@@ -241,1 +258,3 @@
++Offset; // Skip the escaped character.
+if (Offset + 1 < Lex->getBuffer().end() && Offset[0] == '$' &&
+Offset[1] == '{') {
Question by @ygao in
mprobst updated this revision to Diff 68853.
mprobst added a comment.
- Fix escaping issue.
https://reviews.llvm.org/D22431
Files:
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/Forma
Author: mprobst
Date: Mon Aug 22 09:23:30 2016
New Revision: 279436
URL: http://llvm.org/viewvc/llvm-project?rev=279436&view=rev
Log:
clang-format: [JS] supports casts to types starting with punctuation ("{[(").
Before:
x as{x: number}
After:
x as {x: number}
Reviewers: djasper
Subsc
This revision was automatically updated to reflect the committed changes.
mprobst marked an inline comment as done.
Closed by commit rL279436: clang-format: [JS] supports casts to types starting
with punctuation ("{[("). (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D
mprobst added a comment.
No worries, thanks for the review.
https://reviews.llvm.org/D22431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mprobst
Date: Thu Aug 25 05:13:21 2016
New Revision: 279727
URL: http://llvm.org/viewvc/llvm-project?rev=279727&view=rev
Log:
clang-format: [JS] nested and tagged template strings.
JavaScript template strings can be nested arbitrarily:
foo = `text ${es.map(e => { return `<${e}>`; })}
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279727: clang-format: [JS] nested and tagged template
strings. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D22431?vs=68853&id=69219#toc
Repository:
rL LLVM
https://revie
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
User feedback is that they expect *all* imports to be sorted if any import was
affected by a change, not just imports up to the first non-affected line, as
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Default imports appear outside of named bindings in curly braces:
import A from 'a';
import A, {symbol} from 'a';
https://reviews.llvm.org/D23973
Fil
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
When formatting source code that needs both requoting and reindentation,
merge the replacements to avoid erroring out for conflicting replacements.
https:/
mprobst added a comment.
Friendly ping.
https://reviews.llvm.org/D23973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst added a comment.
Friendly ping.
https://reviews.llvm.org/D23972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mprobst
Date: Fri Sep 2 09:01:17 2016
New Revision: 280485
URL: http://llvm.org/viewvc/llvm-project?rev=280485&view=rev
Log:
clang-format: [JS] Sort all JavaScript imports if any changed.
Summary:
User feedback is that they expect *all* imports to be sorted if any import was
affected by
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280485: clang-format: [JS] Sort all JavaScript imports if
any changed. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D23972?vs=69511&id=70158#toc
Repository:
rL LLVM
https
mprobst added a comment.
In https://reviews.llvm.org/D23973#532801, @djasper wrote:
> It would be helpful to have a before/after to review these patches.
I assumed the test case was clear enough. Before, we couldn't parse default
bindings at all, after, we do, and thus sort the imports in the
Author: mprobst
Date: Fri Sep 2 09:06:32 2016
New Revision: 280486
URL: http://llvm.org/viewvc/llvm-project?rev=280486&view=rev
Log:
clang-format: [JS] handle default bindings in imports.
Summary:
Default imports appear outside of named bindings in curly braces:
import A from 'a';
import A,
1 - 100 of 350 matches
Mail list logo
