Re: [PATCH] D11908: Clang support for -fthinlto.

2015-10-14 Thread Mehdi AMINI via cfe-commits
joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

2015-09-10 Thread Mehdi Amini via cfe-commits
> On Sep 9, 2015, at 7:06 PM, David Blaikie <dblai...@gmail.com> wrote: > > > > On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Author: mehdi_amini > Date: Wed S

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

2015-09-10 Thread Mehdi Amini via cfe-commits
blai...@gmail.com >> <mailto:dblai...@gmail.com>> wrote: >> >> >> >> On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits >> <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: mehdi_amini >>

r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Sep 9 20:46:39 2015 New Revision: 247233 URL: http://llvm.org/viewvc/llvm-project?rev=247233=rev Log: EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC) This reapply a variant commit r247179 after post-commit review from D.Blaikie. Hopefully I

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
Hi David, Thanks for the review. > On Sep 9, 2015, at 1:14 PM, David Blaikie <dblai...@gmail.com> wrote: > > > > On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Au

r247183 - Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)"

2015-09-09 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Sep 9 15:35:37 2015 New Revision: 247183 URL: http://llvm.org/viewvc/llvm-project?rev=247183=rev Log: Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)" This reverts commit r247179. From: Mehdi Amini

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
>> On Sep 9, 2015, at 1:14 PM, David Blaikie <dblai...@gmail.com >> <mailto:dblai...@gmail.com>> wrote: >> >> >> >> On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits >> <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm

r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

2015-09-09 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Wed Sep 9 15:08:51 2015 New Revision: 247179 URL: http://llvm.org/viewvc/llvm-project?rev=247179=rev Log: EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC) From: Mehdi Amini Modified:

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-07 Thread Mehdi AMINI via cfe-commits
joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D15025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-04 Thread Mehdi Amini via cfe-commits
> On Dec 4, 2015, at 9:14 AM, Teresa Johnson wrote: > > tejohnson added inline comments. > > > Comment at: lib/CodeGen/CodeGenAction.cpp:822 > @@ +821,3 @@ > + TheModule = std::move(Combined); > +} > + > > joker.eph wrote: >>

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-04 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + tejohnson wrote: > joker.eph wrote: > > tejohnson wrote: > > > joker.eph wrote: > > > > Could we refactor this in a helper

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-04 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + tejohnson wrote: > joker.eph wrote: > > Could we refactor this in a helper in llvm? > I can create a new Linker interface

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-03 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. Looks good to me but I'd like another opinion on the name of "-fthinlto-backend", Duncan? Comment at: include/clang/Driver/Types.h:68 @@ -66,1 +67,3 @@ + bool isLLVMIR(ID Id); + /// isCuda - Is this a CUDA input. I guess you

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-03 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. Talked with Duncan, we're not convinced about //-fthinlto-backend=...// for the option name: the word //backend// does not seems right here. What about //-fthinlto-index=...//? Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ +

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-12-01 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:290 @@ +289,3 @@ + // setup for LTO compiles invoked via the gold plugin and the llvm-lto tool. + if (!CodeGenOpts.ThinLTOIndexFile.empty() && !CodeGenOpts.DisableLLVMOpts) { +legacy::PassManager *MPM

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

2016-01-06 Thread Mehdi AMINI via cfe-commits
joker.eph added a subscriber: joker.eph. Comment at: include/clang/Basic/SourceManager.h:660 @@ -659,1 +659,3 @@ + bool MainFileIsHeader = false; + Document? Comment at: include/clang/Basic/SourceManager.h:764 @@ -761,1 +763,3 @@ + void

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-19 Thread Mehdi Amini via cfe-commits
Sent from my iPhone > On Dec 18, 2015, at 11:11 PM, James Molloy wrote: > > Hi Mehdi, > >> On 18 Dec 2015, at 23:17, Mehdi Amini wrote: >> >> The alternative to the command line flag is to encode the optimization level >> in the bitcode itself.

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-19 Thread Mehdi Amini via cfe-commits
ue that it could be used to change the pipeline theoretically. It is not a problem at the time since (AFAIK) the CodeGen pipeline is intrinsically per function, but this may change with the new instruction selector. — Mehdi > > James > On Sat, 19 Dec 2015 at 17:17, Mehdi Amin

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Mehdi Amini via cfe-commits
Sent from my iPhone > On Dec 18, 2015, at 4:06 AM, Rafael Ávila de Espíndola > wrote: > > rafael added a subscriber: rafael. > rafael added a comment. > > This introduces a meaning to -ON during the link. That normally show up by > people passing CFLAGS when

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

2015-11-26 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:308 @@ +307,3 @@ +return; + } + It does not seem to be nicely integrated within the context of this function. What about all the options set just a few line below? It is not clear if

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-18 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. Isn't the patch reversed or do I miss something? Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

2015-11-18 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. LGTM, please wait for another pair of eye. Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

2016-01-11 Thread Mehdi Amini via cfe-commits
I’d fear the same thing. On our platform you have to use explicitly -Wl,-mllvm (or -Xlinker -plugin-opt). — Mehdi > On Jan 11, 2016, at 4:11 PM, Rafael Espíndola > wrote: > > Maybe. I would like a second opinion on this one. The potential issue > I see is that

Re: r271883 - [clang-format] make header guard identification stricter (with Lexer).

2016-06-10 Thread Mehdi Amini via cfe-commits
Hi Eric, > On Jun 6, 2016, at 4:00 AM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > Date: Mon Jun 6 06:00:13 2016 > New Revision: 271883 > > URL: http://llvm.org/viewvc/llvm-project?rev=271883=rev > Log: > [clang-format] make header guard identification

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

2016-06-05 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. I'm not sure it is consistent with how we handle -flto, for instance -c means usually to output an object file, but adding -flto indicates to dump bitcode instead. http://reviews.llvm.org/D21006 ___ cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

2016-06-05 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. Duncan CC for opinion. http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

2016-06-05 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. What makes me not comfortable with this change is that after that `-c` would not involves codegen but `-S` would. Indeed I am using sometimes `-flto -S` and I expect IR, that's what is the most logical to me considering what -c does.

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

2016-06-05 Thread Mehdi Amini via cfe-commits
But what pipeline do we setup? For instance with ThinLTO we reduced the amount of passes ran during the compile phase with the expectation that more will run during the link, this would get fuzzy here... > On Jun 5, 2016, at 6:49 PM, Davide Italiano wrote: > > davide

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

2016-06-05 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. But what pipeline do we setup? For instance with ThinLTO we reduced the amount of passes ran during the compile phase with the expectation that more will run during the link, this would get fuzzy here... http://reviews.llvm.org/D21006

Re: [PATCH] D20423: [Clang][LLVMGold] Passing LLVM arguments to gold plugin

2016-05-31 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. In http://reviews.llvm.org/D20423#440539, @bunty2020 wrote: > Clang's help shows the following description: > **-mllvm Additional arguments to forward to LLVM's option > processing** > > If -mllvm sets some internal option for cc1 then its strange > for

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Mehdi Amini via cfe-commits
> On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: >> >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: >>> >>> One thing that I'd like to do (and this would help CFI as well)

[PATCH] D17272: Teach clang to use the ThinLTO pipeline

2016-02-15 Thread Mehdi AMINI via cfe-commits
joker.eph created this revision. joker.eph added a reviewer: tejohnson. joker.eph added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. Use the new pipeline implemented in D17115 http://reviews.llvm.org/D17272 Files: lib/CodeGen/BackendUtil.cpp Index:

r261045 - Teach clang to use the ThinLTO pipeline

2016-02-16 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Tue Feb 16 18:42:20 2016 New Revision: 261045 URL: http://llvm.org/viewvc/llvm-project?rev=261045=rev Log: Teach clang to use the ThinLTO pipeline Summary: Use the new pipeline implemented in D17115 Reviewers: tejohnson Subscribers: joker.eph, cfe-commits

Re: [PATCH] D17272: Teach clang to use the ThinLTO pipeline

2016-02-17 Thread Mehdi AMINI via cfe-commits
joker.eph closed this revision. joker.eph added a comment. r261045 http://reviews.llvm.org/D17272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17130: Debloat some headers

2016-02-13 Thread Mehdi AMINI via cfe-commits
joker.eph added a subscriber: joker.eph. joker.eph added a comment. What the build time of clang before and after? (Your goal is to improve build time right?) http://reviews.llvm.org/D17130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

2016-03-10 Thread Mehdi AMINI via cfe-commits
joker.eph updated this revision to Diff 50282. joker.eph added a comment. Add a FIXME to change the compile time switch to a runtime command line flag http://reviews.llvm.org/D18024 Files: lib/CodeGen/CGBuilder.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

2016-03-10 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:660-663 @@ -660,1 +659,6 @@ + OwnsVMContext(!_VMContext) { +#ifdef NDEBUG + _VMContext.setDiscardValueNames(true); +#endif +} chandlerc wrote: > I'm surprised this isn't a

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

2016-03-18 Thread Mehdi AMINI via cfe-commits
joker.eph added a comment. LGTM, but I'm not a clang expert, so if Richard or someone else could double-check? Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + Isn't this correct by the loop which starts with `DC =

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

2016-03-18 Thread Mehdi AMINI via cfe-commits
joker.eph closed this revision. joker.eph added a comment. r263257 http://reviews.llvm.org/D18024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-18 Thread Mehdi AMINI via cfe-commits
joker.eph closed this revision. joker.eph added a comment. r263394 http://reviews.llvm.org/D18127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263394 - Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-13 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Sun Mar 13 16:05:23 2016 New Revision: 263394 URL: http://llvm.org/viewvc/llvm-project?rev=263394=rev Log: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option Summary: This flag is enabled by default in the driver when NDEBUG is set.

[PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Mehdi AMINI via cfe-commits
joker.eph created this revision. joker.eph added reviewers: echristo, chandlerc. joker.eph added a subscriber: cfe-commits. This flag is enabled by default in the driver when NDEBUG is set. It is forwarded on the LLVMContext to discard all value names (but GlobalValue) for performance purpose.

[PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address; Undefined" on OSX

2016-03-09 Thread Mehdi AMINI via cfe-commits
joker.eph created this revision. joker.eph added a reviewer: beanz. joker.eph added a subscriber: cfe-commits. joker.eph set the repository for this revision to rL LLVM. It seems some cases were missing to the configuration. Repository: rL LLVM http://reviews.llvm.org/D18014 Files:

[PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

2016-03-09 Thread Mehdi AMINI via cfe-commits
joker.eph created this revision. joker.eph added a reviewer: chandlerc. joker.eph added a subscriber: cfe-commits. Following r263086, we are now relying on a flag on the Context to discard Value names in release builds. http://reviews.llvm.org/D18024 Files: lib/CodeGen/CGBuilder.h

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Mehdi AMINI via cfe-commits
joker.eph updated this revision to Diff 50541. joker.eph added a comment. Use cc1 in the few tests that were relying on value names. Also add test/CodeGenCXX/discard-name-values.cpp to test the new cc1 flag. http://reviews.llvm.org/D18127 Files: include/clang/Driver/CC1Options.td

r263267 - Fix build: use -> with pointers and not .

2016-03-11 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Mar 11 11:32:58 2016 New Revision: 263267 URL: http://llvm.org/viewvc/llvm-project?rev=263267=rev Log: Fix build: use -> with pointers and not . Silly typo. From: Mehdi Amini Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified:

r263257 - Remove compile time PreserveName switch based on NDEBUG

2016-03-11 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Mar 11 11:15:44 2016 New Revision: 263257 URL: http://llvm.org/viewvc/llvm-project?rev=263257=rev Log: Remove compile time PreserveName switch based on NDEBUG Summary: Following r263086, we are now relying on a flag on the Context to discard Value names in release

r263273 - Fix clang crash: when CodeGenAction is initialized without a context, use the member and not the parameter

2016-03-11 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Mar 11 12:48:02 2016 New Revision: 263273 URL: http://llvm.org/viewvc/llvm-project?rev=263273=rev Log: Fix clang crash: when CodeGenAction is initialized without a context, use the member and not the parameter From: Mehdi Amini Modified:

Re: [PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address;Undefined" on OSX

2016-03-09 Thread Mehdi Amini via cfe-commits
Thanks, that's a lot cleaner indeed. I'll update. -- Mehdi > On Mar 9, 2016, at 4:02 PM, Chris Bieneman wrote: > > beanz added inline comments. > > > Comment at: lib/CMakeLists.txt:51 > @@ -50,2 +50,3 @@ > if (APPLE AND LLVM_USE_SANITIZER) > - if

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Mehdi AMINI via cfe-commits
joker.eph updated this revision to Diff 50546. joker.eph added a comment. s/clang -cc1/%clang_cc1/ http://reviews.llvm.org/D18127 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGBuilder.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp

Re: [PATCH] D18947: Emit the module hash by default with -flto=thin.

2016-04-12 Thread Mehdi AMINI via cfe-commits
joker.eph closed this revision. joker.eph added a comment. r265977 http://reviews.llvm.org/D18947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18947: Emit the module hash by default with -flto=thin.

2016-04-10 Thread Mehdi AMINI via cfe-commits
joker.eph created this revision. joker.eph added a reviewer: tejohnson. joker.eph added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. http://reviews.llvm.org/D18947 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp

r265977 - Emit the module hash by default with -flto=thin.

2016-04-11 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Mon Apr 11 13:45:20 2016 New Revision: 265977 URL: http://llvm.org/viewvc/llvm-project?rev=265977=rev Log: Emit the module hash by default with -flto=thin. Reviewers: tejohnson Subscribers: joker.eph, cfe-commits Differential Revision: http://reviews.llvm.org/D18947

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

2016-03-19 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + pcc wrote: > joker.eph wrote: > > joker.eph wrote: > > > Isn't this correct by the loop which starts with `DC = > > > InnermostExternalDC`? > >

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Mehdi Amini via cfe-commits
Hi, I think this broke clang-tidy somehow: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10881/steps/build%20stage%201/logs/stdio -- Mehdi > On Mar 25, 2016, at 9:29 AM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > Date: Fri

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Mehdi Amini via cfe-commits
Thanks! > On Mar 25, 2016, at 12:47 PM, Samuel Benzaquen wrote: > > Fixed in r264453. > Sorry for the inconvenience. > > _Sam > > On Fri, Mar 25, 2016 at 3:31 PM, Samuel Benzaquen > wrote: > Sorry, this is an unrelated

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Mehdi Amini via cfe-commits
The link I provided is testing r264430... -- Mehdi > On Mar 25, 2016, at 12:25 PM, Samuel Benzaquen wrote: > > I believe r264428 fixes this problem. > > On Fri, Mar 25, 2016 at 2:18 PM, Mehdi Amini > wrote: > Hi, > >

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

2016-03-19 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + joker.eph wrote: > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`? `s/correct/already covered/`

r266277 - Make sure the LLVMContext outlive the CompilerInstance

2016-04-13 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Thu Apr 14 00:37:41 2016 New Revision: 266277 URL: http://llvm.org/viewvc/llvm-project?rev=266277=rev Log: Make sure the LLVMContext outlive the CompilerInstance From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/BufferSourceTest.cpp

r266276 - Do not use llvm:getGlobalContext() in unittests

2016-04-13 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Thu Apr 14 00:34:32 2016 New Revision: 266276 URL: http://llvm.org/viewvc/llvm-project?rev=266276=rev Log: Do not use llvm:getGlobalContext() in unittests Currently trying to nuke this API from LLVM. From: Mehdi Amini Modified:

r267321 - Make thinlto clang test more robust against LLVM changes.

2016-04-23 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Sat Apr 23 22:44:55 2016 New Revision: 267321 URL: http://llvm.org/viewvc/llvm-project?rev=267321=rev Log: Make thinlto clang test more robust against LLVM changes. We should just test the effect of the clang level option here, i.e. that a summary is correctly emitted

Re: [PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

2016-05-18 Thread Mehdi AMINI via cfe-commits
joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r266276 - Do not use llvm:getGlobalContext() in unittests

2016-04-14 Thread Mehdi Amini via cfe-commits
> On Apr 14, 2016, at 4:38 AM, Rafael Espíndola <rafael.espind...@gmail.com> > wrote: > > On 14 April 2016 at 01:34, Mehdi Amini via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> Author: mehdi_amini >> Date: Thu Apr 14 00:34:32 2016 >> New

r266525 - Add missing headers (fix build after headers cleanup in LLVM)

2016-04-16 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Sat Apr 16 03:14:10 2016 New Revision: 266525 URL: http://llvm.org/viewvc/llvm-project?rev=266525=rev Log: Add missing headers (fix build after headers cleanup in LLVM) From: Mehdi Amini Modified: cfe/trunk/include/clang/Lex/LiteralSupport.h

r266594 - Add missing include for StringRef (NFC)

2016-04-18 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Mon Apr 18 04:08:59 2016 New Revision: 266594 URL: http://llvm.org/viewvc/llvm-project?rev=266594=rev Log: Add missing include for StringRef (NFC) From: Mehdi Amini Modified: cfe/trunk/lib/Format/Encoding.h Modified:

Re: [PATCH] D20100: [NFC] Header cleanup

2016-07-12 Thread Mehdi AMINI via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Looks like a nice cleanup. http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-07-14 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:740 @@ +739,3 @@ + ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex, +ImportList); + This should go away at some point right?

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-07-14 Thread Mehdi AMINI via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. (I didn't mark it as accepted because Teresa did, but in case you're waiting for me, don't) https://reviews.llvm.org/D21545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r276361 - Reverting r275115 which caused PR28634.

2016-07-21 Thread Mehdi Amini via cfe-commits
> On Jul 21, 2016, at 4:28 PM, Wolfgang Pieb via cfe-commits > wrote: > > Author: wolfgangp > Date: Thu Jul 21 18:28:18 2016 > New Revision: 276361 > > URL: http://llvm.org/viewvc/llvm-project?rev=276361=rev > Log: > Reverting r275115 which caused PR28634. > When

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Mehdi Amini via cfe-commits
CC hans. > On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith <dexonsm...@apple.com> > wrote: > > This seems like a good candidate to cherry-pick to 3.9. > >> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits >> <cfe-commits@lists.llvm.or

[libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Aug 12 19:02:33 2016 New Revision: 278579 URL: http://llvm.org/viewvc/llvm-project?rev=278579=rev Log: Fix ASAN failures in the demangler These were found fuzzing with ASAN. Modified: libcxxabi/trunk/src/cxa_demangle.cpp

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Mehdi Amini via cfe-commits
gt; wrote: > > Sweet! > Did you fix all of the known crashers? > > > > On Fri, Aug 12, 2016 at 5:02 PM, Mehdi Amini via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Author: mehdi_amini > Date: Fri Aug 12 19:02:33 20

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-13 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. This is committed r275115 for the record. Phabricator will automatically close it if the last line is "Differential Revision: ..." (You put "Differential review: ..." instead). http://reviews.llvm.org/D11360 ___

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

2016-07-20 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: include/clang/Driver/ToolChain.h:71 @@ -70,2 +70,3 @@ const llvm::Triple Triple; + mutable llvm::Triple EffectiveTriple; const llvm::opt::ArgList Documentation would be appreciated, a mutable field is never

Re: [clang-tools-extra] r275886 - Unbreak extra tools build post r275882.

2016-07-18 Thread Mehdi Amini via cfe-commits
Thanks, I just checked out clang-tool-extras and was in the process of doing that :) — Mehdi > On Jul 18, 2016, at 12:21 PM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Mon Jul 18 14:21:22 2016 > New Revision: 275886 > > URL:

r275906 - Add missing header in ClangFuzzer (after r275882 cleanup)

2016-07-18 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Mon Jul 18 15:33:09 2016 New Revision: 275906 URL: http://llvm.org/viewvc/llvm-project?rev=275906=rev Log: Add missing header in ClangFuzzer (after r275882 cleanup) Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp Modified:

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:199 @@ +198,3 @@ + +Here's a proposed plan: + Annoyingly my comment does no longer show-up next to the point it was referring to, it was about your third point: > Make sure we have an

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:208 @@ +207,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, update, merges). +4. Make sure bisecting with llvm-project

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a subscriber: mehdi_amini. Comment at: docs/Proposals/GitHub.rst:122 @@ +121,3 @@ +of understanding the *sequence* in which commits were added by using the +``git rev-list --count hash`` or ``git describe hash`` commands. + filcab wrote: > How

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Mehdi Amini via cfe-commits
> On Jul 18, 2016, at 8:23 PM, Tim Northover via cfe-commits > wrote: > >>> Can't handle the update of the umbrella *because of GitHub*, this could be >>> possible with our own hosting of git for instance. >>> >> Pre-commit hooks are not designed to update the

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

2016-07-19 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: lib/Basic/FileManager.cpp:35 @@ -29,2 +34,3 @@ #include +#include That's a lot of includes though. Ok for the climits, but the other should be a separate patch I think. Repository: rL LLVM

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

2016-07-19 Thread Mehdi Amini via cfe-commits
I'm not necessarily disagreeing, I'm saying that if I understand correctly, there are two unrelated changes (one is a build fix, and the other is a "good practice" kind of change). > On Jul 19, 2016, at 6:43 PM, Eugene Zelenko wrote: > > Eugene.Zelenko added a

Re: [PATCH] D20100: [NFC] Header cleanup

2016-07-16 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. Can you rebase? I can't apply it right now. https://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

2016-06-28 Thread Mehdi AMINI via cfe-commits
mehdi_amini requested changes to this revision. mehdi_amini added a comment. This revision now requires changes to proceed. Missing test. Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

2016-06-28 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. Why was it closed? Was it committed? It'd be nice to have a comment with the closing action. Repository: rL LLVM http://reviews.llvm.org/D21277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

2016-06-28 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:459 @@ -456,2 +458,3 @@ legacy::FunctionPassManager *FPM = getPerFunctionPasses(); + FPM->add(new TargetLibraryInfoWrapperPass(*TLII)); if (CodeGenOpts.VerifyModule) It is not super

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

2016-07-05 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: include/clang/Basic/LangOptions.h:131 @@ +130,3 @@ + /// input is a header file (i.e. -x c-header). + bool IsHeaderFile = false; + aaron.ballman wrote: > Should move the initializer to the constructor (not certain

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-05 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:614 @@ -610,1 +613,3 @@ + SimplifyForwardingBlocks(CurBlock); + } Document Comment at: lib/CodeGen/CGStmt.cpp:633 @@ -626,1 +632,3 @@ + if (CurBlock) +

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

2016-07-06 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: docs/CSI.rst:46 @@ +45,3 @@ +allows the LTO to later elide hooks irrelevant to the tool entirely from the +program-under-test. + The long thread on llvm-dev went to conclude that LTO should not be needed.

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

2016-07-06 Thread Mehdi AMINI via cfe-commits
mehdi_amini added inline comments. Comment at: docs/CSI.rst:78 @@ +77,3 @@ +Notice that in the final stage of linking, the tool user also needs to link in +the static library of the CSI runtime to produce the final TIX. The runtime +archive is distributed under the

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

2016-07-07 Thread Mehdi AMINI via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a reviewer: mehdi_amini. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D11360 ___ cfe-commits mailing list

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

2016-07-01 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a subscriber: mehdi_amini. mehdi_amini added a comment. Is it also PR23849? Is it dup with PR27785? Repository: rL LLVM http://reviews.llvm.org/D21619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r291318 - PR23135: Don't instantiate constexpr functions referenced in unevaluated operands where possible.

2017-01-22 Thread Mehdi Amini via cfe-commits
Hi Richard, I have a link failure in WebKit following this patch, the move-assign operator for an nested class isn’t emitted (IRGen) in some context where it is needed. I’m working on running creduce the test-case which is pretty large, but in case it rings a bell, I let you know already. —

r292960 - Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

2017-01-24 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Tue Jan 24 12:12:25 2017 New Revision: 292960 URL: http://llvm.org/viewvc/llvm-project?rev=292960=rev Log: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly(). Summary: These accessors maps directly to the command line option. Reviewers:

r292964 - Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly

2017-01-24 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Tue Jan 24 12:49:49 2017 New Revision: 292964 URL: http://llvm.org/viewvc/llvm-project?rev=292964=rev Log: Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly Modified: cfe/trunk/test/Driver/embed-bitcode.c Modified:

r292961 - Forward -bitcode_process_mode to ld64 in marker-only mode

2017-01-24 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Tue Jan 24 12:15:21 2017 New Revision: 292961 URL: http://llvm.org/viewvc/llvm-project?rev=292961=rev Log: Forward -bitcode_process_mode to ld64 in marker-only mode Reviewers: steven_wu Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D29066

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

2017-01-27 Thread Mehdi Amini via cfe-commits
> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini > wrote: > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so may > be worth

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

2017-01-27 Thread Mehdi Amini via cfe-commits
CC Hans. This is not a regression (AFAICT), but this is a quality improvement, so may be worth considering in the 4.0 branch? — Mehdi > On Jan 27, 2017, at 2:04 PM, David Blaikie via Phabricator > wrote: > > dblaikie created this revision. > > As Mehdi put it,

  1   2   3   >