[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

michaelplatings added a comment. In general LGTM, as someone who's done a 2-3 conversion of similar scale before. The only suggestion I'd make is to consider changing the `__future__` imports to `from __future__ import absolute_import, division, print_function` I found this gave the best

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 ___ cfe-commits mailing

[PATCH] D57337: [Targets] Adjust ARM data layout

michaelplatings updated this revision to Diff 183893. michaelplatings added a comment. Diff with -U9 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57337/new/ https://reviews.llvm.org/D57337 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings marked 4 inline comments as done. michaelplatings added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:1087 + if (GVAlign == 0U && isa(GV)) +GVAlign = 4U; efriedma wrote: > Using "4" as a default is dangerous; on

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188325. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k-abi.c

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k-abi.c

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187339. michaelplatings added a comment. Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1402194 , @lattner wrote: > > Changed recommendation for acronyms from lower case to upper case, as > > suggested by several responses to the RFC. > > I haven't been following the discussion closely - why is

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187344. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://reviews.llvm.org/D57896 Files: .clang-tidy clang/.clang-tidy llvm/.clang-tidy llvm/docs/CodingStandards.rst Index:

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

This revision was automatically updated to reflect the committed changes. Closed by commit rL355522: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings, committed by ). Changed prior to commit: https://reviews.llvm.org/D57335?vs=188325=189524#toc Repository:

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188184. michaelplatings added a comment. Herald added subscribers: cfe-commits, jdoerfert, mgorny, dschuff. Herald added projects: clang, LLVM. Hi @efriedma, sorry for the delayed response. I've added the features you asked for to DataLayout. It is

[PATCH] D57896: Variable names rule

michaelplatings created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following discussion and general agreement that the current naming rule for variables is not ideal, this patch

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1389042 , @lebedev.ri wrote: > Pretty sure this patch should have gone to llvm-commits, not cfe-commits. I just set the repository, Phabricator did the rest - apparently the magic isn't working so well.

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1389067 , @lebedev.ri wrote: > 1. Does clang-tidy warn on every single existing variable now? > 2. It might be best to give this more visibility, by submitting a mail to > llvm-dev, with a **noticeable**

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187252. michaelplatings added a comment. Update .clang-tidy files to use aNy_CasE until camelBackOrCase is available. Add more guidance around acronyms. Add more guidance around consistency with existing CamelCase variable names. Change other code

[PATCH] D57896: Variable names rule

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: llvm/docs/CodingStandards.rst:1195 + be camel case, and start with a lower case letter (e.g. ``leader`` or + ``boats``). It is also acceptable to use ``UpperCamelCase`` for

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1390517 , @MyDeveloperDay wrote: > Should we come up with a new style? say `UpperOrLowerCamelCase`, I don't > mind going and doing that in the readability-identifier-naming check, given > that I just wrote

[PATCH] D64123: Add clang-llvm-rename tool.

michaelplatings added a comment. Hi @ruiu, Can you comment on how this compares to clang-tidy? I had assumed that the readability-identifier-naming clang-tidy rule would largely do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71991: Fix external-names.c test when separator is \\

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7ca82161b5: Fix external-names.c test when separator is \\ (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71991/new/

[PATCH] D71991: Fix external-names.c test when separator is \\

michaelplatings added a comment. Thanks for accepting. The repo is up to date. I guess the reason the failure hasn't happened with the build bots is that our downstream test setup differs somewhat from the norm - our test runner imports lit.discovery & lit.LitConfig directly rather than using

[PATCH] D71991: Fix external-names.c test when separator is \\

michaelplatings created this revision. michaelplatings added reviewers: rnk, amccarth, dsanders, miyuki. Herald added a project: clang. Herald added a subscriber: cfe-commits. michaelplatings edited the summary of this revision. This fixes the following failure:

[PATCH] D134824: Fix frint ACLE intrinsic names

michaelplatings created this revision. michaelplatings added a reviewer: jaykang10. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although the instruction names begin "frint", the ACLE spec

[PATCH] D134824: Fix frint ACLE intrinsic names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdba8fced969e: Fix frint ACLE intrinsic names (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140959: RFC: Multilib prototype

michaelplatings created this revision. michaelplatings added a project: clang. Herald added subscribers: s.egerton, ormris, abidh, mgrang, simoncook, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay.

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

michaelplatings created this revision. michaelplatings added reviewers: abidh, jroelofs. michaelplatings added a project: clang. Herald added subscribers: dberris, ki.stfu. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

This revision was automatically updated to reflect the committed changes. Closed by commit rG620d2bfdadeb: [clang] Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR… (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. A constraint is that the user should be able to choose the library with a single list of arguments, as displayed with `-print-multi-lib`. Therefore I'm sceptical about making the selection mechanism too expressive, because `-print-multi-lib` can't explain that

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. How the multilib system matches user arguments is the main problem I've been struggling with. These are the options I see: 1. Grant the multilib system full access to all cc1 arguments, as demonstrated by the current code. However declare the multilib system

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The plan is to

[PATCH] D142893: Class for building MultilibSet

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The functionality in

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings updated this revision to Diff 493244. michaelplatings added a comment. Update commit message and run arc with clang-format on the PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878

[PATCH] D142905: Change multilib selection algorithm

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings created this revision. michaelplatings added reviewers: phosek, lenary, simon_tatham. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project:

[PATCH] D142932: Multilib YAML parsing

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib2.h:33-34 +private: + std::vector, std::vector>> Multilibs; + std::vector, std::vector>> RegexAttributes; +}; phosek wrote: > I think it'd really help readability and

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. > The main trouble I had was at that point we don't have a reference to the > ToolChain, so calling `getMultiSelectionFlags` was not possible. [...] I'm > not sure what the solution here is. I see two options: 1. Split getMultiSelectionFlags into

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 493968. michaelplatings added a comment. Incorporated changes requested by @miyuki Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files:

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The name "flag"

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 503904. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 503903. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 503900. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 503902. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503906. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 503905. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503899. michaelplatings added a comment. Rebase on top of D142905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503913. michaelplatings added a comment. Tiny tweak: undo an unnecessary change to a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 506044. michaelplatings added a comment. fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

michaelplatings created this revision. michaelplatings added reviewers: simon_tatham, dcandler. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings abandoned this revision. michaelplatings marked an inline comment as done. michaelplatings added a comment. We're going back to "flags": https://discourse.llvm.org/t/rfc-multilib/67494/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142933: Add -print-multi-selection-tags-experimental option

michaelplatings updated this revision to Diff 505048. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505050. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 505047. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 505051. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 505052. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505053. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 505643. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505644. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files:

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:237-245 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos,

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505286. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + phosek wrote: > Rather than hardcoding the filename

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505293. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 505284. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 505279. michaelplatings marked an inline comment as done. michaelplatings added a comment. Calculate the output for -print-multi-lib lazily. This necessitated returning to using std::vector to store flags to avoid reordering them. In theory the big-O

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 505283. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Decouple multilib versioning scheme from the Clang version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 505288. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 505290. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507527. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add enum to Multilib class for how print options should be calculated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507864. michaelplatings added a comment. Move change to print options into D146757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Sometimes it's necessary to define a multilib in terms of

[PATCH] D142905: [Driver] Change multilib selection algorithm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30bc9e91241: [Driver] Change multilib selection algorithm (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 508036. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 508037. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 508039. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 508041. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 508038. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 508040. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503046. michaelplatings added a comment. - Make "experimental" more obvious. - Demonstrate using a Clang-generated flag directly in Flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 504772. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 504774. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:67 + /// a subset of the flags derived from the Clang command line options. + const flag_set () const { return Flags; }

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 504771. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. parse -> parseYaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932

[PATCH] D142932: Multilib YAML parsing

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:66 + /// options and look similar to them, and others can be defined by a + /// particular multilib.yaml. A multilib is considered compatible if its tags + /// are a subset of the tags

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 504775. michaelplatings added a comment. Reference Multilib.rst from comment in Multilib.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files:

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added a comment. @phosek ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60bbf271b568: [ARM][NFC] Use FPUKind enum instead of unsigned (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings added a comment. Thanks @MaskRay for taking a look and thanks @simon_tatham for the review of the change. This change affects existing code so I think it deserves its own commit, but I'll move it down the stack to before D142932 so that later

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @peter.smith. I've opted to leave the comment as-is. If we can expect a tag_set to actually contain flags then I've continued to use that terminology. Comment at:

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505451. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add quotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files:

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

michaelplatings abandoned this revision. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Squashed into D142932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143763/new/

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. Hi Petr, In LLVM Embedded Toolchain for Arm we put libclang_rt in the regular library directory, not the resource dir. Therefore `-resource-dir` has no effect for us. Instead of this change, I could have added a `--sysroot` argument to each test, but this change

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifying --sysroot prevents libclang_rt from being located in

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e28a3010e1: [Clang] Improve hermeticity of clang_rt tests (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. https://reviews.llvm.org/D144542 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666 ___ cfe-commits mailing list

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61a863050bb: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. I'm happy to revert this and add `--sysroot` if you prefer. That would fit with keeping the tests hermetic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666

[PATCH] D142893: [NFC] Class for building MultilibSet

This revision was automatically updated to reflect the committed changes. michaelplatings marked 4 inline comments as done. Closed by commit rG850dab0f2537: [NFC] Class for building MultilibSet (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 499416. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 499443. michaelplatings added a subscriber: peter.smith. michaelplatings added a comment. - Squash D143763 into this change as suggested by @MaskRay - Use PascalCase field names as requested by @phosek - Applied

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 499963. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

  1   2   3   >