[PATCH] D49127: [libclang 5/8] Add support for ObjC attributes without args

2018-08-02 Thread Michael Wu via Phabricator via cfe-commits
michaelwu added a comment. Some of the CHECKs in the test will be reordered to pass, but it's still the same test. Repository: rC Clang https://reviews.llvm.org/D49127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49635: [libclang 8/8] Add support for the flag_enum attribute

2018-08-02 Thread Michael Wu via Phabricator via cfe-commits
michaelwu added a comment. Thanks for the reviews! Repository: rC Clang https://reviews.llvm.org/D49635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49634: [libclang 7/8] Add support for getting property setter and getter names

2018-08-02 Thread Michael Wu via Phabricator via cfe-commits
michaelwu added a comment. The patch will be adjusted slightly to replace a // comment with a /* */ comment. Repository: rC Clang https://reviews.llvm.org/D49634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50318: Support Swift in platform availability attribute

2018-08-05 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. michaelwu added reviewers: manmanren, friss, doug.gregor. This adds support for Swift platform availability attributes. It's largely a port of the changes made to https://github.com/apple/swift-clang/ for Swift availability attributes. Specifically,

[PATCH] D50318: Support Swift in platform availability attribute

2018-08-23 Thread Michael Wu via Phabricator via cfe-commits
michaelwu added a comment. Review ping Repository: rC Clang https://reviews.llvm.org/D50318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

2018-08-28 Thread Michael Wu via Phabricator via cfe-commits
michaelwu added a comment. It shouldn't be too hard to make a test using `c-index-test`. `-test-print-type` will print out the pointee type if it's valid. Comment at: tools/libclang/CXType.cpp:448 break; +case Type::Auto: + TP =

[PATCH] D49063: [libclang 1/8] Add support for ObjCObjectType

2018-07-21 Thread Michael Wu via Phabricator via cfe-commits
michaelwu updated this revision to Diff 156692. michaelwu added a comment. `clang_Type_getNumObjCTypeArgs` and `clang_Type_getNumObjCProtocolRefs` now return unsigned. I've bumped `CINDEX_VERSION_MINOR` in https://reviews.llvm.org/D49635 , which is the last in this patch series.

[PATCH] D49634: [libclang 7/8] Add support for getting property setter and getter names

2018-07-21 Thread Michael Wu via Phabricator via cfe-commits
michaelwu updated this revision to Diff 156691. michaelwu added a comment. Fix test https://reviews.llvm.org/D49634 Files: include/clang-c/Index.h test/Index/property-getter-setter.m tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/libclang.exports Index:

[PATCH] D49635: [libclang 8/8] Add support for the flag_enum attribute

2018-07-21 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This adds support to libclang for reading the flag_enum attribute. This also bumps CINDEX_VERSION_MINOR for this patch series. Repository: rC Clang https://reviews.llvm.org/D49635 Files: include/clang-c/Index.h test/Index/attributes.c

[PATCH] D49634: [libclang] Add support for getting property setter and getter names

2018-07-21 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This allows libclang to access the actual names of property setters and getters without needing to go through the indexer API. Usually default names are used, but the property can specify a different name. Repository: rC Clang

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

2018-09-06 Thread Michael Wu via Phabricator via cfe-commits
michaelwu accepted this revision. michaelwu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D51281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49127: [libclang] Add support for ObjC attributes without args

2018-07-10 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This adds support to libclang for identifying ObjC related attributes that don't take arguments. All attributes but NSObject and NSConsumed are tested. Repository: rC Clang https://reviews.llvm.org/D49127 Files: include/clang-c/Index.h

[PATCH] D49063: [libclang] Add support for ObjCObjectType

2018-07-12 Thread Michael Wu via Phabricator via cfe-commits
michaelwu added inline comments. Comment at: include/clang-c/Index.h:35 #define CINDEX_VERSION_MAJOR 0 #define CINDEX_VERSION_MINOR 49 yvvan wrote: > Please, increment the minor version (you are adding new functions) This is one in a series of patches that

[PATCH] D49063: [libclang] Add support for ObjCObjectType

2018-07-09 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This patch adds support to the clang-c API for identifying ObjCObjects in CXTypes, enumerating type args and protocols on ObjCObjectTypes, and retrieving the base type of ObjCObjectTypes. Currently only ObjCInterfaceTypes are exposed, which do not have type

[PATCH] D49066: [libclang] Add support for ObjCTypeParam

2018-07-09 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This patch adds support to the libclang API for identifying ObjCTypeParams in CXTypes. This patch depends on https://reviews.llvm.org/D49063 since both patches add new values to CXTypeKind. Repository: rC Clang https://reviews.llvm.org/D49066 Files:

[PATCH] D49063: [libclang] Add support for ObjCObjectType

2018-07-09 Thread Michael Wu via Phabricator via cfe-commits
michaelwu updated this revision to Diff 154540. michaelwu added a comment. Replaced tabs with spaces. https://reviews.llvm.org/D49063 Files: include/clang-c/Index.h test/Index/objc-typeargs-protocols.m test/Index/print-type.m tools/c-index-test/c-index-test.c

[PATCH] D49081: [libclang] Add support for AttributedType

2018-07-09 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This patch adds support to the libclang API for identifying AttributedTypes in CXTypes and reading the modified type that the type points to. Currently AttributedTypes are skipped. This patch continues to skip AttributedTypes by default, but adds a parsing

[PATCH] D49082: [libclang] Add the clang_Type_getNullability() API

2018-07-09 Thread Michael Wu via Phabricator via cfe-commits
michaelwu created this revision. This patch adds a clang-c API for querying the nullability of an AttributedType. The test here also tests https://reviews.llvm.org/D49081 Repository: rC Clang https://reviews.llvm.org/D49082 Files: include/clang-c/Index.h test/Index/nullability.c

[PATCH] D50318: Support Swift in platform availability attribute

2018-11-11 Thread Michael Wu via Phabricator via cfe-commits
michaelwu updated this revision to Diff 173607. michaelwu added a comment. Thanks for the review! All requested changes have been made, and I also had to fix a test due to https://reviews.llvm.org/D50214 https://reviews.llvm.org/D50318 Files: include/clang/Basic/Attr.td