[PATCH] D40415: [libcxx

2017-11-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. Herald added a reviewer: EricWF. https://reviews.llvm.org/D40415 Files: include/iterator test/std/iterators/stream.iterators/istream.iterator/istream.iterator.ops/equal.pass.cpp Index:

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

2017-11-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D40415#934939, @EricWF wrote: > LGTM. Thanks. I don't have write access. Please commit the patch on my behalf. https://reviews.llvm.org/D40415 ___ cfe-commits mailing list

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. [Parser] Diagnose storage classes in template parameter declarations According to the C++ Standard [temp.param]p2: A storage class shall not be specified in a template-parameter declaration. This patch implements a diagnostic for this restriction.

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

2017-12-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. [libcxx] Fix basic_stringbuf constructor The C++ Standard [stringbuf.cons]p1 defines the effects of the basic_stringbuf constructor that takes ios_base::openmode as follows: Effects: Constructs an object of class basic_stringbuf, initializing the base class

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

2017-12-05 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Ping https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

2017-12-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Yes, I don't have write access. https://reviews.llvm.org/D40707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

2017-12-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 126739. miyuki added a comment. Use diff with context. https://reviews.llvm.org/D40707 Files: include/sstream test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp Index:

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: faisalv, rsmith, rogfer01. [Sema] Diagnose template specializations with C linkage According to the C++ standard, templates as well as their specializations cannot have C language linkage. Clang currently does not diagnose function template

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 127324. miyuki added a comment. Merged two diagnostics into one https://reviews.llvm.org/D40705 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseTemplate.cpp test/CXX/temp/temp.param/p2-cpp11.cpp test/CXX/temp/temp.param/p2.cpp

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. I don't have commit access. Please commit the patch on my behalf. https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 126915. miyuki added a comment. Added a test for partial specialization. https://reviews.llvm.org/D41179 Files: lib/Sema/SemaTemplate.cpp test/SemaTemplate/class-template-spec.cpp test/SemaTemplate/function-template-specialization.cpp Index:

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7021 + // C++ [temp]p6: + // A template, a template explicit specialization, and a class template + // partial specialization shall not have C linkage. rogfer01 wrote: > Can you add a

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

2017-12-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 126738. miyuki added a comment. Modified the test to use NULL instead of literal zero. https://reviews.llvm.org/D40707 Files: include/sstream test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp Index:

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 125119. miyuki added a comment. Use explicit lambda capture list. https://reviews.llvm.org/D40705 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseTemplate.cpp test/CXX/temp/temp.param/p2.cpp Index: test/CXX/temp/temp.param/p2.cpp

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

2017-12-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D40415#950793, @rogfer01 wrote: > Hi @miyuki I can commit it. Please do so. https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Ping https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 126325. miyuki added a comment. Added a test for thead_local. https://reviews.llvm.org/D40705 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseTemplate.cpp test/CXX/temp/temp.param/p2-cpp11.cpp test/CXX/temp/temp.param/p2.cpp

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

2017-12-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Ping https://reviews.llvm.org/D40707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

2017-12-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. I would appreciate, if you make those changes (because I'm very new to Clang and I'm not sure that I understand how to move these checks to Sema correctly). https://reviews.llvm.org/D40705 ___ cfe-commits mailing list

[PATCH] D48021: [Driver] Add aliases for -Qn/-Qy

2018-06-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: aprantl, JDevlieghere. This patch adds aliases for -Qn (-fno-ident) and -Qy (-fident) which look less cryptic than -Qn/-Qy. The aliases are compatible with GCC. https://reviews.llvm.org/D48021 Files: CodeGen/no-ident-version.c

[PATCH] D48021: [Driver] Add aliases for -Qn/-Qy

2018-06-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334414: [Driver] Add aliases for -Qn/-Qy (authored by miyuki, committed by ). Changed prior to commit: https://reviews.llvm.org/D48021?vs=150732=150772#toc Repository: rC Clang

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

2018-04-30 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC331164: [Targets] Implement getConstraintRegister for ARM and AArch64 (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D45965 Files:

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D41179#957992, @sepavloff wrote: > Classes do not have language linkage according to 10.5p1, just as > templates, so this code is valid. > > It looks like defining templates inside extern "C" blocks is OK. Currently both Clang and GCC

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2017-12-29 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently std::asinh and std::acosh use std::pow to compute x^2. This results in a significant error when computing e.g. asinh(i) or acosh(-1). This patch expresses x^2 directly via x.real() and x.imag(), like it is done

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2018-01-08 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D41179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently when a regular expression contains an invalid character class name std::regex constructors throw an std::regex_error with std::regex_constants::error_brack code. This patch changes the code to

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-01-23 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-26 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-01-15 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2018-01-15 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-01-25 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: faisalv, rsmith. According to [dcl.init.list]p7: A narrowing conversion is an implicit conversion - ... - from an integer type or unscoped enumeration type to a floating-point type, except where the source is a constant

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently libc++ implements some operations on valarray by using the resize method. This method has a parameter with a default value. Because of this, valarray may spuriously construct and destruct objects of valarray's

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-30 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently when parsing basic POSIX regular expressions libc++ silently skips invalid escaped characters and trailing escapes. This patch changes the behavior, so that a std::regex_error with code set to error_escape is

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 132352. miyuki edited the summary of this revision. miyuki added a comment. Updated __parse_QUOTED_CHAR_ERE. Added more test cases. https://reviews.llvm.org/D42693 Files: include/regex test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp Index:

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: include/regex:3490 { switch (*__temp) { mclow.lists wrote: > Do we need any more cases here? Probably not, but we should throw an exception here as well.

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-31 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: include/regex:3465 +case '{': +case '}': +break; Quuxplusone wrote: > FWIW, I don't understand what's going on in this switch. > Is it intentional that `'('` and `'|'` now take

[PATCH] D42969: [Sema] Fix decltype of static data members

2018-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: faisalv, rsmith. miyuki edited the summary of this revision. According to the C++11 standard [dcl.type.simple]p4: The type denoted by decltype(e) is defined as follows: - if e is an unparenthesized id-expression or an unparenthesized

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D42545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^3 https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42969: [Sema] Fix decltype of static data members

2018-02-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325117: [Sema] Fix decltype of static data members (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D42969 Files: lib/Sema/SemaType.cpp

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-02-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D42545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D42693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-02-08 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 133408. miyuki added a comment. Added a test for __sqr https://reviews.llvm.org/D41629 Files: include/complex test/libcxx/numerics/complex.number/__sqr.pass.cpp test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-02-08 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX324596: [libcxx] Avoid spurious construction of valarray elements (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D41992 Files: include/valarray

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 132974. miyuki added a comment. Removed the changes that are unrelated to the 'enum->float' case from the test. https://reviews.llvm.org/D42545 Files: lib/Sema/SemaOverload.cpp test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp Index:

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-02-07 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^3 https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-02-21 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325668: [Sema] Classify conversions from enum to float as narrowing (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D42545 Files: lib/Sema/SemaOverload.cpp

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

2018-02-21 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: faisalv, rsmith. This patch adds tests of narrowing conversion diagnostics for the 'unscoped enum -> integer' case.q https://reviews.llvm.org/D43572 Files: test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp Index:

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

2018-02-22 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325760: [libcxx] Do not include the C math.h header before __config (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-02-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. No, I'll commit it myself. Thank you for the review. https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-02-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D42545#1010335, @rogfer01 wrote: > Do you plan to submit (in another change) the unscoped enum → integer type > testcases? If this is not currently tested anywhere I think it may be a good > thing to have them too. Yes, I'll submit them in

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-02-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX325510: [libcxx] Improve accuracy of complex asinh and acosh (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D41629 Files: include/complex

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-02-16 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Herald added a subscriber: christof. ping https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

2018-02-21 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Certain C libraries require configuration macros defined in __config to provide the correct functionality for libc++. This patch ensures that the C header math.h is always included after the

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

2017-12-21 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing the patch. Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 128234. miyuki added a comment. Factored out template language linkage check into a separate function https://reviews.llvm.org/D41179 Files: lib/Sema/SemaTemplate.cpp test/SemaTemplate/class-template-spec.cpp

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-01-03 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp:59 +{ +assert(r.real() == 0); +assert(!std::signbit(r.real())); Ideally, I would prefer some approximate comparison

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

2018-08-10 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 160121. miyuki edited the summary of this revision. miyuki added a comment. Fix handling of homogeneous aggregates of FP16 vectors https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/arm-vfp16-arguments.c

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

2018-08-09 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: eli.friedman, olista01, SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. On targets that do not support FP16 natively LLVM currently legalizes vectors of FP16 values by scalarizing them and

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

2018-08-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 160317. miyuki added a comment. Handle return of homogeneous aggregates https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/arm-vfp16-arguments.c test/CodeGen/arm_neon_intrinsics.c Index: test/CodeGen/arm_neon_intrinsics.c

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323322: [libcxx] Correctly handle invalid regex character class names (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323322: [libcxx] Correctly handle invalid regex character class names (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D42291 Files: include/regex

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: faisalv. Herald added subscribers: JDevlieghere, aprantl. By default Clang outputs its version (including git commit hash, in case of trunk builds) into object and assembly files. It might be useful to have an option to disable this,

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D45255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 142165. miyuki added a comment. Updated the test case https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CodeGenModule.cpp

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. One use case for this is debugging: this flag makes it easier to find out which revisions of LLVM introduce changes in codegen and/or debug information without having to filter out .ident/producer metadata. Some users can also use this flag (or an equivalent,

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC330442: [CodeGen] Add an option to suppress output of llvm.ident (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 143327. miyuki added a comment. Updated the test https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CodeGenModule.cpp

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D45255#1073703, @JDevlieghere wrote: > If it were the other way around I’d agree with you, but given that -Qn > becomes the default, I think we should not strip it from the debug info. No, the default is -Qy Repository: rC Clang

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D45255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D45255#1072200, @aprantl wrote: > Does gcc's Qy/Qn option also affect the generated debug information? No, it does not. Do you think it would be better to leave debug information unchanged as well? https://reviews.llvm.org/D45255

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

2018-04-23 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: eli.friedman. Herald added subscribers: chrib, kristof.beyls, eraman, rengolin. Herald added a reviewer: javed.absar. The getConstraintRegister method is used by semantic checking of inline assembly statements in order to diagnose conflicts

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

2018-04-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + thopre wrote: > From

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

2018-04-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 143732. miyuki added a comment. Added a comment for getConstraintRegister https://reviews.llvm.org/D45965 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/AArch64.h lib/Basic/Targets/ARM.h test/Sema/arm-asm.c test/Sema/arm64-inline-asm.c

[PATCH] D44783: [Targets] Adjust ARM data layout

2018-03-22 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: hfinkel. Herald added subscribers: kristof.beyls, javed.absar, dschuff. The DataLayout structure now includes function pointer alignment, on ARM targets it is set to 8 bits. The front end needs to be adjusted to produce matching data layout

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

2018-03-02 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326551: [Sema] Improve test coverage of narrowing conversion diagnostics (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D43572 Files:

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

2018-09-03 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D50507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52036: [Analyzer] Make plist tests less fragile

2018-09-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: NoQ, dcoughlin, george.karpenkov. Herald added subscribers: Szelethus, mikhail.ramalho, a.sidorin, szepet, eraman, xazax.hun. A recent change https://reviews.llvm.org/D50545 started using diff to compare plist output against reference output.

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 165469. miyuki retitled this revision from "[Analyzer] Make plist tests less fragile" to "[Analyzer] Use diff_plist in tests, NFC". miyuki edited the summary of this revision. miyuki added a comment. Use a different approach (suggested by Artem).

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

2018-09-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342034: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

2018-09-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Changed prior to commit: https://reviews.llvm.org/D52036?vs=165469=165732#toc Repository: rC Clang