Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-10-22 Thread Pavel Labath via cfe-commits
labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. I'll just observe this one. Someone with more knowledge of clang needs to review this. Repository: rL LLVM http://reviews.llvm.org/D13959 ___

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-02 Thread Pavel Labath via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271533: [cmake] Fix builds with LLVM_ENABLE_PIC=0 (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20883?vs=59293=59405#toc Repository: rL LLVM http://reviews.llvm.org/D20883

r271533 - [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-02 Thread Pavel Labath via cfe-commits
Author: labath Date: Thu Jun 2 11:35:24 2016 New Revision: 271533 URL: http://llvm.org/viewvc/llvm-project?rev=271533=rev Log: [cmake] Fix builds with LLVM_ENABLE_PIC=0 Summary: When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targets.

r271565 - [cmake] Fix-up r271533

2016-06-02 Thread Pavel Labath via cfe-commits
Author: labath Date: Thu Jun 2 13:49:42 2016 New Revision: 271565 URL: http://llvm.org/viewvc/llvm-project?rev=271565=rev Log: [cmake] Fix-up r271533 I was appending to the wrong variable (over-zealous copy-paste from llvm on my part). Modified: cfe/trunk/test/CMakeLists.txt Modified:

[PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

2016-06-01 Thread Pavel Labath via cfe-commits
labath created this revision. labath added a reviewer: beanz. labath added a subscriber: cfe-commits. When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targets. cmake 2.8 silently ignored this situation, but with

r262700 - [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

2016-03-04 Thread Pavel Labath via cfe-commits
Author: labath Date: Fri Mar 4 04:00:08 2016 New Revision: 262700 URL: http://llvm.org/viewvc/llvm-project?rev=262700=rev Log: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations Summary: While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(), which

Re: [PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

2016-03-03 Thread Pavel Labath via cfe-commits
labath added a subscriber: lldb-commits. labath added a comment. I noticed this while debugging an importing issue in LLDB. I am not sure if I have selected the right reviewer, and also how/if to test this... http://reviews.llvm.org/D17845 ___

[PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

2016-03-03 Thread Pavel Labath via cfe-commits
labath created this revision. labath added a reviewer: akyrtzi. labath added a subscriber: cfe-commits. ASTImporter was importing this attribute only on destructor and constructor decls, as they take it in the constructor, but other decls can have this attribute as well, notably the global

r292914 - Replace use of chdir with llvm::sys::fs::set_current_path

2017-01-24 Thread Pavel Labath via cfe-commits
Author: labath Date: Tue Jan 24 05:14:29 2017 New Revision: 292914 URL: http://llvm.org/viewvc/llvm-project?rev=292914=rev Log: Replace use of chdir with llvm::sys::fs::set_current_path NFCI Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified:

r286356 - [VFS] Replace TimeValue usage with std::chrono

2016-11-09 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Nov 9 04:52:22 2016 New Revision: 286356 URL: http://llvm.org/viewvc/llvm-project?rev=286356=rev Log: [VFS] Replace TimeValue usage with std::chrono Summary: NFCI Reviewers: benlangmuir, zturner Subscribers: cfe-commits Differential Revision:

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

2016-11-09 Thread Pavel Labath via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286356: [VFS] Replace TimeValue usage with std::chrono (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25948?vs=75723=77330#toc Repository: rL LLVM

r286357 - Replace TimeValue with TimePoint in BuildSystem.cpp. NFC.

2016-11-09 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Nov 9 05:19:39 2016 New Revision: 286357 URL: http://llvm.org/viewvc/llvm-project?rev=286357=rev Log: Replace TimeValue with TimePoint in BuildSystem.cpp. NFC. Modified: cfe/trunk/tools/libclang/BuildSystem.cpp Modified: cfe/trunk/tools/libclang/BuildSystem.cpp

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

2016-11-08 Thread Pavel Labath via cfe-commits
labath added a comment. If noone objects, I am going to commit this tomorrow. https://reviews.llvm.org/D25948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

2016-10-25 Thread Pavel Labath via cfe-commits
labath created this revision. labath added reviewers: benlangmuir, zturner. labath added a subscriber: cfe-commits. NFCI https://reviews.llvm.org/D25948 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/FileSystemStatCache.cpp lib/Basic/VirtualFileSystem.cpp

r284964 - Adjust for TimePoint interface change in llvm: D25730. NFC

2016-10-24 Thread Pavel Labath via cfe-commits
Author: labath Date: Mon Oct 24 05:59:13 2016 New Revision: 284964 URL: http://llvm.org/viewvc/llvm-project?rev=284964=rev Log: Adjust for TimePoint interface change in llvm: D25730. NFC Modified: cfe/trunk/include/clang/Basic/VirtualFileSystem.h cfe/trunk/lib/Driver/Tools.cpp Modified:

r332228 - [CodeGen] Disable aggressive structor optimizations at -O0

2018-05-14 Thread Pavel Labath via cfe-commits
Author: labath Date: Mon May 14 04:02:23 2018 New Revision: 332228 URL: http://llvm.org/viewvc/llvm-project?rev=332228=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0 Summary: Removing the full structor and replacing all usages with the base one can degrade debug quality as

r332232 - Revert "[CodeGen] Disable aggressive structor optimizations at -O0"

2018-05-14 Thread Pavel Labath via cfe-commits
Author: labath Date: Mon May 14 04:35:44 2018 New Revision: 332232 URL: http://llvm.org/viewvc/llvm-project?rev=332232=rev Log: Revert "[CodeGen] Disable aggressive structor optimizations at -O0" It breaks the sanitizer build

r332839 - [CodeGen] Disable aggressive structor optimizations at -O0, take 2

2018-05-21 Thread Pavel Labath via cfe-commits
Author: labath Date: Mon May 21 04:47:45 2018 New Revision: 332839 URL: http://llvm.org/viewvc/llvm-project?rev=332839=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0, take 2 The first version of the patch (r332228) was flawed because it was putting structors into C5/D5

r334399 - Move VersionTuple from clang/Basic to llvm/Support

2018-06-11 Thread Pavel Labath via cfe-commits
Author: labath Date: Mon Jun 11 03:28:04 2018 New Revision: 334399 URL: http://llvm.org/viewvc/llvm-project?rev=334399=rev Log: Move VersionTuple from clang/Basic to llvm/Support Summary: This kind of functionality is useful to other project apart from clang. LLDB works with version numbers a

r322268 - [Lex] Use WritableMemoryBuffer in ScratchBuffer.cpp

2018-01-11 Thread Pavel Labath via cfe-commits
Author: labath Date: Thu Jan 11 02:43:45 2018 New Revision: 322268 URL: http://llvm.org/viewvc/llvm-project?rev=322268=rev Log: [Lex] Use WritableMemoryBuffer in ScratchBuffer.cpp This avoids the need to const_cast the buffer contents to write to it. NFCI. Modified:

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-30 Thread Pavel Labath via cfe-commits
29 Jul 2018 at 03:15, Chandler Carruth wrote: > > > > On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth > > wrote: > >> > >> On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits > >> wrote: > >>> > >>> Author: labath &

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-30 Thread Pavel Labath via cfe-commits
Carruth wrote: > > On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth wrote: >> >> On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits >> wrote: >>> >>> Author: labath >>> Date: Thu Jul 19 07:05:22 2018 >>> New Revision: 337456 >

r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-19 Thread Pavel Labath via cfe-commits
Author: labath Date: Thu Jul 19 07:05:22 2018 New Revision: 337456 URL: http://llvm.org/viewvc/llvm-project?rev=337456=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0, take 3 The previous version of this patch (r332839) was reverted because it was causing "definition with

r341472 - Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)

2018-09-05 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Sep 5 07:38:44 2018 New Revision: 341472 URL: http://llvm.org/viewvc/llvm-project?rev=341472=rev Log: Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames) Summary: DWARF v5 accelerator tables provide a considerable performance

r341492 - Revert "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)"

2018-09-05 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Sep 5 13:20:28 2018 New Revision: 341492 URL: http://llvm.org/viewvc/llvm-project?rev=341492=rev Log: Revert "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)" This reverts commit r341472 due to breakage in green dragon bots.

r341564 - Re-commit "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)""

2018-09-06 Thread Pavel Labath via cfe-commits
Author: labath Date: Thu Sep 6 10:01:45 2018 New Revision: 341564 URL: http://llvm.org/viewvc/llvm-project?rev=341564=rev Log: Re-commit "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)"" This recommits r341472, which was reverted due to test failures on

r327383 - clang-import-test: fix build with clang-3.8

2018-03-13 Thread Pavel Labath via cfe-commits
Author: labath Date: Tue Mar 13 04:28:27 2018 New Revision: 327383 URL: http://llvm.org/viewvc/llvm-project?rev=327383=rev Log: clang-import-test: fix build with clang-3.8 clang-3.8 complains that constructor for '...' must explicitly initialize the const object. Newer clangs and gcc seem to be

r327491 - StaticAnalyzer: fix compiler warning. NFC

2018-03-14 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Mar 14 03:16:40 2018 New Revision: 327491 URL: http://llvm.org/viewvc/llvm-project?rev=327491=rev Log: StaticAnalyzer: fix compiler warning. NFC My compiler (clang-3.8) complains that the RCC variable is unused. That's not really true, as it's checked by the

[clang-tools-extra] r351319 - Fix build breakage from llvm r351317

2019-01-16 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Jan 16 02:26:52 2019 New Revision: 351319 URL: http://llvm.org/viewvc/llvm-project?rev=351319=rev Log: Fix build breakage from llvm r351317 The two-argument version of llvm::sys::fs::make_absolute no longer returns an error code. Modified:

r351317 - [Support] Remove error return value from one overload of fs::make_absolute

2019-01-16 Thread Pavel Labath via cfe-commits
Author: labath Date: Wed Jan 16 01:55:32 2019 New Revision: 351317 URL: http://llvm.org/viewvc/llvm-project?rev=351317=rev Log: [Support] Remove error return value from one overload of fs::make_absolute Summary: The version of make_absolute which accepted a specific directory to use as the

Re: [Lldb-commits] [lldb] aee4925 - Recommit: Compress formatting of array type names (int [4] -> int[4])

2021-10-28 Thread Pavel Labath via cfe-commits
On 26/10/2021 23:14, Jim Ingham via lldb-commits wrote: On Oct 26, 2021, at 12:45 PM, David Blaikie wrote: On Tue, Oct 26, 2021 at 12:15 PM Raphael Isemann wrote: Not sure how many LLDB users would (or can) write AST matchers though. And (lldb) type summary add "foo[4]" ... is

[llvm] [compiler-rt] [clang] [clang-tools-extra] [compiler-rt] Mark more calls as blocking (PR #77789)

2024-02-01 Thread Pavel Labath via cfe-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/77789 >From 97c29cab7c7d8af9bf7a5d79baf468154bb83fad Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 11 Jan 2024 12:50:37 +0100 Subject: [PATCH] [compiler-rt] Mark more calls as blocking If we're in a blocking